Page MenuHomePhabricator

[Segmentation] Auto-selection preference was hijacked for something else
Closed, ResolvedPublic

Description

It now controls the auto-selection feature of the selection widgets but it was supposed to hide all other images and segmentations during a segmentation session like it is still done in the multi-label segmentation.

For v2021.01 I adapted the tooltip but an actual fix would be to go back to the original intended behavior.

Event Timeline

kislinsk triaged this task as Normal priority.Jan 31 2021, 2:01 AM
kislinsk created this task.

I tested it and now this explains T27498#217602.

I also looked into QmitkSegmentationView.cpp and see that the property auto selection is now used to define the SetAutoSelectNewNodes modes of the image selectors.

kalali removed kalali as the assignee of this task.EditedFeb 2 2021, 10:18 PM
kalali edited projects, added MITK, Next Milestone; removed MITK (v2021.02).

Ok, I withdraw from this for now. It is useless to fix this since both views are basically the same but their implementation is different (some things are copied, others aren't). Before putting any effort into this I refer to T28142 and propose to refactor the whole thing after the release.

Has been resolved with D533.

However, there is a slightly different behavior now with the selection widgets:
The user cannot select segmentations of image B if image A is selected in the image selection widget (node predicates only allow child-nodes of the selected image node). That means:

  1. selecting a different segmentation will never lead to selection a different image and thus selecting a different segmentation will only hide all other segmentations but never any image (because that doesn't switch the reference image automatically as it was done before when selecting segmentation nodes via the data manager).
  2. in order to select a segmentation from a different image the user first has to select the different reference image in the image selection widget. This will then hide all other images. Changing the reference image will then automatically lead to a new selection of a child node (segmentation node, if available) and thus lead to hiding all other segmentations (as desired).
  3. only special case is if the user selects image B with any segmentation child node. Now he purposely shows image A by e.g. checking the visibility checkbox of image node A in the data manager. Now the user selects another segmentation child node of the already selected image B --> image A will not actively be hidden again

Has been resolved with D533.

However, there is a slightly different behavior now with the selection widgets:
The user cannot select segmentations of image B if image A is selected in the image selection widget (node predicates only allow child-nodes of the selected image node). That means:

Either I do not understand the change correctly, or I am against it.

I think node hirachy should not be a requirement to be selectable. Only the type of node and fitting geometry should. We e.g. have use cases where image and segmentation are on the same hirachy level. In this case it should still be possible to select both (if all other requirements are meet) and modify the segmentation.

Has been resolved with D533.

However, there is a slightly different behavior now with the selection widgets:
The user cannot select segmentations of image B if image A is selected in the image selection widget (node predicates only allow child-nodes of the selected image node). That means:

Either I do not understand the change correctly, or I am against it.

I think node hirachy should not be a requirement to be selectable. Only the type of node and fitting geometry should. We e.g. have use cases where image and segmentation are on the same hirachy level. In this case it should still be possible to select both (if all other requirements are meet) and modify the segmentation.

Ok than I did not explain it correctly. You are right, the node predicate that hinders the user from selecting a different segmentation node is not related to the node hierarchy but to the node geometry.
However, this is not something I changed but something that was already there before - so the typically expected behavior when we added the node selection widgets.
Here I just wanted to highlight that the auto-selection mechanism changed because of the selection widgets (and now you cannot select any arbitrary segmentation node as it was possible before (e.g. MITK 2018) when we had the data manager selection). This results in a slightly different auto-selection behavior.

kalali renamed this task from Auto-selection preference for Segmentation View was hijacked for something else to [Segmentation] Auto-selection preference for was hijacked for something else.Feb 16 2022, 9:49 AM
kalali renamed this task from [Segmentation] Auto-selection preference for was hijacked for something else to [Segmentation] Auto-selection preference was hijacked for something else.Feb 17 2022, 12:44 PM

@floca: I looked into this again because I was about to update the segmentation checklists according to D601 (merged segmentation views):
In the checklists it is still mentioned that clicking on data nodes in the data manager changes the selection / visibility of the segmentation nodes, if auto-selection mode is enabled.

With this task we reverted the changes that were done unwittingly (The auto-selection mode was changed such that the property / preference now controls the auto selection of a fitting node in the selection widgets. But that should not be the case, as stated in this task description).
So with the fixes made in D601 it is now possible again to show / hide segmentation nodes with the auto-selection mode. However, it is not possible anymore (since the time we introduced the data selection widgets at all), to select data nodes in the data manager and have them selected in the selection widgets and show / hide them according to the auto-selection mode.

Question: Is it correct that the user can not use the data manager anymore to select data and solely relies on the two data selection widgets? If so, I would rephrase the checklist accordingly.

This mode was renamed and has a new description now (see db87646fc7e7 of D601) to avoid confusion with the auto-selection feature of the node selection widgets.

WARNING: Preference auto selection was changed to selection mode.

Question: Is it correct that the user can not use the data manager anymore to select data and solely relies on the two data selection widgets? If so, I would rephrase the checklist accordingly.

Yes this is correct.

Proposed renaming makes sense.