Page MenuHomePhabricator
Create Task
Maniphest T28778

"Use constraint zooming and panning" is only applied after reinit/restart
Open, LowPublic
Actions

Description

Note: It's a Standard Multi Widget preference.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKde10d7d801c5 Apply correct zooming and panning when updating render window
Restricted Differential RevisionrMITK86a676bab050 Not set parameter for constraint zooming and panning in InitializeViews
Restricted Differential RevisionrMITK0dd13925b2cb Retrive base renderer only once
Restricted Differential RevisionrMITK5b54b904a6fe Directly apply changes in preferences to "use constraint zooming and panning"

Related Objects

Event Timeline

kislinsk triaged this task as Low priority.Oct 29 2021, 11:26 AM
kislinsk created this task.
kislinsk added subscribers: kahl, a178n.Oct 29 2021, 11:35 AM
kislinsk added a project: Checklist.Nov 10 2021, 4:29 PM
kahl claimed this task.Nov 15 2021, 9:04 AM
kahl added a comment.Nov 15 2021, 9:15 AM

Pushed new branch to rMITK MITK: bugfix/T28778-apply-constraint-zooming-panning.

kahl added a revision: Restricted Differential Revision.Nov 15 2021, 9:23 AM
kahl closed this task as Resolved by committing rMITK5b54b904a6fe: Directly apply changes in preferences to "use constraint zooming and panning".Nov 16 2021, 2:18 PM
kahl added a commit: rMITK5b54b904a6fe: Directly apply changes in preferences to "use constraint zooming and panning".
kahl added a commit: rMITK0dd13925b2cb: Retrive base renderer only once.
kahl added a commit: rMITK86a676bab050: Not set parameter for constraint zooming and panning in InitializeViews.
kahl added a commit: rMITKde10d7d801c5: Apply correct zooming and panning when updating render window.
kislinsk reopened this task as Open.EditedNov 17 2021, 3:33 PM
kislinsk raised the priority of this task from Low to Unbreak Now!.

This fix broke some rendering tests regarding scaling. Please fix/revert as soon as possible since these tests have precedence.

See the Ubuntu continuous or nightly clients on CDash.

kahl added a comment.Nov 18 2021, 10:40 AM

Pushed new branch to rMITK MITK: bugfix/T28778-fix-rendering-tests.

kalali added a subscriber: kalali.Nov 18 2021, 12:11 PM

Could we get an insight about what happened here?

kislinsk mentioned this in rMITKad99aa0b22b9: Revert changes to directly apply correct zooming and panning.Nov 18 2021, 2:16 PM
kislinsk mentioned this in rMITK1c4db16fd159: Revert changes to directly apply correct zooming and panning.
kislinsk added a comment.Nov 18 2021, 2:18 PM

Deleted branch from rMITK MITK: bugfix/T28778-fix-rendering-tests.

kislinsk lowered the priority of this task from Unbreak Now! to Low.Nov 18 2021, 2:18 PM
kislinsk mentioned this in T28902: 2021 Week 48 (Very Early December).Dec 3 2021, 12:41 PM
floca added a subscriber: floca.Feb 14 2022, 10:10 AM

What is the status here?

a) is everything fixed
b) the issue is fixed and landed and only the broken test remains
c) nothin is fixed or landed

Would be good update the issue accordingly. that people know what to do.

@kahl : are you activaly working on that issue? because it is claimed.

kahl removed kahl as the assignee of this task.Feb 14 2022, 10:25 AM

No I am not actively working on this issue. I proposed a change but as written in the comments, this broke some rendering test.
We did not investigate closer why this happened. So I reverted the change and currently the initial task is still not fixed.

kalali added a project: Next Milestone.Apr 28 2022, 10:38 AM
kislinsk edited projects, added MITK (v2022.10); removed Next Milestone, MITK.May 12 2022, 11:19 AM
kislinsk moved this task from Backlog to Tests/Checklists on the MITK (v2022.10) board.May 12 2022, 11:21 AM
floca moved this task from Tests/Checklists to Backlog on the MITK (v2022.10) board.Sep 7 2022, 5:15 PM
kislinsk added a comment.Sep 9 2022, 10:16 AM

Deleted branch from rMITK MITK: bugfix/T28778-apply-constraint-zooming-panning.

kislinsk edited projects, added MITK (v2023.04); removed MITK (v2022.10).Nov 23 2022, 3:52 PM
kislinsk edited projects, added MITK; removed MITK (v2023.04).Nov 30 2022, 12:22 PM
kalali mentioned this in T29536: Switching "constrained zooming and panning" is only applied after Standard Display is re-opened.Apr 21 2023, 1:49 PM
kislinsk merged a task: T29536: Switching "constrained zooming and panning" is only applied after Standard Display is re-opened.Apr 21 2023, 1:59 PM
MITK · MIC · IMSY · DKFZ