Page MenuHomePhabricator
Create Task
Maniphest T3163

clean up org.mitk.gui.qt.segmentation
Closed, ResolvedPublic
Actions

Description

The module was under heavy development during MITK 3M3. A couple of things should be done during the next few bug squashing parties:

  • it is unclear when Activated/Deactivated() are called. this could be replaced be Visible/Invisible or similar maybe
  • selection issues should be reviewed and cleaned (always notice and remember current selection, react only when visible)
  • above point should fix broken context menues when module is invisible
  • whole code structure and naming scheme should be reviewed for consistency
  • graphical testing should be considered

Related Objects
Search...

Event Timeline

maleike added projects: MITK, Bugzilla.Dec 14 2009, 11:37 AM
maleike added a subscriber: maleike.Jan 13 2010, 5:05 PM

Would be nice to have for release 1.0 -- clearer, less faulty, more maintainable code

maleike added a comment.Jan 29 2010, 8:08 PM

Automatic commit message seem to be broken right now, so this comes manually:

FIX (#3163): initial cleaning; pull out context-menu actions; clean up organ color list

  • all context menu actions were separated into a class QmitkSegmentationPostProcessing, saved around 300 lines
  • the list of known organ names and colors was cleaned up to be more maintainable

FIX (#3163): separating known (organ,color) list into QmitkSegmentationOrganNamesHandling.cpp; cleaned up method names; cleaned up includes

maleike added a comment.Feb 1 2010, 11:12 AM

[SVN revision 21170]
COMP (#3163): fix warning

maleike added a comment.Feb 3 2010, 11:59 PM

[SVN revision 21229]
FIX (#3163): major restructuring of code without changing functionality (at least it seems so after first tests)

maleike added a comment.Feb 4 2010, 12:31 AM

With the last commit, QmitkSegmentationView.cpp was reduced by around 100 lines of code without losing functionality. Application logic has been much simplified. In earlier commits around 400 lines of code concerning the DataManager context menu were separated into a file of its own.

Closing this bug now because the code is as clean as it gets. Remaining known issues are handled in separate bugs (see "blocks")

maleike added a comment.Feb 9 2010, 10:55 AM

[SVN revision 21261]
FIX (#3163): remove old bundle. replaced by org.mitk.gui.qt.segmentation

nolden added a subscriber: nolden.Jul 27 2011, 11:43 AM

Merging "applicazion modules" component with "ExtApp plugins"

nolden mentioned this in T3263: Autocropping segmentations produces offset (due to padding).Feb 24 2010, 4:09 PM
kislinsk reopened subtask T3116: Flight camera does not work as 'F' key is already hotkeyed as Open.Jun 27 2018, 1:05 PM
kislinsk closed subtask T3116: Flight camera does not work as 'F' key is already hotkeyed as Wontfix.Jun 27 2018, 1:10 PM
MITK · MIC · IMSY · DKFZ