Page MenuHomePhabricator
Feed Advanced Search

Dec 18 2018

kislinsk added a comment to T25759: MITK crashes when right clicking on missing segmentation label list in multilabel view.

Pushed new branch T25759-ContextMenuCrashInMultilabelSegmentation.

Dec 18 2018, 10:16 AMMITK (2018-04-2)
kislinsk claimed T25759: MITK crashes when right clicking on missing segmentation label list in multilabel view.

This happens if the source image is set to the original image and the segmentation is set to the converted image. It does not happen if the source image is set to the pseudo segmentation image (the image that is converted to the segmentation). The pixel value in the crashing function is set to -1 then but there is no label with this pixel value leading to a nullptr access.

Dec 18 2018, 10:12 AMMITK (2018-04-2)
kislinsk claimed T25760: MITK crashes when deleting files from Data Manager.
Dec 18 2018, 9:46 AMMITK
full added a comment to T25770: Dark theme not available for MAC.

no unfortunately not. A guy from the radiology department asked and he claimed that he downloaded the 2018-04 release. I'll ask him again

Dec 18 2018, 7:32 AMMITK

Dec 17 2018

kislinsk added a comment to T25770: Dark theme not available for MAC.

Dark mode is default on all platforms and it works for me on our macbook and mac minis. Do you have more information and are you really sure that you didn't use the 2016-11 release? 馃嵑 馃槃

Dec 17 2018, 5:13 PMMITK
full created T25774: Segmentation cannot be display when more than one segmetation-raw-image-pair is in Data Manager.
Dec 17 2018, 7:33 AMMITK

Dec 14 2018

full triaged T25770: Dark theme not available for MAC as Low priority.
Dec 14 2018, 3:53 PMMITK
full updated the task description for T25760: MITK crashes when deleting files from Data Manager.
Dec 14 2018, 3:50 PMMITK
kislinsk lowered the priority of T25754: Cannot use tools in multilabel segmentation view without restart from Normal to Low.

I mixed the Segmentation View and the Multilabel Segmentation View. It turned out that the latter one does not even have a protection against non-reinited image/segmentation pairs.

Dec 14 2018, 3:30 PMMissing Info, MITK
kislinsk closed T25750: 100% Opacity of segmentation maps after restart of multilabel segmentation tool as Resolved.
Dec 14 2018, 3:08 PMMITK (2018-04-2)
kislinsk added a comment to T25750: 100% Opacity of segmentation maps after restart of multilabel segmentation tool.

Pushed new branch T25750-SegmentationViewsResetOpacityOfSegmentations.

Dec 14 2018, 3:08 PMMITK (2018-04-2)
kalali added a comment to T25750: 100% Opacity of segmentation maps after restart of multilabel segmentation tool.

My initial thought was that I accidentally fixed a bug with the new context menu actions so looking closer into the original opacity-slider action in the old data manager might reveal the flaw that is responsible for this behavior.
Something like - not correctly setting the opacity using the opacity value from the data node when opening the context menu.

Dec 14 2018, 12:47 PMMITK (2018-04-2)
kislinsk added a comment to T25750: 100% Opacity of segmentation maps after restart of multilabel segmentation tool.

@kalali Thanks for looking into this. The bug that the Multilabel segmentation view resets the opacity to 1 is probably easy for me to fix for the upcoming bugfix release but I do not want to backport a big feature like the new context menu, which is out of the scope of a bugfix release. I may also try to sync the opacity slider to the opacity property in a seperate commit that we do not merge back to the master.

Dec 14 2018, 12:44 PMMITK (2018-04-2)
kislinsk raised the priority of T25754: Cannot use tools in multilabel segmentation view without restart from Low to Normal.
Dec 14 2018, 12:37 PMMissing Info, MITK
kislinsk added a comment to T25754: Cannot use tools in multilabel segmentation view without restart.

May it be that whenever the tools are deactivated that there is a message above like "please perform a reinit on the segmentation image"? I can reproduce your issue just by loading a scene file with your example image and a segmentation. Sometimes the tools are deactivated, and sometimes not (race condition of some kind). But the message is always shown when the tools are deactivated. The actual issue for me is, that the segmentation is not reinitialized even though the tools are activated right from the beginning, leading to very strange effects when using the tools.

Dec 14 2018, 12:36 PMMissing Info, MITK
full added a comment to T25760: MITK crashes when deleting files from Data Manager.

As briefly discussed in the hall way:
I load two files into the object manager. One file is the MR image, the other file holds the segmentation for the MR image. The file holding the segmentation is then converted into a segmentation (right click -> convert to segmentation). This leaves me with 3 files in the data manager.

Dec 14 2018, 12:20 PMMITK
kislinsk added a comment to T25760: MITK crashes when deleting files from Data Manager.

What do you mean by "the converted segmentation from this file"? So there's two or three files in the Data Manager?

Dec 14 2018, 11:21 AMMITK
kislinsk closed T25746: Multilabel segementation tools only available in the 0th time step as Resolved.
Dec 14 2018, 11:16 AMMITK (2018-04-2)
kislinsk added a comment to T25746: Multilabel segementation tools only available in the 0th time step.

Pushed new branch T25746-FixSegmentationToolsFor4DImages2.

Dec 14 2018, 8:57 AMMITK (2018-04-2)

Dec 13 2018

kislinsk claimed T25746: Multilabel segementation tools only available in the 0th time step.
Dec 13 2018, 3:15 PMMITK (2018-04-2)
kislinsk added a comment to T25746: Multilabel segementation tools only available in the 0th time step.
Dec 13 2018, 2:50 PMMITK (2018-04-2)
kislinsk added a comment to T25746: Multilabel segementation tools only available in the 0th time step.
Dec 13 2018, 2:11 PMMITK (2018-04-2)
kislinsk added a comment to T25746: Multilabel segementation tools only available in the 0th time step.
Dec 13 2018, 1:43 PMMITK (2018-04-2)
kislinsk closed T25756: Classic segmentation live wire tool crashes when changing image slice while creating contours as Resolved.

The LiveWire tool stores a reference to a PlaneGeometry as raw pointer. Of course this doesn't go well for long and the pointer is invalid when scrolling through the image slices while drawing a contour. I replaced the raw pointer by a smart pointer. I also cleaned up the code.

Dec 13 2018, 12:54 PMRestricted Project, MITK (2018-04-2)
kislinsk added a comment to T25756: Classic segmentation live wire tool crashes when changing image slice while creating contours.

Pushed new branch T25756-FixCrashInLiveWireTool.

Dec 13 2018, 12:35 PMRestricted Project, MITK (2018-04-2)
full updated the task description for T25759: MITK crashes when right clicking on missing segmentation label list in multilabel view.
Dec 13 2018, 9:50 AMMITK (2018-04-2)
kislinsk moved T25756: Classic segmentation live wire tool crashes when changing image slice while creating contours from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 13 2018, 9:07 AMRestricted Project, MITK (2018-04-2)
kislinsk triaged T25760: MITK crashes when deleting files from Data Manager as High priority.
Dec 13 2018, 9:02 AMMITK
kislinsk triaged T25759: MITK crashes when right clicking on missing segmentation label list in multilabel view as High priority.
Dec 13 2018, 9:01 AMMITK (2018-04-2)
full created T25760: MITK crashes when deleting files from Data Manager.
Dec 13 2018, 9:00 AMMITK
full created T25759: MITK crashes when right clicking on missing segmentation label list in multilabel view.
Dec 13 2018, 8:44 AMMITK (2018-04-2)

Dec 12 2018

kalali added a comment to T25750: 100% Opacity of segmentation maps after restart of multilabel segmentation tool.

I can reproduce your bug.
However, when using the latest master the problem is solved. I changed the context menu (and decoupled it from the data manager) and now everything works fine. This fix was done after the release.
However, one could discuss if reopening the multilabel segmentation plugin should actually reset the opacity to 100% or leave it as it is.

Dec 12 2018, 4:10 PMMITK (2018-04-2)
kislinsk triaged T25756: Classic segmentation live wire tool crashes when changing image slice while creating contours as Normal priority.
Dec 12 2018, 3:48 PMRestricted Project, MITK (2018-04-2)
kislinsk triaged T25750: 100% Opacity of segmentation maps after restart of multilabel segmentation tool as Normal priority.
Dec 12 2018, 3:43 PMMITK (2018-04-2)
kislinsk triaged T25754: Cannot use tools in multilabel segmentation view without restart as Low priority.
Dec 12 2018, 3:41 PMMissing Info, MITK
kislinsk placed T25746: Multilabel segementation tools only available in the 0th time step up for grabs.
Dec 12 2018, 10:32 AMMITK (2018-04-2)
kislinsk edited projects for T25746: Multilabel segementation tools only available in the 0th time step, added: MITK (2018-04-2); removed MITK.
Dec 12 2018, 10:26 AMMITK (2018-04-2)
kislinsk lowered the priority of T25748: Backported fixes (basically cherry-picked from master branch) from Normal to Wishlist.
Dec 12 2018, 10:24 AMMITK (2018-04-2)
kislinsk moved T25748: Backported fixes (basically cherry-picked from master branch) from Backlog to Release Management on the MITK (2018-04-2) board.
Dec 12 2018, 10:21 AMMITK (2018-04-2)
kislinsk triaged T25748: Backported fixes (basically cherry-picked from master branch) as Normal priority.
Dec 12 2018, 10:20 AMMITK (2018-04-2)
kislinsk created MITK (2018-04-2).
Dec 12 2018, 10:12 AM