This seems to be fixed. I tried to reproduce the crash, but everything works as expected. Can this bug be closed?

quite trivial, but I wrote a Change Request anyways...

[SVN revision 20103]
FIX (#2948): add Superclass::PrintSelf() to PrintSelf() method

[SVN revision 20102]
FIX (#2947): cleanup of PrintSelf() methods

[SVN revision 20085]
FIX (#2943): make all tool icons togglebuttons to allow using them.

now all tools but the rectangle tool are working again. The rectangle tool was never working, its action is currently not implemented. I added a warning to the log messages if it is activated.

Does this also apply for new EnhancedPointSetVtkMapper3D? (see T1692)

->Modified is called on the Pointset, but the Mappers seem to not register it. I could just call a RequestUpdateAll() from the widget, but this seems to be a bad workaround.

[SVN revision 20431]
FIX (#2939): explicitly call RequestUpdateAll() when pointset gets modified as workaround for PointSet/Mapper update problem

This should solve the update issue, but the real problem is in the pointset and/or mapper class.

(In reply to comment #2)

Is FileOpenAction the same thing that is used during Drag&Drop? Otherwise the
drag&drop piece of code should be modified as well.

DRag & Drop of scene files is handled in T2950, closing this one now.

[SVN revision 20060]
FIX (#2925): perform reinit if a scene file is loaded.

[SVN revision 20049]
FIX (#2924): add SetDefaultProperties() method for PlanarFigureMapper2D

[SVN revision 20054]
ENH (#2924): Add ColorProperty and newline at end of file

need core modification!

mechanism to create default properties is in place, additional properties can be added in mitk::PlanarFigureMapper2D::SetDefaultProperties().

You got the bug, because you are default assignee...

another try, another crash, another callstack...

screenshot of the call stack

another try, another crash, another callstack...

Build is finished, I'm copying it to the toolkits folder right now. It will be available at T:\Toolkits\windows\x64\QT-4.5.3_VC9.0_Bin at ~13:00 today.

requested configure:

Daniel, can you look into this?

you wrote the IsoSurface bundle, can you look into it?

Maybe a solution could be to use the Qt Signal/Slot mechanism to pass the message to the gui thread?

[SVN revision 20486]
FIX (#2799): correct handling for wired tools.
ENH: new DiscoverWiredTools() method to retrieve connected tools

[SVN revision 19786]
ENH (#2800): Add VER command to query if Polaris or Aurora is connected

[SVN revision 19787]
COMP (#2800): Add ReceiveLine() method and Get-Methods for serial port settings

The problem described in this bug report (duplicate TrackingTool objects on OpenConnection() -> CloseConntection() -> OpenConnection()) is fixed.

[SVN revision 20524]
FIX (#2799): return specific error message if serial port can not be opened. Remove duplicate definition of ErrorMessage

with the committed revision, you can now either select the device type manually as before by calling SetType() (for backward compatibility) or you just call OpenConnection() and it will query the tracking device if it is an Polaris or an Aurora. Note that other NDI devices are not supported yet. To support new tracking devices, extend the VER() method in mitk::NDIProtocol (and change the NDITrackingDevice class accordingly).

[SVN revision 19788]
FIX (#2800): SetMode() uses the m_Mode mutex now

all IGT classes now use mutexlockholder objects where appropriate.

[SVN revision 21907]
CHG (#2787): simplify code by using itk::MutexLockHolder

[SVN revision 21912]
CHG (#2787): simplify code by using itk::MutexLockHolder

party bug, can be done by anyone.

The CMake command file(TO_NATIVE_PATH path result) should convert the paths to windows style. See http://www.cmake.org/cmake/help/cmake2.6docs.html file command documentation.

It shouldn't, but yes, it does work. Still, changing it to native paths seems to be "more correct".

manual test proved that it is working, closing bug now.

[SVN revision 20127]
FIX (#2766): replace invalid file name characters with _

I didn't do any work yet, this is definitely party-able.

[SVN revision 20019]
ENH (#2760): Add Reader and Writer classes for PlanarFigure subclasses, add corresponding factories

[SVN revision 20020]
ENH (#2760): Add serializer for PlanarFigure subclasses

[SVN revision 20056]
ENH (#2760): call PlaceFigure() on loading to initialize the PlanarFigure correctly.

I'll be gone till monday, if this is urgent, someone else needs to continue the work.

[SVN revision 20018]
ENH (#2760): add optional bool parameter to SetControlPoint to allow setting control points with arbitrary id (needed for loading of planar figures)

With the last few commits, it is possible to serialize and deserialize planar figures.

Serialization of PlanarFigures seems to be working as far as I can tell. Michael, Mathias, please test and close this bug or report any open issues.

(In reply to comment #10)

Created an attachment (id=372) [details]
Error with serialization/de-serialization of PlanarFigure

With the following steps, an error occured on my system with saving/reloading
of PlanarFigures as seen in the screenshot:

• Loaded Pic3D.pic
• Created on polyon, one line, and one circle
• Each PlanarFigure is in one of the three standard views
• Saved project, closed the application, loaded project file again
• The scene is displayed as in the screenshot
• Strangely, when scrolling through the slices, all three (distorted)

PlanarFigures are displayed simultaneously in all three views, not only on a
particular slice (as it should be)

draft of reader and writer for planar figures

this patch contains an initial version of an xml based reader and writer class for planar figures.

[SVN revision 20051]
ENH (#2760): save and restore the PlaneGeometry of the PlanarFigure

Maybe the file loading should trigger an selection event. currently, it is annoying that you load an image but cant work with it until you manually select it in the data manager - even if it is the only existing data object!

This is a design choice. As far as I know, ITK objects that hold SmartPointer
to other objects do not get modified, if the objects that they hold get
modified.

(In reply to comment #1)

(The Modified event of PropertyList should only be
emitted if the list is changed, e.g. nodes removed or added.)

core modification needed, spec page is written.

[SVN revision 19630]
CHG (#2724): ImageWriter updates m_FileName if it decides to add the extension.

[SVN revision 21458]
FIX (#2709): add "color" and "opacity" as default properties

Don't call it Save Project, call it "Save Scene" or "Save Data Storage".
Also a "Reset" or "New" Button would be nice that empties the DataStorage and resets all views. Maybe even a "Load Scene" Button that automatically empties the DataStorage before loading a scene.

(In reply to comment #4)

Have you looked through the code in BaseProperty/PropertyList to check if/where
operator== is used? I guess, if at all, it is used during assignment via
SetProperty/ReplaceProperty. I am not sure if object comparison (instead of
pointer comparison) is really what most people expect.
Personally, I would prefer pointer comparison because pointers are what the
property name promises. I would let further comparisons to the user.

[SVN revision 19565]
ENH (#2687): add == operator

[SVN revision 19567]
FIX (#2687): compare transfer functions for equality, not pointers to transfer functions

PropertyListSerializationTest is using the == operator of these classes and all tests are passed as expected. Closing this bug now.

[SVN revision 19566]
FIX (#2687): compare lookup tables for equality, not pointers to lookup tables.

[SVN revision 19577]
FIX (#2687): remove debug output

some more warnings in that class:
http://mbits/cdash/viewBuildError.php?type=1&buildid=13969

dartclients are green, closing bug

removed in revision #19603

manual testing showed that it is working, closing bug now.

[SVN revision 19467]
ENH (#2657): add signal PointSelectionChanged that is emmitted whenever the selection of the underlying pointset changes

[SVN revision 20639]
FIX (#2655): Fixed wrong image statistics calculation due to wrong pixel center.

[SVN revision 20632]
FIX (#2655): fix view layout

[SVN revision 20131]
FIX (#2655): set state of DrawFourPointAngle action correctly

(In reply to comment #16)

also, it seems that a global reinit is missing if a scene file is loaded.
If I start with an empty project and load a scene, nothing is displayed in the
render windows until I click on "Global Reinit" in the DataManager or "Reset
View" in the render window context menus.

(In reply to comment #18)

Then this bug can be considered fixed, right?

also, it seems that a global reinit is missing if a scene file is loaded.
If I start with an empty project and load a scene, nothing is displayed in the render windows until I click on "Global Reinit" in the DataManager or "Reset View" in the render window context menus.

File/Open now loads .mitk scene files! But Drag&Drop of a .mitk scene file does not work yet (on Windows with a current checkout).

Now all DataStorage related classes throw exception objects with a meaningful error description. The test is still passed, closing this bug now.