Page MenuHomePhabricator
Feed Advanced Search

Aug 2 2016

schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

[SVN revision 21198]
ADD (#2401): Simple test for coordinate system consistency

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Reopened for adding (simple) test.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

[SVN revision 20225]
FIX (#2401): Use vnl has_nans() method, should be faster (inline)

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Hopefully everything fixed now. Closing

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

[SVN revision 19796]
FIX (#2401): Severe execution speed increase by Ivo.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Reopened. Still problems inside mitkGeometry3D.
See T2885.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Obsolete because already committed (in a even faster version).

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Also forgot to think of Geometry2D and it's childs, esp. PlaneGeometry.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Closing this bug now. Create a new one if still problems occur. This one's comment history is long enough.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Updated Files to change: added mitkGeometry3DTest.cpp, and mentioned it in Test description.
Marco, did you mean that or a more detailed test description?

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

There has been quite a discussion about this in ITK bug tracker (http://www.itk.org/Bug/view.php?id=6558).

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to F293: Geometry3D.patch.

Final_Patch

Aug 2 2016, 9:26 AM
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

[SVN revision 19702]
FIX (#2401): Display correct units again (Pixel in Index). Display world coordinates again.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Oh, the assertion removal does not belong to the fix, sorry.
But it is stupid there, anyway. If an int is >= 0 and not 0-7, is is surely >=8.
Will exchange it with an itk::ExceptionMacro.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

[SVN revision 19701]
FIX (#2401): Respect the half pixel shift of center in WorldToIndex and IndexToWorld transforms when it is a ImageGeometry.
Also replaced a useless assertion with an ExceptionMacro.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Again: Requesting Core Modification...

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to F292: Geometry3D.patch.

Final_Patch

Aug 2 2016, 9:26 AM
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Fixed bug with Ivo; Updated ChangeRequest;
-> Requesting Core Modification for Final patch.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Ignore the previous patches; this one is the only working

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Maybe it helps to add the Core guys to the Cc list?
Waiting for Core Change permission since a week now.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

"New Patch" does not solve the problem.
Also, only adding half a pixel to WorldToIndex return value does only solve the malposition effect, but still leaves the IsInside false calculation problem.
Ivo, could you take a look at it again with me?

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

New Patch

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Patch

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to F291: Geometry3D.patch.

New Patch

Aug 2 2016, 9:26 AM
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

The problem is that WorldToIndex seems to have an offset of half a pixel.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

ChangeRequest see Wiki

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Stole bug back from Thomas...

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2400: Wrong delete operator in NDIPassiveTool destructor.

Fixed in Rev. 18564

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added projects to T2400: Wrong delete operator in NDIPassiveTool destructor: MITK, Bugzilla.
Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to F288: ChangeRequest.txt.

ChangeRequest

Aug 2 2016, 9:26 AM
schwarzt added a comment to T2399: Point Operation deleted twice in PointSetTest.

Fixed in Rev. 18565

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added projects to T2399: Point Operation deleted twice in PointSetTest: MITK, Bugzilla.
Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2400: Wrong delete operator in NDIPassiveTool destructor.

Thanks, haven't found that.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to F290: Patch.txt.

Patch

Aug 2 2016, 9:26 AM
schwarzt added a comment to T2392: Improve templates for Change Requests.

Looks very good...

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added projects to T2392: Improve templates for Change Requests: MITK, Bugzilla.
Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2375: Output's Geometry is overwritten when update is called on ProcessObject.

Removed core mod flag.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2366: Possible varible overflow in region growing.

Fixed in Rev. 18499

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2366: Possible varible overflow in region growing.

Changed type to int;

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added projects to T2366: Possible varible overflow in region growing: MITK, Bugzilla.
Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added projects to T2351: Discuss integration/support of bit images in MITK: MITK, Bugzilla.
Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2334: Add quick&dirty toolbar for undo, crosshair visibility etc..

I don't really understand how you will add the buttons. Can you specify?

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2328: Modules in the Show View menu should be sorted.

Updated the change requests so hopefully even totally idiots may understand at least the concept of the change.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2328: Modules in the Show View menu should be sorted.

Second request for core modification allowance.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2328: Modules in the Show View menu should be sorted.

Solved in Rev. 18537

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to F273: ChangeRequest_v2.txt.

ChangeRequests_v2

Aug 2 2016, 9:26 AM
schwarzt added a comment to T2328: Modules in the Show View menu should be sorted.

Guess what this may contain...

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2328: Modules in the Show View menu should be sorted.

ChangeRequest.txt

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to F272: ChangeRequest.txt.

ChangeRequest.txt

Aug 2 2016, 9:26 AM
schwarzt added projects to T2327: Default answer in remove dialog to yes: MITK, Bugzilla.
Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to F271: ChangeRequest.txt.

ChangeRequest.txt

Aug 2 2016, 9:26 AM
schwarzt added a comment to T2320: Remove BUILD_IGT variable; always enable IGT Modules.

Done; IGT is now always build

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added projects to T2320: Remove BUILD_IGT variable; always enable IGT Modules: MITK, Bugzilla.
Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2317: MITK application is too slow.

Markus is already working on this...

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to F270: ChangeRequest.txt.

Change Request

Aug 2 2016, 9:26 AM
schwarzt added a comment to T2314: some binary image do not show up in 3D planes.

This is due to a change from Mathias, which turned off the mapping of color (RGBA) scalars (unsigned chars) through the lookup table for the 3D texture. Anyhow, binary images are also (single channel) unsigned chars, and bypassed the LookupTable too.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2314: some binary image do not show up in 3D planes.

Asking for Core Mod; raised severity to normal;

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2314: some binary image do not show up in 3D planes.

Change Request

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2314: some binary image do not show up in 3D planes.

Fixed in Rev. 18817

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2279: Interaction failure with installed MITK application from mitk.org.

Removed core mod flag.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2279: Interaction failure with installed MITK application from mitk.org.

Is now a duplicate of #2413: Controlled initialization of EventMapper and StateMachines. ->Closed.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2247: Fix mitkSceneIOTest.

Sorry, but this does not semm to be the problem. Please see Vista64-VM on DashBoard.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added projects to T2247: Fix mitkSceneIOTest: MITK, Bugzilla.
Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2246: Clean up basic data classes from unnecessary header includes....

Removed a lot of unnecessary includes. Moved mitkBaseProcess.h to Header of BaseData, as most subclasses need it in UpdateOutputInformation(). Added itkCommand.h to 3 subclasses, it was removed in the superclass.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added projects to T2246: Clean up basic data classes from unnecessary header includes...: MITK, Bugzilla.
Aug 2 2016, 9:26 AM · Bugzilla, MITK
schwarzt added a comment to T2195: Correctly initialize data objects (and reinitialize after clear).

Cannot commit momentary; Changes made to public MITK are:

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2195: Correctly initialize data objects (and reinitialize after clear).

Renamed because the problem is a bit more complex;
Many data objects are not correctly initialized.
All data objects that require "normal" Geometry3D's should use the method BaseData::InitializeTimeSlicedGeometry() and not their own.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2195: Correctly initialize data objects (and reinitialize after clear).

This is actually the correct behaviour (for BaseData).

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2195: Correctly initialize data objects (and reinitialize after clear).

Fixed in Rev. 18029

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added projects to T2188: LevelWindowWidget: Strg-Drag not working on upper side...: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added projects to T2189: Unload Dll when closing a bundle: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Auto-closed, Bugzilla, MITK
schwarzt added projects to T2162: Check if gl code in VtkPropRenderer::Resize() is really necessary: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2152: Enable 4D images in RigidRegistration.

Closed. More general time management problem.
Itm, slider works exclusively after a reinit on the 4D image.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added projects to T2152: Enable 4D images in RigidRegistration: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2152: Enable 4D images in RigidRegistration.

Works mostly (after reinit on the 4D image). Does not work after global reinit.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to F237: MITK_New.png.

Same image in MITK from 06/18/09

Aug 2 2016, 9:25 AM
schwarzt added a comment to T2144: Image interpolation failing in rotated images.

It seems only the default value for reslice interpolation changed to "Nearest".
Reassigned to me to find a useful algorithm for determining a start default.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added projects to T2143: Redesign PrintSelf() Methods of the Geometries: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added projects to T2144: Image interpolation failing in rotated images: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2144: Image interpolation failing in rotated images.

Same image in MITK from 06/18/09

MITK_New.png (1×3 px, 267 KB)

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2144: Image interpolation failing in rotated images.

Fixed in Rev. 17787

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added projects to T2142: Restore "Info" Button in DataManager: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to F236: MITK_3M_2.png.

MR image loaded in 3M_2 MITK

Aug 2 2016, 9:25 AM
schwarzt added projects to T2135: "Global Reinit" Button in RigidRegistration does not work: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2136: Disable build of IGT-Tutorial when MITK_BUILD_IGT is OFF....

No. IGT Tutorial is now always on, too.
-> Invalid

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added projects to T2136: Disable build of IGT-Tutorial when MITK_BUILD_IGT is OFF...: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added projects to T2112: Test for mitk::BaseData (mostly) missing: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2112: Test for mitk::BaseData (mostly) missing.

Commited basic test in Rev. 17593

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2111: CopyInformation of mitk::BaseData missing.

Fixed in Rev. 17592

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2112: Test for mitk::BaseData (mostly) missing.

Added a first version in Rev. 18470. Should be extended, though.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to F224: BDTest.patch.

Basic test for mitkBaseData class.

Aug 2 2016, 9:25 AM
schwarzt added a comment to T2112: Test for mitk::BaseData (mostly) missing.

Reassigned to Bugmanager. Eas< Party bug for beginners.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2111: CopyInformation of mitk::BaseData missing.

This patch should fix everything. Cannot commit in the moment.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to F223: copyinfo.patch.

Fix for the problem

Aug 2 2016, 9:25 AM
schwarzt added projects to T2111: CopyInformation of mitk::BaseData missing: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
schwarzt added a comment to T2096: CopyInformation of mitk::Surface missing.

Review result is that information is copied correctly and method GetNumberOfPolyData is not named correctly. And right, geometry is not considered by now, as BaseData does not copy anything.

Aug 2 2016, 9:24 AM · Bugzilla, MITK
schwarzt added a comment to T2096: CopyInformation of mitk::Surface missing.

Reviewed :)

Aug 2 2016, 9:24 AM · Bugzilla, MITK
schwarzt added a comment to T1983: Save 3D+t Data in Chili-Plug-In destroys the data in the data tree.

Committed in Qt4 repository in Rev. 18334.

Aug 2 2016, 9:24 AM · Bugzilla, MITK
schwarzt added a comment to T1983: Save 3D+t Data in Chili-Plug-In destroys the data in the data tree.

Severe bug in mitkImage. When loading data slice by slice, it is composed to greater units in mitkImage when necessary. When using GetChannelData(), after the creation of the first volume, ALL references to the imported slices are set to zero. ->All time steps above one that have not previously created are cleared.

Aug 2 2016, 9:24 AM · Bugzilla, MITK
schwarzt added a comment to T1983: Save 3D+t Data in Chili-Plug-In destroys the data in the data tree.

More details:

  • The image's source is 0
  • The Volumes for time steps the were not already displayed are not initialized (not a bug)
  • Somehow the renderer can init the missing volumes, but not the writer (?)
Aug 2 2016, 9:24 AM · Bugzilla, MITK