[SVN revision 21198]
ADD (#2401): Simple test for coordinate system consistency
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 2 2016
Reopened for adding (simple) test.
[SVN revision 20225]
FIX (#2401): Use vnl has_nans() method, should be faster (inline)
Hopefully everything fixed now. Closing
[SVN revision 19796]
FIX (#2401): Severe execution speed increase by Ivo.
Reopened. Still problems inside mitkGeometry3D.
See T2885.
Obsolete because already committed (in a even faster version).
Also forgot to think of Geometry2D and it's childs, esp. PlaneGeometry.
Closing this bug now. Create a new one if still problems occur. This one's comment history is long enough.
Updated Files to change: added mitkGeometry3DTest.cpp, and mentioned it in Test description.
Marco, did you mean that or a more detailed test description?
There has been quite a discussion about this in ITK bug tracker (http://www.itk.org/Bug/view.php?id=6558).
[SVN revision 19702]
FIX (#2401): Display correct units again (Pixel in Index). Display world coordinates again.
Oh, the assertion removal does not belong to the fix, sorry.
But it is stupid there, anyway. If an int is >= 0 and not 0-7, is is surely >=8.
Will exchange it with an itk::ExceptionMacro.
[SVN revision 19701]
FIX (#2401): Respect the half pixel shift of center in WorldToIndex and IndexToWorld transforms when it is a ImageGeometry.
Also replaced a useless assertion with an ExceptionMacro.
Again: Requesting Core Modification...
Fixed bug with Ivo; Updated ChangeRequest;
-> Requesting Core Modification for Final patch.
Ignore the previous patches; this one is the only working
Maybe it helps to add the Core guys to the Cc list?
Waiting for Core Change permission since a week now.
"New Patch" does not solve the problem.
Also, only adding half a pixel to WorldToIndex return value does only solve the malposition effect, but still leaves the IsInside false calculation problem.
Ivo, could you take a look at it again with me?
New Patch
Patch
The problem is that WorldToIndex seems to have an offset of half a pixel.
ChangeRequest see Wiki
Stole bug back from Thomas...
Fixed in Rev. 18564
Fixed in Rev. 18565
Thanks, haven't found that.
Looks very good...
Removed core mod flag.
Fixed in Rev. 18499
Changed type to int;
I don't really understand how you will add the buttons. Can you specify?
Updated the change requests so hopefully even totally idiots may understand at least the concept of the change.
Second request for core modification allowance.
Solved in Rev. 18537
Guess what this may contain...
ChangeRequest.txt
Done; IGT is now always build
Markus is already working on this...
This is due to a change from Mathias, which turned off the mapping of color (RGBA) scalars (unsigned chars) through the lookup table for the 3D texture. Anyhow, binary images are also (single channel) unsigned chars, and bypassed the LookupTable too.
Asking for Core Mod; raised severity to normal;
Change Request
Fixed in Rev. 18817
Removed core mod flag.
Is now a duplicate of #2413: Controlled initialization of EventMapper and StateMachines. ->Closed.
Sorry, but this does not semm to be the problem. Please see Vista64-VM on DashBoard.
Removed a lot of unnecessary includes. Moved mitkBaseProcess.h to Header of BaseData, as most subclasses need it in UpdateOutputInformation(). Added itkCommand.h to 3 subclasses, it was removed in the superclass.
Cannot commit momentary; Changes made to public MITK are:
Renamed because the problem is a bit more complex;
Many data objects are not correctly initialized.
All data objects that require "normal" Geometry3D's should use the method BaseData::InitializeTimeSlicedGeometry() and not their own.
This is actually the correct behaviour (for BaseData).
Fixed in Rev. 18029
Closed. More general time management problem.
Itm, slider works exclusively after a reinit on the 4D image.
Works mostly (after reinit on the 4D image). Does not work after global reinit.
Same image in MITK from 06/18/09
It seems only the default value for reslice interpolation changed to "Nearest".
Reassigned to me to find a useful algorithm for determining a start default.
Fixed in Rev. 17787
No. IGT Tutorial is now always on, too.
-> Invalid
Commited basic test in Rev. 17593
Fixed in Rev. 17592
Added a first version in Rev. 18470. Should be extended, though.
Basic test for mitkBaseData class.
Reassigned to Bugmanager. Eas< Party bug for beginners.
This patch should fix everything. Cannot commit in the moment.
Review result is that information is copied correctly and method GetNumberOfPolyData is not named correctly. And right, geometry is not considered by now, as BaseData does not copy anything.
Reviewed :)
Committed in Qt4 repository in Rev. 18334.
Severe bug in mitkImage. When loading data slice by slice, it is composed to greater units in mitkImage when necessary. When using GetChannelData(), after the creation of the first volume, ALL references to the imported slices are set to zero. ->All time steps above one that have not previously created are cleared.
More details:
- The image's source is 0
- The Volumes for time steps the were not already displayed are not initialized (not a bug)
- Somehow the renderer can init the missing volumes, but not the writer (?)