Page MenuHomePhabricator
Feed Advanced Search

Aug 2 2016

schroedt added a comment to T16047: Crash on scrolling in FastMarchingTool GUI.

To fix this we need the changes from T16019.
The parameter controls should be disabled on start up and use the same approach as in the bug mentioned above.

Aug 2 2016, 10:06 AM · MITK (2013-09), Bugzilla
schroedt added projects to T16031: Create planar ContourElement implmentation: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added projects to T16030: Enable possibility to use different ContourElement implmentations: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16022: Clear points is not working properly for the fast marching tools.

When clearing the seeds the pointset is completely renewed. So there are no callback functions for adding and deleting points. Can be solved by adding the SimpleMemberCommands again.

Aug 2 2016, 10:06 AM · MITK (2013-09), Bugzilla
schroedt added a comment to T16022: Clear points is not working properly for the fast marching tools.

Can be fixed with T16019

Aug 2 2016, 10:06 AM · MITK (2013-09), Bugzilla
schroedt added a comment to T16022: Clear points is not working properly for the fast marching tools.

Fixed with T16019

Aug 2 2016, 10:06 AM · MITK (2013-09), Bugzilla
schroedt added a comment to T16019: Disable confirm button after clearing points for fast marching 2d and 3d.

[705e4e]: Merge branch 'bug-16019-disable-fastmarching-confirm-button'

Merged commits:

2013-09-11 16:24:06 Tobias Schroeder [63cf59]
Fixed 3D FastMarching

Aug 2 2016, 10:06 AM · MITK (2013-09), Bugzilla
schroedt added a comment to T16019: Disable confirm button after clearing points for fast marching 2d and 3d.

New remote branch pushed: bug-16019-disable-fastmarching-confirm-button

Aug 2 2016, 10:06 AM · MITK (2013-09), Bugzilla
schroedt added a comment to T16019: Disable confirm button after clearing points for fast marching 2d and 3d.

It will be easy to disable the button, but the GUI must somehow get notified to enable the button again. The tools shoul emit a message if the segmentation is ready to be confirmed.

Aug 2 2016, 10:06 AM · MITK (2013-09), Bugzilla
schroedt added projects to T16005: Move ContourUtils to contouring module: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16006: Implement a container for ContourModel objects..

New remote branch pushed: bug-16006-ContourModelSet-integration

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16006: Implement a container for ContourModel objects..

[4280bd]: Merge branch 'bug-16006-ContourModelSet-integration'

Merged commits:

2013-09-11 09:57:43 Tobias Schroeder [e239ab]
Check access inside bounds.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16005: Move ContourUtils to contouring module.

[b7e6c3]: Merge branch 'bug-16005-ContourUtils-integration'

Merged commits:

2014-02-13 15:35:06 Tobias Schroeder [27e0d5]
Removed unused code

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16006: Implement a container for ContourModel objects..

Added mitkContourModelSet containing a std::deque of ContourModel objects.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16006: Implement a container for ContourModel objects..

[068da8]: Merge branch 'bug-16006-fix'

Merged commits:

2013-10-18 11:04:47 Tobias Schroeder [25d5a4]
COMP: fix use of TimeGeometry.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16005: Move ContourUtils to contouring module.

Since T15982 was fixed there is no more ipSegmentation dependency for utility function FillContourInSlice. ContourUtils has been moved to ContourModel module and was renamed to ContourModelUtils to avoid naming conflicts. All methods are now static member functions so no instance of ContourModelUtils is needed.
We are still keeping a legacy support of ContourUtils for class mitk::Contour in Segmentation module.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16005: Move ContourUtils to contouring module.

[f4f4d9]: Merge branch 'bug-16005-fix-windows-build-error'

Merged commits:

2014-02-14 11:16:45 Tobias Schroeder [3a08d9]
COMP: fix missing ContourModel_EXPORT in ContourModelUtils.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16006: Implement a container for ContourModel objects..

New remote branch pushed: bug-16006-ContourModelSet

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added projects to T16006: Implement a container for ContourModel objects.: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16004: Implement a controller for Segmentation module..

Controller class is responsible for handling the result of segmentation tools and also the working and the reference image. So far only AcceptSegmetation methods have been implemented. All methods from SegTool2D were extracted and marked as deprecated. The handling of the image has been moved to T16212

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16004: Implement a controller for Segmentation module..

Waiting for interaction testing framework to test tools with segmentation controller.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16004: Implement a controller for Segmentation module..

Controller handles segmentation image data (reference and working image). ToolManager gets a controller as member and passes all image requests to controller object. Thus the application can use several different ToolManager and SegmentationController instances at the same time.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16004: Implement a controller for Segmentation module..

New remote branch pushed: bug-16004-SegmentationController

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added projects to T16004: Implement a controller for Segmentation module.: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16004: Implement a controller for Segmentation module..

Reopen bug.
Controller is not working as intended.
Storing of contours has been moved to segmentation data type so AcceptSegmentation methods of SegmentationController have to be redesigned.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T16004: Implement a controller for Segmentation module..

New remote branch pushed: bug-16004-SegmentationController-integration

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added projects to T15985: IpSegmentation free SegmentationInterpolationController: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · MITK (2016-03), Bugzilla
schroedt added projects to T15984: IpSegmentation free CorrectorTool: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15982: IpSegmentation free ContourUtils.

We are now using some VTK based filters to fill a contour in a 2D binary image.

  • vtkPolyDataToImageStencil
  • vtkImageStencil
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added projects to T15983: IpSegmentation free RegionGrowing 2D: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15981: Get rid of IpSegmentation in Segmentation module.
  • SegmentationInterpolationController uses mitkShapeBasedInterpolationAlgorithm.cpp
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added projects to T15981: Get rid of IpSegmentation in Segmentation module: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added projects to T15982: IpSegmentation free ContourUtils: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15947: Exception thrown from ctkPluginContextPrivate::isPluginContextValid() when closing the workbench.

Occurs on MacOS too.

Aug 2 2016, 10:06 AM · MITK (2013-09), Bugzilla
schroedt added projects to T15918: Implement contour cutter for 2D rendering: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added projects to T15880: Debug assertion in ContourModelSubDivisionFilter: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15880: Debug assertion in ContourModelSubDivisionFilter.

[b85ffc]: Merge branch 'bug-15880-Debug-assertion-ContourModelSubdivisionFilter'

Merged commits:

2013-08-19 11:32:04 Tobias Schroeder [81006a]
Use SetNthOutput

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15880: Debug assertion in ContourModelSubDivisionFilter.

New remote branch pushed: bug-15880-Debug-assertion-ContourModelSubdivisionFilter

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15876: new threshold tool does not work for float images with values < 1.

New remote branch pushed: bug-15876-threshold-tool-with-float-images

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15876: new threshold tool does not work for float images with values < 1.

[0c119d]: Merge branch 'bug-15876-ThresholdTool-fix-for-float-images'

Merged commits:

2013-10-18 11:50:18 Tobias Schroeder [d509a3]
Merge branch 'bug-15876-threshold-tool-with-float-images' into bug-15876-ThresholdTool-fix-for-float-images

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15876: new threshold tool does not work for float images with values < 1.

Thresholding tool is working with single threshold value (mitkBinaryThresholTool). The issue with the tool that uses two thresholds (mitkBinaryThresholdULTool) is due to casting the slider values to int. A solution would be to use the same appraoch as BinaryThresholdTool for its slider.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to F1028: StrangeCut.PNG.

Contour cut gone wrong.

Aug 2 2016, 10:06 AM
schroedt added a comment to T15870: ContourModel is strangely rendered in oblique planes.

Contour appears projected on axial view in instead of cut.

StrangeCut.PNG (404×744 px, 73 KB)

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15870: ContourModel is strangely rendered in oblique planes.

[c96ae3]: Merge branch 'bug-15870-contour-in-oblique-planes'

Merged commits:

2013-08-26 13:50:09 Tobias Schroeder [ee0417]
Perfomance issues in UpDateOutputInformation fixed.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15870: ContourModel is strangely rendered in oblique planes.

Moved contour cut issue to T15918

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added projects to T15870: ContourModel is strangely rendered in oblique planes: MITK, Bugzilla.
Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15870: ContourModel is strangely rendered in oblique planes.

New remote branch pushed: bug-15870-contour-in-oblique-planes

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15870: ContourModel is strangely rendered in oblique planes.

If current point is close enough to the current rendering plane a bool flag was set to true. This flag was never changed to false for the following points. So all points were drawn no matter if they were far away from the plane.

Aug 2 2016, 10:06 AM · Bugzilla, MITK
schroedt added a comment to T15828: ToolManagerProvider as Micro Service.

Note:
This only affects the use of ToolManager within Segmentation plugin, nothing will be changed in ToolManager class. There will also be no changes to the current interaction implementation (Tool framework). The migration will be done with T14943.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15828: ToolManagerProvider as Micro Service.

I have introduced a module activator (mitk::SegmentationModuleActivator) that registers services for the Segmentation Module. It now registers a ToolManagerProvider service that can be called to get an instance of mitk::ToolManager. As the service itself is a singleton there will be only one object of ToolManager. So if the service is used within Segmentation plugin it is ensured that everybody uses the instance.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15828: ToolManagerProvider as Micro Service.

[2902dc]: Merge branch 'bug-15828-ToolManagerProvider-integration'

Merged commits:

2013-08-23 13:34:57 Tobias Schroeder [ddb1fa]
Fix namespace.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added projects to T15828: ToolManagerProvider as Micro Service: MITK, Bugzilla.
Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15828: ToolManagerProvider as Micro Service.

New remote branch pushed: bug-15828-ToolManagerProvider-integration

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15820: 2d images can no longer be saved as bmp.

.bmp:

  • It only occurs for 2D images that are saved as 3D with single slice.
  • It works for images that also have a 2D Geometry.
Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15820: 2d images can no longer be saved as bmp.

*no chance to edit a comment*

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15820: 2d images can no longer be saved as bmp.

[659952]: Merge branch 'bug-15820-save-2D-images-as-bmp'

Merged commits:

2013-08-14 16:28:11 Tobias Schroeder [d4d730]
Check all support picture formats.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15820: 2d images can no longer be saved as bmp.

New remote branch pushed: bug-15820-save-2D-images-as-bmp

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15820: 2d images can no longer be saved as bmp.

We also changed the mitkImageWriterTest to cover all supported picture formats.
During the implementation we've noticed that PixelType comparison won't work for this. Not all of the bit sizes can be used. E.g. PNGs max bit size for grayscale images is 16. So the images won't have the same PixelType after saving and loading again.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15808: Store contours of segmentation tool.

Issue moved to T16497.
Feature will be introduced with new segmentation data type.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15808: Store contours of segmentation tool.

New remote branch pushed: bug-15808-ContourManager-integration

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added projects to T15808: Store contours of segmentation tool: MITK, Bugzilla.
Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15808: Store contours of segmentation tool.

New remote branch pushed: bug-15808-ContourManager-integration-2

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15808: Store contours of segmentation tool.

New remote branch pushed: bug-15808-keep-contours-for-segmentation

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15808: Store contours of segmentation tool.

New remote branch pushed: bug-15808-ContourManager-store-contours

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to F1026: Requirements.pdf.

Requirements

Aug 2 2016, 10:05 AM
schroedt added a comment to T15804: Disable interaction with contour objects after deactivating LiveWire tool.

Has already been fixed

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added projects to T15804: Disable interaction with contour objects after deactivating LiveWire tool: MITK, Bugzilla.
Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15779: Description of LiveWire tool in UI.

New remote branch pushed: bug-15779-LiveWire-tool-description

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15779: Description of LiveWire tool in UI.

[65d3ed]: Merge branch 'bug-15779-LiveWire-tool-description'

Merged commits:

2013-08-06 11:50:38 Tobias Schroeder [3f80e3]
Changed max size of description text.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added projects to T15779: Description of LiveWire tool in UI: MITK, Bugzilla.
Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added projects to T15780: Add description for FastMarching Tool in UI: MITK, Bugzilla.
Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15763: ContourModel bundle.

The IpSegmentation free ContourUtils is found in T15982

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15763: ContourModel bundle.

New remote branch pushed: bug-15763-ContourModel-Modul

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15763: ContourModel bundle.

[cff5b5]: Merge branch 'bug-15763-move-classes-into-new-module'

Merged commits:

2013-09-09 15:30:21 Andreas Fetzer [60a45d]
Renamed Module in the CMakeLists

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15763: ContourModel bundle.

Added a ContourObjectFactory for Mappers and IO classes and fixed some of the filters. (Changes were done in bug-15763-move-classes-into-new-module).

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15763: ContourModel bundle.

Renamed module to ContourModel.
mitk::ContourUtils needs to be moved to ContourModel module as soon as it has no dependency to IpSegmentation (see T15982 and T16005).

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15686: SurfaceInterpolationController throws execption in case of 4D images.

This bug occured after T15676 was fixed. Changed severity because the application is in corrupt state afterwards.

Aug 2 2016, 10:05 AM · MITK (2013-09), Bugzilla
schroedt added a comment to T15687: Feedback contour is not visible for time step > 1.

New remote branch pushed: bug-15687-feedback-contour-for-4D-segmentations

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added projects to T15687: Feedback contour is not visible for time step > 1: MITK, Bugzilla.
Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15687: Feedback contour is not visible for time step > 1.

All access functions to contour vertices had to be adapted within the tools. Also ContourUntils had to be extented for FillContourInSlice to specify the time step due to 2D slice .

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15687: Feedback contour is not visible for time step > 1.

Time steps greater than 1 could only be tested after T15676 was fixed.
The contour is not visible because all segmentations tools are adding vertices at the default time step, which is 0.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added projects to T15686: SurfaceInterpolationController throws execption in case of 4D images: MITK, Bugzilla.
Aug 2 2016, 10:05 AM · MITK (2013-09), Bugzilla
schroedt added a comment to T15676: Crash while creating segmentation image for 3D+t images.

The problem was that memset has accessed memory that was not allocated for the image itself. The volumes for each time step seem not to be continuous in memory. memset is now executed separately for each volume in case of 4D data.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added projects to T15676: Crash while creating segmentation image for 3D+t images: MITK, Bugzilla.
Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added projects to T15650: Migrate mitk::Contour to mitk::ContourModel: MITK, Bugzilla.
Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15650: Migrate mitk::Contour to mitk::ContourModel.

Switched to mitkContourModel for Tools using contour to visualize segmentation result. All classes that inherit from mitkFeedbackContourTool are using mitkContourModel.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15650: Migrate mitk::Contour to mitk::ContourModel.

Fixed by integration of UI redesign branch

Aug 2 2016, 10:05 AM · Bugzilla, MITK
schroedt added a comment to T15589: Confirm dialog for 3D segmentation tools.

Seems to be fixed in current master

Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
schroedt added a comment to T15391: FastMarchingTool3D deletes all time steps of segmentation image..

Set volume at current time step by SetVolume(void*, t) with itk filter output data.

Aug 2 2016, 10:04 AM · Bugzilla, MITK
schroedt added a comment to T15391: FastMarchingTool3D deletes all time steps of segmentation image..

New remote branch pushed: bug-15391-FastMarching3D-deletes-time-steps

Aug 2 2016, 10:04 AM · Bugzilla, MITK
schroedt added projects to T15391: FastMarchingTool3D deletes all time steps of segmentation image.: MITK, Bugzilla.
Aug 2 2016, 10:04 AM · Bugzilla, MITK
schroedt added a comment to T15372: Region Growing deactivates segmentation function.

Fixed with UI redesign of segmentation plugin. A RegionGrowing view is no longer available. We have tested the mentioned steps with current master.

Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
schroedt added a comment to T15282: Segmentation UI Redesign - 3D Interactive RegionGrower.

Reopen bug - compiler errors on linux

Aug 2 2016, 10:03 AM · Bugzilla, MITK
schroedt added a comment to T15282: Segmentation UI Redesign - 3D Interactive RegionGrower.

New remote branch pushed: bug-15282-3D-RegionGrower

Aug 2 2016, 10:03 AM · Bugzilla, MITK
schroedt added a comment to T15282: Segmentation UI Redesign - 3D Interactive RegionGrower.

Added a dummy Tool class to be handled by ToolManager and changed the RegionGrower widget class to act as a Tool GUI. So activating AdaptiveRegionGrowingTool now shows up the the UI above the tool button in the 3D ToolGUIArea of QmitkSegmentationView. Also some changes had to be done to combine the binary segmentation image with the RegionGrowing preview.

Aug 2 2016, 10:03 AM · Bugzilla, MITK
schroedt added a comment to T15282: Segmentation UI Redesign - 3D Interactive RegionGrower.

Fix compiler errors - missing typename

Aug 2 2016, 10:03 AM · Bugzilla, MITK
schroedt added projects to T15281: Add confirm button to LiveWireTool: MITK, Bugzilla.
Aug 2 2016, 10:03 AM · Bugzilla, MITK
schroedt added projects to T15282: Segmentation UI Redesign - 3D Interactive RegionGrower: MITK, Bugzilla.
Aug 2 2016, 10:03 AM · Bugzilla, MITK
schroedt added a comment to T15149: Redesign Segmentation Plugin - Add FastMarching tool 2D.

Added a Tool to work on 2D slice to perform FastMarching segmentation.

Aug 2 2016, 10:03 AM · Bugzilla, MITK
schroedt added a comment to T15149: Redesign Segmentation Plugin - Add FastMarching tool 2D.

New remote branch pushed: bug-15149-FastMarching-2D

Aug 2 2016, 10:03 AM · Bugzilla, MITK