Page MenuHomePhabricator
Feed All Stories

Sep 24 2020

wiesenfa moved T27685: changes in subset() from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 3:23 PM · challengeR (v1.0)
wiesenfa added a comment to T27685: changes in subset().

taskSubset is deprecated
there is now
subset(x, top, tasks)

  • if top is specified subset to top algorithms (only applicable to single task challenges)
  • if tasks is specified subset of tasks (only applicable to multi task challenges)
Sep 24 2020, 3:22 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGERaf8f561d7b94: fix subset(), remove taskSubset() (authored by wiesenfa).
fix subset(), remove taskSubset()
Sep 24 2020, 3:20 PM
wiesenfa updated subscribers of T27775: only export functions to be used by user.
Sep 24 2020, 3:17 PM · challengeR
wiesenfa triaged T27775: only export functions to be used by user as Low priority.
Sep 24 2020, 3:17 PM · challengeR
wiesenfa claimed T27326: autolayout networks in multi task report ugly.
Sep 24 2020, 2:43 PM · challengeR
wiesenfa moved T27708: ggplot2 dendrogram from Backlog to In Progress on the challengeR (v1.0) board.
Sep 24 2020, 2:42 PM · challengeR
wiesenfa added a comment to T27748: Decide on limit for algorithms in plot legends.

20 might be a sensible number

Sep 24 2020, 2:42 PM · challengeR (v1.0)
wiesenfa moved T27714: Report contains weird R output from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 2:40 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGERd34e4efe8ea5: fix output classes (authored by wiesenfa).
fix output classes
Sep 24 2020, 2:40 PM
wiesenfa placed T27288: separate readme.md and readme.Rmd up for grabs.
Sep 24 2020, 2:27 PM · challengeR (v1.0)
wiesenfa claimed T27708: ggplot2 dendrogram .
Sep 24 2020, 2:26 PM · challengeR
wiesenfa moved T27714: Report contains weird R output from Backlog to In Progress on the challengeR (v1.0) board.
Sep 24 2020, 2:26 PM · challengeR (v1.0)
wiesenfa claimed T27714: Report contains weird R output.
Sep 24 2020, 2:26 PM · challengeR (v1.0)
wiesenfa added a comment to T27770: Inconsistency in report description.

the sentence can be dropped. But wasn't it planned to revise the text in line with the paper in total?

Sep 24 2020, 2:23 PM · challengeR (v1.0)
kompan committed rMITKbb4bf944dcc2: Revise segmentation plugin documentation (T27093). (authored by kompan).
Revise segmentation plugin documentation (T27093).
Sep 24 2020, 1:53 PM
kompan committed rMITK4ae15b5a8910: Additional information for watershed segmentation tool. (authored by kompan).
Additional information for watershed segmentation tool.
Sep 24 2020, 1:53 PM
kompan committed rMITK36a793284d56: Additional notes for 2D region growing tool. (authored by kompan).
Additional notes for 2D region growing tool.
Sep 24 2020, 1:53 PM
kompan committed rMITKaed895a043e3: Add section on 3D+t segmentation. (authored by kompan).
Add section on 3D+t segmentation.
Sep 24 2020, 1:53 PM
kompan committed rMITKffacadc3f7db: Add literature references to watershed segmentation. (authored by kompan).
Add literature references to watershed segmentation.
Sep 24 2020, 1:53 PM
kompan committed rMITK28d0ee0db34b: Correct typo. (authored by kompan).
Correct typo.
Sep 24 2020, 1:53 PM
kompan committed rMITK7cff72bed516: Clarification for 3D Otsu description. (authored by kompan).
Clarification for 3D Otsu description.
Sep 24 2020, 1:53 PM
kompan committed rMITK8e6f7cd8d5eb: Correct typo and reword. (authored by kompan).
Correct typo and reword.
Sep 24 2020, 1:53 PM
kompan committed rMITKc70686df761a: Correct sonsistency sub-nodes/subnodes. Rename all to sub-nodes. (authored by kompan).
Correct sonsistency sub-nodes/subnodes. Rename all to sub-nodes.
Sep 24 2020, 1:53 PM
kompan committed rMITK41ceff77e4ba: Sort out 2D and 3D interpolation layout. (authored by kompan).
Sort out 2D and 3D interpolation layout.
Sep 24 2020, 1:53 PM
kompan committed rMITK9e82009c940e: Correct typos. (authored by kompan).
Correct typos.
Sep 24 2020, 1:53 PM
kompan committed rMITK07eaebccf295: Correct typos. (authored by kompan).
Correct typos.
Sep 24 2020, 1:53 PM
kompan committed rMITKc2d3cf488263: Correct typos. (authored by kompan).
Correct typos.
Sep 24 2020, 1:53 PM
kompan committed rMITKc59b0ee2bf3d: Correct typo. (authored by kompan).
Correct typo.
Sep 24 2020, 1:53 PM
kompan committed rMITK00b8f7d66a99: Correct typo. (authored by kompan).
Correct typo.
Sep 24 2020, 1:53 PM
kompan committed rMITK4192875b179c: Use coronal instead of frontal. (authored by kompan).
Use coronal instead of frontal.
Sep 24 2020, 1:53 PM
kompan committed rMITK6a11e86ae2fd: Rephrase section on RGB image suppport. (authored by kompan).
Rephrase section on RGB image suppport.
Sep 24 2020, 1:53 PM
kompan committed rMITK5c9ba38c36ef: Fix upper/lower case writing of segmentation view and plugin. (authored by kompan).
Fix upper/lower case writing of segmentation view and plugin.
Sep 24 2020, 1:53 PM
kompan committed rMITK862ba9a70b69: Description updates and typo corrections. (authored by kompan).
Description updates and typo corrections.
Sep 24 2020, 1:53 PM
kompan committed rMITK01aa7a49a255: Correct segmentation plugin overview image. (authored by kompan).
Correct segmentation plugin overview image.
Sep 24 2020, 1:53 PM
kompan committed rMITK3e107abbe027: Update 3D segmentation tools figures. (authored by kompan).
Update 3D segmentation tools figures.
Sep 24 2020, 1:53 PM
kompan committed rMITK520b308b4175: Update documentation and images. (authored by kompan).
Update documentation and images.
Sep 24 2020, 1:53 PM
kompan committed rMITK5af0f354a116: Rename gui_qt to views for consistent naming. (authored by kompan).
Rename gui_qt to views for consistent naming.
Sep 24 2020, 1:53 PM
eisenman added a comment to T27774: wrong text in report on algorithm subsets.

Ok, weird. For me it says: "The top 5 out of 5 algorithms are considered."

your result is strange given the fact that not the correct things are actually counted

Sep 24 2020, 1:16 PM · challengeR (v1.0)
wiesenfa moved T27685: changes in subset() from Backlog to In Progress on the challengeR (v1.0) board.
Sep 24 2020, 1:16 PM · challengeR (v1.0)
wiesenfa claimed T27685: changes in subset().
Sep 24 2020, 1:16 PM · challengeR (v1.0)
wiesenfa added a comment to T27774: wrong text in report on algorithm subsets.

Ok, weird. For me it says: "The top 5 out of 5 algorithms are considered."

Sep 24 2020, 1:13 PM · challengeR (v1.0)
wiesenfa added a comment to T27774: wrong text in report on algorithm subsets.
  1. it won't be more that I needed for the missing data description I guess;-) I still think that this sentence should be avoided if no subset is in fact used
Sep 24 2020, 1:11 PM · challengeR (v1.0)
wiesenfa moved T27453: Create complete network plot in its function from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 1:09 PM · challengeR (v1.0)
wiesenfa added a comment to T27453: Create complete network plot in its function.

this is more or less what I tried, ugliness is T27326. I think a ggplot solution mentioned there would be better

Sep 24 2020, 1:08 PM · challengeR (v1.0)
wiesenfa moved T27452: Provide plot function for dendrogram from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 1:07 PM · challengeR (v1.0)
wiesenfa moved T27337: Report contains wrong ranking method when rank-then-aggregate is used from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 1:06 PM · challengeR (v1.0)
wiesenfa moved T27294: add multiple figure output formats in report with option clean=TRUE from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 1:05 PM · challengeR (v1.0)
wiesenfa added a comment to T27294: add multiple figure output formats in report with option clean=TRUE.

report gains new argument "dpi" to change resolution

Sep 24 2020, 1:05 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER88b673042288: set dpi default to 150 (authored by wiesenfa).
set dpi default to 150
Sep 24 2020, 1:05 PM
wiesenfa committed rCHALLENGER88e1de7d8cc3: set dpi default to 300 (authored by wiesenfa).
set dpi default to 300
Sep 24 2020, 1:05 PM
wiesenfa committed rCHALLENGERb2891c3b4f02: Merge branch 'develop' of https://phabricator.mitk.org/source/challenger into… (authored by wiesenfa).
Merge branch 'develop' of https://phabricator.mitk.org/source/challenger into…
Sep 24 2020, 1:00 PM
wiesenfa committed rCHALLENGERc66c18f1fbcd: allow setting dpi (authored by wiesenfa).
allow setting dpi
Sep 24 2020, 1:00 PM
eisenman claimed T27774: wrong text in report on algorithm subsets.
  1. I think it will be confusing if it writes "top 5 of 5 algorithms", I would put an if
  2. which changes? as.challenge does not have a full data attribute. The changes in subset have been done by you, see my comments in T27685.
Sep 24 2020, 12:53 PM · challengeR (v1.0)
eisenman added a comment to T27774: wrong text in report on algorithm subsets.

Ok, weird. For me it says: "The top 5 out of 5 algorithms are considered."

Sep 24 2020, 12:32 PM · challengeR (v1.0)
eisenman moved T27773: package dependencies from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 12:23 PM · challengeR (v1.0)
eisenman committed rCHALLENGER64f2452c0f45: Merge branch 'feature/T27773-FixPackageDependencies' into develop (authored by eisenman).
Merge branch 'feature/T27773-FixPackageDependencies' into develop
Sep 24 2020, 12:23 PM
eisenman committed rCHALLENGERce606a59b22c: Move ggplot2 and purrr to Depends (authored by eisenman).
Move ggplot2 and purrr to Depends
Sep 24 2020, 12:20 PM
wiesenfa added a comment to T27774: wrong text in report on algorithm subsets.
set.seed(4)
strip=runif(n,.9,1)
c_ideal=cbind(task="c_ideal",
              rbind(
                      data.frame(alg_name="A1",value=runif(n,.9,1),case=1:n),
                      data.frame(alg_name="A2",value=runif(n,.8,.89),case=1:n),
                      data.frame(alg_name="A3",value=runif(n,.7,.79),case=1:n),
                      data.frame(alg_name="A4",value=runif(n,.6,.69),case=1:n),
                      data.frame(alg_name="A5",value=runif(n,.5,.59),case=1:n)
              ))
challenge=as.challenge(c_ideal, 
                       algorithm="alg_name", case="case", value="value",
                       smallBetter = T)
ranking=challenge%>%aggregateThenRank(FUN = "mean", # aggregation function, 
                                      na.treat="na.rm", # either "na.rm" to remove missing data, 
                                      ties.method = "min" # a character string specifying 
)
Sep 24 2020, 12:18 PM · challengeR (v1.0)
eisenman claimed T27773: package dependencies.
Sep 24 2020, 12:12 PM · challengeR (v1.0)
eisenman added a comment to T27774: wrong text in report on algorithm subsets.

currently It says "The top 0 out of 0 algorithms are considered." in my latest example

Sep 24 2020, 12:07 PM · challengeR (v1.0)
wiesenfa moved T27338: Report contains misleading information on missing values from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 12:07 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER0e1a1e5dae75: description of missings in reports+as.challenge (authored by wiesenfa).
description of missings in reports+as.challenge
Sep 24 2020, 12:06 PM
wiesenfa added a comment to T27774: wrong text in report on algorithm subsets.

currently It says "The top 0 out of 0 algorithms are considered." in my latest example

Sep 24 2020, 11:46 AM · challengeR (v1.0)
wiesenfa added a comment to T27774: wrong text in report on algorithm subsets.
  1. I think it will be confusing if it writes "top 5 of 5 algorithms", I would put an if
  2. which changes? as.challenge does not have a full data attribute. The changes in subset have been done by you, see my comments in T27685.
Sep 24 2020, 11:45 AM · challengeR (v1.0)
eisenman added a comment to T27774: wrong text in report on algorithm subsets.
  1. This is on purpose as I wanted to avoid further nested ifs, but can be discussed.
  2. This was the only variable where I found all algorithm factors. How can they be accessed now? fulldata is not working anymore after you latest changes.
Sep 24 2020, 11:40 AM · challengeR (v1.0)
wiesenfa added a comment to T27773: package dependencies.

yes I think so. maybe you have purrr (or dplyr) and ggplot loaded in the workspace.
packages in depends are loaded at startup (and we need these package to be available by the user). imports does not load the packages, functions of challengeR can however call them.
it is true that packages in depends should be minimize, but these are needed

Sep 24 2020, 11:38 AM · challengeR (v1.0)
eisenman added a comment to T27773: package dependencies.

Are you using the latest develop branch? There everything works for me.

Sep 24 2020, 11:34 AM · challengeR (v1.0)
wiesenfa triaged T27774: wrong text in report on algorithm subsets as High priority.
Sep 24 2020, 11:32 AM · challengeR (v1.0)
wiesenfa created T27773: package dependencies.
Sep 24 2020, 11:21 AM · challengeR (v1.0)
kompan closed T27116: [MITKDoc] Revise Matchpoint Algorithm Browser Plugin Documentation as Resolved.
Sep 24 2020, 10:27 AM · Cleared, MITK (v2021.02)
kompan committed rMITKa912e9dce820: Revise Matchpoint algorithm browser documentation. (authored by kompan).
Revise Matchpoint algorithm browser documentation.
Sep 24 2020, 10:27 AM
kompan committed rMITK1b88f63fd98d: Update BuildTag description. (authored by kompan).
Update BuildTag description.
Sep 24 2020, 10:27 AM
kompan committed rMITK22fb87e87b6c: Update Interaction description. (authored by kompan).
Update Interaction description.
Sep 24 2020, 10:27 AM
kompan committed rMITK30ea97d9c6a6: Add description of Version and BuildTag. (authored by kompan).
Add description of Version and BuildTag.
Sep 24 2020, 10:27 AM
kompan committed rMITK39de0380e119: Update Location definition. (authored by kompan).
Update Location definition.
Sep 24 2020, 10:27 AM
kompan committed rMITK71b6e8863aff: Update documentation. (authored by kompan).
Update documentation.
Sep 24 2020, 10:27 AM
kompan committed rMITK00975fc60625: Remove sentence about default path in the usage section. (authored by kompan).
Remove sentence about default path in the usage section.
Sep 24 2020, 10:27 AM
kompan committed rMITK64a361dd73f4: Update images. (authored by kompan).
Update images.
Sep 24 2020, 10:27 AM
kompan triaged T27772: Clean up ModelFitInspector in TOC of doxygen documentation as Normal priority.
Sep 24 2020, 9:37 AM · Cleared, MITK (v2021.02)
aguilera moved T27764: [shiny] Detect early when insufficient number of columns are loaded from Backlog to In Progress on the webChallengeR board.
Sep 24 2020, 9:14 AM · webChallengeR
floca committed rMITK3d7a1b765f58: T27111 - Revise documentation of MatchPoint Visualizer (authored by floca).
T27111 - Revise documentation of MatchPoint Visualizer
Sep 24 2020, 9:06 AM
floca committed rMITKd887bc53b9bb: Fixed review remarks (authored by floca).
Fixed review remarks
Sep 24 2020, 9:06 AM
floca committed rMITKfaf315c77212: Revise documentation of MatchPoint Visualizer (authored by floca).
Revise documentation of MatchPoint Visualizer
Sep 24 2020, 9:06 AM
floca closed T27111: [MITKDoc] Revise Matchpoint Registration Visualizer Plugin Documentation as Resolved by committing rMITKfaf315c77212: Revise documentation of MatchPoint Visualizer.
Sep 24 2020, 9:06 AM · Cleared, MITK (v2021.02)
aguilera moved T27765: [shiny] Make sure that column specified for metric values has numeric values from In Progress to Done on the webChallengeR board.
Sep 24 2020, 9:05 AM · webChallengeR
aguilera moved T27765: [shiny] Make sure that column specified for metric values has numeric values from Backlog to In Progress on the webChallengeR board.
Sep 24 2020, 9:04 AM · webChallengeR

Sep 23 2020

eisenman moved T27769: Top x performing algorithms are not mentioned in the reports anymore from In Progress to Done on the challengeR (v1.0) board.

This issue is fixed in T27677.

Sep 23 2020, 11:24 PM · challengeR (v1.0)
eisenman moved T27677: Update text in reports (feedback from Lena) from In Progress to Done on the challengeR (v1.0) board.
Sep 23 2020, 11:24 PM · challengeR (v1.0)
eisenman added a comment to T27677: Update text in reports (feedback from Lena).

In section 3.2.1 "Visualizing bootstrap results", two visualization methods are mentioned, but only one is contained in the report: "To investigate which tasks separate algorithms well (i.e., lead to a stable ranking), two visualization methods
are recommended."

Do we add a second plot or adapt the text?

Sep 23 2020, 11:24 PM · challengeR (v1.0)
eisenman created T27770: Inconsistency in report description.
Sep 23 2020, 11:22 PM · challengeR (v1.0)
eisenman committed rCHALLENGER53cad48c02bb: Merge branch 'feature/T27677-RestructureReports' into develop (authored by eisenman).
Merge branch 'feature/T27677-RestructureReports' into develop
Sep 23 2020, 11:20 PM
eisenman committed rCHALLENGER3487afdc60ae: Rephrase some explanations (authored by eisenman).
Rephrase some explanations
Sep 23 2020, 11:17 PM
eisenman committed rCHALLENGERce659d3df8a2: Mention top x performing algorithms in the single-task reports (authored by eisenman).
Mention top x performing algorithms in the single-task reports
Sep 23 2020, 11:17 PM
aguilera moved T27758: [shiny] Remove "next" button from page "Generate report" from In Progress to Done on the webChallengeR board.
Sep 23 2020, 10:50 PM · webChallengeR
aguilera moved T27758: [shiny] Remove "next" button from page "Generate report" from Backlog to In Progress on the webChallengeR board.
Sep 23 2020, 10:45 PM · webChallengeR
aguilera moved T27757: [shiny] Contradicting instruction on page "Uncertainty analysis" from In Progress to Done on the webChallengeR board.
Sep 23 2020, 10:42 PM · webChallengeR
aguilera moved T27757: [shiny] Contradicting instruction on page "Uncertainty analysis" from Backlog to In Progress on the webChallengeR board.
Sep 23 2020, 10:39 PM · webChallengeR
aguilera moved T27766: [shiny] Update workflow figure from In Progress to Done on the webChallengeR board.
Sep 23 2020, 10:39 PM · webChallengeR
aguilera moved T27766: [shiny] Update workflow figure from Backlog to In Progress on the webChallengeR board.
Sep 23 2020, 10:31 PM · webChallengeR