Branch

Branch for master is bug-19819-reset-selected-interactor-after-remove.

Simple solution:

removed warnings with unsigned int

[c825b9]: Merge branch 'bug-17962-wrong-index-statistics-based-on-master'

Merged commits:

2014-07-29 15:48:08 Danial Saruji [5c5463]
calculate correct min and max index if values are the same

(In reply to Git Admin from comment #3)

User dsaruji has pushed new remote branch:

bug-17962-wrong-index-statistics-based-on-master

Workaround to fix here mentioned input has been implemented. Follow-up ticket created for refactoring: T17963

(In reply to Danial Saruji from comment #6)

Workaround to fix here mentioned input has been implemented. Follow-up
ticket created for refactoring: T17963

see also T17962

For now I will implement a workaround to be able to calculate the correct index if min and max have the same value. I still think that (at least) this part should be refactored: T17963

New remote branch pushed: bug-16310-split-seriesreader-compilation-rebased-snapshot-201308

Temporarily reopened to rebase branch for integration into branch releases/snapshot-201308.

It took a while to get an overview here. 3 or 4 different developers worked on this topic and multiple branches were pushed, also some of those are not included and not needed. (definitely NOT a good way!)

(In reply to Danial Saruji from comment #11)

Taking over Ticket. There are still some problems:

• If the input mask image is smaller than the input image then the hotspot

calculation crashes

• Problem: the convolution image has the size of the original input image

and the mask has the size of the adapted image (= input image resized to
size of input mask image) and an iterator for the mask image was initialized
with the region of the convolution image.

• The calculation of the statistics of the found hotspot throws exception:

"Requested region is (at least partially) outside the largest possible
region"

Taking over Ticket. There are still some problems:

• If the input mask image is smaller than the input image then the hotspot calculation crashes
  • Problem: the convolution image has the size of the original input image and the mask has the size of the adapted image (= input image resized to size of input mask image) and an iterator for the mask image was initialized with the region of the convolution image.
• The calculation of the statistics of the found hotspot throws exception: "Requested region is (at least partially) outside the largest possible region"
  • Problem: The used itk::ImageExtractImageFilter adapts the region of the input image so that the the index values correspond to the index values of the mask image (only if the mask image is smaller than the input image), but the origin is not modified. The origin of the mask image was modified using the itk::ChangeInformationImageFilter so that the origin is the same as the origin of the input image. This is done so that the index values are the same for input image and mask image. This makes it easier to iterate over both. When converting the itk::Image to an mitk::Image in line 1746ff the start index of the region is reseted to the origin of the mask image which actually is outside of the largest possible region.

New remote branch pushed: bug-16236-hotspot-search-imagestatisticscalculator-integration-snapshot

New remote branch pushed: bug-16236-hotspot-search-imagestatisticscalculator

Sorry wrong attachement added. This one should work, but it is just a quick and not tested fix.

ExtractImageFilter patch

ExtractImageFilter patch

New remote branch pushed: bug-14827-planarfigureinteractor-ignore-invisible-nodes-based-on-master

Added check to method mitk::PlanarFigureInteractor::CanHandleEvent. Data nodes which are invisible will be ignored.

New remote branch pushed: bug-14827-planarfigureinteractor-ignore-invisible-nodes

New remote branch pushed: bug-13351-breakpad-module

(In reply to Sascha Zelzer from comment #9)

TODOS:

• Remove Qt dependency from the module

Not needed for this release. Will be done afterwards.

added attachment with fix

merged in master. done

proposed solution

in the attachment is the proposed solution

[040251]: Merge branch 'bug-9689-rebased'

Merged commits:

2011-10-11 16:50:57 Mathias Seitel [9cc2d1]
Modified misalignment check to cover tilted geometries

fix for misalignment check

Another change: In cases where there is only one slice the geometry3D has the same geometry as the plane geometry. In those cases we take the corner points of the geometry3D and check if they are on the plane. In some cases the distance of the point to the plane is a little bit bigger than mitk::eps. Changed so that the check controls whether the distance is smaller than mitk::sqrteps.

use only first and last slice

use only first and last slice

changed range of t and distance smaller than sqrteps

another change: widened range of variable t (which is used to verify if there is an intersection between the line segment and the plane) by mitk::sqrteps

quick solution to determine intersection points of 2 Geometry3D

quick solution to determine intersection points of 2 Geometry3D

easier instead of taking all just take first and last slice. All corner points of geometry are included. Added another patch

Added attachement with a quick solution. If a Geometry3D is given as input instead of a PlaneGeometry, the intersection points of each slice are determined. This way is not very good because this is not needed to be done for all slices.

ist in master und releases/snapshot-201109 integriert

Patch for PlanarCircle enhancement

Patch for PlanarCircle enhancement

already fixed in T9607

[d1bfa2]: Merge branch 'bug-9342-enhance-statemachine-scroll-zoom-and-pan'

changes to the mitkDisplayVectorInteractorScroll:

The mitkDisplayVectorInteractorScroll class also needs to be enhanced, so that it can be determined if the alt modifier has been pressed or not.

Solved another issue: with the above "fix" it was now possible to set e.g. a single line with just one double-click (leading to two control points exactly on the same position).

One transition needs to be added so that the shown correction region is still visible when scrolling through the slices with the mouse wheel.

the mitkBaseRenderer needs to be modified in the method WheelEvent:

[5133ac]: Merge branch 'bug-8953-enhace-statemachine-binaryimageinteractor'

[d27c22]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

[9e34fc]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

added missing unittest

added short summary

[1c20dd]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

Mostly code cleanup. Also not the isIndexInside method is used to check if the point is inside the boundaries of the image. Instead the method intersectionPointParam from class PlaneGeometry is used which gives a double value between 0 and 1 if the intersection point is between the start and the end point of the line we are intersecting with. The method intersectionPointParam had to be fixed: the vectors planeNormal and lineDirection shouldn't be normalized to get values between 0 and 1.

[f0bed2]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

Implemented class ClippedSurfaceBoundsCalculator. The class Geometry2DDataToSurfaceFilter wasn't used to get the polygon points. Instead the ClippedSurfaceBoundsCalculator class has its own method to get the intersection points between a PlaneGeometry and a Geometry3D.

[548a38]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

[36b99f]: Merge branch 'bug-8664-implement-clipped-surface-bounds-calculator'

impplementiert in branch bug-8506-create-unittest-for-planarsubdivisionpolygon und
gemergt in branch bug-8505-implement-class-planarsubdivisionpolygon mit commit:
9f51fa7d8a9fc6a4eb8842792a5bd3347244c197
gemergt in master mit commit 3a68a00f9295ac0856f0454b78ebc99884de9cad

[f33ecc]: Merge branch 'bug-8506-create-unittest-for-planarsubdivisionpolygon' C

Merged commits:

2011-08-09 14:39:21 Danial Bin Mohamed Saruji [308b87]
added property initiallyplaced and set maximum numbers to 1000

Due to changes on the class subdivision polygon the unittest needs to be modified.

Die neuesten Änderungen für die Klasse PlanarSubdiviosnPolygon befinden sich scheinbar im patch in T8506

[3a68a0]: Merge branch 'bug-8505-implement-class-planarsubdivisionpolygon'

[0f6e46]: Merge branch 'bug-8505-implement-class-planarsubdivisionpolygon'

[77a029]: Merge branch 'bug-8505-implement-class-planarsubdivisionpolygon'

reopened for code cleanup. parent class already has the functionality implemented. Only small modifications for methods of PlanarPolygon to make subdivisonPolygon work.

[ebcb77]: Merge branch 'bug-8505-implement-class-planarsubdivisionpolygon'

Enhanced unittest DICOMSeriesReader. Checks if DICOMTags have been set correctly.

[9d7b58]: Merge branch 'bug-7528-test-dicom-tags-loading-image-properties'

Reopened because unittest needs to be enhanced. File path for dicom tags should be retrieved from mitk::image property

reopened for code cleanup

[94b2d0]: Merge branch 'bug-7339-provide-dicom-tags-as-image-property'

[04d383]: Merge branch 'bug-7339-provide-dicom-tags-as-image-property' (COMP)

[0ab668]: Merge branch 'bug-7339-provide-dicom-tags-as-image-property'

fehlende Überprüfung ob DICOM tags vorhanden sind hinzugefügt