Page MenuHomePhabricator
Create Task
Maniphest T28145

SetRegionTool does not work as expected (flood fill like) with concentric structures.
Closed, ResolvedPublic
Actions

Description

How to reproduce:

  • Load an image (e.g. Pic3D)
  • Start segmentation.
  • Segment a structure like shown in the attached fig
    fill_error.png (359×378 px, 69 KB)
    .
  • Fill the middel background ring (A)
  • Result: Everything is filled (also the inner background B). Expected: only A should be filled, as it should behave like a flood fill operation. B should still be untouched.

Revisions and Commits

Restricted Differential Revision
rMITK MITK
Restricted Differential RevisionrMITKe5f00365d075 T29078-Fix_erase_tool
Restricted Differential RevisionrMITK484f6d6cb126 Preperation of new Close tool icons with placeholder.
Restricted Differential RevisionrMITK815d672a3d46 Fixed typos
Restricted Differential RevisionrMITK7014afcb419e Added documentation of close tool
Restricted Differential RevisionrMITK89566de2f706 BREAKING: Removed obsolete class SetRegionTool.
Restricted Differential RevisionrMITK092abf8914f9 prevent crashes if the active label is not in the active label set
Restricted Differential RevisionrMITK307bd227e0aa Added close tool
Restricted Differential RevisionrMITK271839f8fd19 Reworked signature of GenerateFillImage to move the lock check logic
Restricted Differential RevisionrMITK43d1853aad0f fixed compile error
Restricted Differential RevisionrMITK30bb7f9eca23 Addapted documentation to new fill tool behavior.
Restricted Differential RevisionrMITKd7cef5bfe428 Introduced new base tool for region filling
Restricted Differential RevisionrMITKdffc8d43c586 BREAKING: Switched FillRegion and EraseRegion to new FillRegionBase tool.
Restricted Differential RevisionrMITK1c5f71f86d9a Refactored IsPositionEventInsideImageRegion to be available via

Related Objects
Search...

Event Timeline

floca triaged this task as Normal priority.Jan 5 2021, 4:55 PM
floca created this task.
floca edited projects, added MITK (v2021.10); removed MITK.Apr 12 2021, 9:15 PM
floca moved this task from Backlog to Segmentation on the MITK (v2021.10) board.
floca added a comment.Jun 4 2021, 5:42 PM

This issue should be postponed until T28523: Evaluate MITK segmentation survey (to now the new priority) is done.

floca added a subtask: T28523: Evaluate MITK segmentation survey.Jun 4 2021, 5:42 PM
floca added a project: Missing Info.Jun 4 2021, 6:42 PM
floca removed a project: Missing Info.Jul 28 2021, 12:49 PM
floca added a subtask: T28525: Design refactoring of LabelSetImage and associated classes.
a178n closed subtask T28523: Evaluate MITK segmentation survey as Resolved.Jul 28 2021, 1:22 PM
kislinsk edited projects, added MITK (v2022.04); removed MITK (v2021.10).Nov 10 2021, 4:32 PM
floca moved this task from Backlog to Segmentation on the MITK (v2022.04) board.Nov 17 2021, 11:59 AM
kalali mentioned this in T29132: [MultiLabel Segmentation] Define desired behavior of fill / erase tool.Apr 12 2022, 4:37 PM
kalali added a subscriber: kalali.

I tested this and as far as I can see this bug is still valid. However, we have already opened related tasks (T28763: [Multilabel Segmentation] Fill / Erase tool does not fully respect multiple labels and T29078: [Segmentation] Erase tool has unclear edge cases) and it seems as if we have to make a decision, how the fill / erase tools should behave, so I opened T29132: [MultiLabel Segmentation] Define desired behavior of fill / erase tool.

kalali added a parent task: T29132: [MultiLabel Segmentation] Define desired behavior of fill / erase tool.Apr 12 2022, 4:37 PM
kalali edited projects, added MITK, Next Milestone; removed MITK (v2022.04).Apr 20 2022, 4:53 PM
floca added a revision: Restricted Differential Revision.Sep 28 2022, 9:15 AM
floca claimed this task.Sep 28 2022, 10:37 AM
floca edited projects, added MITK (v2022.10); removed Next Milestone, MITK.
floca moved this task from Backlog to Cycle on the MITK (v2022.10) board.
floca added a revision: Restricted Differential Revision.Oct 4 2022, 4:15 PM
floca closed this task as Resolved by committing rMITKdffc8d43c586: BREAKING: Switched FillRegion and EraseRegion to new FillRegionBase tool..Oct 4 2022, 4:38 PM
floca added a commit: rMITK1c5f71f86d9a: Refactored IsPositionEventInsideImageRegion to be available via.
floca added a commit: rMITKdffc8d43c586: BREAKING: Switched FillRegion and EraseRegion to new FillRegionBase tool..
floca added a commit: rMITKd7cef5bfe428: Introduced new base tool for region filling.
floca added a commit: rMITK30bb7f9eca23: Addapted documentation to new fill tool behavior..
floca added a commit: rMITK43d1853aad0f: fixed compile error.
floca added a commit: rMITK271839f8fd19: Reworked signature of GenerateFillImage to move the lock check logic.
floca added a commit: rMITK307bd227e0aa: Added close tool.
floca added a commit: rMITK092abf8914f9: prevent crashes if the active label is not in the active label set.
floca added a commit: rMITK89566de2f706: BREAKING: Removed obsolete class SetRegionTool..
floca added a commit: rMITK7014afcb419e: Added documentation of close tool.
floca added a commit: rMITK484f6d6cb126: Preperation of new Close tool icons with placeholder..
floca added a commit: rMITK815d672a3d46: Fixed typos.
floca added a commit: rMITKe5f00365d075: T29078-Fix_erase_tool.
kislinsk mentioned this in T29327: 2022 Week 40 (Very Early October).Oct 6 2022, 5:46 AM
floca closed subtask T28525: Design refactoring of LabelSetImage and associated classes as Resolved.Thu, Apr 18, 4:37 PM
MITK · MIC · IMSY · DKFZ