Page MenuHomePhabricator
Create Task
Maniphest T28248

[Segmentation] Picking 3D Tool creates a 3D segmentation out of a 4D image
Closed, ResolvedPublic
Actions

Description

To reproduce:

  1. Load US4DCyl
  2. Create dynamic segmentation
  3. Add two regions
  4. Pick a region with the picking tool --> the result is a 3D segmentation although 4D was selected

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK148d43a825c1 Updated picking tool screenshot
Restricted Differential RevisionrMITK540f9ce6f8f4 T28248 Refactor picking tool
Restricted Differential RevisionrMITK8532f8f56985 Fixed review remarks
Restricted Differential RevisionrMITK88c58d855c19 Changed behavior of AutoSegmentationWithPreviewTool when not overwritting the…
Restricted Differential RevisionrMITK5ceb625e0fc4 Fixed T26970
Restricted Differential RevisionrMITK7f5b4f962ac6 Refactored PickingTool and its UI.
Restricted Differential RevisionrMITKe9f414f7e792 Fixed gcc compile errors
Restricted Differential RevisionrMITKa3aa5679e0c9 BREAKING! Changed signature of mitk::AutoSegmentationWithPreviewTool…
Restricted Differential RevisionrMITKa3e1edc80b03 BREAKING! Member mitk::Tool::m_ToolManager is now private

Related Objects
Search...

Event Timeline

• thomass created this task.Jan 29 2021, 7:45 PM
• thomass renamed this task from Please enter a meaningful title to [Segmentation] Picking 3D Tool creates a 3D segmentation out of a 4D image.Jan 29 2021, 7:49 PM
• thomass triaged this task as High priority.
• thomass updated the task description. (Show Details)
• thomass edited projects, added MITK (v2021.02); removed MITK.
• thomass lowered the priority of this task from High to Normal.Jan 29 2021, 7:53 PM

Sorry this was already mentioned in T27507. But I think we never discussed / decided what the purpose of picking on 4D tools should be. But not necessarily important for the release though.

• thomass moved this task from Backlog to Segmentation on the MITK (v2021.02) board.Jan 29 2021, 7:54 PM
kislinsk added a subscriber: kislinsk.Jan 29 2021, 9:38 PM

Addition: time bounds of the picking result are set to [min possible value, max possible value] instead of the time bounds of the reference image.

kislinsk added a parent task: T28000: MITK v2021.02.Jan 29 2021, 9:38 PM
floca added a subscriber: floca.Jan 29 2021, 9:42 PM

Picking tool is not refactored yet. 😱
Only managed to get to the 2D tools. Picking is still missing.

kislinsk edited projects, added MITK, Next Milestone; removed MITK (v2021.02).Feb 1 2021, 10:04 AM
kislinsk removed a parent task: T28000: MITK v2021.02.
floca added a comment.Feb 7 2021, 3:14 PM

Deactivated for 4D images as a work arround fix for the release. Will be removed if this tool is properly refactored.

kislinsk mentioned this in rMITK3b3045b97a87: Deactivated PickingTool for 4D images as a workarround fix for T28248.Feb 10 2021, 5:49 PM
floca edited projects, added MITK (v2021.10); removed Next Milestone, MITK.Apr 9 2021, 6:37 PM
floca moved this task from Backlog to Cycle on the MITK (v2021.10) board.
floca claimed this task.Apr 14 2021, 10:30 AM
floca added a revision: Restricted Differential Revision.May 5 2021, 9:44 PM
floca added a subtask: T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected.May 6 2021, 11:17 AM
floca closed this task as Resolved by committing rMITK7f5b4f962ac6: Refactored PickingTool and its UI..May 14 2021, 12:27 PM
floca added a commit: rMITKa3e1edc80b03: BREAKING! Member mitk::Tool::m_ToolManager is now private.
floca added a commit: rMITKa3aa5679e0c9: BREAKING! Changed signature of mitk::AutoSegmentationWithPreviewTool….
floca added a commit: rMITKe9f414f7e792: Fixed gcc compile errors.
floca added a commit: rMITK7f5b4f962ac6: Refactored PickingTool and its UI..
floca added a commit: rMITK88c58d855c19: Changed behavior of AutoSegmentationWithPreviewTool when not overwritting the….
floca added a commit: rMITK5ceb625e0fc4: Fixed T26970.
floca closed subtask T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected as Resolved.
floca added a commit: rMITK8532f8f56985: Fixed review remarks.
floca added a commit: rMITK148d43a825c1: Updated picking tool screenshot.
floca added a commit: rMITK540f9ce6f8f4: T28248 Refactor picking tool.
kislinsk mentioned this in T28602: 2021 Week 26 (Very Early July).Jul 2 2021, 9:42 AM
MITK · MIC · IMSY · DKFZ