Page MenuHomePhabricator

Add a Test to check if the GrowCut algorithm produces a different output
Open, NormalPublic

Assigned To
None
Authored By
j762e
Wed, Sep 21, 1:39 PM
Referenced Files
F2572276: InputSeedImage.nrrd
Thu, Sep 22, 3:35 PM
F2572277: ExpectedResultImage.nrrd
Thu, Sep 22, 3:35 PM
F2572274: files.cmake
Thu, Sep 22, 3:35 PM
F2572275: mitkGrowCutFilterTest.cpp
Thu, Sep 22, 3:35 PM

Description

It is interesting to add a test so that we ll get a notice if the GrowCut algorithm changes so that a different ouput is generated

Event Timeline

j762e triaged this task as Normal priority.Wed, Sep 21, 1:39 PM
j762e created this task.

Haven't you added a test alread? Or are you thinking about other test cases?
If this is the case, could you give a bit more input regarding your thoughts.

I already wrote a test, but removed it for now so I could create the Diff (D712).
Now the Diff needs to be accepted and the T28851-AddImagesForGrowCutSegmentationTest Branch needs to be merged into the mitkdata repository:

rMD MITK-Data: T28851-AddImagesForGrowCutSegmentationTest.
so that the test does not fail.

I add the files here in case the process is not through before I leave.




What do you mean with removed? Is the code still somewhere? If it was functional it would make no sense if someone has to write a new test from scratch.

Tests work again. So if the DLL-Exception/failing tests was the reason for removing it, you can add it again.

The idea was to provide an additional differential here for this task that adds the test so yes, the code is there and will be visible in the differential.

What do you mean with removed? Is the code still somewhere? If it was functional it would make no sense if someone has to write a new test from scratch.

Tests work again. So if the DLL-Exception/failing tests was the reason for removing it, you can add it again.

The code was removed only from the feature branch so that we have a "clean" review for only the tool and gui changes.
The code still exists and can be found in my comment above. These files (mitkGrowCutFilterTest.cpp and files.cmake) just needs to be added.
They are not reviewed and there is no Diff yet because they depend on D712.