Page MenuHomePhabricator
Feed Advanced Search

Jan 18 2021

kislinsk committed rMITKe1f7ba295014: Adjust date range (authored by kislinsk).
Adjust date range
Jan 18 2021, 6:38 AM
kislinsk added a comment to T28164: Update date in copyright.

Pushed new branch bugfix/T28164-CopyrightDate.

Jan 18 2021, 6:38 AM · MITK (v2021.02)
kislinsk triaged T28164: Update date in copyright as Low priority.
Jan 18 2021, 6:33 AM · MITK (v2021.02)
kislinsk added a comment to T28127: Reopen segmentation in MITK.

Thanks for looking into this issue as well. :-) I think 1e-5 is okay. We/you already introduced NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION not long ago since we had similar issues and 1e-5 should still be conservative enough for the purpose of geometries.

Jan 18 2021, 5:01 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)

Jan 15 2021

kislinsk added a comment to T28159: Officially support MITK using system Qt.

I understand. :-) Just wanted to give you more options to think about as it is probably only a temporal solution. Sooner or later (currently read "later"), our minimum version requirements won't match again with the OS-provided Qt version. So we cannot run away from it forever I guess. :D

Jan 15 2021, 12:40 PM · Auto-closed, CI, Request for Discussion, MITK
kislinsk renamed T27693: Packaging Python does not work/is not implemented from Cannot start nightly workbench on a clean Ubuntu 18/20 to Packaging Python does not work/is not implemented.
Jan 15 2021, 12:09 PM · MITK
kislinsk merged T27894: Linux nightly installer doesn't start on Fedora into T27693: Packaging Python does not work/is not implemented.
Jan 15 2021, 12:09 PM · MITK
kislinsk merged task T27894: Linux nightly installer doesn't start on Fedora into T27693: Packaging Python does not work/is not implemented.
Jan 15 2021, 12:09 PM · MITK (v2021.02)
kislinsk edited projects for T27196: Rewrite packaging of MITK, added: Next Milestone, MITK; removed MITK (v2021.02).
Jan 15 2021, 12:07 PM · Moved to git.dkfz.de, MITK, Cleared

Jan 14 2021

kislinsk triaged T28159: Officially support MITK using system Qt as Normal priority.

As it already works (?) and we will stay at least another year with Qt 5 we can do this. But in general, do you know of the new Qt Installer Framework with command-line interface? It's much easier now to install Qt with a single command and there are a few possibilities to provide credentials if that's an issue. See here for examples: https://phabricator.mitk.org/T27960#214043

Jan 14 2021, 5:22 PM · Auto-closed, CI, Request for Discussion, MITK
kislinsk closed T28155: Make Qt log messages optional as Resolved.
Jan 14 2021, 11:09 AM · MITK (v2021.02)
kislinsk added a comment to T28155: Make Qt log messages optional.

Deleted branch feature/T28155-MakeQtLogMessagesOptional.

Jan 14 2021, 11:08 AM · MITK (v2021.02)
kislinsk committed rMITK8aeabe996f16: Make Qt log messages optional (authored by kislinsk).
Make Qt log messages optional
Jan 14 2021, 11:08 AM
kislinsk committed rMITK46eee069a4bf: Merge branch 'feature/T28155-MakeQtLogMessagesOptional' into develop (authored by kislinsk).
Merge branch 'feature/T28155-MakeQtLogMessagesOptional' into develop
Jan 14 2021, 11:08 AM
kislinsk added a comment to T28155: Make Qt log messages optional.

Pushed new branch feature/T28155-MakeQtLogMessagesOptional.

Jan 14 2021, 11:07 AM · MITK (v2021.02)

Jan 13 2021

kislinsk added a revision to T28155: Make Qt log messages optional: Unknown Object (Differential Revision).
Jan 13 2021, 3:33 PM · MITK (v2021.02)
kislinsk triaged T28155: Make Qt log messages optional as Normal priority.
Jan 13 2021, 3:26 PM · MITK (v2021.02)
kislinsk updated subscribers of T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.
Jan 13 2021, 2:53 PM · Noteworthy, MITK (v2021.02)
kislinsk closed T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12 as Resolved.

Since we need to patch VTK anyway, I took the opportunity to upgrade from VTK 9.0.0 to 9.0.1.

Jan 13 2021, 2:52 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.

Deleted branch bugfix/T28151-FixVTKOnMacOSXCode12.

Jan 13 2021, 2:51 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITKc0ad4f1441a1: Exclude unistd.h from Windows builds (authored by kislinsk).
Exclude unistd.h from Windows builds
Jan 13 2021, 2:47 PM
kislinsk committed rMITKda3e2af67311: Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop (authored by kislinsk).
Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop
Jan 13 2021, 2:47 PM
kislinsk committed rMITK6617af527acd: Patch (and upgrade) VTK (authored by kislinsk).
Patch (and upgrade) VTK
Jan 13 2021, 2:16 PM
kislinsk committed rMITKca75fe9867c2: Fix compiler errors with XCode 12 (authored by kislinsk).
Fix compiler errors with XCode 12
Jan 13 2021, 2:16 PM
kislinsk committed rMITKbce1eaddb837: Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop (authored by kislinsk).
Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop
Jan 13 2021, 2:16 PM
kislinsk added a comment to T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.

Pushed new branch bugfix/T28151-FixVTKOnMacOSXCode12.

Jan 13 2021, 9:45 AM · Noteworthy, MITK (v2021.02)

Jan 11 2021

kislinsk triaged T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12 as Unbreak Now! priority.
Jan 11 2021, 11:18 PM · Noteworthy, MITK (v2021.02)
kislinsk closed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start , a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Jan 11 2021, 11:12 PM · Moved to git.dkfz.de, MITK, Cleared
kislinsk closed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start as Resolved.
Jan 11 2021, 11:12 PM · MITK (v2021.02)
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

Deleted branch bugfix/T27717-FixMacOSInstallerOpenApp.

Jan 11 2021, 11:12 PM · MITK (v2021.02)
kislinsk committed rMITKff9ca2f439c0: Fix num of chars in strncmp() (authored by kislinsk).
Fix num of chars in strncmp()
Jan 11 2021, 11:12 PM
kislinsk committed rMITK35cc4be67bda: Merge branch 'bugfix/T27717-FixMacOSInstallerOpenApp' into develop (authored by kislinsk).
Merge branch 'bugfix/T27717-FixMacOSInstallerOpenApp' into develop
Jan 11 2021, 11:12 PM
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

Pushed new branch bugfix/T27717-FixMacOSInstallerOpenApp.

Jan 11 2021, 11:11 PM · MITK (v2021.02)
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

It works when any argument is passed to the workbench via the open command, e.g., open MitkWorkbench.app --args --BlueBerry.newInstance. My first guess that the additions in rMITKf54a83e2 cannot handle 0 arguments when the implicit -psn argument is sneaked into argv by macOS.

Jan 11 2021, 9:25 PM · MITK (v2021.02)
kislinsk claimed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .
Jan 11 2021, 8:56 PM · MITK (v2021.02)
kislinsk closed T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore as Resolved.

Was removed in rMITK66bb0d67 and forgotten to get restored in rMITK02a46548.

Jan 11 2021, 3:58 PM · MITK (v2021.02)
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Deleted branch bugfix/T28137-FixMissingContextMenuEntries.

Jan 11 2021, 3:57 PM · MITK (v2021.02)
kislinsk committed rMITK1aa2efd2c474: Add missing context menu extension point line (authored by kislinsk).
Add missing context menu extension point line
Jan 11 2021, 3:57 PM
kislinsk committed rMITK2e864760744f: Merge branch 'bugfix/T28137-FixMissingContextMenuEntries' into develop (authored by kislinsk).
Merge branch 'bugfix/T28137-FixMissingContextMenuEntries' into develop
Jan 11 2021, 3:57 PM
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Pushed new branch bugfix/T28137-FixMissingContextMenuEntries.

Jan 11 2021, 3:55 PM · MITK (v2021.02)
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Thanks @kalali, nice find and hint. A sneaky line is missing in DataManager's plugin.xml: <extension-point id="contextMenuActions" name="Context menu actions"/>.

Jan 11 2021, 3:51 PM · MITK (v2021.02)
kislinsk claimed T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.
Jan 11 2021, 3:39 PM · MITK (v2021.02)
kislinsk raised the priority of T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore from High to Unbreak Now!.
Jan 11 2021, 12:08 PM · MITK (v2021.02)

Dec 21 2020

kislinsk closed T28126: 2020 Week 52 (Late December) as Resolved.
Dec 21 2020, 6:52 AM · MITK
kislinsk edited the content of Changelog.
Dec 21 2020, 6:52 AM · MITK
kislinsk added a comment to T28126: 2020 Week 52 (Late December).

Deleted branch release/T28126-2020-Week-52.

Dec 21 2020, 6:51 AM · MITK
kislinsk committed rMITK5dc9bf8b39f9: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Dec 21 2020, 6:51 AM
kislinsk committed rMITKbd9ce02f928c: 2020 Week 52 (Late December) (authored by kislinsk).
2020 Week 52 (Late December)
Dec 21 2020, 6:50 AM
kislinsk edited the content of 2020 Week 52 (Late December).
Dec 21 2020, 6:44 AM
kislinsk added a comment to T28126: 2020 Week 52 (Late December).

Pushed new branch release/T28126-2020-Week-52.

Dec 21 2020, 5:16 AM · MITK
kislinsk triaged T28126: 2020 Week 52 (Late December) as Normal priority.
Dec 21 2020, 5:14 AM · MITK
kislinsk created an object: 2020 Week 52 (Late December).
Dec 21 2020, 5:13 AM

Dec 18 2020

kislinsk closed T26237: Improve performance for interactions in 2d widgets as Resolved.
Dec 18 2020, 4:03 AM · MITK
kislinsk added a comment to T26237: Improve performance for interactions in 2d widgets.

Deleted branch bugfix/T26237-ImprovePerformance.

Dec 18 2020, 4:02 AM · MITK
kislinsk committed rMITKbf264ce891b8: Improve performance (authored by kislinsk).
Improve performance
Dec 18 2020, 4:02 AM
kislinsk committed rMITKd05bd6a2660b: Merge remote-tracking branch 'origin/develop' into bugfix/T26237… (authored by kislinsk).
Merge remote-tracking branch 'origin/develop' into bugfix/T26237…
Dec 18 2020, 4:02 AM
kislinsk committed rMITKdbbf947882f4: Improve ITK patch (authored by kislinsk).
Improve ITK patch
Dec 18 2020, 4:02 AM
kislinsk committed rMITKdc76958e5051: Merge branch 'bugfix/T26237-ImprovePerformance' into develop (authored by kislinsk).
Merge branch 'bugfix/T26237-ImprovePerformance' into develop
Dec 18 2020, 4:02 AM

Dec 17 2020

kislinsk renamed Phabricator Onboarding from Phabricator onboarding to Phabricator Onboarding.
Dec 17 2020, 7:59 PM · Onboarding

Dec 12 2020

kislinsk closed T28101: Early-out when CMake 3.19 is used as Resolved.
Dec 12 2020, 4:47 AM · MITK (v2021.02)
kislinsk added a comment to T28101: Early-out when CMake 3.19 is used.

Deleted branch bugfix/T28101-CMake3.19.

Dec 12 2020, 4:47 AM · MITK (v2021.02)
kislinsk committed rMITKeab123b123ea: Early out if CMake version is [3.19, 3.19.2) (authored by kislinsk).
Early out if CMake version is [3.19, 3.19.2)
Dec 12 2020, 4:47 AM
kislinsk committed rMITK5b214745c789: Merge branch 'bugfix/T28101-CMake3.19' into develop (authored by kislinsk).
Merge branch 'bugfix/T28101-CMake3.19' into develop
Dec 12 2020, 4:47 AM
kislinsk added a comment to T28101: Early-out when CMake 3.19 is used.

Pushed new branch bugfix/T28101-CMake3.19.

Dec 12 2020, 4:46 AM · MITK (v2021.02)
kislinsk updated subscribers of T28101: Early-out when CMake 3.19 is used.

Will be fixed very soon in CMake 3.19.2: https://gitlab.kitware.com/cmake/cmake/-/issues/21529

Dec 12 2020, 4:19 AM · MITK (v2021.02)

Dec 11 2020

kislinsk triaged T28101: Early-out when CMake 3.19 is used as Unbreak Now! priority.
Dec 11 2020, 2:45 PM · MITK (v2021.02)
kislinsk edited the content of Step 0 - Create a Phabricator account.
Dec 11 2020, 11:04 AM · Onboarding
kislinsk renamed Phabricator Onboarding from Onboarding to Phabricator onboarding.
Dec 11 2020, 10:34 AM · Onboarding

Dec 8 2020

kislinsk added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

If this is now a crash but wasn't before, the TinyXML-2 migration is also a good candidate.
edit: Oh, was already authored in August. Sorry for the noise.

Dec 8 2020, 8:18 PM · Request for Discussion, MITK
kislinsk removed a project from T28062: Fix IsotropicWavelets (ITK) dependency: Noteworthy.
Dec 8 2020, 9:50 AM · MITK (v2021.02)

Dec 7 2020

kislinsk closed T28081: Create shortcuts for executables in Windows installers/packages, a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Dec 7 2020, 10:15 PM · Moved to git.dkfz.de, MITK, Cleared
kislinsk closed T28081: Create shortcuts for executables in Windows installers/packages as Resolved.
Dec 7 2020, 10:15 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T28081: Create shortcuts for executables in Windows installers/packages.

Deleted branch bugfix/T28081-ShortcutsInWindowsInstallers.

Dec 7 2020, 10:14 PM · Cleared, MITK (v2021.02)
kislinsk committed rMITK7ba5ffbb2e50: Create shortcuts in Windows installers/packages (authored by kislinsk).
Create shortcuts in Windows installers/packages
Dec 7 2020, 10:14 PM
kislinsk committed rMITKa9f7c91fd852: Remove redist part (authored by kislinsk).
Remove redist part
Dec 7 2020, 10:14 PM
kislinsk committed rMITKccbaf060bde7: Merge branch 'bugfix/T28081-ShortcutsInWindowsInstallers' into develop (authored by kislinsk).
Merge branch 'bugfix/T28081-ShortcutsInWindowsInstallers' into develop
Dec 7 2020, 10:14 PM
kislinsk added a comment to T28081: Create shortcuts for executables in Windows installers/packages.

Pushed new branch bugfix/T28081-ShortcutsInWindowsInstallers.

Dec 7 2020, 10:13 PM · Cleared, MITK (v2021.02)
kislinsk triaged T28081: Create shortcuts for executables in Windows installers/packages as Normal priority.
Dec 7 2020, 10:09 PM · Cleared, MITK (v2021.02)
kislinsk updated subscribers of T27196: Rewrite packaging of MITK.
Dec 7 2020, 10:07 PM · Moved to git.dkfz.de, MITK, Cleared
kislinsk closed T28080: Microsoft Visual C++ Redistributable not included in packages anymore, a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Dec 7 2020, 8:44 PM · Moved to git.dkfz.de, MITK, Cleared
kislinsk closed T28080: Microsoft Visual C++ Redistributable not included in packages anymore as Resolved.
Dec 7 2020, 8:44 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T28080: Microsoft Visual C++ Redistributable not included in packages anymore.

Deleted branch bugfix/T28080-RedistPackagingAndNSISGenerator.

Dec 7 2020, 8:44 PM · Cleared, MITK (v2021.02)
kislinsk committed rMITKc63dd0997faa: Rely on InstallRequiredSystemLibraries to handle runtime DLLs (authored by kislinsk).
Rely on InstallRequiredSystemLibraries to handle runtime DLLs
Dec 7 2020, 8:44 PM
kislinsk committed rMITKb9f6499dd3f3: Merge branch 'bugfix/T28080-RedistPackagingAndNSISGenerator' into develop (authored by kislinsk).
Merge branch 'bugfix/T28080-RedistPackagingAndNSISGenerator' into develop
Dec 7 2020, 8:43 PM
kislinsk added a comment to T28080: Microsoft Visual C++ Redistributable not included in packages anymore.

Pushed new branch bugfix/T28080-RedistPackagingAndNSISGenerator.

Dec 7 2020, 8:40 PM · Cleared, MITK (v2021.02)
kislinsk triaged T28080: Microsoft Visual C++ Redistributable not included in packages anymore as Normal priority.
Dec 7 2020, 8:28 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services.

At least for XNAT this was recently resolved in T26449: XNAT connection failes due to missing OpenSSL connections.

Dec 7 2020, 8:17 PM · Restricted Project, CSI-HD, MITK
kislinsk closed T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15 as Resolved.
Dec 7 2020, 8:15 PM · MITK

Dec 6 2020

kislinsk added a comment to T26237: Improve performance for interactions in 2d widgets.

Before:

Dec 6 2020, 10:15 PM · MITK
kislinsk added a comment to T26237: Improve performance for interactions in 2d widgets.

Pushed new branch bugfix/T26237-ImprovePerformance.

Dec 6 2020, 9:02 PM · MITK
kislinsk claimed T26237: Improve performance for interactions in 2d widgets.

A profiling session revealed that a substantial amount of time during interaction with the 2d widgets is spent by the ITK object factory in the context of mitk::BaseGeometry when creating new instances of itk::BoundingBox, itk::VectorContainer, and itk::ScalableAffineTransform.

Dec 6 2020, 8:46 PM · MITK

Dec 4 2020

kislinsk edited projects for T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15, added: MITK; removed MITK (v2021.02).

It will be automatically listed in the changelog table regardless of the task status. :)

Dec 4 2020, 4:30 PM · MITK
kislinsk moved T27992: Release of MITK CLIs from Backlog to MITK Meeting on the Request for Discussion board.
Dec 4 2020, 1:13 PM · MITK (v2021.02), Request for Discussion
kislinsk lowered the priority of T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15 from High to Normal.
Dec 4 2020, 12:43 PM · MITK
kislinsk reopened T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15 as "Open".

Maybe I should leave this task open until we came up with a minimum prototype...

Dec 4 2020, 12:43 PM · MITK
kislinsk closed T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15 as Resolved.
Dec 4 2020, 12:42 PM · MITK
kislinsk added a comment to T26399: Workbench crash on simple tree model update.

Isn't (1) a requirement anyways? Let me just look it up in the Qt documentation...

Dec 4 2020, 12:37 PM · Moved to git.dkfz.de, MITK, Request for Discussion
kislinsk added a comment to T28062: Fix IsotropicWavelets (ITK) dependency.

Deleted branch bugfix/T28062-FixIsotropicWaveletsDep.

Dec 4 2020, 12:31 PM · MITK (v2021.02)
kislinsk closed T28062: Fix IsotropicWavelets (ITK) dependency as Resolved.

The actual issue seems to be network troubles so maybe a server is down or something similar. Should resolve itself either now/today or the next days. Anyway, as we now made the dependency explicit, this task was not a complete waste of time. :-)

Dec 4 2020, 12:30 PM · MITK (v2021.02)
kislinsk committed rMITK24edc5c4c833: Make IsotropicWavelets dependency explicit (authored by kislinsk).
Make IsotropicWavelets dependency explicit
Dec 4 2020, 12:27 PM