Page MenuHomePhabricator
Feed Advanced Search

Wed, Jan 12

kislinsk removed a project from T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly: Request for Discussion.

The current solution was never meant as a user interface but only for saving slice positions in scene files. However, it turned out that it is quite handy to jump to drawn contours with a simple click so we should probably move the list of positions into the segmentation view itself if needed.

Wed, Jan 12, 11:48 AM · MITK (v2022.04)
kislinsk edited projects for T28649: Deprecated classes in ImageExtraction-module are not used, added: MITK; removed MITK (v2022.04), Request for Discussion.
Wed, Jan 12, 11:42 AM · MITK
kislinsk added a comment to T28903: [Segmentation] Monitoring of segmentation nodes in views is error prone/ not safe..

Suggestion: Open another task for ensuring at least default properties like "visible" that we can then kind of rely on.

Wed, Jan 12, 11:40 AM · MITK (v2022.04)
kislinsk removed a project from T28903: [Segmentation] Monitoring of segmentation nodes in views is error prone/ not safe.: Request for Discussion.
Wed, Jan 12, 11:35 AM · MITK (v2022.04)
kislinsk removed a project from T28262: TimeGeometry inconsistent documentation and implementation of time bounds and checks: Request for Discussion.

We can assume that this is a time-intensive task and a few solutions were already proposed but we do not see how to resolve it completely at the moment with our available resources.

Wed, Jan 12, 11:25 AM · MITK (v2022.04)
kislinsk removed a project from T28725: VTP files cannot be opened from paths with "special" characters: Request for Discussion.
Wed, Jan 12, 11:17 AM · MITK (v2022.04)

Tue, Jan 11

kislinsk closed T28910: Enabling MBILog messages causes compile errors as Resolved.

Thank your for the report. I removed all erroneous MITK_DEBUG calls as they should be used rarely anyway.

Tue, Jan 11, 12:40 PM · MITK
kislinsk added a comment to T28910: Enabling MBILog messages causes compile errors.

Deleted branch from rMITK MITK: bugfix/T28910-MITK_DEBUG-Errors.

Tue, Jan 11, 12:39 PM · MITK
kislinsk committed rMITKbeef73a3a02e: Remove erroneous MITK_DEBUG lines (authored by kislinsk).
Remove erroneous MITK_DEBUG lines
Tue, Jan 11, 12:39 PM
kislinsk committed rMITK6af4792c2c0b: Fix/reduce dependency to WebEngineCore (authored by kislinsk).
Fix/reduce dependency to WebEngineCore
Tue, Jan 11, 12:39 PM
kislinsk committed rMITK4bec5aa5be6a: Remove fixed version of SimpleITK as recommendation (authored by kislinsk).
Remove fixed version of SimpleITK as recommendation
Tue, Jan 11, 12:38 PM
kislinsk committed rMITK891067173875: Merge branch 'bugfix/T28910-MITK_DEBUG-Errors' into develop (authored by kislinsk).
Merge branch 'bugfix/T28910-MITK_DEBUG-Errors' into develop
Tue, Jan 11, 12:38 PM
kislinsk added a comment to T28910: Enabling MBILog messages causes compile errors.

Pushed new branch to rMITK MITK: bugfix/T28910-MITK_DEBUG-Errors.

Tue, Jan 11, 12:35 PM · MITK
kislinsk triaged T28866: [Segmentation] Redundant label "recomputation" for Otsu/Watershed (& nnUNet) when any of the Preview-generated labels are selected to Confirm as Normal priority.
Tue, Jan 11, 6:49 AM · MITK (v2022.04)
kislinsk triaged T28886: MITK Flowbench - Reopen created segmentation not working as Normal priority.
Tue, Jan 11, 6:48 AM · MITK (v2022.04), Missing Info, Kaapana (internal)
kislinsk added a subtask for T28886: MITK Flowbench - Reopen created segmentation not working: Unknown Object (Maniphest Task).
Tue, Jan 11, 6:48 AM · MITK (v2022.04), Missing Info, Kaapana (internal)
kislinsk added a parent task for T28903: [Segmentation] Monitoring of segmentation nodes in views is error prone/ not safe.: T28886: MITK Flowbench - Reopen created segmentation not working.
Tue, Jan 11, 6:47 AM · MITK (v2022.04)
kislinsk added a subtask for T28886: MITK Flowbench - Reopen created segmentation not working: T28903: [Segmentation] Monitoring of segmentation nodes in views is error prone/ not safe..
Tue, Jan 11, 6:47 AM · MITK (v2022.04), Missing Info, Kaapana (internal)
kislinsk claimed T28910: Enabling MBILog messages causes compile errors.
Tue, Jan 11, 6:46 AM · MITK

Dec 15 2021

kislinsk added a member for MIC: kahl.
Dec 15 2021, 10:34 AM

Dec 10 2021

kislinsk added a member for MIC: a993s.
Dec 10 2021, 9:19 AM
kislinsk removed a watcher for MIC: koehlerg.
Dec 10 2021, 9:18 AM

Dec 3 2021

kislinsk edited the content of Changelog.
Dec 3 2021, 1:43 PM · MITK
kislinsk closed T28902: 2021 Week 48 (Very Early December) as Resolved.
Dec 3 2021, 1:43 PM · MITK
kislinsk added a comment to T28902: 2021 Week 48 (Very Early December).

Deleted branch from rMITK MITK: release/T28902-2021-Week-48.

Dec 3 2021, 1:42 PM · MITK
kislinsk committed rMITK888ff91720a2: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Dec 3 2021, 1:42 PM
kislinsk edited the content of Merging into master Branch.
Dec 3 2021, 1:41 PM
kislinsk committed rMITKcc4b475633d8: 2021 Week 48 (Very Early December) (authored by kislinsk).
2021 Week 48 (Very Early December)
Dec 3 2021, 1:41 PM
kislinsk edited the content of 2021 Week 48 (Very Early December).
Dec 3 2021, 1:33 PM
kislinsk edited the content of MITK v2021.10.
Dec 3 2021, 12:54 PM
kislinsk added a comment to T28902: 2021 Week 48 (Very Early December).

Pushed new branch to rMITK MITK: release/T28902-2021-Week-48.

Dec 3 2021, 12:41 PM · MITK
kislinsk triaged T28902: 2021 Week 48 (Very Early December) as Normal priority.
Dec 3 2021, 12:40 PM · MITK
kislinsk created an object: 2021 Week 48 (Very Early December).
Dec 3 2021, 12:39 PM
kislinsk closed T28898: Cannot create new label in multilabel segmentation as Resolved.
Dec 3 2021, 12:12 PM · MITK
kislinsk added a comment to T28898: Cannot create new label in multilabel segmentation.

Deleted branch from rMITK MITK: bugfix/T28898-AddMoreThan255Labels.

Dec 3 2021, 12:11 PM · MITK
kislinsk committed rMITKe19c02f22e8f: Remove legacy size check (authored by kislinsk).
Remove legacy size check
Dec 3 2021, 12:11 PM
kislinsk committed rMITKbc1afdbf3f25: Merge branch 'bugfix/T28898-AddMoreThan255Labels' into develop (authored by kislinsk).
Merge branch 'bugfix/T28898-AddMoreThan255Labels' into develop
Dec 3 2021, 12:11 PM
kislinsk added a comment to T28898: Cannot create new label in multilabel segmentation.

Pushed new branch to rMITK MITK: bugfix/T28898-AddMoreThan255Labels.

Dec 3 2021, 12:10 PM · MITK
kislinsk added a comment to T28898: Cannot create new label in multilabel segmentation.

Okay, the fix is very simple as there is an unnecessary check in LabelSet::AddLabel() if the size of the label container is bigger than 255 and then return without any further action. I traced it back to the initial implementation of Sebastian Ordas and I guess it is only there since back then it wasn't clear if label sets should be 8-bit or more. So, a no-brainer to remove the check. All other parts of label set obviously work just fine with more labels.

Dec 3 2021, 12:08 PM · MITK
kislinsk claimed T28898: Cannot create new label in multilabel segmentation.
Dec 3 2021, 10:51 AM · MITK

Dec 1 2021

kislinsk added a comment to T28725: VTP files cannot be opened from paths with "special" characters.

Can confirm. Tried to load a VTP from a folder called ßè#$§%&!.

Dec 1 2021, 11:14 AM · MITK (v2022.04)
kislinsk renamed T28725: VTP files cannot be opened from paths with "special" characters from Crashes during hands on tutorial to VTP files cannot be opened from paths with "special" characters.
Dec 1 2021, 11:14 AM · MITK (v2022.04)
kislinsk closed T28736: Preferences for segmentation '2D display' are not properly utilized as Wontfix.

Stopping here since it also is in consideration for the new segmentation anyway and AFAIK it wont be a property of the segmentation itself anymore.

Dec 1 2021, 9:57 AM · MITK (v2022.04)

Nov 30 2021

kislinsk placed T28881: 3D interpolation mesh has inverted normals up for grabs.

I experimented a little with changing the order of filters and using other filters (clean poly data before normal generation, PCA normals estimation) but nothing produced consistent results. So I propose to at least implement a simple flip normals action for the DataManager context menu.

Nov 30 2021, 11:52 AM · MITK
kislinsk lowered the priority of T28881: 3D interpolation mesh has inverted normals from Normal to Low.
Nov 30 2021, 11:25 AM · MITK
kislinsk added a comment to T28881: 3D interpolation mesh has inverted normals.

So, this is not a straight forward fix since other interpolations I tested have correct results. Maybe VTK provides a smart filter for determining the outside that can be used.

Nov 30 2021, 11:25 AM · MITK
kislinsk added a comment to T28881: 3D interpolation mesh has inverted normals.

Haha: T19695: 3D interpolation surface has flipped normals

Nov 30 2021, 11:14 AM · MITK
kislinsk closed T28731: Update README.md of project template as Resolved.

Thanks!

Nov 30 2021, 11:11 AM · MITK (v2022.04), MITK-ProjectTemplate
kislinsk closed T28882: Properties of initially selected nodes are not shown in Properties View. as Resolved.
Nov 30 2021, 10:40 AM · MITK
kislinsk added a comment to T28882: Properties of initially selected nodes are not shown in Properties View..

Deleted branch from rMITK MITK: bugfix/T28882-FixInitialSelectionInPropertiesView.

Nov 30 2021, 10:40 AM · MITK
kislinsk committed rMITKd0f87205c5b0: Handle initial selection after signal and slots are connected (authored by kislinsk).
Handle initial selection after signal and slots are connected
Nov 30 2021, 10:39 AM
kislinsk committed rMITK608047a12d38: Merge branch 'bugfix/T28882-FixInitialSelectionInPropertiesView' into develop (authored by kislinsk).
Merge branch 'bugfix/T28882-FixInitialSelectionInPropertiesView' into develop
Nov 30 2021, 10:39 AM
kislinsk added a comment to T28882: Properties of initially selected nodes are not shown in Properties View..

Pushed new branch to rMITK MITK: bugfix/T28882-FixInitialSelectionInPropertiesView.

Nov 30 2021, 10:39 AM · MITK
kislinsk triaged T28882: Properties of initially selected nodes are not shown in Properties View. as Normal priority.
Nov 30 2021, 10:14 AM · MITK
kislinsk claimed T28881: 3D interpolation mesh has inverted normals.

Can confirm. To reproduce, it is enough to switch on the Surface.2D.Normals.Draw Normals property and check in any 2-d render window. Meshes generated from segmentations in the Data Manager context-menu have correctly oriented normals in contrast.

Nov 30 2021, 10:13 AM · MITK

Nov 22 2021

kislinsk added a member for MIC: o280o.
Nov 22 2021, 3:26 PM

Nov 18 2021

kislinsk lowered the priority of T28778: "Use constraint zooming and panning" is only applied after reinit/restart from Unbreak Now! to Low.
Nov 18 2021, 2:18 PM · Checklist, MITK
kislinsk added a comment to T28778: "Use constraint zooming and panning" is only applied after reinit/restart.

Deleted branch from rMITK MITK: bugfix/T28778-fix-rendering-tests.

Nov 18 2021, 2:18 PM · Checklist, MITK
kislinsk committed rMITK1c4db16fd159: Revert changes to directly apply correct zooming and panning (authored by kahl).
Revert changes to directly apply correct zooming and panning
Nov 18 2021, 2:17 PM
kislinsk committed rMITKad99aa0b22b9: Revert changes to directly apply correct zooming and panning (authored by kahl).
Revert changes to directly apply correct zooming and panning
Nov 18 2021, 2:16 PM
kislinsk closed T28861: Support Visual Studio 2022 as Resolved.
Nov 18 2021, 9:49 AM · MITK
kislinsk added a comment to T28861: Support Visual Studio 2022.

Deleted branch from rMITK MITK: feature/T28861-SupportVisualStudio2022.

Nov 18 2021, 9:48 AM · MITK
kislinsk committed rMITK4b65abbacc90: Handle Visual Studio 2022 (authored by kislinsk).
Handle Visual Studio 2022
Nov 18 2021, 9:48 AM
kislinsk committed rMITK9a962c1e41f4: Upgrade Boost to version 1.78 beta (authored by kislinsk).
Upgrade Boost to version 1.78 beta
Nov 18 2021, 9:48 AM
kislinsk committed rMITK92e5e45dfdd5: Find compatible Qt binaries for Visual Studio 2022 (authored by kislinsk).
Find compatible Qt binaries for Visual Studio 2022
Nov 18 2021, 9:48 AM
kislinsk committed rMITK5f4de198d575: Add Visual Studio 2022 as Tier 2 platform (authored by kislinsk).
Add Visual Studio 2022 as Tier 2 platform
Nov 18 2021, 9:48 AM
kislinsk committed rMITKa8b5789c4365: Merge branch 'feature/T28861-SupportVisualStudio2022' into develop (authored by kislinsk).
Merge branch 'feature/T28861-SupportVisualStudio2022' into develop
Nov 18 2021, 9:48 AM
kislinsk added a comment to T28861: Support Visual Studio 2022.

Pushed new branch to rMITK MITK: feature/T28861-SupportVisualStudio2022.

Nov 18 2021, 9:20 AM · MITK
kislinsk added a comment to T28861: Support Visual Studio 2022.
IMPORTANT: Visual Studio 2022 didn't work out of the box on my machine. For example, CMake wasn't even able to detect the compilers and I wasn't able to link a minimum executable when using Visual Studio 2022 directly. It always boils down to the linker not being able to find ucrt(d).lib. It seems to be a bug in the default Windows SDK version that comes with Visual Studio 2022 at the moment and/or a bug in Visual Studio 2022 itself, since the SDK works fine with Visual Studio 2019. Fix: In the Visual Studio Installer, uninstall the default Windows 10 SDK (10.0.19041.0) and install Windows 10 SDK (10.0.20348.0).
Nov 18 2021, 9:14 AM · MITK
kislinsk triaged T28861: Support Visual Studio 2022 as Wishlist priority.
Nov 18 2021, 9:03 AM · MITK

Nov 17 2021

kislinsk reopened T28778: "Use constraint zooming and panning" is only applied after reinit/restart as "Open".

This fix broke some rendering tests regarding scaling. Please fix/revert as soon as possible since these tests have precedence.

Nov 17 2021, 3:33 PM · Checklist, MITK
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

Deleted branch from rMITK MITK: feature/T27437-migrate-to-ITK-5.

Nov 17 2021, 9:53 AM · MITK (v2022.04)
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

Deleted branch from rMITK MITK: feature/T27437-ITK-v5.1.

Nov 17 2021, 9:52 AM · MITK (v2022.04)
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

Pushed new branch to rMITK MITK: feature/T27437-ITK-v5.

Nov 17 2021, 9:51 AM · MITK (v2022.04)

Nov 16 2021

kislinsk added a hashtag to MITK (v2022.04): #mitk-2022-04.
Nov 16 2021, 9:21 AM
kislinsk triaged T28852: [DICOM] support temporal position and encoding for MR images as Wishlist priority.
Nov 16 2021, 9:17 AM · MITK (v2022.04)

Nov 10 2021

kislinsk archived MITK (v2021.10).
Nov 10 2021, 4:33 PM
kislinsk edited projects for T16153: [Segmentation] Jump to center of mass of segmentation on click, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Bugzilla
kislinsk edited projects for T27189: REST API for data storage, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Restricted Project, Request for Discussion
kislinsk edited projects for T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04)
kislinsk edited projects for T28244: [Segmentation] Fast Marching Tool not really responsive for large images, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04)
kislinsk edited projects for T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary", added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · Request for Discussion, Next Milestone, MITK
kislinsk edited projects for T27133: [Segmentation] Is QmitkDataSelectionWidget needed anymore?, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04)
kislinsk edited projects for T25192: Enable DICOM SEG conversion for nrrd segmentations, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), MICO (Demo MICCAI 2018)
kislinsk edited projects for T24738: [Selection concept] Thumbnail preview of images for datastorage inspectors, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Restricted Project
kislinsk edited projects for T28247: [Segmentation] Watershed tool freezes when slider and threshold are set to a low value, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Missing Info, Request for Discussion
kislinsk edited projects for T18014: write tool interaction tests for segmentation, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Bugzilla
kislinsk edited projects for T25445: MultiLabel segmentation mapper is very slow, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04)
kislinsk edited projects for T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label , added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Request for Discussion
kislinsk edited projects for T25098: Mapper (partially?) do not handle images correctly if they are out of time bound, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04)
kislinsk edited projects for T25097: ItkImageIOTest: Missing tests for reading nrrd data with time geometry, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Cleared, Restricted Project
kislinsk edited projects for T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Cleared
kislinsk edited projects for T25804: [Selection concept] Set 'selected' property when using the new selection concept, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Request for Discussion
kislinsk edited projects for T26972: Dialog and plugin layout seems to be not shown correctly on laptops, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Missing Info
kislinsk edited projects for T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04)
kislinsk edited projects for T27455: Go through pull requests, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Cleared
kislinsk edited projects for T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Pull Request
kislinsk edited projects for T27154: Define clean workflow for segmentation copying, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04)
kislinsk edited projects for T27196: Rewrite packaging of MITK, added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · MITK (v2022.04), Cleared
kislinsk edited projects for T27377: Suppress or fix all build warnings , added: MITK (v2022.04); removed MITK (v2021.10).
Nov 10 2021, 4:32 PM · Restricted Project, MITK (v2022.04)