Page MenuHomePhabricator

Pull RequestTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Jul 1 2020

kislinsk placed T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D up for grabs.
Jul 1 2020, 12:27 PMMITK (2020), Pull Request

May 26 2020

kislinsk closed T13974: Undo functionality on planar figures would be useful. as Wontfix.

Hi there! 馃檪

May 26 2020, 11:18 AMAuto-closed, Pull Request, Bugzilla, MITK
kislinsk closed T10785: Spacing of a worldGeometry of several images is not the greatest common divisor of all spacings, a subtask of T11113: MITK doesn't visualize normalized and thus very small meshes in the expected way., as Wontfix.
May 26 2020, 11:17 AMPull Request, MITK, Bugzilla
kislinsk closed T22990: SlicedGeometry3D crash when volume is rotated by 45 degrees as Wontfix.

Hi there! 馃檪

May 26 2020, 11:17 AMAuto-closed, Pull Request, MITK
kislinsk closed T23120: Add support for loading color from a serialized tool storage file as Wontfix.

Hi there! 馃檪

May 26 2020, 11:17 AMAuto-closed, Pull Request, MITK
kislinsk closed T23990: Changing render window layout mess up Qt layout as Wontfix.

Hi there! 馃檪

May 26 2020, 11:17 AMAuto-closed, Pull Request, Restricted Project, MITK
kislinsk closed T22573: Bad rotation zone for images with small spacing as Wontfix.

Hi there! 馃檪

May 26 2020, 11:16 AMAuto-closed, Pull Request, MITK

May 21 2020

floca added projects to T27247: MITK_SHOW_CONSOLE_WINDOW is not honored in mitk_create_executable function: Cleared, Pull Request.
May 21 2020, 9:48 PMPull Request, Cleared, MITK (2020)

Apr 16 2020

milano updated the task description for T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D.
Apr 16 2020, 1:15 PMMITK (2020), Pull Request

Apr 6 2020

kislinsk closed T26656: Gitlab pull request 238 (Avoid collapsing 'Properties' view when editing child-properties (e.g. "material.something")) as Wontfix.

The actual problem is that some time ago it was decided that modifications of properties also mark the property list containing the property modified (and than the containing data node). Personally I am not a fan of this decision and this task is a good example why. However, even if everyone now would agree that it wasn't the best decision, it would be a huge pain in the back to find and fix all the code locations that rely on this mechanism. Hence, I will close this task as Won't fix, sorry. :/

Apr 6 2020, 12:53 PMMITK, Pull Request

Jan 16 2020

kislinsk placed T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11) up for grabs.
Jan 16 2020, 12:51 PMMITK, Pull Request

Jan 13 2020

kislinsk placed T26835: Crash on change of Surface interpolation from Phong to Flat up for grabs.
Jan 13 2020, 1:47 PMPull Request, MITK

Dec 16 2019

kislinsk triaged T26835: Crash on change of Surface interpolation from Phong to Flat as High priority.
Dec 16 2019, 7:54 PMPull Request, MITK
maleike added a comment to T26835: Crash on change of Surface interpolation from Phong to Flat.

FYI: VTK integrated this fix:

Dec 16 2019, 8:40 AMPull Request, MITK

Nov 25 2019

kausch closed T19683: "Show only selected node" changes the visibility of crosshair as Resolved.
Nov 25 2019, 11:03 AMBugzilla, Pull Request, MITK

Nov 20 2019

maleike updated the task description for T26835: Crash on change of Surface interpolation from Phong to Flat.
Nov 20 2019, 12:23 PMPull Request, MITK
maleike assigned T26835: Crash on change of Surface interpolation from Phong to Flat to kislinsk.
Nov 20 2019, 12:23 PMPull Request, MITK

Nov 19 2019

maleike added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

@maleike

I re-enabled depth peeling support based on your pull request and also enabled depth peeling for volumes and FXAA. It works well for surfaces and volumes but totally breaks rendering of images/cross hair with opacity < 1. So this is not yet complete and I/we have to fix this before I am able to merge it.

Nov 19 2019, 2:16 PMMITK, Noteworthy, Pull Request

Nov 13 2019

kislinsk added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

Pushed new branch T26653-MasterIntegrationFixes.

Nov 13 2019, 2:07 PMMITK, Noteworthy, Pull Request
kislinsk closed T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling) as Resolved.
Nov 13 2019, 1:12 PMMITK, Noteworthy, Pull Request
kislinsk added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

All remaining issues solved by @maleike. I reintroduced the rendering mode preference but instead of switching between "Standard" (default, basically equivalent to "nothing") and "Depth Peeling" it now allows to switch between "No anti-aliasing" and "Fast Approximate Anti-Aliasing (FXAA)" (default). Depth peeling is always enabled as it only kicks in if there are translucent objects in the scene and in the worst case it is preferable to have not the fasted rendering instead of having a broken rendering. The future will show if we there is really a need to additionally add quality options regarding depth peeling.

Nov 13 2019, 12:43 PMMITK, Noteworthy, Pull Request

Nov 8 2019

kalali renamed T26801: Github pull request 243 (Details dialog close button) from Use "Close" instead of "Cancel" for button text in details dialog to Github pull request 243 (Details dialog close button).
Nov 8 2019, 4:27 PMPull Request, MITK
kalali triaged T26801: Github pull request 243 (Details dialog close button) as Normal priority.
Nov 8 2019, 4:21 PMPull Request, MITK

Nov 6 2019

kislinsk added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

Also PointSets have a similar problem with opacity now.

Nov 6 2019, 10:42 AMMITK, Noteworthy, Pull Request

Nov 5 2019

kislinsk added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

I re-enabled depth peeling support based on your pull request and also enabled depth peeling for volumes and FXAA. It works well for surfaces and volumes but totally breaks rendering of images/cross hair with opacity < 1. So this is not yet complete and I/we have to fix this before I am able to merge it.

Nov 5 2019, 11:40 AMMITK, Noteworthy, Pull Request
kislinsk added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

Pushed new branch T26653-ReenableDepthPeeling.

Nov 5 2019, 11:30 AMMITK, Noteworthy, Pull Request

Nov 4 2019

kislinsk placed T26656: Gitlab pull request 238 (Avoid collapsing 'Properties' view when editing child-properties (e.g. "material.something")) up for grabs.
Nov 4 2019, 9:49 AMMITK, Pull Request

Oct 24 2019

kalali added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

Is this solved?

Oct 24 2019, 9:57 PMBugzilla, Pull Request, MITK

Oct 23 2019

ericheim added a comment to T26762: Compile Error In MITK-ProjectTemplate.

Yes. It's the two fixes that are necessary!

Oct 23 2019, 2:29 PMPull Request, MITK
kislinsk added a comment to T26762: Compile Error In MITK-ProjectTemplate.

We try to fix these kind of compatibility issues based on the releases/2018-04 branch or backport their fix to the releases/2018-04 branch in case it was fixed only in the master branch. But I think we actually build that branch on macOS Catalina and the two fixes that were necessary are:

Oct 23 2019, 1:39 PMPull Request, MITK
ericheim added a comment to T26762: Compile Error In MITK-ProjectTemplate.

Thx, for the clarification. Will there be a new release? The current one is not compatible with the actual Mac OS dev kits.

Oct 23 2019, 1:31 PMPull Request, MITK
kislinsk added a project to T26762: Compile Error In MITK-ProjectTemplate: Pull Request.
Oct 23 2019, 1:25 PMPull Request, MITK

Oct 17 2019

kislinsk triaged T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11) as High priority.
Oct 17 2019, 9:27 AMMITK, Pull Request
kislinsk edited projects for T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11), added: MITK (2018-04-4); removed MITK.
Oct 17 2019, 9:27 AMMITK, Pull Request
kislinsk claimed T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).
Oct 17 2019, 9:27 AMMITK, Pull Request
kislinsk added a project to T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11): Pull Request.
Oct 17 2019, 9:18 AMMITK, Pull Request

Oct 16 2019

kislinsk closed T26654: Github pull request 239 (Check filename for invalid characters before saving e.g. "a:b.obj") as Resolved.
Oct 16 2019, 12:07 PMMITK, Pull Request

Sep 13 2019

kausch added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

Pushed new branch T19683-ShowOnlySelectedNodesSecondLevel.

Sep 13 2019, 10:44 AMBugzilla, Pull Request, MITK

Sep 9 2019

kislinsk added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

Cool! 馃憤馃徎
Will look into this on Community Day.

Sep 9 2019, 12:03 PMMITK, Noteworthy, Pull Request
kislinsk triaged T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling) as Normal priority.
Sep 9 2019, 11:58 AMMITK, Noteworthy, Pull Request
kislinsk triaged T26654: Github pull request 239 (Check filename for invalid characters before saving e.g. "a:b.obj") as Normal priority.

Requested code changes in pull request.

Sep 9 2019, 11:56 AMMITK, Pull Request
kislinsk closed T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) as Resolved.

Merged into releases/2018-04.

Sep 9 2019, 11:38 AMMITK, Pull Request
kislinsk added a comment to T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal).

Pushed new branch T26655-GizmoFix.

Sep 9 2019, 11:37 AMMITK, Pull Request
kislinsk triaged T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) as Low priority.
Sep 9 2019, 11:37 AMMITK, Pull Request
kislinsk triaged T26656: Gitlab pull request 238 (Avoid collapsing 'Properties' view when editing child-properties (e.g. "material.something")) as Low priority.

Not yet working. Tree doesn't collapse only the first time.

Sep 9 2019, 11:34 AMMITK, Pull Request

Sep 6 2019

kausch added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

Yes, unfortunately the current solution only works for first level.

Sep 6 2019, 9:58 AMBugzilla, Pull Request, MITK

Sep 3 2019

kalali added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

I experienced a problem with that approach:
I have an image with many segmentation nodes as child nodes. If I want to hide all segmentation nodes except for one (using "show only selected node") it does not hide all other segmentation nodes because they are not on the first level.

Sep 3 2019, 6:48 PMBugzilla, Pull Request, MITK

Aug 28 2019

maleike added a project to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling): Noteworthy.
Aug 28 2019, 2:42 PMMITK, Noteworthy, Pull Request
maleike created T26656: Gitlab pull request 238 (Avoid collapsing 'Properties' view when editing child-properties (e.g. "material.something")).
Aug 28 2019, 2:39 PMMITK, Pull Request
maleike assigned T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) to kislinsk.
Aug 28 2019, 2:38 PMMITK, Pull Request