Page MenuHomePhabricator
Create Task
Maniphest T8188

Clean up open GL context after VTK rendering
Closed, ResolvedPublic
Actions

Description

MITK supports rendering with both openGL and VTK. However, VTK does ensure a "clean" (or regular) openGL context after rendering. It takes some effort to ensure a clean openGL context after VTK rendering.

Today, in the weekly MITK meeting we decided to try to wrap our openGL mappers with the VTK mapper concept. This will result in a unified mapping concept for MITK/VTK and we can get rid of switching between different contexts.

I will make a list of the MITK openGL mappers to wrap and try to figure out which openGL policy/guideline VTK uses for coding new mappers.

Related Objects
Search...

StatusAssignedTask
 ResolvedNoneT7027 Meta Bug: Rework the 2D rendering
 ResolvedNoneT8188 Clean up open GL context after VTK rendering

Event Timeline

• kilgus added projects: MITK, Bugzilla.May 24 2011, 3:04 PM
• kilgus added a subscriber: • kilgus.May 24 2011, 4:27 PM

I discussed this with Matthias and he guessed that there is no official VTK guideline for custom mappers. The best way would be to look about the example implementations of the vtkMapper interfaces, like vtkOpenGLPolyDataMapper, etc..

For cleaning up the context he proposed to look into several vtkWidgets which make use of different VTK mappers, and thus, have to clean up the context.

nolden added a subscriber: nolden.Jul 27 2011, 2:42 PM

Resetting all bugs without active assignee flag to "CONFIRMED". Change status to IN_PROGRESS if you are working on it.

• kilgus added a comment.Sep 8 2011, 9:17 AM

This bug should also refactor the following methods in the mitkVtkPropRenderer:
-Enable2DOpenGL()
-Disabl2DeOpenGL()
-OpenGL commands inside Render()

zelzer added a subscriber: zelzer.Sep 4 2012, 5:19 PM

Due to its severity, this bug is considered relevant for the upcoming 2012.09 release.

Please check the status and consider fixing this bug for 2012.09.

• kilgus added a comment.Sep 5 2012, 9:33 AM

I think Sebastian worked on this. The status was more or less "we can't do more right now". I asked him to write his findings down, but he couldn't do it yet.

@Sebastian: Do you remember the status of this bug?

fangerau added a subscriber: fangerau.Sep 12 2012, 1:58 PM

In our current implementation, the openGL context is in a clean state after our custom GL rendering.

No changes are required.

• heime added a subscriber: • heime.Jan 2 2013, 2:05 PM

There is an ugly workaround for this bug in the mitkVtkProprenderer.cpp:212 which causes a bug in MES because there the glGetFloatv/boolean is not available. A Cleaner solution would be to disable Texturing in Enable2DOpenGL like it is done with the lightning there.

Re-opend the bug.

• heime added a comment.Jan 2 2013, 2:17 PM

New remote branch pushed: bug-8188-cleaupglcontext

nolden added a comment.Jan 2 2013, 2:19 PM

This bug has a 18 month history. Please write change request / summary before requesting the flag.

• heime added a comment.Jan 9 2013, 2:10 PM

Revisited it with Markus F. Changes are Ok.

• heime added a comment.Jan 9 2013, 2:11 PM

[6e7c6c]: Merge branch 'bug-8188-cleaupglcontext'

Merged commits:

2013-01-09 14:08:13 Eric Heim [37273f]
added comments in changes

2013-01-02 14:17:17 Eric Heim [632fbd]
removed the workaround for T8188 in mitkVtkProprenderer.cpp:212 and added cleaner solution in Enable2DOpenGL

graser mentioned this in T8320: Statics Bundle - Histogram not working.Jun 1 2011, 3:26 PM
franza mentioned this in T10647: Colored surfaces are not correctly visualized in 2d views.Jan 11 2012, 5:39 PM
kislinsk edited projects, added MITK (2012-09); removed MITK.Aug 1 2016, 10:47 PM
MITK · MIC · IMSY · DKFZ