Page MenuHomePhabricator
Feed Advanced Search

Aug 2 2016

seitelm added a comment to T3024: Add 3D+t support to ImageStatistics module.

[SVN revision 20297]
ENH (#3024): Made ImageStatisticsCalculator and QmitkImageStatistics 3D+t capable; removed minor bugs with histogram caching

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T3024: Add 3D+t support to ImageStatistics module.

Basic feature works. Closing bug.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T3024: Add 3D+t support to ImageStatistics module: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T3012: PlanarFigure TextBrowser is not updated when control points are moved.

As described in T3031, an itk::EndEvent() is now issued when interaction with a PlanarFigure is completed, which can be listened to so that the application updates itself.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T3014: Volume Rendering not working for 2D images: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T3012: PlanarFigure TextBrowser is not updated when control points are moved.

Confirmed. Setting to CLOSED.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T3011: Polygons do not throw initialized event.

Appears to work correctly now. Closing bug.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T3011: Polygons do not throw initialized event.

[SVN revision 20323]
FIX (#3011): Issue initialize / end events when placement of PlanarPolygon is finished

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2999: Get rid of workaround for using vtkQtChart* classes: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2998: Allow image masking with PlanarFigures even if partially out of bounds: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2993: if you click on a tool, message: "None selected..." is display.

(In reply to comment #7)

seams to work in 2306 with vs2008.

why does a double click not end the "editing" mode? I think thats a typical
behaviour in graphic apps, isn't it?

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2986: "Closed" state of PlanarPolygon is not correctly restored when loading.

[SVN revision 20205]
FIX (#2986): Added writing/reading of "closed" state to PlanarFigure serialization

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2986: "Closed" state of PlanarPolygon is not correctly restored when loading: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2985: PlanarFigureInteractor should issue event when figure placement is completed: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2985: PlanarFigureInteractor should issue event when figure placement is completed.

Done with r20200: the interactor now issues an itk::InitializeEvent when initial placement is complete. Setting bug to FIXED.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2963: Interaction with PlanarFigures should always (but only) work in QmitkMeasurement.

Confirmed. Setting to CLOSED.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2964: PlanarRectangle sometimes slightly misaligned: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2963: Interaction with PlanarFigures should always (but only) work in QmitkMeasurement: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2934: RenderWindows are not shown properly after splash screen.

[SVN revision 20243]
FIX (#2934): Fixed by using new Qt QSplashScreen instead of custom QTranslucentSplashScreen

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2934: RenderWindows are not shown properly after splash screen.

The above fix now uses QSplashScreen and creats the transparency mask directly from the passed image. In this way, the splash screen stays always on top of all other windows during initialization and closes properly when the application has loaded, without leaving any artifacts in the windows.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2933: vtkQtChart classes (for new vtk based Histogram) are only available for VTK >= 5.4.

Everything seems fine now. Closing bug.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2933: vtkQtChart classes (for new vtk based Histogram) are only available for VTK >= 5.4: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2933: vtkQtChart classes (for new vtk based Histogram) are only available for VTK >= 5.4.

[SVN revision 20097]
FIX (#2933): Add cpp file to CPP_FILES and h file to MOC_H_FILES, not vice versa

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2933: vtkQtChart classes (for new vtk based Histogram) are only available for VTK >= 5.4.

[SVN revision 20088]
FIX (#2933): Disable classes/bundles using vtkQtChart* for VTK < 5.4.0

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2916: Enable dragging of control points.

Fixed with commit to parent T2655

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2915: VTK Installer: vtkQtChart*.h files need to be copied into header folder.

Workaround appears sufficient for 3M3. At a later time, a fix could be proposed by us to VTK, or we wait for Kitware to fix this in a future VTK version. Opened new T2999 for this.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2915: VTK Installer: vtkQtChart*.h files need to be copied into header folder.

As a workaround, currently all vtkQtChart*.h files are placed in the folder

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2915: VTK Installer: vtkQtChart*.h files need to be copied into header folder: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2897: Check for activated VTK_USE_QVTK_OPENGL when using vtkQtChart classes: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2881: PlanarCircles are distorted in anisotropic images: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2881: PlanarCircles are distorted in anisotropic images.

The above commit fixes the problem of distortion for anisotropic images / geometries. Closing bug.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added a comment to T2881: PlanarCircles are distorted in anisotropic images.

[SVN revision 20204]
FIX (#2881): Change from index to world coordinates for storing PlanarFigure control points

Aug 2 2016, 9:31 AM · Bugzilla, MITK
seitelm added projects to T2866: Clip PlanarFigure polygon to image bounds for masking: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2857: Correct initialization of PlanarFigures: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2858: Time-support in PlanarFigure / measurement framework: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2857: Correct initialization of PlanarFigures.

Feature complete; setting bug entry to FIXED

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2857: Correct initialization of PlanarFigures.

[SVN revision 19975]
ENH (#2857): Moved Geometry2D initialization for PlanarFigures from QmitkMeasurement to PlanarFigureInteractor to allow for placement in any render window

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2816: Implement new general purpose histogram widget.

The first working version has a basic functionality for rendering and interacting with histograms. Still work in progress.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2816: Implement new general purpose histogram widget.

[SVN revision 20146]
FIX (#2816): Allow only one post-comma digit for histogram annotation

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2816: Implement new general purpose histogram widget.

[SVN revision 20298]
ENH (#2816): Limit visible histogram value range to actual value min/max bounds; show nothing if histogram is empty

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2816: Implement new general purpose histogram widget.

Basic feature working as required. Closing bug.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2816: Implement new general purpose histogram widget: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2816: Implement new general purpose histogram widget.

[SVN revision 20028]
ENH (#2816): Added rudimentary version of new VTK based histogram widget

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2798: Allow picking, moving and rotating of PlanarFigures.

Will implement this later together with general picking in MITK.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2798: Allow picking, moving and rotating of PlanarFigures: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2796: Imlement PlanarFourPointAngle: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2797: Implement PlanarRectangle: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2795: Make sure that PlanarFigures can be re-discovered in a scene.

Rediscovering generally works with the current window initialization. However, for future releases the QmitkMeasurement application should restrict mesurement planes to actual image planes. A new T3062 has been created to solve this problem (not 3M3).

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2795: Make sure that PlanarFigures can be re-discovered in a scene.

[SVN revision 20163]
FIX (#2795): Use origin of PlanarFigure geometry instead of center; render PlanarFigure if current render plane is contained in the bounds of the PlanarFigure Geometry

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2794: Improve performance of PlanarFigure handling.

The performance bottle-neck is in PlanarCircle objects, which currently consist of 256 polygon points. For other PlanarFigures, rendering performances is ok.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2794: Improve performance of PlanarFigure handling.

[SVN revision 20541]
FIX (#2794): Improved performance by reducing number of polygon points for PlanarCircles from 256 to 64

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2794: Improve performance of PlanarFigure handling.

64 polygon points still produce nice circles and improve rendering performance. Removing 3M3 tag.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2795: Make sure that PlanarFigures can be re-discovered in a scene: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2795: Make sure that PlanarFigures can be re-discovered in a scene.

[SVN revision 20001]
ENH (#2795): Set a render-window-specific bool property when a PlanarFigure is placed (to recover the render window in which this was done later on)

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2795: Make sure that PlanarFigures can be re-discovered in a scene.

We should make sure that a scene is reinitialized on the dataset to which PlanarFigures belong when adding/interacting with them. Otherwise finding PlanarFigures will sometimes not work, as described above

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2795: Make sure that PlanarFigures can be re-discovered in a scene.

PlanarFigure re-discovery works now if

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2792: Extend PlanarFigure interactor to allow point adding/removal: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2793: Extend PlanarFigure interface to allow retrieval of feature measurements.

[SVN revision 19769]
COMP (#2793): Fixed gcc-incompatible reference initialization

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2793: Extend PlanarFigure interface to allow retrieval of feature measurements: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2794: Improve performance of PlanarFigure handling: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2793: Extend PlanarFigure interface to allow retrieval of feature measurements.

This feature has been implemented; setting bug to FIXED

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2793: Extend PlanarFigure interface to allow retrieval of feature measurements.

[SVN revision 19768]
ENH (#2793): Extended interface of PlanarFigure and subclasses to allow for retrieval of feature measurements

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2791: Allow PlanarFigur representations to consist of multiple PolyLine.

Sounds good! The draw-only poly-lines (e.g. angles, arrows, etc.) should in most (all?) cases be scale-invariant w.r.t. the display geometry / size, which means that they need to be handled differently during rendering.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2791: Allow PlanarFigur representations to consist of multiple PolyLine: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2782: Tutorial steps crash.

(In reply to comment #3)

Mathias, in Tutorial step 3, the GlobalInteraction is not used. Is it crashing
at your system, too? Only step 6-8 use GlobalInteraction.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2781: Tutorial applications produce warnings due to incorrect LOD behavior: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2780: Tutorials fail.

Marking this bug as duplicate of T2782

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to F359: tutorial7_errors.JPG.

Warnings produced from tutorial step 7

Aug 2 2016, 9:30 AM
seitelm added a comment to T2781: Tutorial applications produce warnings due to incorrect LOD behavior.

Attached screenshot shows warning about rendering LOD mechanism

tutorial8_warnings.JPG (1×1 px, 221 KB)

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to F358: tutorial8_warnings.JPG.

Warnings produced from tutorial step 8

Aug 2 2016, 9:30 AM
seitelm added a comment to T2781: Tutorial applications produce warnings due to incorrect LOD behavior.

In tutorial step 7, another different VTK warning occurs: The attached screenshot shows warning relating to uninitialized vtkPainterPolyDataMapper (Mapper has no input)

tutorial7_errors.JPG (1×1 px, 124 KB)

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2781: Tutorial applications produce warnings due to incorrect LOD behavior.

(In reply to comment #1)

Created an attachment (id=343) [details]
Warnings produced from tutorial step 8

Attached screenshot shows warning about rendering LOD mechanism

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2780: Tutorials fail: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2781: Tutorial applications produce warnings due to incorrect LOD behavior.

(In reply to comment #2)

Created an attachment (id=344) [details]
Warnings produced from tutorial step 7

In tutorial step 7, another different VTK warning occurs: The attached
screenshot shows warning relating to uninitialized vtkPainterPolyDataMapper
(Mapper has no input)

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2762: Calculation of image statistics.

This feature is realized in the module described in T2674. DUPLICATE.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2760: Serialization of Planar Figures.

(In reply to comment #15)

Writing/reading of PlanarFigures seems to work now. Selection of the correct
planes is now also working properly since the fixes in T795.

Setting bug to FIXED.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2760: Serialization of Planar Figures.

Writing/reading of PlanarFigures seems to work now. Selection of the correct planes is now also working properly since the fixes in T795.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2760: Serialization of Planar Figures.

[SVN revision 20164]
FIX (#2760): Use axis vectors, origin, and spacing for saving/loading PlaneGeometry for PlanarFigures

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2760: Serialization of Planar Figures.

[SVN revision 20165]
ENH (#2760): Added PlanarRectangle to serialization

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to F357: MeasurementSerializationError.png.

Error with serialization/de-serialization of PlanarFigure

Aug 2 2016, 9:30 AM
seitelm added a comment to T2760: Serialization of Planar Figures.

With the following steps, an error occured on my system with saving/reloading of PlanarFigures as seen in the screenshot:

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2750: Range slider for two values.

Just had a quick look: Qwt has extra sliders, but no such "range slider".

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added a comment to T2750: Range slider for two values.

I also think this could be a good option... Also, according to the change history, the project has seen various recent and regular updates, probably more than Qwt.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
seitelm added projects to T2728: StateMachineEditor is not working properly anymore with relocated StateMachine.xml: MITK, Bugzilla.
Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2717: opacity does not work with mitkShaderLighting.

Markus, can you have a look at this?

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2695: Missing FileWriters and FileReaders.

Serialization of objects of Geometry3D and sub-classes would allow to store various Geometry information contained in a scene. If a mechanism for saving/loading Geometry objects was available in MITK, it would also be straightforward to impelemtn a writer for mitk::GeometryData (e.g., needed to store curved geometries/planes)

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20381]
ENH (#2674): Added progress bar update; improved handling of statistics updates and memory clean-up

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20385]
FIX (#2674): Avoid crash at application shutdown by disabling unused internal event connections

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

Basic features working. Future extensions will be document in different bugs.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20331]
ENH (#2674): Made GUI more contact by moving buttons around

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

The functions currently disabled (in particular, multi-image statistics and reporting of min/max indices) should be re-integrated / re-enabled in future versions of this tool. Possibly, an expert mode would offer an extended GUI with features such as multi-image statistics.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20307]
FIX (#2674): Correct PlanarFigure conversion from 2D world to 3D world coordinates in ImageStatistics (used to be 2D index coordinates); extended error handling

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20147]
FIX (#2674): Display name of mask, not name of class for mask images

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20145]
FIX (#2674): Corrected recognition of mask images

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20299]
ENH (#2674): Use new icon for image statistics view

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20329]
ENH (#2674): Proper clean-up of GUI when no dataset is selected or statistics cannot be computed

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20036]
ENH (#2674): New version of QmitkImageStatistics which includes the new QmitkVtkHistogramWidget and reduced some of the previous existant functions for the sake of a simple GUI.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20321]
ENH (#2674): Statistics and histogram are automatically updated when Image, Image Mask or PlanarFigure change (added listeners)

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20211]
COMP (#2674): use case-sensitive include file name

Aug 2 2016, 9:29 AM · Bugzilla, MITK
seitelm added a comment to T2674: Statistics / Histogram tool for segmentations.

[SVN revision 20038]
COMP (#2674): Changed include file name to case-sensitive

Aug 2 2016, 9:29 AM · Bugzilla, MITK