Page MenuHomePhabricator
Feed Advanced Search

Aug 2 2016

schroedt added a comment to T10925: Make MITK compatible with ITK 4.0.

[d80862]: Merge branch 'bug-10925-ITK4MigrationNew'

Merged commits:

2013-04-26 14:28:27 Tobias Schroeder [09257c]
COMP: Temporarily removed SegmentationInterpolationTest

Aug 2 2016, 9:51 AM · Bugzilla, MITK
schroedt added a comment to T10925: Make MITK compatible with ITK 4.0.

[0d8e19]: Merge branch 'bug-10925-ITK4MigrationNew'

Merged commits:

2013-04-26 14:12:40 Tobias Schroeder [cdcf4f]
COMP: Temporarily removed SegmentationInterpolationTest

Aug 2 2016, 9:51 AM · Bugzilla, MITK
schroedt added projects to T10865: crosshair rotation crashes if two planes are rotated to be congruent: MITK, Bugzilla.
Aug 2 2016, 9:51 AM · MITK (2012-06), Bugzilla
schroedt added projects to T10864: 3d interpolation crashes: MITK, Bugzilla.
Aug 2 2016, 9:51 AM · Bugzilla, MITK
schroedt added a comment to F780: vtk_error_3D_interpolation.PNG.

vtk error output

Aug 2 2016, 9:51 AM
schroedt added a comment to T10860: CreateOutlinePolyData in mitkImageVtkMapper2D does not consider the plane bounds.

Resolved:

  • indices initialized with minimum values of the extent
  • iterate until maximum y value is reached
  • consider the pixels located at the edge of the image by adding outlinepolydata to these pixels
  • update the wholeExtent of vtkImageReslice before actually reslicing
Aug 2 2016, 9:51 AM · Bugzilla, MITK
schroedt added a comment to T10860: CreateOutlinePolyData in mitkImageVtkMapper2D does not consider the plane bounds.

Has to be fixed separatly and thus needs an own changerequest.

Aug 2 2016, 9:51 AM · Bugzilla, MITK
schroedt added a comment to T10860: CreateOutlinePolyData in mitkImageVtkMapper2D does not consider the plane bounds.

No PolyData for pixels at the edge of the image is added.
There is no if clause for these cases.

Aug 2 2016, 9:51 AM · Bugzilla, MITK
schroedt added a comment to T10860: CreateOutlinePolyData in mitkImageVtkMapper2D does not consider the plane bounds.

[58c0e6]: Merge branch 'bug-10860-CreateOulinePolyData-consider-plane-bounds'

Merged commits:

2012-01-31 10:12:42 Tobias Schroeder [750faf]
some docu and code formatting

Aug 2 2016, 9:51 AM · Bugzilla, MITK
schroedt added projects to T10860: CreateOutlinePolyData in mitkImageVtkMapper2D does not consider the plane bounds: MITK, Bugzilla.
Aug 2 2016, 9:51 AM · Bugzilla, MITK
schroedt added projects to T10816: .pic file can not be loaded: MITK, Bugzilla.
Aug 2 2016, 9:51 AM · Bugzilla, MITK
schroedt added projects to T10815: 2D images are displayed gray in Debug Mode: MITK, Bugzilla.
Aug 2 2016, 9:50 AM · MITK (2012-09), Bugzilla
schroedt added projects to T10785: Spacing of a worldGeometry of several images is not the greatest common divisor of all spacings: MITK, Bugzilla.
Aug 2 2016, 9:50 AM · Auto-closed, Bugzilla, MITK
schroedt added a comment to T10470: ExtApp crashes after reading a previously saved 2d .nrrd image (sagital / coronal).

I figured out that ExtApp only crashes in Debug mode. In Release mode nothing happens.
It seems to be the TransformMatrix property of the geometry. I checked it in the mhd file of the image

Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added a comment to T10476: Reading a 3D image with only one slice information does work.

fixed with T11541.
A filter was implemented to transform a 2D image into a 3D image with only one slice, so the matrix of the image will be correctly written to file

Aug 2 2016, 9:50 AM · MITK (2012-09), Bugzilla
schroedt added projects to T10476: Reading a 3D image with only one slice information does work: MITK, Bugzilla.
Aug 2 2016, 9:50 AM · MITK (2012-09), Bugzilla
schroedt added a comment to F769: 2Dimages.zip.

contains the corrupt nrrd files and pic files

Aug 2 2016, 9:50 AM
schroedt added projects to T10470: ExtApp crashes after reading a previously saved 2d .nrrd image (sagital / coronal): MITK, Bugzilla.
Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added a comment to T10470: ExtApp crashes after reading a previously saved 2d .nrrd image (sagital / coronal).

Andreas and I found two location where the image writing as well as the reading of 2D images going wrong.

Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added a comment to T10470: ExtApp crashes after reading a previously saved 2d .nrrd image (sagital / coronal).

The bug is related to bug in the writing of the matrix, a dimension of 2 causes the matrix to be cut to 2x2 instead of 3x3.

Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added a comment to T10452: Review FileWriter test.

I stumbled upon the same issue while searching for an example of a writer test. The following tests are all doing the same(actually nothing):

Aug 2 2016, 9:50 AM · Auto-closed, Bugzilla, MITK
schroedt added a comment to T10348: Moving OverwriteImageFilters from MitkExt to module ImageExtraction.

Will fixed with bug-10333

Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added a comment to T10333: implement an overwriteImageFilter based on the algorithm of vtkImageReslice.

fixed with bug-7994

Aug 2 2016, 9:50 AM · MITK (2012-09), Bugzilla
schroedt added a comment to T10333: implement an overwriteImageFilter based on the algorithm of vtkImageReslice.

A requirement for the filter is also to enable undo functionality for segmentation in rotated planes. This is done by introducing an operation class and its appropriate applier class.
<a href="http://bugs.mitk.org/show_bug.cgi?id=7994">T7994</a> realizes this feature. As all the code from T10333 is required for 7994, 10333 is closed with pushing 7994.

Aug 2 2016, 9:50 AM · MITK (2012-09), Bugzilla
schroedt added a comment to T10333: implement an overwriteImageFilter based on the algorithm of vtkImageReslice.

I've written a filter that inherits from vtkImageReslice and modified the execute algorithm in a way that slices can be written back to an image volume.
All optimizations of vtkImageReslice are left and only nearest neighbour interpolation available.
The slice can be set via SetInputSlice method.

Aug 2 2016, 9:50 AM · MITK (2012-09), Bugzilla
schroedt added a comment to T10333: implement an overwriteImageFilter based on the algorithm of vtkImageReslice.

There will be a meeting with Marco next week. I will then add an explanation to wiki page.

Aug 2 2016, 9:50 AM · MITK (2012-09), Bugzilla
schroedt added a comment to T10333: implement an overwriteImageFilter based on the algorithm of vtkImageReslice.

Progress update:
The overwrite functionality is working with all segmentation tools. Several issues had to be fixed:

  • the image's extent was not adapted during rotation within crosshair rotaion
  • the origin of the plane too
  • race condition in PaintbrushTool, the working slice stored in node was somehow deleted and the overwrite filter accessed random memory
Aug 2 2016, 9:50 AM · MITK (2012-09), Bugzilla
schroedt added projects to T10333: implement an overwriteImageFilter based on the algorithm of vtkImageReslice: MITK, Bugzilla.
Aug 2 2016, 9:50 AM · MITK (2012-09), Bugzilla
schroedt added projects to T10265: a vtk error occurs when a plane is rotated and the crosshair is moved: MITK, Bugzilla.
Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added a comment to T10265: a vtk error occurs when a plane is rotated and the crosshair is moved.

There were actually two vtk errors.

Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added a comment to T10222: planar figure isn't able to be deselected.

if the current PlanarFigureNode is NULL or no Data is set in current node
the corresponding counter for the figure name has to be incremented.

Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added a comment to T10222: planar figure isn't able to be deselected.

[669b72]: Merge branch 'bug-10222-MeasurementPlanarFigureSelection'

Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added a comment to T10174: Provide opacity property for first color in Lookup Table.

The current workaround is available on branch personal/schroedt/lut-clipping-issue-2d-3d

Aug 2 2016, 9:50 AM · Bugzilla, MITK
schroedt added projects to T9318: Remove duplicated Code from mitkImageVtkMapper2d and mitExtractDirectedPlaneImageFilter: MITK, Bugzilla.
Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added projects to T9319: Bring together mitExtractDirectedPlaneImageFilter and mitExtractDirectedPlaneImageFilterNew: MITK, Bugzilla.
Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added a comment to T9318: Remove duplicated Code from mitkImageVtkMapper2d and mitExtractDirectedPlaneImageFilter.

Finally fixed by implemention of a new Filter called mitkExtractSliceFilter.
This filter is based on vtkImageReslice to extract slices from a volume. See dokumentation for its use.

Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added a comment to T9318: Remove duplicated Code from mitkImageVtkMapper2d and mitExtractDirectedPlaneImageFilter.

[d47e2e]: Merge branch 'bug-9318-implement-a-mitk-filter-for-slice-extraction'

Merged commits:

2012-05-25 15:57:38 Tobias Schroeder [ad59d3]
yet another tabfix

Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added a comment to T9317: Cleanup ExtractDirectedPlaneImageFilter.

Fixed see bug #9318

Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added a comment to T9318: Remove duplicated Code from mitkImageVtkMapper2d and mitExtractDirectedPlaneImageFilter.

There will be a new class which is responsible for extracting slices.

Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added a comment to T9319: Bring together mitExtractDirectedPlaneImageFilter and mitExtractDirectedPlaneImageFilterNew.

Fixed by creating a new filter which is responsible for extracting slices for rendering and segmentation.

Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added a comment to T9321: mitkExtractDirectedPlaneImageFilter - only one class should be responsable for imageextraction.

Fixed by creating a new class which is responsible for extracting slices for rendering and segmentation

Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added projects to T9321: mitkExtractDirectedPlaneImageFilter - only one class should be responsable for imageextraction: MITK, Bugzilla.
Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added projects to T9317: Cleanup ExtractDirectedPlaneImageFilter: MITK, Bugzilla.
Aug 2 2016, 9:48 AM · Bugzilla, MITK
schroedt added a comment to T9098: Keep DataNode name during rename.

The effort is much too high for this small feature.

Aug 2 2016, 9:47 AM · Bugzilla, MITK
schroedt added a comment to T7994: Realize undo functionality for the segmentation in rotated planes.

[fcfbfe]: Merge branch 'bug-7994-undo-functionality-for-segmentation'

Merged commits:

2012-06-28 16:06:12 Tobias Schroeder [0d58bb]
added prefix in files.cmake

Aug 2 2016, 9:44 AM · Bugzilla, MITK
schroedt added a comment to T7994: Realize undo functionality for the segmentation in rotated planes.

In the segmentation workflow there are two operations instantiated within mitkSegTool2D. One is the undo operation representing the state of a slice before editing and the other one (redo) represents the state after a segmentation was done. Both are then put on the undo stack.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
schroedt added a comment to T7994: Realize undo functionality for the segmentation in rotated planes.

For the realization of this feature a new filter for overwriting slices in rotated planes had to be implemented. vtkImageOverwrite is based on vtkImageReslice and working together mitkExtractSliceFilter (see T10333). The filter replaces the two overwrite-filters currently used by mitk's segmentation module. With vtkImageOverwrite it was possible to define an operation and its appropriate applier to enable undo functionality.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
schroedt added a comment to T6986: Crash on closing Application.

Can't be reproduced with MITK-2012.06.99_r5d2306

Aug 2 2016, 9:43 AM · MITK (2012-09), Bugzilla
schroedt added a comment to T5402: Memory-Usage is falsely calculated on Mac systems.

What is the status of this bug?

Aug 2 2016, 9:40 AM · Bugzilla, MITK