Page MenuHomePhabricator

[Segmentation] Watershed tool freezes when slider and threshold are set to a low value
Closed, InvalidPublic

Description

This is one task in the checklist, which says:

Theory:
Set both sliders to a small value = nothing should happen...

Reality:
Setting to small limits /Setting them to the lower limit = Nothing, literally, nothing happens anymore, Workbench not responding anymore.
(Stopped after 5 mins each because didn't expect anything to happen)

Computation with Level = 0,6 took 2 min but produces results

Event Timeline

thomass triaged this task as Unbreak Now! priority.Jan 29 2021, 7:44 PM
thomass created this task.
kislinsk added a subscriber: kislinsk.

We should take the opportunity to discuss the general sense of some segmentation tools. It appears to me that quite a few tools are just there because the algorithm is mentioned in the ITK book. In particular when looking at the abstract parameters that the tools offer I highly doubt they are of use for anyone at all. "alpha", "beta", "gamma", "level", you name it. We should consider to actually remove those tools and invest our time instead in improving tools people use or the integration of the DL algorithms of our department.

Ref T28244: [Segmentation] Fast Marching Tool not really responsive for large images

BTW I also tested with small values and the computation did at least finish after 2 minutes on my desktop PC.

floca lowered the priority of this task from Unbreak Now! to Normal.May 5 2021, 11:54 AM
floca moved this task from Cycle to Segmentation on the MITK (v2021.10) board.

This issue should be postponed until T28523: Evaluate MITK segmentation survey (to now the new priority) and T27437: Migrate MITK to use ITK 5.x (check for performance improvments due to refactored ITK) is done.

floca lowered the priority of this task from Normal to Low.Jul 28 2021, 12:45 PM

Down prioritized it, because survey indicated currently low relevance.

Are we keeping Watershed for the next release? I'm currently testing it because of T28641: [Segmentation] Improve Watershed tool documentation and it just stops at 59%.

Edit: I tried to change the level slider but obviously it seems to be more beneficial for the speed to raise the threshold, to reduce the number of local minima and have less regions to start with.

@kislinsk Do we want to close this task, because of 2ef49f51d547?