Page MenuHomePhabricator | MITK

META BUG Geometry Cleanup
Closed, DuplicatePublic

Description

  1. Create a new member matrix for rotation:

ITK images include a Matrix m_Direction, containing information about rotation. At the moment we do not have a similar member in our MITK Geometries. ATM we handle rotation by adjusting the index-to-world transform funciton directly, which is not always comprehensible (since it does contain spacing as well).
It is desirable to have a Matrix Membervariable for Rotation in MITK Geometry3D as well, with respective Set/Get Functions. When the matrix is changed, the world-to-index transform should be be recalculated.

  1. More Privacy for better comprehension

Editing the World-To-Index Transform directly should be avoided, instead you should set Spacing, Origin and DirectionMatrix. This is much more comprehensible!! The Geometry classes should take care of recalcuation of VTK and ITK Transform Matrixes itself!

  1. Remove unused and redundant members

There are unused and redundant methods and parameters (e.g. setSpacing, setFloatSpacing, Quaternion.. ) in the Geometry3D class. We should get rid of them to make the geometry class more comprehensible and smaller

Related Objects

StatusAssignedTask
Resolvedkislinsk
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedkislinsk
Resolvedkislinsk
Resolvedkislinsk
OpenNone
Wontfixkislinsk
Wontfixkislinsk
InvalidNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
Wontfixkislinsk
ResolvedNone

Event Timeline

graser added a subscriber: graser.Sep 29 2011, 10:07 AM

There is a need for a IndexToWorld transform, that accepts mitk::index3d as input

Bastian and I started cleaning up the geometries. We created a wikipage in order to write down some definitions we had to make during the refactoring process and to have some kind of record about what we have done so far:

http://mbits/mbiwiki/mitk%3A%3AGeometry%20Refactoring#preview

@ivo, Marco, Daniel: It would be create if you could take a look at the wikipage from time to time and to check whether our definitions are consistent with the original intention of the geometries.

(In reply to comment #2)

http://mbits/mbiwiki/mitk%3A%3AGeometry%20Refactoring#preview
@ivo, Marco, Daniel: It would be create if you could take a look at the
wikipage from time to time and to check whether our definitions are consistent
with the original intention of the geometries.

Could you please put this on mitk.org/wiki/internal or similar? mbits is DKFZ internal, which I am not anymore without VPN.

espak added a subscriber: espak.Feb 8 2012, 8:54 PM

Has the wiki page been moved to mitk.org?

wildes added a subscriber: wildes.Dec 3 2014, 4:35 PM

I'll close this bug as dublicate of 18034 and 17035, as a lot of these requests are already solved due to the new Geometry concepts. T18520 describes new tasks for cleaning up geometries.