Page MenuHomePhabricator
Feed Advanced Search

May 9 2023

floca triaged T29573: [Segmentation] Segmentation without label (only empty Group 0) cannot be saved as High priority.
May 9 2023, 9:30 AM · Checklist, MITK (v2023.04)
floca moved T29589: [Segmentation] [Lasso] Add/subtract not in sync with radio buttons in GUI from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 9:29 AM · Checklist, MITK (v2023.04)
floca moved T29566: TotalSegmentator GUI bug: Install button not Activated correctly from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 9:29 AM · Checklist, MITK (v2023.04)
floca moved T29567: TotalSeg: inferencing issue on MacOS from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 9:29 AM · MITK (v2023.12)
floca moved T29571: [Segmentation] Changing groups on loaded multi-group segmentations crash from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 9:29 AM · Checklist, MITK (v2023.04)
floca moved T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 9:29 AM · MITK (v2023.12), Checklist
floca added a comment to T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds.

I have the feeling it is an race condition/timing problem.
I was able to recreate the problem also in release after rapidly clicking arround (at least 50 times, machine gun style). In debug I clicked for minutes without anything appening.

May 9 2023, 8:23 AM · MITK (v2023.12), Checklist

May 8 2023

floca closed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS as Resolved.
May 8 2023, 2:42 PM · MITK (v2023.04)
floca added a comment to T29567: TotalSeg: inferencing issue on MacOS.

Is @wasserth active here? Or we goto GitHub and make an issue over there?

I would also open an issue at GitHub. As you already analyzed the current versions, we could also think of providing a pull request (and have the fork with that changes as back up plan for the release).

May 8 2023, 11:42 AM · MITK (v2023.12)
floca closed T29474: [SEG] Remove exterior label, a subtask of T28524: Refactor LabelSetImage and associated classes., as Resolved.
May 8 2023, 9:52 AM · MITK, Next Milestone
floca closed T29474: [SEG] Remove exterior label as Resolved.
May 8 2023, 9:52 AM · Next Milestone

May 7 2023

floca added a comment to T29375: Cursor offset in 2D tools with Qt 5.15 on macOS.

@a178n could you check if this task is solved with T29572?

May 7 2023, 1:19 PM · MITK (v2023.04)
floca added a parent task for T29572: [SEG] Tool interaction does not work on multi montor setup with different dpi: T29375: Cursor offset in 2D tools with Qt 5.15 on macOS.
May 7 2023, 1:18 PM · MITK (v2023.04)
floca added a subtask for T29375: Cursor offset in 2D tools with Qt 5.15 on macOS: T29572: [SEG] Tool interaction does not work on multi montor setup with different dpi.
May 7 2023, 1:18 PM · MITK (v2023.04)
floca added a revision to T29572: [SEG] Tool interaction does not work on multi montor setup with different dpi: Unknown Object (Differential Revision).
May 7 2023, 1:16 PM · MITK (v2023.04)
floca moved T29573: [Segmentation] Segmentation without label (only empty Group 0) cannot be saved from Backlog to Cycle on the MITK (v2023.04) board.
May 7 2023, 10:31 AM · Checklist, MITK (v2023.04)
floca claimed T29573: [Segmentation] Segmentation without label (only empty Group 0) cannot be saved.
May 7 2023, 10:30 AM · Checklist, MITK (v2023.04)

May 6 2023

floca moved T29572: [SEG] Tool interaction does not work on multi montor setup with different dpi from Backlog to Cycle on the MITK (v2023.04) board.
May 6 2023, 12:27 PM · MITK (v2023.04)
floca triaged T29572: [SEG] Tool interaction does not work on multi montor setup with different dpi as Unbreak Now! priority.
May 6 2023, 12:27 PM · MITK (v2023.04)
floca added a comment to T29571: [Segmentation] Changing groups on loaded multi-group segmentations crash.

I can do it, if you want.

May 6 2023, 9:34 AM · Checklist, MITK (v2023.04)

May 5 2023

floca updated subscribers of T29567: TotalSeg: inferencing issue on MacOS.
May 5 2023, 6:31 PM · MITK (v2023.12)
floca added a comment to T29567: TotalSeg: inferencing issue on MacOS.

I think it would be more efficient /sufficient to advise @wasserth to use explicitly defined versions for total segmentator dependencies. That is something all projects should regard for productive versions to have a better control on their supply chain.

May 5 2023, 6:29 PM · MITK (v2023.12)

May 4 2023

floca added a subtask for T29562: [GrowCut] "Undo" only changes slices with seed images: Unknown Object (Maniphest Task).
May 4 2023, 2:54 PM · Moved to git.dkfz.de, Request for Discussion, MITK
floca added a project to T29562: [GrowCut] "Undo" only changes slices with seed images: Request for Discussion.

grow cut (as all preview tools) does not generate any undo point right now. What you witness is the undo of your seed painting up front.

May 4 2023, 2:49 PM · Moved to git.dkfz.de, Request for Discussion, MITK

May 3 2023

floca added a comment to T29452: Setting arbitrary label names to a LabelSetImage can be more straightforward.

I am not sure I would put it a member function. This can be done without the need of accessing any internals.

May 3 2023, 3:55 PM · Moved to git.dkfz.de, MITK, Request for Discussion
floca edited projects for T28275: [Segmentation] AdaptiveRegionGrowingTool must be refactored / 4D Segmentation returns error message when point is not on the correct timestep, added: MITK, Next Milestone, Request for Discussion; removed MITK (v2023.04).

We should discuss if it is still worth it to get it back online after all this time and with the new tools.

May 3 2023, 3:51 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca edited projects for T28499: Refactor/rewrite RegionGrowing3D tool, added: MITK, Next Milestone; removed MITK (v2023.04).

We should discuss if we realy try to get region growing back online with all the other tools ...

May 3 2023, 3:48 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca added a comment to T29558: TotalSegmentator: Modify as per new Segmentation changes.

You should do a compbination (to keep the 4D support).

May 3 2023, 3:45 PM · MITK (v2023.04)
floca added a revision to T29548: [Segmentation] Missing I- button: Unknown Object (Differential Revision).
May 3 2023, 9:40 AM · MITK (v2023.04)

May 2 2023

floca added a comment to T29451: [SEG] Response labels all not displayed on Workbench.

@a178n the changes in D816 should offer everything to solve the problem. I also adapted TotalSegmentator Tool. But you should verify that it works as expected.
Basically the tool should now change the labels in the preview as they like (see Otsu and TotalSegmentator for example) and use the TransferMode AddLabel. Then the labels (with all there settings) of the preview image will be added instead of mapped.

May 2 2023, 9:34 PM · Cleared, MITK (v2023.04)
floca added a comment to T29458: Include Advanced settings support for TotalSegmentator tool in MITK.

Pushed new branch to rMITK MITK: bugfix/T29458-Optimize_QmitkMultiLabelManager_buttons.

May 2 2023, 9:01 PM · MITK (v2023.04)
floca claimed T29548: [Segmentation] Missing I- button.
May 2 2023, 8:53 PM · MITK (v2023.04)
floca committed rMITKc799e916bffc: T29551 Corrected update of manager buttons (authored by floca).
T29551 Corrected update of manager buttons
May 2 2023, 8:52 PM
floca closed T29551: [Segmentation] Label tool buttons should be updated whenever the model changes as Resolved by committing rMITKc799e916bffc: T29551 Corrected update of manager buttons.
May 2 2023, 8:52 PM · MITK (v2023.04)
floca committed rMITK33aada28909d: Corrected update of manager buttons (authored by floca).
Corrected update of manager buttons
May 2 2023, 8:52 PM
floca committed rMITK74fcf859be1c: Fixed typos (authored by floca).
Fixed typos
May 2 2023, 5:43 PM
floca committed rMITK553ef94f7598: Fixed T29550 - load save label presets (authored by floca).
Fixed T29550 - load save label presets
May 2 2023, 5:43 PM
floca closed T29550: [Segmentation] Load/save Label set preset buttons do nothing as Resolved by committing rMITK392d2571238e: Fixed T29550 - load save label presets.
May 2 2023, 5:43 PM · MITK (v2023.04)
floca committed rMITK392d2571238e: Fixed T29550 - load save label presets (authored by floca).
Fixed T29550 - load save label presets
May 2 2023, 5:43 PM
floca added a revision to T29451: [SEG] Response labels all not displayed on Workbench: Unknown Object (Differential Revision).
May 2 2023, 5:32 PM · Cleared, MITK (v2023.04)
floca added a revision to T29500: [SEG] SegWithPreview tools with multiple labels are broken (if the produce a 0 label): Unknown Object (Differential Revision).
May 2 2023, 5:32 PM · MITK (v2023.04)
floca claimed T29451: [SEG] Response labels all not displayed on Workbench.
May 2 2023, 8:35 AM · Cleared, MITK (v2023.04)

May 1 2023

floca added a comment to T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash.

Serialization error: I already renamed LabelSetImageSerializer into MultiLabelSegmentationSerializer, but the data class still names LabeSetImage. I forgot that our scene serializer logic deduces the serializer by <className>+Serializer.
Thus it breaks now. I guess the simpelest solution for now would be to rename the serializer class back.

May 1 2023, 12:18 PM · MITK (v2023.04)
floca added a comment to T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash.

Crash seems to occur because the SurfaceInterpolationController observer logic is broken. It seems like registered observers ar never removed only added.
E.g. also if the segmentation is set to nullptr, nothing is removed from the old segmentation. That leads to the crash, because the events are triggered by the old segmentation when session is closed, but the controller has only a null ptr at this point.

May 1 2023, 12:13 PM · MITK (v2023.04)

Apr 30 2023

floca moved T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label from Backlog to Cycle on the MITK (v2023.04) board.
Apr 30 2023, 9:27 PM · MITK (v2023.04)
floca moved T29548: [Segmentation] Missing I- button from Backlog to MITK Meeting on the Request for Discussion board.
Apr 30 2023, 9:27 PM · MITK (v2023.04)
floca added a project to T29548: [Segmentation] Missing I- button: Request for Discussion.
Apr 30 2023, 9:27 PM · MITK (v2023.04)
floca moved T29551: [Segmentation] Label tool buttons should be updated whenever the model changes from Backlog to Cycle on the MITK (v2023.04) board.
Apr 30 2023, 9:26 PM · MITK (v2023.04)
floca claimed T29550: [Segmentation] Load/save Label set preset buttons do nothing.
Apr 30 2023, 9:26 PM · MITK (v2023.04)
floca moved T29550: [Segmentation] Load/save Label set preset buttons do nothing from Backlog to Cycle on the MITK (v2023.04) board.
Apr 30 2023, 9:25 PM · MITK (v2023.04)
floca moved T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash from Backlog to Cycle on the MITK (v2023.04) board.
Apr 30 2023, 9:24 PM · MITK (v2023.04)
floca moved T29545: [Segmentation] Removing groups, labels, or instances crashes in certain cases from Backlog to Cycle on the MITK (v2023.04) board.
Apr 30 2023, 9:24 PM · MITK (v2023.04)

Apr 28 2023

floca claimed T29551: [Segmentation] Label tool buttons should be updated whenever the model changes.

right. it is now broken since we allow modification on none selected elements.

Apr 28 2023, 8:54 PM · MITK (v2023.04)
floca raised a concern with rMITK78c7dc4a6bd9: Merge branch 'bugfix/T29546-FixVariousCrashes' into develop.
Apr 28 2023, 6:13 PM

Apr 27 2023

floca added a comment to T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.

Definetly the interpolator has to rework and the different accept function refactored/streamlined.

Apr 27 2023, 5:42 PM · MITK (v2023.04)

Apr 26 2023

floca closed T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns, a subtask of T29077: [Segmentation] Showing / hiding labels using the labelsetwidget selects them, as Resolved.
Apr 26 2023, 6:12 PM · MITK (v2023.04), Checklist
floca closed T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns as Resolved.
Apr 26 2023, 6:12 PM · MITK (v2023.04), Checklist
floca closed T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns, a subtask of T29369: [Segmentation Utilities] Handle / select different labels independently, as Resolved.
Apr 26 2023, 6:12 PM · MITK (v2024.06)
floca closed T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns, a subtask of T29495: [SEG] Rework segmentation view UX, as Resolved.
Apr 26 2023, 6:12 PM · MITK (v2023.12)
floca closed T29077: [Segmentation] Showing / hiding labels using the labelsetwidget selects them as Resolved.
Apr 26 2023, 6:12 PM · MITK (v2023.04), Checklist
floca closed T29505: [SEG] New NRRD file formate for MultiLabelSegmentation + IO classes + introduction of legacy reader, a subtask of T29392: [SEG] Add dedicated writer to store multi-label images in nifti, as Resolved.
Apr 26 2023, 6:11 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca closed T29505: [SEG] New NRRD file formate for MultiLabelSegmentation + IO classes + introduction of legacy reader, a subtask of T29495: [SEG] Rework segmentation view UX, as Resolved.
Apr 26 2023, 6:11 PM · MITK (v2023.12)
floca closed T29505: [SEG] New NRRD file formate for MultiLabelSegmentation + IO classes + introduction of legacy reader as Resolved.
Apr 26 2023, 6:11 PM · Breaking Change, MITK (v2023.04)
floca committed rMITK748fe9d05784: T29206 Rework of SegmentationView and MultiLabelSegmentation Qt model - 2nd… (authored by floca).
T29206 Rework of SegmentationView and MultiLabelSegmentation Qt model - 2nd…
Apr 26 2023, 6:10 PM
floca committed rMITK8811789eb25b: Reactivated interpolation feature (authored by floca).
Reactivated interpolation feature
Apr 26 2023, 6:10 PM
floca committed rMITKb2f2c1fdc077: Fixed review remarks (authored by floca).
Fixed review remarks
Apr 26 2023, 6:10 PM
floca committed rMITK0e51ece75289: Changed new MultiLabelSegmentation format to store groups as json objects (authored by floca).
Changed new MultiLabelSegmentation format to store groups as json objects
Apr 26 2023, 6:10 PM
floca committed rMITK83967826be7e: Fixed review remarks (authored by floca).
Fixed review remarks
Apr 26 2023, 6:10 PM
floca committed rMITK161ef77635da: fixed compiler errors (authored by floca).
fixed compiler errors
Apr 26 2023, 6:10 PM
floca committed rMITK7bc7d04acd99: Added new MultiLabelSegmentationIO (authored by floca).
Added new MultiLabelSegmentationIO
Apr 26 2023, 6:10 PM
floca committed rMITK6d8859a46687: Fixed tests (authored by floca).
Fixed tests
Apr 26 2023, 6:10 PM
floca committed rMITKd6e6ca159e22: Reworked context menue of the QmitkMultiLabelInspector (authored by floca).
Reworked context menue of the QmitkMultiLabelInspector
Apr 26 2023, 6:10 PM
floca committed rMITKc065a37153d3: adapted names of labels and instance in the model as discussed (authored by floca).
adapted names of labels and instance in the model as discussed
Apr 26 2023, 6:10 PM
floca committed rMITKcf959064b14e: BREAKING (authored by floca).
BREAKING
Apr 26 2023, 6:10 PM
floca committed rMITKdc575ac889bd: Fixed tests (authored by floca).
Fixed tests
Apr 26 2023, 6:10 PM
floca committed rMITK517e2d244209: Extracted functions for legacy LabelSetImageIO to make it reusable at other… (authored by floca).
Extracted functions for legacy LabelSetImageIO to make it reusable at other…
Apr 26 2023, 6:10 PM
floca committed rMITK62df944813ce: Fixed crash in LabelSet equal for empty label sets. (authored by floca).
Fixed crash in LabelSet equal for empty label sets.
Apr 26 2023, 6:10 PM
floca committed rMITKf4cd9f3ad77b: Refactored ItkImageIO to make some code parts reusable for other classes (authored by floca).
Refactored ItkImageIO to make some code parts reusable for other classes
Apr 26 2023, 6:10 PM
floca committed rMITKa77be8dd5351: fixed crash in LabelSet::Clone with an empty label set (authored by floca).
fixed crash in LabelSet::Clone with an empty label set
Apr 26 2023, 6:10 PM
floca committed rMITKe44829be11d7: BREAKING (authored by floca).
BREAKING
Apr 26 2023, 6:10 PM
floca committed rMITK5dac9d7c8dce: BREAKING: Introduced TransferLabelContentAtTimeStep (authored by floca).
BREAKING: Introduced TransferLabelContentAtTimeStep
Apr 26 2023, 6:10 PM
floca committed rMITK00e8d0f29781: Fixed wrong enableing of widget in SegmentationView (authored by floca).
Fixed wrong enableing of widget in SegmentationView
Apr 26 2023, 6:10 PM
floca committed rMITKc8395def108e: Fixed gcc unused variable error (authored by floca).
Fixed gcc unused variable error
Apr 26 2023, 6:10 PM
floca committed rMITK24cd939e6137: Fixed crash on label delete. (authored by floca).
Fixed crash on label delete.
Apr 26 2023, 6:10 PM
floca committed rMITKdf9e230d48f2: BREAKING: Exterior label and setter/getter was removed from LabelSetImage. (authored by floca).
BREAKING: Exterior label and setter/getter was removed from LabelSetImage.
Apr 26 2023, 6:10 PM
floca committed rMITK5e0c4a833afb: fixed bug in rename label shortcut (authored by floca).
fixed bug in rename label shortcut
Apr 26 2023, 6:10 PM
floca committed rMITK341e72ce4f04: added interim text to buttons for easier testing. Icons will be added later (authored by floca).
added interim text to buttons for easier testing. Icons will be added later
Apr 26 2023, 6:10 PM
floca committed rMITKb2d13db76fe9: fixed compiler warning due to unused variable. (authored by floca).
fixed compiler warning due to unused variable.
Apr 26 2023, 6:10 PM
floca committed rMITK5a484be3498e: Fixed problem of not correctly rendered expanded label nodes (authored by floca).
Fixed problem of not correctly rendered expanded label nodes
Apr 26 2023, 6:10 PM
floca committed rMITK12722f716e73: Visibility modifications in QmitkMultiLabelTreeModel request a rendering update… (authored by floca).
Visibility modifications in QmitkMultiLabelTreeModel request a rendering update…
Apr 26 2023, 6:10 PM
floca committed rMITK2b5f10ca06e2: Temporary deactivation of sliceInterpolator due to problems with (authored by floca).
Temporary deactivation of sliceInterpolator due to problems with
Apr 26 2023, 6:10 PM
floca committed rMITKd93804180295: Added renaming features again. (authored by floca).
Added renaming features again.
Apr 26 2023, 6:10 PM
floca committed rMITK9c3e06ad6993: Introduced change guards, as old LabelSetImage implementations (authored by floca).
Introduced change guards, as old LabelSetImage implementations
Apr 26 2023, 6:10 PM
floca committed rMITKb73c5d498ac4: Added early out in SurfaceInterpolationController::AddNewContours when no (authored by floca).
Added early out in SurfaceInterpolationController::AddNewContours when no
Apr 26 2023, 6:10 PM
floca committed rMITK5da1b0d9ebc8: Remove old label/layer widgets from segmentation view (authored by floca).
Remove old label/layer widgets from segmentation view
Apr 26 2023, 6:10 PM
floca committed rMITK2f2122226e35: Fixed errors after merging with current develop (authored by floca).
Fixed errors after merging with current develop
Apr 26 2023, 6:10 PM
floca committed rMITK45c23a3e6c43: First draft of QmitkMultiLabelManager widget (authored by floca).
First draft of QmitkMultiLabelManager widget
Apr 26 2023, 6:10 PM
floca committed rMITKd599ec6f451a: Introduced helper function to QmitkNewSegmentationDialog (authored by floca).
Introduced helper function to QmitkNewSegmentationDialog
Apr 26 2023, 6:10 PM
floca committed rMITK685a4251e308: Patched QmitkMultiLabelManager into QmitkSegmentationView for testing purpose. (authored by floca).
Patched QmitkMultiLabelManager into QmitkSegmentationView for testing purpose.
Apr 26 2023, 6:10 PM
floca committed rMITK2096c0944762: Interim draft of QmitkMultiLabelInspector adding modify operations (authored by floca).
Interim draft of QmitkMultiLabelInspector adding modify operations
Apr 26 2023, 6:10 PM