Page MenuHomePhabricator
Create Task
Maniphest T28524

Refactor LabelSetImage and associated classes.
Open, NormalPublic
Actions

Description

As discussed in https://hub.dkfz.de/f/5459842 we want to address several problems that are caused or enforced by the current design.

This tasks focuses on the refactoring that solves

  • P2: Label manipulation code is scattered
  • P3: Labelset is (too) statefull 1 - Active Layer/Label / behaves (wronlgy) like an image
  • P4: Labelset is statefull 2 - Lock states - teethless tiger

There is surely plenty of additional room for improvent. But we have identified this things as the most important/hindering problems, that have impact on many UX issues. Therfore we decided to first solve them pragmatically but well designed and strive for perfection later ;).

This tasks is for the implementation of the new design. The refactored design will be discussed in the subtask.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKdeb2fe9ecb72 Clean labelset image
Restricted Differential RevisionrMITKf3915ff59b9a Use consistent parameter names
Restricted Differential RevisionrMITK15024015b1d8 Remove layer-parameter from erase-function
Restricted Differential RevisionrMITK5a2c83714860 Remove commented code
Restricted Differential RevisionrMITKd6cb46c14fa4 Remove not-implemented "ChangeLayerProcessing"-function
Restricted Differential RevisionrMITKb9c9085a5a21 Remove unused "Concatenate"-function
Restricted Differential RevisionrMITKc7008bf1cce6 Remove not-implemented functions

Related Objects
Search...

StatusAssignedTask
 OpenNoneT27807 [MultiLabel Segmentation] Inspection of module and plugin
 OpenNoneT22593 Update the MitkMultilabelTestDriver
 OpenNoneT22458 Merging a label in the MultiLabel segmentation plugin leaves one label without a segmentation
 OpenNoneT26397 Multilabel Segmentation file cannot be converted to multilabel segmentation in MITK
 ResolvedflocaT23981 Multilabel color map should disable interpolation
 OpenNoneT25445 MultiLabel segmentation mapper is very slow
 ResolvedkalaliT28131 [MultiLabel Segmentation] 3D Threshold tool does not work with multiple labels / layers
 OpenNoneT28176 [Segmentation] Inspection of module and plugin
 ResolvedflocaT28526 [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage
 OpenNoneT26959 [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary"
 OpenNoneT28479 [Segmentation] Rethink / reevaluate our existing segmentation tools / algorithms
 OpenNoneT8140 Reimplement volume annotations for segmentations
 ResolvedkislinskT27319 [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View
 OpenflocaT28524 Refactor LabelSetImage and associated classes.
 ResolvedflocaT28525 Design refactoring of LabelSetImage and associated classes
 ResolvedflocaT28140 [MultiLabel Segmentation] Default parameter (unsigned int layer = 0) is unnecessary and causes problems
 ResolvedflocaT28139 [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage
 DuplicateNoneT16153 [Segmentation] Jump to center of mass of segmentation on click
 ResolvedflocaT28549 Remove deprecated functions from classes involved in the LabelSetImage refactoring
 OpenNoneT28561 Refactor/Fix mitk::SegmentationInteractor::ChangeActiveLabel
 ResolvedflocaT23742 Implement proof of concept for new segmentation data type
 WontfixNoneT23772 Implement adaptor between new segmentation data type and current segmentation data type
 ResolvedkislinskT23867 Improve mitk::WeakPointer
 ResolvedkislinskT23971 Implement robust, easy-to-use ExtractSliceFilter
 WontfixNoneT24303 A segmentation should generate all DICOM relevant IDs as soon as it can be referenced.
 OpenflocaT29204 [SEG] Rework properties of Label class + add instance information
 ResolvedflocaT29474 [SEG] Remove exterior label
 OpenflocaT30194 [SEG] Refactor LabelSetImage to MultiLabelSegmentation class
 ResolvedflocaT30294 {SEG] Remove label set structure

Event Timeline

floca triaged this task as Unbreak Now! priority.Jun 4 2021, 7:04 PM
floca created this task.
floca added a parent task: T28499: Refactor/rewrite RegionGrowing3D tool.Jun 4 2021, 7:09 PM
floca added a parent task: T28275: [Segmentation] AdaptiveRegionGrowingTool must be refactored / 4D Segmentation returns error message when point is not on the correct timestep.
floca added a parent task: T8140: Reimplement volume annotations for segmentations.
floca added a parent task: T28131: [MultiLabel Segmentation] 3D Threshold tool does not work with multiple labels / layers.Jun 4 2021, 7:11 PM
floca moved this task from Backlog to Segmentation on the MITK (v2021.10) board.
floca added a parent task: T28500: Multilabel Segmentation Utilities do not work for multilabel segmentations.Jun 4 2021, 7:16 PM
floca added a parent task: T28526: [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage.Jun 4 2021, 7:36 PM
floca mentioned this in T28561: Refactor/Fix mitk::SegmentationInteractor::ChangeActiveLabel.Jun 18 2021, 8:51 AM
floca closed subtask T28549: Remove deprecated functions from classes involved in the LabelSetImage refactoring as Resolved.Jun 28 2021, 10:08 AM
kislinsk edited projects, added MITK (v2022.04); removed MITK (v2021.10).Nov 10 2021, 4:32 PM
floca moved this task from Backlog to Segmentation on the MITK (v2022.04) board.Nov 17 2021, 11:56 AM
floca added a parent task: T22593: Update the MitkMultilabelTestDriver.Jan 19 2022, 5:40 PM
floca added a parent task: T22458: Merging a label in the MultiLabel segmentation plugin leaves one label without a segmentation.Jan 19 2022, 5:42 PM
floca added a parent task: T26397: Multilabel Segmentation file cannot be converted to multilabel segmentation in MITK.
floca added a parent task: T25445: MultiLabel segmentation mapper is very slow.
floca added a parent task: T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View.
floca added a parent task: T23981: Multilabel color map should disable interpolation.Jan 19 2022, 5:45 PM
kalali added a subtask: T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations.Jan 20 2022, 8:55 AM
floca edited projects, added MITK, Next Milestone; removed MITK (v2022.04).Jan 20 2022, 9:35 AM
floca added a parent task: T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary".Jan 20 2022, 10:00 AM
kalali removed a subtask: T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations.Jan 20 2022, 10:58 AM
kalali edited parent tasks, added: T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation; removed: T28500: Multilabel Segmentation Utilities do not work for multilabel segmentations.
kalali mentioned this in T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View.Jan 20 2022, 11:51 AM
kalali added a revision: Restricted Differential Revision.May 9 2022, 2:53 PM
kalali added a commit: rMITKc7008bf1cce6: Remove not-implemented functions.May 11 2022, 11:02 AM
kalali added a commit: rMITKb9c9085a5a21: Remove unused "Concatenate"-function.
kalali added a commit: rMITKd6cb46c14fa4: Remove not-implemented "ChangeLayerProcessing"-function.
kalali added a commit: rMITK15024015b1d8: Remove layer-parameter from erase-function.
kalali added a commit: rMITK5a2c83714860: Remove commented code.
kalali added a commit: rMITKf3915ff59b9a: Use consistent parameter names.
kalali added a commit: rMITKdeb2fe9ecb72: Clean labelset image.
floca edited projects, added MITK (v2022.10); removed Next Milestone, MITK.May 12 2022, 10:28 AM
floca moved this task from Backlog to Segmentation on the MITK (v2022.10) board.May 12 2022, 11:07 AM
floca added a subtask: T23742: Implement proof of concept for new segmentation data type.May 12 2022, 5:37 PM
floca closed subtask T23742: Implement proof of concept for new segmentation data type as Resolved.
floca mentioned this in T23742: Implement proof of concept for new segmentation data type.
kislinsk mentioned this in T29226: 2022 Week 28 (Mid July).Jul 11 2022, 7:17 AM
kalali removed a parent task: T28499: Refactor/rewrite RegionGrowing3D tool.Aug 15 2022, 9:37 AM
kalali removed a parent task: T28275: [Segmentation] AdaptiveRegionGrowingTool must be refactored / 4D Segmentation returns error message when point is not on the correct timestep.
kalali removed a parent task: T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation.Sep 8 2022, 7:54 AM
kalali mentioned this in T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation.
floca claimed this task.Sep 14 2022, 11:27 AM
kislinsk lowered the priority of this task from Unbreak Now! to Normal.Oct 19 2022, 10:29 AM
kislinsk edited projects, added Next Milestone; removed MITK (v2022.10).
floca mentioned this in rMITK7a869a55d24d: Fixed T29391.Nov 22 2022, 11:57 AM
floca mentioned this in rMITKf3a099455a38: Fixed T29391.
floca closed subtask T29474: [SEG] Remove exterior label as Resolved.May 8 2023, 9:52 AM
floca closed subtask T30294: {SEG] Remove label set structure as Resolved.Mar 11 2024, 10:50 AM
floca closed subtask T28525: Design refactoring of LabelSetImage and associated classes as Resolved.Thu, Apr 18, 4:37 PM
MITK · MIC · IMSY · DKFZ