Page MenuHomePhabricator
Feed Advanced Search

Oct 12 2017

goch added a comment to T23491: RT Struct visualization crashes.

It happens here. GetPen() returns a null pointer. However just checking for it and aborting results in 2D contours no longer being rendered.

Oct 12 2017, 4:00 PM · Restricted Project, Restricted Project, MITK

Oct 11 2017

goch created T23526: Autoload modules not installed on MITK based projects.
Oct 11 2017, 6:01 PM · MITK-ProjectTemplate, MITK
goch committed rMPTf2fee42ae0ec: Add example command line app (authored by goch).
Add example command line app
Oct 11 2017, 2:01 PM
goch closed T22441: Add example command line app to the project template as Resolved by committing rMPTf2fee42ae0ec: Add example command line app.
Oct 11 2017, 2:01 PM · MITK-ProjectTemplate, MITK
goch added a member for IMSY: dreherk.
Oct 11 2017, 1:34 PM

Oct 10 2017

goch added a member for MITK: seidlits.
Oct 10 2017, 10:29 AM

Oct 6 2017

goch added a comment to T22118: Use Qt's windeployqt.exe to deploy Qt instead of our current install rules.

The following windeplyqt call seems to work on our globbed installer binary after deleting most/all of the Qt stuff

windeployqt.exe --plugindir bin\plugins -opengl bin\MitkWorkbench.exe bin\plugins
Oct 6 2017, 3:06 PM · MITK
goch triaged T23487: MITK crashes when loading DICOM Segmentation Object as High priority.
Oct 6 2017, 9:59 AM · MITK (2018-04)
goch triaged T23489: MitkDICOMQIMimeType always outputs error if file can not be read as Low priority.

This is just about getting rid of an error message, correct? I think the correct way would be to just not consider your mime type not applying to be an error and not logging that information. Or is this error message caused by a third party library?

Oct 6 2017, 9:59 AM · Auto-closed, MITK

Oct 5 2017

goch committed rMITKcece89b9f34b: Provide basic Qt installer framework support (authored by goch).
Provide basic Qt installer framework support
Oct 5 2017, 5:29 PM
goch added a comment to T22118: Use Qt's windeployqt.exe to deploy Qt instead of our current install rules.

Pushed new branch T22118-create-Qt-installer.

Oct 5 2017, 5:28 PM · MITK
goch created T23485: VTK surface rendering shows incorrect transparency on some systems.
Oct 5 2017, 11:26 AM · Auto-closed, MITK

Oct 4 2017

goch added a comment to T22654: Extending the Segmentation plugin with a multi-region threshold-based tool.

I had a look at the new tools today. There was a compile error that I resolved and some issues:

Oct 4 2017, 3:18 PM · Pull Request, MITK
goch committed rMITK999cfd181811: Fix compile errors (authored by goch).
Fix compile errors
Oct 4 2017, 3:12 PM
goch committed rMITK671257d259c7: Merge remote-tracking branch 'ac3957/T22654-SegmentationModuleExtensions' into… (authored by goch).
Merge remote-tracking branch 'ac3957/T22654-SegmentationModuleExtensions' into…
Oct 4 2017, 3:12 PM
goch added a comment to T22654: Extending the Segmentation plugin with a multi-region threshold-based tool.

Pushed new branch T22654-threshold-components-tool.

Oct 4 2017, 3:12 PM · Pull Request, MITK
goch triaged T23475: Update HDF5 to remove a bug on Visual Studio's RelWithDebInfo mode. as Low priority.

Thanks for the pointer and patch. The last upgrade of HDF proved to be a bit troublesome due to a changing internal structure. Not the highest priority for us as we usually do not usually use RelWithDebInfo ourselves.

Oct 4 2017, 1:26 PM · Auto-closed, MITK
goch triaged T23479: Rigid registration of short vector images does not work as Normal priority.
Oct 4 2017, 1:12 PM · Auto-closed, MITK
goch triaged T23427: Can not build doc_usersguide in MITK project as Normal priority.
Oct 4 2017, 1:12 PM · Auto-closed, MITK

Oct 2 2017

goch added a comment to T19859: Incorrect ordering of nodes when initialising data manager from data storage.

As for the random ordering within the data storage issue. I did include a change to the way the default layer is set when loading via the command line rMITK0ed347588bfb: Use command line argument position as default layer

Oct 2 2017, 4:33 PM · MITK
goch closed T19859: Incorrect ordering of nodes when initialising data manager from data storage as Resolved.

Thanks for the contribution

Oct 2 2017, 4:30 PM · MITK
goch committed rMITK1a7ac5b75dac: Merge branch 'T19859-datamanager-node-ordering' (authored by goch).
Merge branch 'T19859-datamanager-node-ordering'
Oct 2 2017, 4:14 PM
goch committed rMITK0ed347588bfb: Use command line argument position as default layer (authored by goch).
Use command line argument position as default layer
Oct 2 2017, 4:06 PM
goch committed rMITKae55ee68b5d7: Merge remote-tracking branch 'NifTK/T19859-data-manager-node-order' into T19859… (authored by goch).
Merge remote-tracking branch 'NifTK/T19859-data-manager-node-order' into T19859…
Oct 2 2017, 4:06 PM
goch added a comment to T19859: Incorrect ordering of nodes when initialising data manager from data storage.

Pushed new branch T19859-datamanager-node-ordering.

Oct 2 2017, 4:05 PM · MITK
goch committed rMITK6daeb9121cdf: Merge branch 'T23473-remove-unused-variable' (authored by goch).
Merge branch 'T23473-remove-unused-variable'
Oct 2 2017, 3:36 PM
goch committed rMITK8b87c9dec34c: Remove unused variable to fix warning (authored by goch).
Remove unused variable to fix warning
Oct 2 2017, 3:35 PM
goch added a comment to T23473: Adding an image node to the data storage leads to a loss of the current segmentation selection in the segmentation view..

Pushed new branch T23473-remove-unused-variable.

Oct 2 2017, 3:35 PM · MITK

Sep 29 2017

goch closed T22699: Crash in MultiLabelSegmentation Plugin as Resolved.

Thanks for the contribution

Sep 29 2017, 2:38 PM · Pull Request, MITK
goch committed rMITK807f27d2c47c: Merge branch 'T22699-multilabelsegmentation-preferences-crash' (authored by goch).
Merge branch 'T22699-multilabelsegmentation-preferences-crash'
Sep 29 2017, 2:37 PM
goch committed rMITK368d858c0cbd: Bugfix for a crash after changing the MultiLabelSegmentation Plugin… (authored by goch).
Bugfix for a crash after changing the MultiLabelSegmentation Plugin…
Sep 29 2017, 2:36 PM
goch added a comment to T22699: Crash in MultiLabelSegmentation Plugin.

Pushed new branch T22699-multilabelsegmentation-preferences-crash.

Sep 29 2017, 2:36 PM · Pull Request, MITK
goch claimed T22699: Crash in MultiLabelSegmentation Plugin.
Sep 29 2017, 2:07 PM · Pull Request, MITK
goch closed T22870: Crash on segmentation threshold [0, 1[ as Resolved.

Thanks for the contribution.

Sep 29 2017, 9:58 AM · Pull Request, MITK
goch committed rMITK5ea478957b6e: Merge branch 'T22870-fix-threshold-crash' (authored by goch).
Merge branch 'T22870-fix-threshold-crash'
Sep 29 2017, 9:57 AM
goch committed rMITKcedb7d528d74: Merge remote-tracking branch 'nilgoyette/T22870-WrongThresholdFloatImage' into… (authored by goch).
Merge remote-tracking branch 'nilgoyette/T22870-WrongThresholdFloatImage' into…
Sep 29 2017, 9:57 AM
goch added a comment to T22870: Crash on segmentation threshold [0, 1[.

Pushed new branch T22870-fix-threshold-crash.

Sep 29 2017, 9:57 AM · Pull Request, MITK
goch closed T23444: Enable quick exploration of CEST spectrum as Resolved.
Sep 29 2017, 8:58 AM · Restricted Project, MITK

Sep 28 2017

goch committed rMITK86817b525435: Create test json in subdirectory (authored by goch).
Create test json in subdirectory
Sep 28 2017, 6:34 PM
goch committed rMITKa0043303e092: Add interactive exploration via crosshair (authored by goch).
Add interactive exploration via crosshair
Sep 28 2017, 6:34 PM
goch committed rMITKb2661fa354a9: Merge branch 'T23445-stricter-CEST-json-handler' (authored by goch).
Merge branch 'T23445-stricter-CEST-json-handler'
Sep 28 2017, 6:33 PM
goch committed rMITK22cce810a2d2: Create test json in subdirectory (authored by goch).
Create test json in subdirectory
Sep 28 2017, 6:33 PM
goch committed rMITK48d73fcb1415: Merge branch 'T23444-quick-exploration-for-CEST-statistics' (authored by goch).
Merge branch 'T23444-quick-exploration-for-CEST-statistics'
Sep 28 2017, 6:08 PM
goch committed rMITK5d4de1e04ac0: Add interactive exploration via crosshair (authored by goch).
Add interactive exploration via crosshair
Sep 28 2017, 6:07 PM
goch added a comment to T23444: Enable quick exploration of CEST spectrum.

Pushed new branch T23444-quick-exploration-for-CEST-statistics.

Sep 28 2017, 6:07 PM · Restricted Project, MITK
goch added a member for MIC: kamphenk.
Sep 28 2017, 1:48 PM
goch closed T23445: Stricter json handling for CEST reader as Resolved.

The current implementation does not allow for detailed text to be set, so I just opted for a more comprehensive error message instead of building some kind of passing-the-details mechanism from mitkIOUtil.cpp to QmitkIOUtil.cpp.

Sep 28 2017, 10:39 AM · Restricted Project, MITK
goch committed rMITK37c6efc67606: Make CEST reading revision mapping less lenient (authored by goch).
Make CEST reading revision mapping less lenient
Sep 28 2017, 10:28 AM
goch committed rMITK2074042daa0b: Merge branch 'T23445-stricter-CEST-json-handler' (authored by goch).
Merge branch 'T23445-stricter-CEST-json-handler'
Sep 28 2017, 10:26 AM
goch committed rMITKddcaf68a087d: Make CEST reading revision mapping less lenient (authored by goch).
Make CEST reading revision mapping less lenient
Sep 28 2017, 10:23 AM
goch added a comment to T23445: Stricter json handling for CEST reader.

Pushed new branch T23445-stricter-CEST-json-handler.

Sep 28 2017, 10:23 AM · Restricted Project, MITK

Sep 27 2017

goch added a comment to T23445: Stricter json handling for CEST reader.

They want the option to place the jsons in a subfolder instead of in the same directory as the library.

Sep 27 2017, 6:08 PM · Restricted Project, MITK
goch created T23445: Stricter json handling for CEST reader.
Sep 27 2017, 4:20 PM · Restricted Project, MITK
goch created T23444: Enable quick exploration of CEST spectrum.
Sep 27 2017, 4:18 PM · Restricted Project, MITK

Sep 26 2017

goch added a comment to T22656: Boost binaries provoke a compile error in superbuild when built for multiple configurations.

Awesome project seems to have the same issue. I pulled it from Github and did the following change:

diff --git a/CMakeExternals/MITK.cmake b/CMakeExternals/MITK.cmake
index 1d0a0d1..f30ae72 100644
--- a/CMakeExternals/MITK.cmake
+++ b/CMakeExternals/MITK.cmake
@@ -123,7 +123,7 @@ if(NOT MITK_DIR)
Sep 26 2017, 5:04 PM · Restricted Project

Sep 25 2017

goch closed T22727: VS project "RUN_TESTS" does not work as Resolved.
Sep 25 2017, 4:56 PM · MITK

Sep 21 2017

goch closed T22919: CEST reader needs to handle missing parameters for old revisions as Resolved.
Sep 21 2017, 11:09 AM · Restricted Project, MITK
goch committed rMITK8631ab26e39f: Catch stoi exceptions for empty parameters (authored by goch).
Catch stoi exceptions for empty parameters
Sep 21 2017, 11:05 AM
goch committed rMITK95bdc89ce841: Merge branch 'T22919-catch-exception' (authored by goch).
Merge branch 'T22919-catch-exception'
Sep 21 2017, 11:04 AM
goch committed rMITKea76eaf23a49: Catch stoi exceptions for empty parameters (authored by goch).
Catch stoi exceptions for empty parameters
Sep 21 2017, 11:04 AM
goch added a comment to T22919: CEST reader needs to handle missing parameters for old revisions.

Pushed new branch T22919-catch-exception.

Sep 21 2017, 11:04 AM · Restricted Project, MITK
goch reopened T22919: CEST reader needs to handle missing parameters for old revisions as "Open".

There is still a test error.

Sep 21 2017, 11:03 AM · Restricted Project, MITK
goch committed rMITKf7513a4dcecd: Merge branch 'T22727-re-enable-building-RUN_TESTS' (authored by goch).
Merge branch 'T22727-re-enable-building-RUN_TESTS'
Sep 21 2017, 10:13 AM

Sep 20 2017

goch committed rMITK8d2d183c2ff4: Provide library path for tests via cmake (authored by goch).
Provide library path for tests via cmake
Sep 20 2017, 4:57 PM
goch added a comment to T22727: VS project "RUN_TESTS" does not work.

Pushed new branch T22727-re-enable-building-RUN_TESTS.

Sep 20 2017, 4:57 PM · MITK
goch added a comment to T23414: integrate logarithmic axes in MitkChart.

Might want to check this https://github.com/c3js/c3/issues/252 and the mentioned pull request https://github.com/c3js/c3/pull/2100

Sep 20 2017, 2:20 PM · MITK
goch added a comment to T22727: VS project "RUN_TESTS" does not work.

Some musings:

  • I can get the tests to run in the command line by extending the PATH environment variable to include all needed directories
  • The tests are run as a post-build event for RUN_TESTS, thus just adding the path to the environment part of the ConfigurationProperties->Debugging does not help
  • Adapting the CTestCustom.cmake to include a set(CTEST_CUSTOM_PRE_TEST ) which sets the PATH results in errors for me
Sep 20 2017, 1:27 PM · MITK

Sep 19 2017

goch triaged T22775: DCMTK build fails with clang 7 as High priority.
Sep 19 2017, 12:41 PM · MITK
goch triaged T23355: Improve dose rendering as Wishlist priority.
Sep 19 2017, 12:41 PM · Restricted Project, Auto-closed, MITK
goch triaged T23305: Review warning fixes that changed runtime behaviour as High priority.
Sep 19 2017, 12:40 PM · Auto-closed, MITK
goch closed T22919: CEST reader needs to handle missing parameters for old revisions as Resolved.

Added a reader option to force either T1 or WASABI/CEST loading

Sep 19 2017, 12:40 PM · Restricted Project, MITK
goch committed rMITK6222ffd9b617: Merge branch 'T22919-expand-CEST-reader-functionality' (authored by goch).
Merge branch 'T22919-expand-CEST-reader-functionality'
Sep 19 2017, 11:07 AM
goch committed rMITKdeb307c84a38: Merge branch 'CEST-force-parsing' into T22919-expand-CEST-reader-functionality (authored by goch).
Merge branch 'CEST-force-parsing' into T22919-expand-CEST-reader-functionality
Sep 19 2017, 11:07 AM
goch committed rMITK1e74d28ace90: Merge branch 'T22919-handle-missing-parameters' into T22919-expand-CEST-reader… (authored by goch).
Merge branch 'T22919-handle-missing-parameters' into T22919-expand-CEST-reader…
Sep 19 2017, 11:07 AM
goch added a comment to T22919: CEST reader needs to handle missing parameters for old revisions.

Pushed new branch T22919-expand-CEST-reader-functionality.

Sep 19 2017, 11:06 AM · Restricted Project, MITK
goch updated the task description for T22919: CEST reader needs to handle missing parameters for old revisions.
Sep 19 2017, 9:45 AM · Restricted Project, MITK

Sep 18 2017

goch closed T23295: Pull request 211: Make gizmo track the mouse and highlight parts of the gizmo when under mouse as Resolved.

Seems reasonable. I am not too hot on the highlight color, but it is a definite improvement over no color at all.

Sep 18 2017, 5:53 PM · Pull Request, MITK
goch committed rMITK702f4ee4cad6: Merge branch 'T23295-gizmo-track-and-highlight' (authored by goch).
Merge branch 'T23295-gizmo-track-and-highlight'
Sep 18 2017, 5:52 PM
goch committed rMITK5df2e4239aa3: Merge branch 'maleike/gizmo-parts-highlighting-MASTER' into T23295-gizmo-track… (authored by goch).
Merge branch 'maleike/gizmo-parts-highlighting-MASTER' into T23295-gizmo-track…
Sep 18 2017, 5:51 PM
goch added a comment to T23295: Pull request 211: Make gizmo track the mouse and highlight parts of the gizmo when under mouse.

Pushed new branch T23295-gizmo-track-and-highlight.

Sep 18 2017, 5:51 PM · Pull Request, MITK
goch closed T23317: Pull request 212: Make Data Manager's color button work on multi-selections as Resolved.

Merged.
@maleike are my changes working for you?

Sep 18 2017, 4:38 PM · Pull Request, MITK
goch committed rMITKbd603fc7d548: Merge branch 'T23317-color-on-multi-selection' (authored by goch).
Merge branch 'T23317-color-on-multi-selection'
Sep 18 2017, 4:36 PM
goch committed rMITK3361d4539f2e: Add all applicable node descriptors to multi node context menu selections (authored by goch).
Add all applicable node descriptors to multi node context menu selections
Sep 18 2017, 4:36 PM
goch committed rMITK33ef775e10b0: Merge remote-tracking branch 'maleike/change-color-multi-selection-MASTER' into… (authored by goch).
Merge remote-tracking branch 'maleike/change-color-multi-selection-MASTER' into…
Sep 18 2017, 4:36 PM
goch added a comment to T23317: Pull request 212: Make Data Manager's color button work on multi-selections.

Pushed new branch T23317-color-on-multi-selection.

Sep 18 2017, 4:35 PM · Pull Request, MITK
goch added a comment to T23317: Pull request 212: Make Data Manager's color button work on multi-selections.

Just a quick note:

QList<QAction *> QmitkNodeDescriptorManager::GetActions(const mitk::DataNode *_Node) const

will return all actions for all applicable descriptors, whereas

QList<QAction *> QmitkNodeDescriptorManager::GetActions(const QList<mitk::DataNode::Pointer> &_Nodes) const

will only return all actions for the last applicable descriptor.

Sep 18 2017, 1:43 PM · Pull Request, MITK
goch added a comment to T23317: Pull request 212: Make Data Manager's color button work on multi-selections.

Ok, the reason seems to be that

QmitkNodeDescriptor *QmitkNodeDescriptorManager::GetDescriptor(const mitk::DataNode *_Node) const

returns a "NoneBinaryImage" nodes descriptor instead of an "Image" node descriptor. When I add that descriptor to

void QmitkDataManagerView::CreateQtPartControl(QWidget* parent)

The color button appears.

Sep 18 2017, 1:16 PM · Pull Request, MITK

Sep 15 2017

goch added a comment to T23317: Pull request 212: Make Data Manager's color button work on multi-selections.

The changes seem reasonable for me, but the button does not appear if multiple Pic3Ds are loaded and selected, I am going to check out why.

Sep 15 2017, 3:15 PM · Pull Request, MITK
goch closed T23292: DataManager does not sort its custom context menu entries as Resolved.
Sep 15 2017, 10:51 AM · Pull Request, MITK

Sep 14 2017

goch committed rMITKd84a8c712b4b: Add option to forcing parsing as specific image type (authored by goch).
Add option to forcing parsing as specific image type
Sep 14 2017, 6:46 PM
goch committed rMITK423bc7c56b47: Add option to forcing parsing as specific image type (authored by goch).
Add option to forcing parsing as specific image type
Sep 14 2017, 6:44 PM
goch committed rMITKde8eb8d749cc: Merge branch 'T22057-release-base-CEST-integration' (authored by goch).
Merge branch 'T22057-release-base-CEST-integration'
Sep 14 2017, 6:43 PM
goch committed rMITKb6db7d4ccf97: Added basically untested T1 reading capabilities for CEST (authored by goch).
Added basically untested T1 reading capabilities for CEST
Sep 14 2017, 6:14 PM
goch committed rMITK1cbf0577f041: Use repitions + averages if measurements are missing (authored by goch).
Use repitions + averages if measurements are missing
Sep 14 2017, 6:14 PM
goch committed rMITK29b50fcee5d2: Remove uids after normalization and a fix for the last time step being M0 (authored by goch).
Remove uids after normalization and a fix for the last time step being M0
Sep 14 2017, 6:13 PM
goch committed rMITK0e1bffad0751: Switch globbing to case insensitive (authored by goch).
Switch globbing to case insensitive
Sep 14 2017, 6:13 PM
goch committed rMITK6522522551ff: Merge branch 'T23292-enable-context-menu-sorting' (authored by goch).
Merge branch 'T23292-enable-context-menu-sorting'
Sep 14 2017, 11:58 AM
goch committed rMITK627bd344929c: Merge branch 'master' into T23292-sort-data-manager-context-menu-extensions… (authored by maleike).
Merge branch 'master' into T23292-sort-data-manager-context-menu-extensions…
Sep 14 2017, 11:58 AM
goch added a comment to T23292: DataManager does not sort its custom context menu entries.

Pushed new branch T23292-enable-context-menu-sorting.

Sep 14 2017, 11:57 AM · Pull Request, MITK
goch added a comment to T23292: DataManager does not sort its custom context menu entries.

There are still a couple of entries that will not be sorted, as they are specifically added by the datamanager itself.

after-menu.png (460×434 px, 21 KB)

But the suggested solution is better than the current way.

Sep 14 2017, 11:37 AM · Pull Request, MITK