Page MenuHomePhabricator
Feed Advanced Search

Dec 19 2019

kislinsk committed rMITKa441d37b79ac: Change Python3_INCLUDE_DIR result variable to Python3_INCLUDE_DIRS (authored by kislinsk).
Change Python3_INCLUDE_DIR result variable to Python3_INCLUDE_DIRS
Dec 19 2019, 4:10 PM
kislinsk closed T26941: MITK_USE_Python3 and CMake 3.16 does not work as Resolved.
Dec 19 2019, 1:15 PM · MITK
kislinsk committed rMITKec1b19e15871: Merge branch 'T26941-WorkaroundCMake3.16' (authored by kislinsk).
Merge branch 'T26941-WorkaroundCMake3.16'
Dec 19 2019, 1:14 PM
kislinsk committed rMITK5d1ec4dd4a69: Work around a bug in CMake 3.16 FindPython3 module (authored by kislinsk).
Work around a bug in CMake 3.16 FindPython3 module
Dec 19 2019, 1:14 PM
kislinsk added a comment to T26941: MITK_USE_Python3 and CMake 3.16 does not work.

Pushed new branch T26941-WorkaroundCMake3.16.

Dec 19 2019, 1:13 PM · MITK
kislinsk triaged T26941: MITK_USE_Python3 and CMake 3.16 does not work as Normal priority.
Dec 19 2019, 1:11 PM · MITK

Dec 18 2019

kislinsk closed T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time as Resolved.

Okay, this is somehow unsatisfying but I noticed that a lambda function I connected in addition to the original connection always triggered as expected. So I used it as indirection to call the actual member function.

Dec 18 2019, 4:59 PM · MITK
kislinsk committed rMITK462698dbbc2a: Merge branch 'T26938-FixExtensionPointContextMenuActionTrigger' (authored by kislinsk).
Merge branch 'T26938-FixExtensionPointContextMenuActionTrigger'
Dec 18 2019, 4:58 PM
kislinsk committed rMITKcec397e3dd86: Use lambda function for connection (authored by kislinsk).
Use lambda function for connection
Dec 18 2019, 4:57 PM
kislinsk committed rMITK89719c8b3d35: Do more clean-up (authored by kislinsk).
Do more clean-up
Dec 18 2019, 4:07 PM
kislinsk committed rMITK79669e3eeea3: Clean up QmitkDataNodeContextMenu (authored by kislinsk).
Clean up QmitkDataNodeContextMenu
Dec 18 2019, 9:26 AM
kislinsk added a comment to T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time.

Pushed new branch T26938-FixExtensionPointContextMenuActionTrigger.

Dec 18 2019, 9:26 AM · MITK
kislinsk claimed T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time.
Dec 18 2019, 9:23 AM · MITK
kislinsk added a comment to T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time.

Extension point actions are connected like QAction::triggered() QmitkDataNodeContextMenu::OnExtensionPointActionTriggered(). The second time, the slot isn't called anymore.

Dec 18 2019, 7:32 AM · MITK

Dec 17 2019

kislinsk triaged T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time as High priority.
Dec 17 2019, 9:33 PM · MITK
kislinsk committed rMITK719616fb02e6: Merge branch 'T26936-MigrateUiStdMultiWidgetNames' (authored by kislinsk).
Merge branch 'T26936-MigrateUiStdMultiWidgetNames'
Dec 17 2019, 7:56 PM
kislinsk committed rMITK2be7aef1d58a: Migrate render window widget names (authored by kislinsk).
Migrate render window widget names
Dec 17 2019, 7:55 PM
kislinsk added a comment to T26936: QmitkStdMultiWidget render window names messed up.

Pushed new branch T26936-MigrateUiStdMultiWidgetNames.

Dec 17 2019, 7:55 PM · Noteworthy, MITK
kislinsk placed T26934: Multiple logos in screenshot when using screenshot maker plugin up for grabs.
Dec 17 2019, 4:17 PM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Only partly fixed so far. Logo can be disabled in the Overlay Manager View.

Dec 17 2019, 4:17 PM · MITK (v2024.06)
kislinsk committed rMITKa7e08d799f36: Merge branch 'T26934-FixScreenshotMaker' (authored by kislinsk).
Merge branch 'T26934-FixScreenshotMaker'
Dec 17 2019, 4:16 PM
kislinsk committed rMITK67cf388ee02c: Disable all decorations while doing screenshot (authored by kislinsk).
Disable all decorations while doing screenshot
Dec 17 2019, 4:15 PM
kislinsk committed rMITKbb905350c178: Invert wrong nullptr check (authored by kislinsk).
Invert wrong nullptr check
Dec 17 2019, 4:15 PM
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch T26934-FixScreenshotMaker.

Dec 17 2019, 4:15 PM · MITK (v2024.06)
kislinsk claimed T26934: Multiple logos in screenshot when using screenshot maker plugin.
Dec 17 2019, 4:13 PM · MITK (v2024.06)
kislinsk closed T26936: QmitkStdMultiWidget render window names messed up as Resolved.
Dec 17 2019, 3:39 PM · Noteworthy, MITK
kislinsk awarded T26936: QmitkStdMultiWidget render window names messed up a Hungry Hippo token.
Dec 17 2019, 3:39 PM · Noteworthy, MITK
kislinsk committed rMITK6c0f7fdc22b7: Merge branch 'T26936-FixStdMultiWidgetRenderWindowNames' (authored by kislinsk).
Merge branch 'T26936-FixStdMultiWidgetRenderWindowNames'
Dec 17 2019, 3:39 PM
kislinsk committed rMITK7dfdc934e199: Migrate stdmulti widget names from <n> to <n-1> (authored by kislinsk).
Migrate stdmulti widget names from <n> to <n-1>
Dec 17 2019, 3:38 PM
kislinsk committed rMITK4c5d62d08d16: Fix stdmulti base name of widgets (authored by kislinsk).
Fix stdmulti base name of widgets
Dec 17 2019, 3:38 PM
kislinsk added a comment to T26936: QmitkStdMultiWidget render window names messed up.

Pushed new branch T26936-FixStdMultiWidgetRenderWindowNames.

Dec 17 2019, 3:38 PM · Noteworthy, MITK
kislinsk triaged T26936: QmitkStdMultiWidget render window names messed up as High priority.
Dec 17 2019, 3:31 PM · Noteworthy, MITK
kislinsk closed T26935: Superbuild fails in case of debug and release batch build (Visual Studio) as Resolved.
Dec 17 2019, 2:16 PM · MITK
kislinsk committed rMITKea4ac0abbc7c: Merge branch 'T26935-DoNotResetCMAKE_DEBUG_POSTFIX' (authored by kislinsk).
Merge branch 'T26935-DoNotResetCMAKE_DEBUG_POSTFIX'
Dec 17 2019, 1:38 PM
kislinsk committed rMITK7e63a8010d88: Revert resetting of CMAKE_DEBUG_POSTFIX when Python is enabled (authored by kislinsk).
Revert resetting of CMAKE_DEBUG_POSTFIX when Python is enabled
Dec 17 2019, 1:37 PM
kislinsk added a comment to T26935: Superbuild fails in case of debug and release batch build (Visual Studio).

Pushed new branch T26935-DoNotResetCMAKE_DEBUG_POSTFIX.

Dec 17 2019, 1:37 PM · MITK
kislinsk added a comment to T26935: Superbuild fails in case of debug and release batch build (Visual Studio).

If MITK_USE_Python3 is on, CMAKE_DEBUG_POSTFIX is reset. ❗

Dec 17 2019, 11:24 AM · MITK
kislinsk removed a parent task for T26431: Fix gcc 9 and clang 8 compilation: T26935: Superbuild fails in case of debug and release batch build (Visual Studio).
Dec 17 2019, 11:18 AM · MITK
kislinsk removed a subtask for T26935: Superbuild fails in case of debug and release batch build (Visual Studio): T26431: Fix gcc 9 and clang 8 compilation.
Dec 17 2019, 11:18 AM · MITK
kislinsk closed T26431: Fix gcc 9 and clang 8 compilation, a subtask of T26935: Superbuild fails in case of debug and release batch build (Visual Studio), as Resolved.
Dec 17 2019, 11:18 AM · MITK
kislinsk closed T26431: Fix gcc 9 and clang 8 compilation as Resolved.
Dec 17 2019, 11:18 AM · MITK
kislinsk added a subtask for T26935: Superbuild fails in case of debug and release batch build (Visual Studio): T26431: Fix gcc 9 and clang 8 compilation.
Dec 17 2019, 10:32 AM · MITK
kislinsk added a parent task for T26431: Fix gcc 9 and clang 8 compilation: T26935: Superbuild fails in case of debug and release batch build (Visual Studio).
Dec 17 2019, 10:32 AM · MITK
kislinsk added a comment to T26431: Fix gcc 9 and clang 8 compilation.
Dec 17 2019, 10:31 AM · MITK

Dec 16 2019

kislinsk triaged T26935: Superbuild fails in case of debug and release batch build (Visual Studio) as High priority.
Dec 16 2019, 11:41 PM · MITK
kislinsk closed T15528: Integrate VMTK as Wontfix.
Dec 16 2019, 11:37 PM · Bugzilla, MITK
kislinsk triaged T26835: Crash on change of Surface interpolation from Phong to Flat as High priority.
Dec 16 2019, 7:54 PM · Pull Request, MITK
kislinsk triaged T26930: Crash Ubuntu 18.04.3 Qt 5.12.4 as High priority.

This was supposed to be solved in T26150: Build tree version of MitkWorkbench crashes twice before eventually starting on Ubuntu with GCC. Long story short, it has probably something to do with a messed up linkage of mixed superbuild/system dependencies. After some months of silence I think you are not the first one to encounter this bug again so we have to reinvestigate. As far as I remember using Clang does not lead to this issue in the first place.

Dec 16 2019, 4:20 PM · MITK

Dec 12 2019

kislinsk committed rMITK0f8a56ccc4bf: Fix swapping to temporary (authored by kislinsk).
Fix swapping to temporary
Dec 12 2019, 3:22 PM
kislinsk committed rMITKcfdaacfc3473: Merge branch 'T26921-FixCompileErrors' (authored by kislinsk).
Merge branch 'T26921-FixCompileErrors'
Dec 12 2019, 3:21 PM
kislinsk committed rMITKf258bcd91a13: Fix swapping to temporary (authored by kislinsk).
Fix swapping to temporary
Dec 12 2019, 3:21 PM
kislinsk committed rMITKacc546ec9313: Use std::queue's own swap function (authored by kislinsk).
Use std::queue's own swap function
Dec 12 2019, 3:18 PM
kislinsk committed rMITKe178c6b0e73c: Merge branch 'T26921-FixCompileErrors' (authored by kislinsk).
Merge branch 'T26921-FixCompileErrors'
Dec 12 2019, 3:16 PM
kislinsk committed rMITKd6a64191cb0f: Use std::queue's own swap function (authored by kislinsk).
Use std::queue's own swap function
Dec 12 2019, 3:16 PM
kislinsk closed T26921: Latest Visual Studio 16.4 2019 reveals some bugs that result in compile errors as Resolved.

Back-ported/cherry-picked fixes also to releases/2018-04.

Dec 12 2019, 3:09 PM · MITK
kislinsk committed rMITKd04a914d39db: Fix incomplete code comment (authored by kislinsk).
Fix incomplete code comment
Dec 12 2019, 3:09 PM
kislinsk committed rMITK453ed5f95880: Fix discarded return value of function with nodiscard attribute (authored by kislinsk).
Fix discarded return value of function with nodiscard attribute
Dec 12 2019, 3:09 PM
kislinsk committed rMITKf4e2436ce065: Fix wrong use of .empty() to clear containers (authored by kislinsk).
Fix wrong use of .empty() to clear containers
Dec 12 2019, 3:09 PM
kislinsk committed rMITK9b78e0bf440e: Merge branch 'T26921-FixCompileErrors' (authored by kislinsk).
Merge branch 'T26921-FixCompileErrors'
Dec 12 2019, 3:06 PM
kislinsk committed rMITK8a975b2f6517: Fix incomplete code comment (authored by kislinsk).
Fix incomplete code comment
Dec 12 2019, 3:05 PM
kislinsk committed rMITK1307f9b641db: Fix discarded return value of function with nodiscard attribute (authored by kislinsk).
Fix discarded return value of function with nodiscard attribute
Dec 12 2019, 3:05 PM
kislinsk committed rMITKa0585a02a272: Fix wrong use of .empty() to clear containers (authored by kislinsk).
Fix wrong use of .empty() to clear containers
Dec 12 2019, 3:05 PM
kislinsk added a comment to T26921: Latest Visual Studio 16.4 2019 reveals some bugs that result in compile errors.

Pushed new branch T26921-FixCompileErrors.

Dec 12 2019, 3:04 PM · MITK
kislinsk triaged T26921: Latest Visual Studio 16.4 2019 reveals some bugs that result in compile errors as High priority.
Dec 12 2019, 3:01 PM · MITK

Dec 6 2019

kislinsk assigned T26854: Unattended Qt installation to kalali.
Dec 6 2019, 3:55 PM · CI, Restricted Project, MITK
kislinsk placed T26854: Unattended Qt installation up for grabs.
Dec 6 2019, 3:47 PM · CI, Restricted Project, MITK
kislinsk closed T26849: Remove polling loop from continuous CDash scripts as Resolved.
Dec 6 2019, 3:43 PM · MITK, CI
kislinsk closed T25256: MITK license file features "Division of Medical and Biological Informatics" as Resolved.
Dec 6 2019, 3:40 PM · MITK
kislinsk committed rMPTdc1554a13695: Unify license and copyright headers (authored by kislinsk).
Unify license and copyright headers
Dec 6 2019, 3:35 PM
kislinsk closed T26893: GitHub doesn't recognize our license as Wontfix.

I give up, it makes no sense to put much time into this until Github clearly communicates the heuristic to detect the license.

Dec 6 2019, 3:08 PM · MITK
kislinsk committed rMITK56c0ba1005be: Merge branch 'T26893-GitHubCompatibleLicenseFile' (authored by kislinsk).
Merge branch 'T26893-GitHubCompatibleLicenseFile'
Dec 6 2019, 2:38 PM
kislinsk committed rMITKa724ab165f2e: Move COPYRIGHT_HEADER to Templates/copyright_header.txt (authored by kislinsk).
Move COPYRIGHT_HEADER to Templates/copyright_header.txt
Dec 6 2019, 2:37 PM
kislinsk archived Mint Medical GmbH.
Dec 6 2019, 2:01 PM
kislinsk committed rMITKb1ef2d248b65: Merge branch 'T26893-GitHubCompatibleLicenseFile' (authored by kislinsk).
Merge branch 'T26893-GitHubCompatibleLicenseFile'
Dec 6 2019, 1:52 PM
kislinsk committed rMITK385425e1a97f: Make license recognizable by GitHub (authored by kislinsk).
Make license recognizable by GitHub
Dec 6 2019, 1:51 PM
kislinsk added a comment to T26893: GitHub doesn't recognize our license.

Pushed new branch T26893-GitHubCompatibleLicenseFile.

Dec 6 2019, 1:51 PM · MITK
kislinsk removed a project from T16153: [Segmentation] Jump to center of mass of segmentation on click: Request for Discussion.

We decided in the MITK meeting that is a complex issue regarding UI-integration at other places as soon as you have multi-label segmentations. That's why we propose to keep the functionality at your plugin for the moment.

Dec 6 2019, 9:57 AM · MITK (v2023.04), Bugzilla
kislinsk removed a project from T26451: DICOM plugin cannot parse DICOM directories in macOS installer: Request for Discussion.

We came to the conclusion that we need example data to reproduce this issue on our site. Can we arrange a transfer (see above)?

Dec 6 2019, 9:46 AM · MITK

Dec 5 2019

kislinsk committed rMITKeb0b237d7c3e: Merge branch 'T26888-FixUpBundleWritePermissionsOnMacOS' (authored by kislinsk).
Merge branch 'T26888-FixUpBundleWritePermissionsOnMacOS'
Dec 5 2019, 1:30 PM
kislinsk committed rMITKe7aa9ff9efc7: Mark bundle items writable before calling install_name_tool (authored by kislinsk).
Mark bundle items writable before calling install_name_tool
Dec 5 2019, 1:28 PM
kislinsk added a comment to T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients.

Pushed new branch T26888-FixUpBundleWritePermissionsOnMacOS.

Dec 5 2019, 1:28 PM · MITK
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

Maybe Git is not in PATH?

Dec 5 2019, 10:23 AM · Noteworthy, MITK
kislinsk triaged T26893: GitHub doesn't recognize our license as Normal priority.
Dec 5 2019, 9:13 AM · MITK

Dec 4 2019

kislinsk committed rMITK78a8dc37f609: Merge branch 'T25256-UnifyLicenseAndCopyright' (authored by kislinsk).
Merge branch 'T25256-UnifyLicenseAndCopyright'
Dec 4 2019, 11:53 PM
kislinsk committed rMITKce5dc8011723: Unified license text and copyright headers (authored by kislinsk).
Unified license text and copyright headers
Dec 4 2019, 11:53 PM
kislinsk added a comment to T26501: Patching on windows fails.

This happens on Windows systems with the wrong checkout type for line endings. So not really a bug. We should investigate if the binary option is worth it anyway, as it is currently a big hassle to get patches right in the first place on Windows.

Dec 4 2019, 11:38 PM · Auto-closed, MITK
kislinsk closed T26889: OpenIGTLink does not link on Linux with CMake 3.16 as Wontfix.

Will be fixed in CMake 3.16.1.

Dec 4 2019, 11:31 PM · MITK
kislinsk added a comment to T25256: MITK license file features "Division of Medical and Biological Informatics".
Dec 4 2019, 6:41 PM · MITK
kislinsk committed rMITK12e52aeac5c9: Merge branch 'T25256-UnifyLicenseAndCopyright' (authored by kislinsk).
Merge branch 'T25256-UnifyLicenseAndCopyright'
Dec 4 2019, 6:40 PM
kislinsk committed rMITK1d57ec84fc1d: Unified license text and copyright headers (authored by kislinsk).
Unified license text and copyright headers
Dec 4 2019, 6:39 PM
kislinsk added a comment to T25256: MITK license file features "Division of Medical and Biological Informatics".

Pushed new branch T25256-UnifyLicenseAndCopyright.

Dec 4 2019, 6:38 PM · MITK
kislinsk claimed T25256: MITK license file features "Division of Medical and Biological Informatics".
Dec 4 2019, 5:32 PM · MITK
kislinsk added a comment to T26889: OpenIGTLink does not link on Linux with CMake 3.16.

Found a very recent OpenIGTLink issue: https://github.com/openigtlink/OpenIGTLink/issues/218
CMake issue tracker: https://gitlab.kitware.com/cmake/cmake/issues/20065

Dec 4 2019, 8:29 AM · MITK
kislinsk added a comment to T26889: OpenIGTLink does not link on Linux with CMake 3.16.

A script to easily reproduce the error:

Dec 4 2019, 7:44 AM · MITK
kislinsk triaged T26889: OpenIGTLink does not link on Linux with CMake 3.16 as Normal priority.
Dec 4 2019, 6:52 AM · MITK
kislinsk triaged T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients as Normal priority.
Dec 4 2019, 6:27 AM · MITK

Dec 3 2019

kislinsk closed T26887: Upgrade OpenCV to support Visual Studio 2019 as Resolved.
Dec 3 2019, 4:32 PM · MITK
kislinsk edited projects for T26887: Upgrade OpenCV to support Visual Studio 2019, added: MITK; removed MITK (2018-04-4).
Dec 3 2019, 4:21 PM · MITK
kislinsk committed rMITK40e721dba80e: Merge branch 'T26887-OpenCVUpgrade' (authored by kislinsk).
Merge branch 'T26887-OpenCVUpgrade'
Dec 3 2019, 4:05 PM
kislinsk committed rMITKeb3058d3772a: Upgrade OpenCV from version 3.4.2 to 3.4.8 (authored by kislinsk).
Upgrade OpenCV from version 3.4.2 to 3.4.8
Dec 3 2019, 4:04 PM