Page MenuHomePhabricator
Feed Advanced Search

Aug 2 2016

schwarzt added a comment to T2849: TotalVariationFilter used in BasicImageProcessing is internal.

Okay, bad documentation.
SVN Rev. 19899 (and Rev. 19900) show the problem.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added projects to T2840: Redesign StateMachine loading mechanism: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added projects to T2828: PrintSelf of emtpy surfaces crashes: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2817: MITK crashes on close after some Bundles have been closed.

Actually, MITK is crashing whenever a bundle is closed, then MITK is closed.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2817: MITK crashes on close after some Bundles have been closed.

Also appeares with segmentation.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added projects to T2817: MITK crashes on close after some Bundles have been closed: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added projects to T2809: Do not change selection when setting visibility: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2806: Otsu filter context menu produces 1 pixel offset.

No, thank you for reminding me of the backward compatibility problem.
Will send a mail to the users list.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2806: Otsu filter context menu produces 1 pixel offset.

Most possibly invalid.
MITK is no longer compatible to ITK versions < 3.16 due to the pixel center change. Please try again with 3.16 if your not using it.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2783: Enabling tutorial in CMake leads to a complete recompile of MITK.

Most possibly invalid due to local changes, too.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2782: Tutorial steps crash.

Well, this is actually the problem.
GlobalInteraction, and with it the FocusManager, StateMachineFactory and EventMapper, as members, have been changed to be initialized by an Activator for the MITk main application. But, in the Tutorial, RenderingManager->GetInstance is called without initializing the GlobalInteraction. This creates an instance of BaseRenderer, which then needs GlobalInteraction.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2782: Tutorial steps crash.

Cite from Mathias S.: "Recently, at least some of the tutorial applications (tested Step3, Step6,
Step8) produce a crash in mitk::GlobalInteraction::AddFocusElement(). The
variable m_FocusManager has not been initialized properly. This seems to be
related to the recent chhanges applied to GlobalInteraction (r19557)."

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2782: Tutorial steps crash.

Because GlobalInteraction is then initialized via BaseRenderer, which should not be the "normal" behaviour, because it should be initialized before. It is not initialized anymore in the GlobalInteraction constructor. Initialize() is to be mandatory called seperately.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2782: Tutorial steps crash.

Should bge fixed now, as in Rev. [SVN revision 19736]
GlobalInteraction is now initialized in QmitkRegisterClasses() function if it is not already. For the main application, this function is called, too, in the CommonActivator, but GlobalInteraction is initialized earlier.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2782: Tutorial steps crash.

Found the reason: I just forgot to initialize GlobalInteraction here.
Since revision [SVN revision 19503], this is mandatory.
Will post the fix as soon as it compiled.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added projects to T2783: Enabling tutorial in CMake leads to a complete recompile of MITK: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2782: Tutorial steps crash.

Okay, this is a problem.
In MITK ExtApp etc., GlobalInteraction is created and initialized via a openChrry Activator. As the tutorial does not call this, GlobalInteraction is never initialized.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2782: Tutorial steps crash.

The problem here is that the behaviour of GlobalInteraction->Initialize is different for an application built from source code (which has StateMachine.xml as file found at mitk::StandardFileLocations()) and an Installer (which has the XML content compiled in as Qt resource). GlobalInteraction->Initialize respects both cases, but not the tutorial, which has none of both, as it seems.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2782: Tutorial steps crash.

Will have a look at it.
Should be no big problem.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2769: Fix 0.5-pixel offset issues.

This is actually a different bug:

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added projects to T2764: Auto-expand tree node if new child is added: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2750: Range slider for two values.

Closed.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2750: Range slider for two values.

Hi guys,

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2750: Range slider for two values.

Qxt Span Slider

SpanSlider.jpg (149×174 px, 5 KB)

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to F355: SpanSlider.jpg.

Qxt Span Slider

Aug 2 2016, 9:30 AM
schwarzt added a comment to T2750: Range slider for two values.

Haven't found code for the Qt lab slider.

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2750: Range slider for two values.

[SVN revision 19798]
ADD (#2750): Added qxt, which e.g. features the two button slider

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2747: Basic Image Processing: generated images should be added as childs to source images.

Fixed in Rev. 19703

Aug 2 2016, 9:30 AM · Bugzilla, MITK
schwarzt added a comment to T2728: StateMachineEditor is not working properly anymore with relocated StateMachine.xml.

Moved the file to the \source\mitk\CoreUI\Bundles\org.mitk.gui.qt.common\resources folder in Rev. 19663. This should fix the problem.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2723: QmitkDataStorageComboBox does not emit a signal when last node is removed.

[SVN revision 19684]
FIX (#2723): Also emit a signal (NULL) when last entry in box is removed

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2723: QmitkDataStorageComboBox does not emit a signal when last node is removed.

Still waiting for Core Mod.
I need this for my 3M module.
Although it does not seem to help, adding the Core Mod guys to the Cc list.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added projects to T2723: QmitkDataStorageComboBox does not emit a signal when last node is removed: MITK, Bugzilla.
Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2723: QmitkDataStorageComboBox does not emit a signal when last node is removed.

Filed ChangeRequests/2723 in Wiki; waiting for core mod permittance

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2723: QmitkDataStorageComboBox does not emit a signal when last node is removed.

Fixed.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2721: Deselect items on click, rename on double click in DM.

I just can't wait... :)

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2721: Deselect items on click, rename on double click in DM.

I would say 3M-3 relevant -> Usability

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added projects to T2720: NULL selection passed after clicking somewhere outside of data manager: MITK, Bugzilla.
Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added projects to T2721: Deselect items on click, rename on double click in DM: MITK, Bugzilla.
Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2721: Deselect items on click, rename on double click in DM.

Related to #2751.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19899]
FIX (#2686): Remove obsolete dependencies

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19995]
ADD (#2686): Add perspective for BIP

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 20662]
FIX (#2686): Add boolean image operations and threshold to BasicImageProcessing

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

Reopened again...
This time bug will now stay open till #2494 is closed.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

Reopen cause of request from Francois Malan, for binary image operations.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19988]
FIX (#2686): Replaced not working downsampling filter with more general one (which is working).

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

Reopened again for some minor GUI changes (3M-3 related).

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19882]
FIX (#2686): Remove unused StdMultiWidgetAvailable() method

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

Now with user basic manual. Closed.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19592]
FIX (#2686): Make BasicImageProcessing public

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19593]
FIX (#2686): Make BasicImageProcessing public

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19880]
FIX (#2686): Use flat group boxes without margins; logic update for 2 image ops; removed unused onImage2Selected() method

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added projects to T2686: QmitkBasicImageProcessing bundle: MITK, Bugzilla.
Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

And closed again...

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19703]
FIX (#2686): GUI cleanup and simplification; new nodes are now added to their parent, too; (see T2747).

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19879]
FIX (#2686): Use flat group boxes without margins; logic update for 2 image ops; removed unused onImage2Selected() method

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

Finished GUI update.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19706]
FIX (#2686): Further GUI cleanup and simplification; code cleanup;

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2686: QmitkBasicImageProcessing bundle.

[SVN revision 19629]
FIX (#2686): Major GUI and logic revision

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2683: Segmentation documentation.

Added some more info, too.
Answering comment #4: The MRI Sequence names are unique and not DKFZ-internal.
Every radiologist should know them. Can also be found by Google.
These names are actually the only way to describe the used sequences.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2683: Segmentation documentation.

Reopened for commit

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2683: Segmentation documentation.

[SVN revision 20172]
FIX (#2683): Added docu for heart MRI sequences

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2677: BasicImageProcessing Documentation.

Closed.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2677: BasicImageProcessing Documentation.

[SVN revision 19599]
DOC (#2677): Updated UserManual/QmitkBasicImageProcessing.dox

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2677: BasicImageProcessing Documentation.

First version of doxygen docu committed.
Will be further enhanced by short filter desriptions.

Aug 2 2016, 9:29 AM · Bugzilla, MITK
schwarzt added a comment to T2661: Status bar shows "No image information at this position".

Duplicate of 2401; also, don't forget to ReInit first!
Closed

Aug 2 2016, 9:28 AM · Bugzilla, MITK
schwarzt added projects to T2619: Add convenient method for busy cursor to QmitkFunctionality: MITK, Bugzilla.
Aug 2 2016, 9:28 AM · Bugzilla, MITK
schwarzt added a comment to F327: ChangeRequest.txt.

Change Request

Aug 2 2016, 9:28 AM
schwarzt added a comment to T2619: Add convenient method for busy cursor to QmitkFunctionality.

[SVN revision 19337]
COMP (#2619): Added convenient methods for using a busy cursor

Aug 2 2016, 9:28 AM · Bugzilla, MITK
schwarzt added a comment to T2619: Add convenient method for busy cursor to QmitkFunctionality.

Change Request

Aug 2 2016, 9:28 AM · Bugzilla, MITK
schwarzt added projects to T2592: Remove POCO warnings under Win32: MITK, Bugzilla.
Aug 2 2016, 9:28 AM · Bugzilla, MITK
schwarzt added a comment to T2442: enhance mitkPointLocatorTest.

The class: Yes.
The test coverage of it: Yes, but there are much bigger issues first.
Leave it on "?" for 2 weeks, then we can check again.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2442: enhance mitkPointLocatorTest.

Adding method for setting ITK PointSets;
Please add test for them, too.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2432: levelwindow slider has wrong scale.

Not a bug.
The level window is initialized by the middle slice, middle timestep and middle channel. This makes the initial value setting faster by NumberOfSlices*NumberOfTimesteps*NumberOfChannels.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

Closing this bug; Initialization working so far.
Follow-Up see T2840

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

GlobalInteraction is now initialized in QmitkRegisterClasses() function if it is not already. For the main application, this function is called, too, in the CommonActivator, but GlobalInteraction is initialized earlier.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

Copied Change Request to Wiki page.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19736]
FIX (#2413): Removed double call of itksys::SystemTools in EventMapper; STYLE: removed unused header files

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19680]
FIX (#2413): Move mitkEventAndActionConstants.xml to same folder as StateMachine.xml to make StateMachineEditor work again.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

Reopened. Still some issues.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

Marked as assigned again.
There are still some issues, mainly with the tutorial.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19734]
FIX (#2413): If GlobalInteraction is not already initialized, do it here. (Needed for tutorial)

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19663]
FIX (#2413): Move mitkEventAndActionConstants.xml to same folder as StateMachine.xml to make StateMachineEditor work again.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19735]
COMP (#2413): Moved IsInitialized method from private to public

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19733]
FIX (#2413): Changed order of initialization, because if GlobalInteraction is not already initialized, it will now be in QmitkRegisterClasses

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19562]
COMP (#2413): Adapt tests to new GlobalInteraction initialization routine

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19526]
FIX (#2413): Remove obsolete security check

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19527]
FIX (#2413): Documentation and code cleanup

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19557]
FIX (#2413): Combined Initialize() methods to a single one. Can be used with an empty string, a file name with path, or the actual XML content as string.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19525]
FIX (#2413): Correctly call GlobalInteraction::GetInstance

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19524]
FIX (#2413): Remove Global state machine setter/getter in event mapper, because it is now a member of GlobalInteraction.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19556]
FIX (#2413): Initialize GlobalInteraction with default values for testing

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19555]
FIX (#2413): Only delete elements in destructor that are really created

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

Seems to work now. Closed.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19503]
FIX (#2413): GlobalInteraction, its StateMachineFactory and EventMapper are now initialized via an Activator and a compiled-in XML string. See T2413 for details.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19563]
COMP (#2413): Adapt tests to new GlobalInteraction initialization routine

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

[SVN revision 19561]
COMP (#2413): Adapt tests to new GlobalInteraction initialization routine

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2413: Controlled initialization of EventMapper and StateMachines.

Change Request

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to F294: ChangeRequest.txt.

Change Request

Aug 2 2016, 9:27 AM
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

[SVN revision 20007]
FIX (#2401): Adapt convenience method for WorldToIndex with Itk Index to corrected MITK coordinate system, and therefore rounding

Aug 2 2016, 9:27 AM · Bugzilla, MITK
schwarzt added a comment to T2401: MPR displays pixel brightness mismatch.

Reopened for adding (simple) test.

Aug 2 2016, 9:27 AM · Bugzilla, MITK