Page MenuHomePhabricator
Feed All Stories

Apr 5 2019

floca removed a project from T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget: Request for Discussion.
Apr 5 2019, 2:27 PM · MITK
floca committed rMITK535dd626daa2: Merge branch 'T26219-Crash_by_selection_widget_after_close_project' (authored by floca).
Merge branch 'T26219-Crash_by_selection_widget_after_close_project'
Apr 5 2019, 2:26 PM
floca closed T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget as Resolved by committing rMITK8dea40a4a757: Fixed T26219.
Apr 5 2019, 2:26 PM · MITK
floca committed rMITK8dea40a4a757: Fixed T26219 (authored by floca).
Fixed T26219
Apr 5 2019, 2:24 PM
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

Pushed new branch T26219-Crash_by_selection_widget_after_close_project.

Apr 5 2019, 2:24 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

Found it.

Apr 5 2019, 2:14 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

OK, I have narrowed it further down.

Apr 5 2019, 2:10 PM · MITK
kislinsk closed T26224: Restructure CppRestSdk modules as Resolved.
Apr 5 2019, 2:09 PM · MITK
kislinsk committed rMITK9aa721d0b5bc: Merge branch 'T26224-RestructureCppRestSdkModule' (authored by kislinsk).
Merge branch 'T26224-RestructureCppRestSdkModule'
Apr 5 2019, 2:08 PM
kislinsk committed rMITK97721d58205b: Deactivate tests to external URIs (authored by kislinsk).
Deactivate tests to external URIs
Apr 5 2019, 1:56 PM
neher committed rMITKf960441edc75: Merge branch 'T25779-StpFiles' into T25779-StpFiles2 (authored by neher).
Merge branch 'T25779-StpFiles' into T25779-StpFiles2
Apr 5 2019, 1:28 PM
neher committed rMITK37420551156c: Tracking pic (authored by neher).
Tracking pic
Apr 5 2019, 1:28 PM
neher added a comment to T25779: [MITK Diffusion] Streamline tractography parameter files.

Pushed new branch T25779-StpFiles2.

Apr 5 2019, 1:28 PM · MITK
neher edited projects for T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed., added: MITK (2018-04-4); removed MITK.
Apr 5 2019, 11:19 AM · MITK
floca committed rOBSHYPPOPYb2ed49c1cfcc: Fixed T26243 (authored by floca).
Fixed T26243
Apr 5 2019, 10:50 AM
floca closed T26243: Missing number of iterations is not handled if there is an incomplete config section as Resolved.
Apr 5 2019, 10:08 AM · Hyppopy
floca triaged T26242: Solvers exceptions due to missing hyper parameter configs should be more telling. as Normal priority.
Apr 5 2019, 10:06 AM · Hyppopy
floca added a project to T26241: VirtualFunction should get better name: Hyppopy.
Apr 5 2019, 9:50 AM · Hyppopy
floca created T26241: VirtualFunction should get better name.
Apr 5 2019, 9:49 AM · Hyppopy
floca triaged T26240: File headers are "strange" as Normal priority.
Apr 5 2019, 9:46 AM · Hyppopy
neher committed rMITK6b4ea15d8155: Check if matrix is rotation. Safe calculate dominant axes. (authored by neher).
Check if matrix is rotation. Safe calculate dominant axes.
Apr 5 2019, 9:19 AM

Apr 4 2019

traversaro added a comment to T24971: .zip files do not extract in superbuild (Windows non-NTFS file system).

I experienced a similar problem, and I opened an issue in CMake: https://gitlab.kitware.com/cmake/cmake/issues/19132 .

Apr 4 2019, 6:35 PM · Restricted Project, IGT, MITK
goetzm committed rMITK2e708a6e05e9: Merge branch 'T25826-RadiomicsGUIUpdate' into T25826-RadiomicsGUIUpdate-V2 (authored by goetzm).
Merge branch 'T25826-RadiomicsGUIUpdate' into T25826-RadiomicsGUIUpdate-V2
Apr 4 2019, 5:06 PM
goetzm committed rMITKaa970f78ede0: Update Build List for MITK Phenotyping (authored by goetzm).
Update Build List for MITK Phenotyping
Apr 4 2019, 5:06 PM
goetzm added a comment to T25826: Update Radiomics GUI.

Pushed new branch T25826-RadiomicsGUIUpdate-V2.

Apr 4 2019, 5:06 PM · Auto-closed, MITK
floca created T26239: BlackboxFunction custom parameters in own "bucket" and not in "params".
Apr 4 2019, 4:45 PM · Hyppopy
floca created T26238: CallbackFcn in BlackBox function is never used/called.
Apr 4 2019, 4:41 PM
goetzm committed rMITK20da40ee2fc6: Add posibility to register multiple images within one run (authored by goetzm).
Add posibility to register multiple images within one run
Apr 4 2019, 4:36 PM
kislinsk triaged T26237: Improve performance for interactions in 2d widgets as Wishlist priority.
Apr 4 2019, 4:20 PM · MITK
onogur updated the image for OP 4.1 from F1110245: profile to F1357356: profile.
Apr 4 2019, 3:41 PM
neher closed T26179: [MITK Diffusion] Fiberfox: account for partial fourier in ETL calculation as Invalid.
Apr 4 2019, 2:57 PM · MITK
neher closed T26123: [MITK Diffusion] Fiberfox output tick image as Resolved.
Apr 4 2019, 2:56 PM · MITK
neher closed T26234: [MITK Diffusion] Fiberfox TSE sequence as Resolved.
Apr 4 2019, 2:51 PM · MITK
neher committed rMITK198a079c6c37: Merge branch 'T26234-TSE' (authored by neher).
Merge branch 'T26234-TSE'
Apr 4 2019, 2:49 PM
neher committed rMITK340761862ae4: Adjust echo spacing and output tick and RF image (authored by neher).
Adjust echo spacing and output tick and RF image
Apr 4 2019, 2:49 PM
neher added a comment to T26234: [MITK Diffusion] Fiberfox TSE sequence.

Pushed new branch T26234-TSE.

Apr 4 2019, 2:48 PM · MITK
neher triaged T26234: [MITK Diffusion] Fiberfox TSE sequence as Normal priority.
Apr 4 2019, 2:18 PM · MITK
neher committed rMD70532cbb2c5b: Add data for corrupted rotation matrix check (authored by neher).
Add data for corrupted rotation matrix check
Apr 4 2019, 2:03 PM
espak added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Another place where inverse matrix calculation has been introduced:

Apr 4 2019, 1:26 PM · MITK
espak added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

As I see, the inverse matrix calculation came in with this commit of mine:

Apr 4 2019, 1:10 PM · MITK
floca updated subscribers of T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

@kalali @kislinsk , added you two has you have some experience with at least either rendering/mapper or selection concept. May be you have additional ideas.

Apr 4 2019, 12:52 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

The problem occured in context of selection widgets and may be could be patched for selection widgets in context of T26218.

This assumption was incorrect :(. Even if the widget properly release the node if it is deleted the problem still occures?!?

Apr 4 2019, 12:51 PM · MITK
floca updated the task description for T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.
Apr 4 2019, 12:28 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

The callstack as additional information:

Apr 4 2019, 12:27 PM · MITK
floca renamed T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget from Crash in rendering mappers when closing session after using a selection widget to Crash in rendering mappers when pressing "Close Project" after using a selection widget.
Apr 4 2019, 12:24 PM · MITK
s635r added a comment to T26227: Own documentation section for hyper parameter aspects.

Was too fast? Thought you might meant what I added. If you had something else in mind shall I reopen the task?

Apr 4 2019, 12:18 PM · Hyppopy
floca updated the task description for T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage.
Apr 4 2019, 12:12 PM · MITK
floca added a comment to T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage.

Pushed an implementation for option 2. Widgets are now synced and remove selections that are not part of their datastorage any more.

Apr 4 2019, 12:11 PM · MITK
floca committed rMITK4fd405cf0b4e: Fixed T26218 (authored by floca).
Fixed T26218
Apr 4 2019, 12:09 PM
floca added a comment to T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage.

Pushed new branch T26218-Sync_node_selection_widget_with_datastorage_node_delete.

Apr 4 2019, 12:09 PM · MITK
floca added a comment to T26227: Own documentation section for hyper parameter aspects.

Uh oh, that was fast. ;)
I hadn't even made up my mind on that matter. My first purpose was to open up the discussion on that topic...

Apr 4 2019, 11:54 AM · Hyppopy
kalali closed T25483: Apply level window to multiple selected images as Resolved.
Apr 4 2019, 11:44 AM · Noteworthy, Restricted Project, MITK
kalali committed rMITK37e99d5e97ec: Apply level window to multiple selected images (authored by kalali).
Apply level window to multiple selected images
Apr 4 2019, 11:42 AM
s635r closed T26227: Own documentation section for hyper parameter aspects as Resolved.
Apr 4 2019, 11:33 AM · Hyppopy
GitHub <noreply@github.com> committed rOBSHYPPOPY6a9d12eb9d83: Update README.md (authored by s635r).
Update README.md
Apr 4 2019, 11:33 AM
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

I just realized that it is actually checked in SetIndexToWorldTransform :-D

Apr 4 2019, 10:59 AM · MITK
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

While I changed the matrix check, I left it at the current position in in the PlaneGeometry.
We should discuss if it is sensible to move this ckec and also it's applications to a different location, e.g. to SetIndexToWorldTransform of BaseGeometry.

Apr 4 2019, 10:45 AM · MITK
neher added a revision to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed.: Unknown Object (Differential Revision).
Apr 4 2019, 10:42 AM · MITK
neher committed rMITKe2a1d71ddd26: Add tests if rotation matrix check and default dominant axes calculation work. (authored by neher).
Add tests if rotation matrix check and default dominant axes calculation work.
Apr 4 2019, 10:40 AM
hentsch triaged T26230: Debug assertion failed in ImageStatistics as Low priority.
Apr 4 2019, 10:25 AM · MITK
s635r committed rOBSHYPPOPY00b87c88baf3: Release 0.4.1.3, bugfixes (authored by s635r).
Release 0.4.1.3, bugfixes
Apr 4 2019, 10:14 AM
s635r committed rOBSHYPPOPY9103a4806328: Merge branch 'master' of github.com:MIC-DKFZ/Hyppopy (authored by s635r).
Merge branch 'master' of github.com:MIC-DKFZ/Hyppopy
Apr 4 2019, 10:14 AM
s635r committed rOBSHYPPOPY0e8e679be0ac: changed best parameter viewer to be consistent with solver output using <… (authored by s635r).
changed best parameter viewer to be consistent with solver output using <…
Apr 4 2019, 10:11 AM
hentsch awarded T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed. a Burninate token.
Apr 4 2019, 10:09 AM · MITK
neher committed rMITK223c1163e9ee: Check if matrix is rotation. Safe calculate dominant axes. (authored by neher).
Check if matrix is rotation. Safe calculate dominant axes.
Apr 4 2019, 10:01 AM
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Pushed new branch T25682-DominantAxesError.

Apr 4 2019, 10:01 AM · MITK
neher closed T26217: [MITK Diffusion] Diffusion function collection reference bvalue as Resolved.
Apr 4 2019, 9:29 AM · MITK
neher committed rMITKbcf8a2eb2c9b: Merge branch 'T26217-FfRefBval' (authored by neher).
Merge branch 'T26217-FfRefBval'
Apr 4 2019, 9:18 AM
neher committed rMITK8d34836f609f: Catch 0 (authored by neher).
Catch 0
Apr 4 2019, 9:17 AM
neher added a comment to T26217: [MITK Diffusion] Diffusion function collection reference bvalue.

Pushed new branch T26217-FfRefBval.

Apr 4 2019, 9:16 AM · MITK
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Does anyone know why the inverse is always calculated and not simply set to the transpose? After all, we are talking about rotation matrices.
In this context, the EnsurePerpendicularNormal method (https://phabricator.mitk.org/source/mitk/browse/master/Modules/Core/src/DataManagement/mitkPlaneGeometry.cpp$37) seems rather complex and also does not catch all cases since it only checks if axis 3 is perpendicular to 1&2 but not if 1&2 are perpendicular to each other. I would prefer to simply check if the matrix R is a rotation matrix by checking

  1. det(R) == 1?
  2. R*R^T = ID?
Apr 4 2019, 8:16 AM · MITK

Apr 3 2019

kislinsk committed rMITK11e88f4618c2: Merge branch 'T26224-RestructureCppRestSdkModule' (authored by kislinsk).
Merge branch 'T26224-RestructureCppRestSdkModule'
Apr 3 2019, 11:50 PM
kislinsk committed rMITKb41c43fd94ef: Make URIs unique to enable parallel test runs (authored by kislinsk).
Make URIs unique to enable parallel test runs
Apr 3 2019, 11:50 PM
kislinsk committed rMITK39e5f9558d0c: Merge remote-tracking branch 'origin/T26228-VisualStudio2019' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26228-VisualStudio2019'
Apr 3 2019, 11:42 PM
kislinsk closed T26228: Make MITK compatible to Visual Studio 2019 as Resolved.
Apr 3 2019, 11:42 PM · MITK
kislinsk committed rMITK73a3a40cc368: Merge branch 'T26228-VisualStudio2019' into releases/2018-04 (authored by kislinsk).
Merge branch 'T26228-VisualStudio2019' into releases/2018-04
Apr 3 2019, 11:39 PM
kislinsk committed rMITK95c5558757da: Add missing include (authored by kislinsk).
Add missing include
Apr 3 2019, 11:38 PM
kislinsk committed rMITK10c754a888d6: Support Visual Studio 2019 (authored by kislinsk).
Support Visual Studio 2019
Apr 3 2019, 10:57 PM
kislinsk committed rMITK97f18342ab5a: Support CMake 3.14 (authored by kislinsk).
Support CMake 3.14
Apr 3 2019, 10:57 PM
kislinsk committed rMITK413c2e3dd3f3: Fix minor version extraction (authored by kislinsk).
Fix minor version extraction
Apr 3 2019, 10:57 PM
kislinsk committed rMITK5bac0ce1f14a: Support Visual Studio Code (authored by kislinsk).
Support Visual Studio Code
Apr 3 2019, 10:57 PM
kislinsk added a comment to T26228: Make MITK compatible to Visual Studio 2019.

Pushed new branch T26228-VisualStudio2019.

Apr 3 2019, 10:57 PM · MITK
kislinsk triaged T26228: Make MITK compatible to Visual Studio 2019 as Wishlist priority.
Apr 3 2019, 10:48 PM · MITK
espak added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

The meaning of the dominant axes is also documented here:

Apr 3 2019, 5:10 PM · MITK
hentsch committed rMITKae0def9259a8: Merge branch 'T26188-fixes' (authored by hentsch).
Merge branch 'T26188-fixes'
Apr 3 2019, 4:58 PM
hentsch committed rMITK20c17c45d896: fixes in CEST plugin due to the changes of T26188 (authored by hentsch).
fixes in CEST plugin due to the changes of T26188
Apr 3 2019, 4:57 PM
hentsch added a comment to T26188: Don't use itk smart pointer for input in ImageStatisticsCalculator.

Pushed new branch T26188-fixes.

Apr 3 2019, 4:57 PM · MITK
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

It's apparently an issue of the "dominantAxis" calculation. In some cases this does not make sense and yields the same index twice. Not sure what this "dominantAxis" is supposed to be anyway. Supposedly related to T22254.

Apr 3 2019, 4:12 PM · MITK
s635r committed rOBSHYPPOPY2844b0ed89c6: adapted HyppopyProject set_hyperparamter to accept frequency (authored by s635r).
adapted HyppopyProject set_hyperparamter to accept frequency
Apr 3 2019, 2:28 PM
s635r committed rOBSHYPPOPY0b303d616201: README update (authored by s635r).
README update
Apr 3 2019, 1:58 PM
kalali committed rMITK6b9ff1f5b83d: Remove unnecessary destructors (authored by kalali).
Remove unnecessary destructors
Apr 3 2019, 1:57 PM
kalali committed rMITK50940d2a7921: Add getter for BaseRenderer (authored by kalali).
Add getter for BaseRenderer
Apr 3 2019, 1:57 PM
kalali committed rMITK7186be0331a7: Rename classes and uncomment code (authored by kalali).
Rename classes and uncomment code
Apr 3 2019, 1:57 PM
s635r added a comment to T26227: Own documentation section for hyper parameter aspects.

What other aspects do you mean?

Apr 3 2019, 1:57 PM · Hyppopy
kalali committed rMITK88cd250817f1: Change corner annotation of new render window widgets (authored by kalali).
Change corner annotation of new render window widgets
Apr 3 2019, 1:57 PM
kalali committed rMITK15e804982de5: Remove unnecessary comments (authored by kalali).
Remove unnecessary comments
Apr 3 2019, 1:57 PM
kalali committed rMITK79628815fb55: Clean constructors / destructors (authored by kalali).
Clean constructors / destructors
Apr 3 2019, 1:57 PM
kalali committed rMITKc4a02b3b0330: Add class documentation (authored by kalali).
Add class documentation
Apr 3 2019, 1:57 PM
kalali committed rMITKf52a208ca6ee: Add class documentation and remove unnecessary code (authored by kalali).
Add class documentation and remove unnecessary code
Apr 3 2019, 1:57 PM
kalali committed rMITK8b9eea23e307: Use correct logo / watermark (authored by kalali).
Use correct logo / watermark
Apr 3 2019, 1:57 PM