Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Dec 20 2019

kislinsk committed rMITKf22aa6c62e6b: Fix pre-loading of org.blueberry.core.expressions (authored by kislinsk).
Fix pre-loading of org.blueberry.core.expressions
Dec 20 2019, 7:39 PM
kislinsk added a comment to T26930: Crash Ubuntu 18.04.3 Qt 5.12.4.

Pushed new branch T26930-FixPreloading.

Dec 20 2019, 7:39 PM · MITK
kislinsk claimed T26930: Crash Ubuntu 18.04.3 Qt 5.12.4.
Dec 20 2019, 7:23 PM · MITK
kislinsk closed T26942: Crash on DICOM loading as Resolved.
Dec 20 2019, 3:30 PM · DICOM, Kaapana (internal), MITK
kislinsk committed rMITKfc9eb6fb17b5: Merge branch 'T26942-ImproveCESTPrivateTagParsing' (authored by kislinsk).
Merge branch 'T26942-ImproveCESTPrivateTagParsing'
Dec 20 2019, 3:28 PM
kislinsk committed rMITKd51de1cd1846: Fix wrong assumption made about ASCII format (authored by kislinsk).
Fix wrong assumption made about ASCII format
Dec 20 2019, 3:27 PM
franza committed rMITK895edd232597: CT registration demo running (display transformations to console only once at… (authored by franza).
CT registration demo running (display transformations to console only once at…
Dec 20 2019, 3:27 PM
franza committed rMITKc8e7a90f32f8: added initialization button for initial check of combined modality (authored by franza).
added initialization button for initial check of combined modality
Dec 20 2019, 1:51 PM
franza committed rMITK4b80dc832a83: stopping timer after calibration to avoid a bug and be able to save the… (authored by franza).
stopping timer after calibration to avoid a bug and be able to save the…
Dec 20 2019, 1:51 PM
adler added a member for Photoacoustics: j806e.
Dec 20 2019, 1:18 PM
kislinsk reopened T26942: Crash on DICOM loading as "Open".

CI

Dec 20 2019, 12:48 PM · DICOM, Kaapana (internal), MITK
kislinsk changed the edit policy for Photoacoustics.
Dec 20 2019, 12:03 PM
kislinsk committed rMITK926e62c0b205: Merge branch 'T26942-ImproveCESTPrivateTagParsing' (authored by kislinsk).
Merge branch 'T26942-ImproveCESTPrivateTagParsing'
Dec 20 2019, 11:59 AM
kislinsk committed rMITK2abe8ed53c56: Make parsing even more robust against unexpected input (authored by kislinsk).
Make parsing even more robust against unexpected input
Dec 20 2019, 11:58 AM
kislinsk committed rMITK36f887654582: Merge branch 'T26944-ClearBorderOfRenderWindowMenuButtons' (authored by kislinsk).
Merge branch 'T26944-ClearBorderOfRenderWindowMenuButtons'
Dec 20 2019, 10:09 AM
kislinsk committed rMITKfbc49fc5c831: Prevent stylesheet inheritance in first place (authored by kislinsk).
Prevent stylesheet inheritance in first place
Dec 20 2019, 10:08 AM
kislinsk committed rMITKfb7ccddc0b51: Merge branch 'T26942-ImproveCESTPrivateTagParsing' (authored by kislinsk).
Merge branch 'T26942-ImproveCESTPrivateTagParsing'
Dec 20 2019, 10:01 AM
kislinsk committed rMITK66d2e034ea99: Use std::size type for length and offset (authored by kislinsk).
Use std::size type for length and offset
Dec 20 2019, 10:00 AM
kislinsk closed T26942: Crash on DICOM loading as Resolved.
Dec 20 2019, 9:55 AM · DICOM, Kaapana (internal), MITK
kislinsk committed rMITK6a9ff80fa313: Merge branch 'T26942-ImproveCESTPrivateTagParsing' (authored by kislinsk).
Merge branch 'T26942-ImproveCESTPrivateTagParsing'
Dec 20 2019, 9:55 AM
kislinsk committed rMITKaef3aa0e5c16: Improve and fix parsing of private tags (authored by kislinsk).
Improve and fix parsing of private tags
Dec 20 2019, 9:54 AM
kislinsk added a comment to T26942: Crash on DICOM loading.

Pushed new branch T26942-ImproveCESTPrivateTagParsing.

Dec 20 2019, 9:54 AM · DICOM, Kaapana (internal), MITK
kislinsk claimed T26942: Crash on DICOM loading.
Dec 20 2019, 9:40 AM · DICOM, Kaapana (internal), MITK
kislinsk added a comment to T26942: Crash on DICOM loading.

Despite all of the obvious flaws of the parsing code around the highlighted line linked above, the particular reason for the crash is a missing check against npos regarding the results of the find() calls. Even without a more comprehensive fix, the hex number string extraction and conversion to ASCII characters should be enhanced by checking against non-ASCII hex values.

Dec 20 2019, 9:13 AM · DICOM, Kaapana (internal), MITK
kislinsk added a comment to T26942: Crash on DICOM loading.

@k656s Is the example data available on our network drives?

Dec 20 2019, 9:09 AM · DICOM, Kaapana (internal), MITK
kislinsk committed rMDe714e4a9628a: Fix layer and value property types (authored by kislinsk).
Fix layer and value property types
Dec 20 2019, 6:03 AM
kislinsk committed rMITK69f7f38253f8: Merge branch 'T26944-ClearBorderOfRenderWindowMenuButtons' (authored by kislinsk).
Merge branch 'T26944-ClearBorderOfRenderWindowMenuButtons'
Dec 20 2019, 5:44 AM
kislinsk closed T26944: Render window menu buttons have render window widget decoration border on Linux as Resolved.
Dec 20 2019, 5:44 AM · MITK
kislinsk committed rMITKcb13b3acdb1f: Explicitly clear border of render window menu buttons (authored by kislinsk).
Explicitly clear border of render window menu buttons
Dec 20 2019, 5:44 AM
kislinsk added a comment to T26944: Render window menu buttons have render window widget decoration border on Linux.

Pushed new branch T26944-ClearBorderOfRenderWindowMenuButtons.

Dec 20 2019, 5:44 AM · MITK
kislinsk triaged T26944: Render window menu buttons have render window widget decoration border on Linux as Low priority.
Dec 20 2019, 5:41 AM · MITK
kislinsk closed T26943: "Show crosshair" render window menu item has wrong default as Resolved.
Dec 20 2019, 5:32 AM · MITK
kislinsk committed rMITKd02a92d0a398: Merge branch 'T26943-FixShowCrosshair' (authored by kislinsk).
Merge branch 'T26943-FixShowCrosshair'
Dec 20 2019, 5:28 AM
kislinsk committed rMITK8199d2f06739: Fix default visibility of crosshair in render window menu (authored by kislinsk).
Fix default visibility of crosshair in render window menu
Dec 20 2019, 5:28 AM
kislinsk added a comment to T26943: "Show crosshair" render window menu item has wrong default.

Pushed new branch T26943-FixShowCrosshair.

Dec 20 2019, 5:27 AM · MITK
kislinsk triaged T26943: "Show crosshair" render window menu item has wrong default as Normal priority.
Dec 20 2019, 5:26 AM · MITK
• ramien committed rMDTPUBLICb5c1db0ec4f6: pytorch update to >1.x, python to 3.7.5. custom exts to c++ and cuda 10.1 (authored by • ramien).
pytorch update to >1.x, python to 3.7.5. custom exts to c++ and cuda 10.1
Dec 20 2019, 2:32 AM
• ramien committed rMDTPUBLICfc7334279637: intermed save for sharing (authored by • ramien).
intermed save for sharing
Dec 20 2019, 2:32 AM
• ramien committed rREGRCNN4ddfe9be979a: fix: mrcnn gt masks roi align (authored by • ramien).
fix: mrcnn gt masks roi align
Dec 20 2019, 2:10 AM
• ramien committed rREGRCNNaa53131be7ac: fix: mrcnn gt masks rescale before roi align (authored by • ramien).
fix: mrcnn gt masks rescale before roi align
Dec 20 2019, 2:10 AM
• ramien committed rREGRCNN9d67338bda89: fix: roi align in gt masks loss mining, map boxes to unnormalized scale (authored by • ramien).
fix: roi align in gt masks loss mining, map boxes to unnormalized scale
Dec 20 2019, 2:02 AM
• ramien committed rREGRCNNa10d4c3f3870: pre gt masks change (authored by • ramien).
pre gt masks change
Dec 20 2019, 2:02 AM

Dec 19 2019

kislinsk updated the task description for T26150: Build tree version of MitkWorkbench crashes twice before eventually starting on Ubuntu with GCC.
Dec 19 2019, 4:50 PM · MITK (2018-04-2)
kislinsk renamed T26941: MITK_USE_Python3 and CMake 3.16 does not work from MITK_USE_Python3 and CMake 3.16 does not work (bug in CMake 3.16) to MITK_USE_Python3 and CMake 3.16 does not work.
Dec 19 2019, 4:27 PM · MITK
kislinsk committed rMITK85205724ec57: Merge branch 'T26941-WorkaroundCMake3.16' (authored by kislinsk).
Merge branch 'T26941-WorkaroundCMake3.16'
Dec 19 2019, 4:26 PM
kislinsk committed rMITKa441d37b79ac: Change Python3_INCLUDE_DIR result variable to Python3_INCLUDE_DIRS (authored by kislinsk).
Change Python3_INCLUDE_DIR result variable to Python3_INCLUDE_DIRS
Dec 19 2019, 4:10 PM
• ramien committed rMDTPUBLIC8a2218f89f8b: pre pytorch update from 0.4.x to 1.x (authored by • ramien).
pre pytorch update from 0.4.x to 1.x
Dec 19 2019, 3:18 PM
nolden triaged T26942: Crash on DICOM loading as Normal priority.
Dec 19 2019, 1:54 PM · DICOM, Kaapana (internal), MITK
kislinsk closed T26941: MITK_USE_Python3 and CMake 3.16 does not work as Resolved.
Dec 19 2019, 1:15 PM · MITK
kislinsk committed rMITKec1b19e15871: Merge branch 'T26941-WorkaroundCMake3.16' (authored by kislinsk).
Merge branch 'T26941-WorkaroundCMake3.16'
Dec 19 2019, 1:14 PM
kislinsk committed rMITK5d1ec4dd4a69: Work around a bug in CMake 3.16 FindPython3 module (authored by kislinsk).
Work around a bug in CMake 3.16 FindPython3 module
Dec 19 2019, 1:14 PM
kislinsk added a comment to T26941: MITK_USE_Python3 and CMake 3.16 does not work.

Pushed new branch T26941-WorkaroundCMake3.16.

Dec 19 2019, 1:13 PM · MITK
kislinsk triaged T26941: MITK_USE_Python3 and CMake 3.16 does not work as Normal priority.
Dec 19 2019, 1:11 PM · MITK

Dec 18 2019

kislinsk closed T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time as Resolved.

Okay, this is somehow unsatisfying but I noticed that a lambda function I connected in addition to the original connection always triggered as expected. So I used it as indirection to call the actual member function.

Dec 18 2019, 4:59 PM · MITK
kislinsk committed rMITK462698dbbc2a: Merge branch 'T26938-FixExtensionPointContextMenuActionTrigger' (authored by kislinsk).
Merge branch 'T26938-FixExtensionPointContextMenuActionTrigger'
Dec 18 2019, 4:58 PM
kislinsk committed rMITKcec397e3dd86: Use lambda function for connection (authored by kislinsk).
Use lambda function for connection
Dec 18 2019, 4:57 PM
kislinsk committed rMITK89719c8b3d35: Do more clean-up (authored by kislinsk).
Do more clean-up
Dec 18 2019, 4:07 PM
kislinsk committed rMITK79669e3eeea3: Clean up QmitkDataNodeContextMenu (authored by kislinsk).
Clean up QmitkDataNodeContextMenu
Dec 18 2019, 9:26 AM
kislinsk added a comment to T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time.

Pushed new branch T26938-FixExtensionPointContextMenuActionTrigger.

Dec 18 2019, 9:26 AM · MITK
kislinsk claimed T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time.
Dec 18 2019, 9:23 AM · MITK
kislinsk added a comment to T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time.

Extension point actions are connected like QAction::triggered() QmitkDataNodeContextMenu::OnExtensionPointActionTriggered(). The second time, the slot isn't called anymore.

Dec 18 2019, 7:32 AM · MITK

Dec 17 2019

kislinsk triaged T26938: Extension point actions in Data Manager context menu trigger only when the context menu is shown for the first time as High priority.
Dec 17 2019, 9:33 PM · MITK
kislinsk committed rMITK719616fb02e6: Merge branch 'T26936-MigrateUiStdMultiWidgetNames' (authored by kislinsk).
Merge branch 'T26936-MigrateUiStdMultiWidgetNames'
Dec 17 2019, 7:56 PM
kislinsk committed rMITK2be7aef1d58a: Migrate render window widget names (authored by kislinsk).
Migrate render window widget names
Dec 17 2019, 7:55 PM
kislinsk added a comment to T26936: QmitkStdMultiWidget render window names messed up.

Pushed new branch T26936-MigrateUiStdMultiWidgetNames.

Dec 17 2019, 7:55 PM · Noteworthy, MITK
kislinsk placed T26934: Multiple logos in screenshot when using screenshot maker plugin up for grabs.
Dec 17 2019, 4:17 PM · Auto-closed, MITK
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Only partly fixed so far. Logo can be disabled in the Overlay Manager View.

Dec 17 2019, 4:17 PM · Auto-closed, MITK
kislinsk committed rMITKa7e08d799f36: Merge branch 'T26934-FixScreenshotMaker' (authored by kislinsk).
Merge branch 'T26934-FixScreenshotMaker'
Dec 17 2019, 4:16 PM
kislinsk committed rMITK67cf388ee02c: Disable all decorations while doing screenshot (authored by kislinsk).
Disable all decorations while doing screenshot
Dec 17 2019, 4:15 PM
kislinsk committed rMITKbb905350c178: Invert wrong nullptr check (authored by kislinsk).
Invert wrong nullptr check
Dec 17 2019, 4:15 PM
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch T26934-FixScreenshotMaker.

Dec 17 2019, 4:15 PM · Auto-closed, MITK
kislinsk claimed T26934: Multiple logos in screenshot when using screenshot maker plugin.
Dec 17 2019, 4:13 PM · Auto-closed, MITK
kislinsk closed T26936: QmitkStdMultiWidget render window names messed up as Resolved.
Dec 17 2019, 3:39 PM · Noteworthy, MITK
kislinsk awarded T26936: QmitkStdMultiWidget render window names messed up a Hungry Hippo token.
Dec 17 2019, 3:39 PM · Noteworthy, MITK
kislinsk committed rMITK6c0f7fdc22b7: Merge branch 'T26936-FixStdMultiWidgetRenderWindowNames' (authored by kislinsk).
Merge branch 'T26936-FixStdMultiWidgetRenderWindowNames'
Dec 17 2019, 3:39 PM
kislinsk committed rMITK7dfdc934e199: Migrate stdmulti widget names from <n> to <n-1> (authored by kislinsk).
Migrate stdmulti widget names from <n> to <n-1>
Dec 17 2019, 3:38 PM
kislinsk committed rMITK4c5d62d08d16: Fix stdmulti base name of widgets (authored by kislinsk).
Fix stdmulti base name of widgets
Dec 17 2019, 3:38 PM
kislinsk added a comment to T26936: QmitkStdMultiWidget render window names messed up.

Pushed new branch T26936-FixStdMultiWidgetRenderWindowNames.

Dec 17 2019, 3:38 PM · Noteworthy, MITK
kislinsk triaged T26936: QmitkStdMultiWidget render window names messed up as High priority.
Dec 17 2019, 3:31 PM · Noteworthy, MITK
mittmann committed rMITKfece22f400cf: Improving and adjusting fiducial localization algorithm due to big variability… (authored by mittmann).
Improving and adjusting fiducial localization algorithm due to big variability…
Dec 17 2019, 3:01 PM
kislinsk closed T26935: Superbuild fails in case of debug and release batch build (Visual Studio) as Resolved.
Dec 17 2019, 2:16 PM · MITK
kislinsk committed rMITKea4ac0abbc7c: Merge branch 'T26935-DoNotResetCMAKE_DEBUG_POSTFIX' (authored by kislinsk).
Merge branch 'T26935-DoNotResetCMAKE_DEBUG_POSTFIX'
Dec 17 2019, 1:38 PM
kislinsk committed rMITK7e63a8010d88: Revert resetting of CMAKE_DEBUG_POSTFIX when Python is enabled (authored by kislinsk).
Revert resetting of CMAKE_DEBUG_POSTFIX when Python is enabled
Dec 17 2019, 1:37 PM
kislinsk added a comment to T26935: Superbuild fails in case of debug and release batch build (Visual Studio).

Pushed new branch T26935-DoNotResetCMAKE_DEBUG_POSTFIX.

Dec 17 2019, 1:37 PM · MITK
kislinsk added a comment to T26935: Superbuild fails in case of debug and release batch build (Visual Studio).

If MITK_USE_Python3 is on, CMAKE_DEBUG_POSTFIX is reset. ❗

Dec 17 2019, 11:24 AM · MITK
kislinsk removed a parent task for T26431: Fix gcc 9 and clang 8 compilation: T26935: Superbuild fails in case of debug and release batch build (Visual Studio).
Dec 17 2019, 11:18 AM · MITK
kislinsk removed a subtask for T26935: Superbuild fails in case of debug and release batch build (Visual Studio): T26431: Fix gcc 9 and clang 8 compilation.
Dec 17 2019, 11:18 AM · MITK
kislinsk closed T26431: Fix gcc 9 and clang 8 compilation, a subtask of T26935: Superbuild fails in case of debug and release batch build (Visual Studio), as Resolved.
Dec 17 2019, 11:18 AM · MITK
kislinsk closed T26431: Fix gcc 9 and clang 8 compilation as Resolved.
Dec 17 2019, 11:18 AM · MITK
kalali added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Which version / commit did you use?

Dec 17 2019, 10:33 AM · Auto-closed, MITK
kislinsk added a subtask for T26935: Superbuild fails in case of debug and release batch build (Visual Studio): T26431: Fix gcc 9 and clang 8 compilation.
Dec 17 2019, 10:32 AM · MITK
kislinsk added a parent task for T26431: Fix gcc 9 and clang 8 compilation: T26935: Superbuild fails in case of debug and release batch build (Visual Studio).
Dec 17 2019, 10:32 AM · MITK
kislinsk added a comment to T26431: Fix gcc 9 and clang 8 compilation.
Dec 17 2019, 10:31 AM · MITK

Dec 16 2019

kislinsk triaged T26935: Superbuild fails in case of debug and release batch build (Visual Studio) as High priority.
Dec 16 2019, 11:41 PM · MITK
kislinsk closed T15528: Integrate VMTK as Wontfix.
Dec 16 2019, 11:37 PM · Bugzilla, MITK
kislinsk triaged T26835: Crash on change of Surface interpolation from Phong to Flat as High priority.
Dec 16 2019, 7:54 PM · Pull Request, MITK
nolden created T26934: Multiple logos in screenshot when using screenshot maker plugin.
Dec 16 2019, 5:35 PM · Auto-closed, MITK
ericheim added a comment to T26930: Crash Ubuntu 18.04.3 Qt 5.12.4.

Thanks for the explanation. It happens on two freshly installed Ubuntu 18.04.3 PC's. An older setup seems to magically work fine

Dec 16 2019, 4:25 PM · MITK
kislinsk triaged T26930: Crash Ubuntu 18.04.3 Qt 5.12.4 as High priority.

This was supposed to be solved in T26150: Build tree version of MitkWorkbench crashes twice before eventually starting on Ubuntu with GCC. Long story short, it has probably something to do with a messed up linkage of mixed superbuild/system dependencies. After some months of silence I think you are not the first one to encounter this bug again so we have to reinvestigate. As far as I remember using Clang does not lead to this issue in the first place.

Dec 16 2019, 4:20 PM · MITK
maleike added a comment to T26835: Crash on change of Surface interpolation from Phong to Flat.

FYI: VTK integrated this fix:

Dec 16 2019, 8:40 AM · Pull Request, MITK
First
Prev
Next
MITK · MIC · IMSY · DKFZ