Page MenuHomePhabricator
Create Task
Maniphest T28525

Design refactoring of LabelSetImage and associated classes
Closed, ResolvedPublic
Actions

Description

As discussed in https://hub.dkfz.de/f/5459842 we want to address several problems that are caused or enforced by the current design.

This tasks focuses on specifing the refactored design that solves

  • P2: Label manipulation code is scattered
  • P3: Labelset is (too) statefull 1 - Active Layer/Label / behaves (wronlgy) like an image
  • P4: Labelset is statefull 2 - Lock states - teethless tiger

There is surely plenty of additional room for improvent. But we have identified this things as the most important/hindering problems, that have impact on many UX issues. Therfore we decided to first solve them pragmatically but well designed and strive for perfection later ;).

This tasks is just for discussing and defining the new design. The real refactoring will be done in the super task.

Revisions and Commits

rMITK MITK
Audit RequiredrMITK5a37ab08b342 - added first review comments
Audit RequiredrMITK07c00faee192 First draft of the central classes.

Related Objects
Search...

StatusAssignedTask
 OpenNoneT27807 [MultiLabel Segmentation] Inspection of module and plugin
 OpenNoneT22593 Update the MitkMultilabelTestDriver
 OpenNoneT22458 Merging a label in the MultiLabel segmentation plugin leaves one label without a segmentation
 OpenNoneT26397 Multilabel Segmentation file cannot be converted to multilabel segmentation in MITK
 ResolvedflocaT23981 Multilabel color map should disable interpolation
 OpenNoneT25445 MultiLabel segmentation mapper is very slow
 ResolvedkalaliT28131 [MultiLabel Segmentation] 3D Threshold tool does not work with multiple labels / layers
 OpenNoneT28176 [Segmentation] Inspection of module and plugin
 ResolvedflocaT28526 [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage
 OpenNoneT26959 [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary"
 OpenNoneT28479 [Segmentation] Rethink / reevaluate our existing segmentation tools / algorithms
 OpenNoneT8140 Reimplement volume annotations for segmentations
 ResolvedkislinskT27319 [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View
 OpenflocaT28524 Refactor LabelSetImage and associated classes.
 ResolvedflocaT29132 [MultiLabel Segmentation] Define desired behavior of fill / erase tool
 ResolvedflocaT28145 SetRegionTool does not work as expected (flood fill like) with concentric structures.
 ResolvedflocaT28525 Design refactoring of LabelSetImage and associated classes
 ResolvedflocaT28140 [MultiLabel Segmentation] Default parameter (unsigned int layer = 0) is unnecessary and causes problems
 ResolvedflocaT28139 [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage
 DuplicateNoneT16153 [Segmentation] Jump to center of mass of segmentation on click

Event Timeline

floca triaged this task as Unbreak Now! priority.Jun 4 2021, 7:06 PM
floca created this task.
floca moved this task from Backlog to Cycle on the MITK (v2021.10) board.Jun 4 2021, 7:13 PM
floca claimed this task.Jun 6 2021, 8:27 PM
floca added a comment.Jun 9 2021, 8:41 AM

Pushed new branch to rMITK MITK: feature/T28525-Design_refactoring_labelset.

floca added a commit: rMITK07c00faee192: First draft of the central classes..Jun 9 2021, 8:43 AM
floca added a commit: rMITK5a37ab08b342: - added first review comments.Jun 13 2021, 2:25 PM
floca added subscribers: kalali, kislinsk.
floca added a subtask: T28140: [MultiLabel Segmentation] Default parameter (unsigned int layer = 0) is unnecessary and causes problems.Jul 27 2021, 9:57 AM
floca added a subtask: T28139: [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage.
floca added a parent task: T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures..Jul 28 2021, 12:50 PM
kislinsk edited projects, added MITK (v2022.04); removed MITK (v2021.10).Nov 10 2021, 4:32 PM
floca moved this task from Backlog to Segmentation on the MITK (v2022.04) board.Nov 17 2021, 11:55 AM
floca edited projects, added Next Milestone, MITK; removed MITK (v2022.04).Jan 20 2022, 9:35 AM
floca mentioned this in T29169: [Segmentation] Extract TransferLabelToImage from Tool class.May 7 2022, 7:05 PM
floca removed floca as the assignee of this task.May 12 2022, 10:27 AM
floca edited projects, added MITK (v2022.10); removed MITK, Next Milestone.
floca moved this task from Backlog to Segmentation on the MITK (v2022.10) board.May 12 2022, 11:07 AM
floca mentioned this in T28139: [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage.May 13 2022, 7:03 PM
kalali added a subtask: T16153: [Segmentation] Jump to center of mass of segmentation on click.May 19 2022, 9:00 AM
floca mentioned this in T29204: [SEG] Rework properties of Label class + add instance information.Jun 3 2022, 3:52 PM
kislinsk lowered the priority of this task from Unbreak Now! to Normal.Oct 19 2022, 10:28 AM
kislinsk edited projects, added Next Milestone; removed MITK (v2022.10).
floca closed subtask T28139: [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage as Resolved.Jul 4 2023, 5:22 PM
floca closed subtask T28140: [MultiLabel Segmentation] Default parameter (unsigned int layer = 0) is unnecessary and causes problems as Resolved.Feb 22 2024, 5:26 PM
floca closed this task as Resolved.Thu, Apr 18, 4:37 PM
floca claimed this task.
MITK · MIC · IMSY · DKFZ