Page MenuHomePhabricator

[Segmentation] New Add/Remove tool
Closed, ResolvedPublic

Description

After the user feedback (polygon like handling, instead of lasso while clicked), I would propose we implement a base tool (for add and remove) that behaves (mouse interactions and keys) like the lasso tool of GIMP. Only difference I would make, is that i would make it a closed contour from the beginning (anything else does not make sense in our context).

Key features:

  • Normal state is polygon tool (click some where generates the next control point and a straigt line to it)
  • Move while mouse button pressed, free lasso paint as now (when mouse button is release new controll point is generated)
  • If courser is on an existing control point, we switch to control point moving mode (pressing mouse button starts moving the point)
  • Return, Space (or like other tools (tool change, slice change...) finishes segmentation
  • ESC cancles it
  • Backspace, removes everything up to the last control point.

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

floca triaged this task as Normal priority.Apr 25 2021, 9:59 PM
floca created this task.
floca raised the priority of this task from Normal to High.Jul 27 2021, 9:46 AM
floca added a project: Cleared.

@kahl I hope it is ok, that I assigned you, since you are working on this anyways.

kislinsk added a revision: Restricted Differential Revision.Mar 20 2022, 11:10 AM
kislinsk added a revision: Restricted Differential Revision.Mar 20 2022, 11:16 AM
kislinsk lowered the priority of this task from High to Normal.
kislinsk edited projects, added MITK; removed MITK (v2022.04), Cleared.
floca raised the priority of this task from Normal to High.May 13 2022, 10:24 AM
floca edited projects, added MITK (v2022.10); removed MITK.

What is the status here?

@s434n Have claimed it for finding the error* (good job by the way). Then you can unclaim it now.
Or will you work on that issue further?

@s434n Have claimed it for finding the error* (good job by the way). Then you can unclaim it now.
Or will you work on that issue further?

That depends on how the further steps look like. One reason why I claimed it was to make sure somebody is pushing the new tool forward. If someone else is continuing the work, they can claim it. Otherwise I guess I will stay assigned and work further on it.

@s434n If it is OK for you, I would take over as I think the tools need a further refactoring. They still have to much redundancy that could be avoided.

s434n added a subscriber: s434n.

Deleted branch from rMITK MITK: feature/T28464-new-add-tool-2.

Deleted branch from rMITK MITK: feature/T28464-new-add-tool.