- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Apr 4 2019
I just realized that it is actually checked in SetIndexToWorldTransform :-D
While I changed the matrix check, I left it at the current position in in the PlaneGeometry.
We should discuss if it is sensible to move this ckec and also it's applications to a different location, e.g. to SetIndexToWorldTransform of BaseGeometry.
Pushed new branch T25682-DominantAxesError.
Pushed new branch T26217-FfRefBval.
Does anyone know why the inverse is always calculated and not simply set to the transpose? After all, we are talking about rotation matrices.
In this context, the EnsurePerpendicularNormal method (https://phabricator.mitk.org/source/mitk/browse/master/Modules/Core/src/DataManagement/mitkPlaneGeometry.cpp$37) seems rather complex and also does not catch all cases since it only checks if axis 3 is perpendicular to 1&2 but not if 1&2 are perpendicular to each other. I would prefer to simply check if the matrix R is a rotation matrix by checking
- det(R) == 1?
- R*R^T = ID?
Apr 3 2019
Pushed new branch T26228-VisualStudio2019.
The meaning of the dominant axes is also documented here:
Pushed new branch T26188-fixes.
It's apparently an issue of the "dominantAxis" calculation. In some cases this does not make sense and yields the same index twice. Not sure what this "dominantAxis" is supposed to be anyway. Supposedly related to T22254.
What other aspects do you mean?
Pushed new branch T26224-RestructureCppRestSdkModule.
Pushed new branch T25832-migrateModelFitToMitkCHart.
after deleting the old plugin and renaming the new plugin, the documentation has to be fixed again.
Apr 2 2019
If you have already an interim branch, could you push it, just to be sure that it doesn't get lost.