Page MenuHomePhabricator
Feed Advanced Search

Oct 28 2020

kislinsk closed T27663: Crosshair navigation not disabled in QmitkMeasurementView as Wontfix.

I see. The only implication however is that one is able to scroll through the slices while placing a planar figure while placing control points on different slices is prevented, so I would say this is more like a feature than a bug, as one can look up neighboring slices during placement to support the decision where to exactly place points.

Oct 28 2020, 7:05 AM · Breaking Change, MITK
kislinsk added a comment to T27908: [MITKDoc] Update Multilabel Segmentation documentation regarding label presets.

Pushed new branch bugfix/T27908-UpdateMultilabelSegmentationDoc.

Oct 28 2020, 6:59 AM · Cleared, MITK (v2021.02)
kislinsk closed T27844: CDash links to commits in phabricator seems not to work correctly as Resolved.

As the devs of CDash prefer to stay dead silent about this feature both in the issue linked above and on the mailing list, I think we can make an educated guess that it is not implemented.

Oct 28 2020, 6:56 AM · Restricted Project, Restricted Project, MITK
kislinsk added a revision to T27908: [MITKDoc] Update Multilabel Segmentation documentation regarding label presets: Unknown Object (Differential Revision).
Oct 28 2020, 6:52 AM · Cleared, MITK (v2021.02)

Oct 26 2020

kislinsk closed T27914: Transform relative MITK extension dirs to absolute dirs as Resolved.
Oct 26 2020, 4:52 PM · MITK
kislinsk added a comment to T27914: Transform relative MITK extension dirs to absolute dirs.

Deleted branch bugfix/T27914-AbsoluteMITKExtensionDirs.

Oct 26 2020, 4:52 PM · MITK
kislinsk committed rMITK659426760b45: Merge branch 'bugfix/T27914-AbsoluteMITKExtensionDirs' into develop (authored by kislinsk).
Merge branch 'bugfix/T27914-AbsoluteMITKExtensionDirs' into develop
Oct 26 2020, 4:51 PM
kislinsk added a comment to T27914: Transform relative MITK extension dirs to absolute dirs.

Pushed new branch bugfix/T27914-AbsoluteMITKExtensionDirs.

Oct 26 2020, 4:49 PM · MITK
kislinsk triaged T27914: Transform relative MITK extension dirs to absolute dirs as Unbreak Now! priority.
Oct 26 2020, 11:24 AM · MITK
kislinsk added a comment to T27910: 2020 Week 43 (Late October).

Deleted branch release/T27910-2020-Week-43.

Oct 26 2020, 11:06 AM · MITK

Oct 23 2020

kislinsk closed T27910: 2020 Week 43 (Late October) as Resolved.
Oct 23 2020, 5:22 PM · MITK
kislinsk committed rMITK701c8286244c: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Oct 23 2020, 5:15 PM
kislinsk committed rMITKf09362ceac6d: 2020 Week 43 (Late October) (authored by kislinsk).
2020 Week 43 (Late October)
Oct 23 2020, 5:14 PM
kislinsk edited the content of Changelog.
Oct 23 2020, 4:57 PM · MITK
kislinsk edited the content of 2020 Week 43 (Late October).
Oct 23 2020, 4:57 PM
kislinsk added a comment to T27910: 2020 Week 43 (Late October).

Pushed new branch release/T27910-2020-Week-43.

Oct 23 2020, 1:40 PM · MITK
kislinsk triaged T27910: 2020 Week 43 (Late October) as Normal priority.
Oct 23 2020, 1:38 PM · MITK
kislinsk created T27910: 2020 Week 43 (Late October).
Oct 23 2020, 1:38 PM · MITK
kislinsk created an object: 2020 Week 43 (Late October).
Oct 23 2020, 1:38 PM
kislinsk closed T27902: Handle slashes in installer names as Resolved.

Slashes are now replaced by underscores.

Oct 23 2020, 1:34 PM · MITK (v2021.02)
kislinsk added a comment to T27902: Handle slashes in installer names.

Deleted branch bugfix/T27902-ReplaceSlashesInInstallerName.

Oct 23 2020, 1:34 PM · MITK (v2021.02)
kislinsk committed rMITKf8ca3b7be4a9: Merge branch 'bugfix/T27902-ReplaceSlashesInInstallerName' into develop (authored by kislinsk).
Merge branch 'bugfix/T27902-ReplaceSlashesInInstallerName' into develop
Oct 23 2020, 1:33 PM
kislinsk added a comment to T27902: Handle slashes in installer names.

Pushed new branch bugfix/T27902-ReplaceSlashesInInstallerName.

Oct 23 2020, 1:33 PM · MITK (v2021.02)
kislinsk claimed T27902: Handle slashes in installer names.
Oct 23 2020, 1:12 PM · MITK (v2021.02)
kislinsk triaged T27908: [MITKDoc] Update Multilabel Segmentation documentation regarding label presets as Normal priority.
Oct 23 2020, 1:10 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27851: Unhide label presets.

Deleted branch bugfix/T27851-FixLabelSetPresetsAndMakeThemMoreAccessible.

Oct 23 2020, 11:49 AM · MITK (v2021.02)
kislinsk committed rMITK499751fb1eca: Fix loading and saving of LabelSet presets and make it more accessible (authored by kislinsk).
Fix loading and saving of LabelSet presets and make it more accessible
Oct 23 2020, 11:49 AM
kislinsk closed T27851: Unhide label presets as Resolved by committing rMITK499751fb1eca: Fix loading and saving of LabelSet presets and make it more accessible.
Oct 23 2020, 11:49 AM · MITK (v2021.02)
kislinsk edited projects for T27383: Update external toolkits, added: MITK (v2021.02); removed MITK.
Oct 23 2020, 11:46 AM · Noteworthy, MITK (v2021.02)
kislinsk renamed T8140: Reimplement volume annotations for segmentations from Implement volume annotation for ImageVtkMapper2D to Reimplement volume annotations for segmentations.
Oct 23 2020, 11:44 AM · MITK (v2024.12), Request for Discussion, Bugzilla
kislinsk removed a project from T8140: Reimplement volume annotations for segmentations: Request for Discussion.
Oct 23 2020, 11:43 AM · MITK (v2024.12), Request for Discussion, Bugzilla
kislinsk removed a project from T27383: Update external toolkits: Request for Discussion.
Oct 23 2020, 11:41 AM · Noteworthy, MITK (v2021.02)
kislinsk removed a project from T27340: [ModelFit] Request for Mac Workbench installer: Request for Discussion.
Oct 23 2020, 11:35 AM · Auto-closed, Restricted Project, MITK
kislinsk moved T27340: [ModelFit] Request for Mac Workbench installer from MITK Meeting to Backlog on the Request for Discussion board.
Oct 23 2020, 11:35 AM · Auto-closed, Restricted Project, MITK
kislinsk removed a project from T27904: Feature request: Colorbars to interpret data in MITK: Request for Discussion.
Oct 23 2020, 11:23 AM · Moved to git.dkfz.de, Request for Discussion, MITK
kislinsk added a comment to T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation.

Deleted branch feature/T27789-ClippingPlanePlugin.

Oct 23 2020, 9:19 AM · MITK (v2021.02)
kislinsk committed rMITK26bde1c5b441: Move Clipping Plane view into separate plugin (authored by kislinsk).
Move Clipping Plane view into separate plugin
Oct 23 2020, 9:19 AM
kislinsk closed T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation as Resolved by committing rMITK26bde1c5b441: Move Clipping Plane view into separate plugin.
Oct 23 2020, 9:18 AM · MITK (v2021.02)
kislinsk added a comment to T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation.

Pushed new branch feature/T27789-ClippingPlanePlugin.

Oct 23 2020, 9:18 AM · MITK (v2021.02)

Oct 20 2020

kislinsk added a comment to T27902: Handle slashes in installer names.

Also, in the zip folder for example, we suddenly have nested folders: MITK-snapshots/2020-09-25-123-gabcdefab-windows-x86_64.

Oct 20 2020, 1:46 PM · MITK (v2021.02)
kislinsk updated the task description for T27902: Handle slashes in installer names.
Oct 20 2020, 1:43 PM · MITK (v2021.02)
kislinsk triaged T27902: Handle slashes in installer names as High priority.
Oct 20 2020, 1:42 PM · MITK (v2021.02)
kislinsk closed T27900: Reference typo in mitkPlanarEllipse.cpp as Resolved.
Oct 20 2020, 12:04 PM · MITK
kislinsk added a comment to T27900: Reference typo in mitkPlanarEllipse.cpp.

Deleted branch bugfix/T27900-TypoInReference.

Oct 20 2020, 12:03 PM · MITK
kislinsk committed rMITKe10d0aee8877: Merge branch 'bugfix/T27900-TypoInReference' into develop (authored by kislinsk).
Merge branch 'bugfix/T27900-TypoInReference' into develop
Oct 20 2020, 12:03 PM
kislinsk added a comment to T27900: Reference typo in mitkPlanarEllipse.cpp.

Pushed new branch bugfix/T27900-TypoInReference.

Oct 20 2020, 12:02 PM · MITK
kislinsk triaged T27900: Reference typo in mitkPlanarEllipse.cpp as Low priority.
Oct 20 2020, 11:59 AM · MITK
kislinsk merged task T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism into T27701: Overhaul or remove PluginGenerator.
Oct 20 2020, 9:11 AM · Request for Discussion, MITK
kislinsk merged T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism into T27701: Overhaul or remove PluginGenerator.
Oct 20 2020, 9:11 AM · MITK, Next Milestone

Oct 19 2020

kislinsk added a comment to T27894: Linux nightly installer doesn't start on Fedora.

Agree, but we should definitely package Python instead of relying on system python in any case as there are more strings attached. Even between minor Python updates there are imcompatibilities especially when SWIG is involved. Also we rely on certain Python packages like numpy or SimpleITK. So the plan is:

Oct 19 2020, 1:44 PM · MITK (v2021.02)
kislinsk added a parent task for T27894: Linux nightly installer doesn't start on Fedora: T27196: Rewrite packaging of MITK.
Oct 19 2020, 1:19 PM · MITK (v2021.02)
kislinsk added a subtask for T27196: Rewrite packaging of MITK: T27894: Linux nightly installer doesn't start on Fedora.
Oct 19 2020, 1:19 PM · Moved to git.dkfz.de, MITK, Cleared
kislinsk triaged T27894: Linux nightly installer doesn't start on Fedora as Normal priority.
Oct 19 2020, 1:18 PM · MITK (v2021.02)
kislinsk merged T26258: MITK and python only works with the specific python version the installer was created with into T27894: Linux nightly installer doesn't start on Fedora.
Oct 19 2020, 1:18 PM · MITK (v2021.02)
kislinsk merged task T26258: MITK and python only works with the specific python version the installer was created with into T27894: Linux nightly installer doesn't start on Fedora.
Oct 19 2020, 1:18 PM · MITK
kislinsk added a comment to T27894: Linux nightly installer doesn't start on Fedora.

I guess this is not specific to Fedora (not even to Linux) as we do not yet package python into the installer as far as I know. As this task is a bit moe vorbose than T26258: MITK and python only works with the specific python version the installer was created with, I will close the other one as duplicate.

Oct 19 2020, 1:18 PM · MITK (v2021.02)
kislinsk added a subtask for T27196: Rewrite packaging of MITK: T26258: MITK and python only works with the specific python version the installer was created with.
Oct 19 2020, 1:16 PM · Moved to git.dkfz.de, MITK, Cleared
kislinsk added a parent task for T26258: MITK and python only works with the specific python version the installer was created with: T27196: Rewrite packaging of MITK.
Oct 19 2020, 1:16 PM · MITK
kislinsk added a revision to T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation: Unknown Object (Differential Revision).
Oct 19 2020, 1:13 PM · MITK (v2021.02)
kislinsk claimed T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation.
Oct 19 2020, 12:51 PM · MITK (v2021.02)

Oct 16 2020

kislinsk added a comment to T27851: Unhide label presets.
  • I renamed the context menu entries to Load/Save LabelSet Preset
  • I made these actions also available as tool buttons in the Multilabel Segmentation View
  • I fixed quite a few bugs in the loading mechanism
    • Existing label properties are now overridden by a preset
    • Layers/labels in other layers work now
    • The state of the Multilabel Segmentation View is now updated after a preset was loaded
Oct 16 2020, 10:23 AM · MITK (v2021.02)
kislinsk added a comment to T27851: Unhide label presets.

Pushed new branch bugfix/T27851-FixLabelSetPresetsAndMakeThemMoreAccessible.

Oct 16 2020, 8:27 AM · MITK (v2021.02)

Oct 15 2020

kislinsk committed rMITK663e373e312f: Fix loop and data type in LevelWindow::SetAuto() (authored by kislinsk).
Fix loop and data type in LevelWindow::SetAuto()
Oct 15 2020, 6:57 PM
kislinsk closed T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto as Resolved by committing rMITK663e373e312f: Fix loop and data type in LevelWindow::SetAuto().
Oct 15 2020, 6:57 PM · MITK
kislinsk committed rMITKb04e68dba7f1: Fix loop and data type (authored by kislinsk).
Fix loop and data type
Oct 15 2020, 6:57 PM
kislinsk added a revision to T27851: Unhide label presets: Unknown Object (Differential Revision).
Oct 15 2020, 6:53 PM · MITK (v2021.02)
kislinsk closed T27887: Make package fails when using system Qt packages on Ubuntu 20.04 as Resolved.
Oct 15 2020, 4:24 PM · MITK
kislinsk added a comment to T27887: Make package fails when using system Qt packages on Ubuntu 20.04.

Deleted branch hotfix/T27887-fix-packaging-with-system-qt.

Oct 15 2020, 4:24 PM · MITK
kislinsk committed rMITKc25989b3eaa9: Merge remote-tracking branch 'origin/hotfix/T27887-fix-packaging-with-system… (authored by kislinsk).
Merge remote-tracking branch 'origin/hotfix/T27887-fix-packaging-with-system…
Oct 15 2020, 4:22 PM
kislinsk committed rMITK0f33cec9e310: Merge remote-tracking branch 'origin/hotfix/T27887-fix-packaging-with-system-qt' (authored by kislinsk).
Merge remote-tracking branch 'origin/hotfix/T27887-fix-packaging-with-system-qt'
Oct 15 2020, 4:22 PM
kislinsk claimed T27851: Unhide label presets.

The functionality is already in a separate class LabelSetIOHelper so it is not restricted to DataManager actions per se. The code in these actions is of pretty bad quality, though. The first step will be to clean up these actions. I will also rename the actions in the context menu to Load LabelSet Preset and Save LabelSet Preset to make them more distinguishable. Then I will look into the view to see if the functionality is already there somewhere or if we must add it. I also already noticed that while the preset files contain information about layers as well, only the labels of the first layer are loaded.

Oct 15 2020, 11:58 AM · MITK (v2021.02)
kislinsk added a revision to T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto: Unknown Object (Differential Revision).
Oct 15 2020, 9:49 AM · MITK
kislinsk added a comment to T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto.

Thanks for reporting. The whole method seems to be dubious. The lines of code you mentioned are plain wrong, the loop should start with k=1 and the data type of numPixelsInDataset should be more appropriate.

Oct 15 2020, 9:30 AM · MITK
kislinsk claimed T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto.
Oct 15 2020, 9:27 AM · MITK

Oct 14 2020

kislinsk edited projects for T27817: [Multilabel] Live Wire tool always assigns first label when being used with multiple labels, added: Cleared; removed Request for Discussion.
Oct 14 2020, 10:29 AM · Cleared, MITK (v2021.02)
kislinsk raised the priority of T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation from Normal to High.
Oct 14 2020, 10:24 AM · MITK (v2021.02)
kislinsk closed T27879: [CDash] CTEST_BUILD_NAME suffix feature as Resolved.
Oct 14 2020, 9:36 AM · MITK
kislinsk added a comment to T27879: [CDash] CTEST_BUILD_NAME suffix feature.

Deleted branch feature/T27879-MITK_BUILD_NAME_SUFFIX.

Oct 14 2020, 9:36 AM · MITK
kislinsk committed rMITK0a52c695f724: Merge branch 'feature/T27879-MITK_BUILD_NAME_SUFFIX' into develop (authored by kislinsk).
Merge branch 'feature/T27879-MITK_BUILD_NAME_SUFFIX' into develop
Oct 14 2020, 9:36 AM
kislinsk added a comment to T27879: [CDash] CTEST_BUILD_NAME suffix feature.

Pushed new branch feature/T27879-MITK_BUILD_NAME_SUFFIX.

Oct 14 2020, 9:35 AM · MITK
kislinsk triaged T27879: [CDash] CTEST_BUILD_NAME suffix feature as Wishlist priority.
Oct 14 2020, 9:34 AM · MITK

Oct 13 2020

kislinsk added a project to T26897: Build error: Could not find git for clone of qRestAPI: Noteworthy.
Oct 13 2020, 12:22 PM · Noteworthy, MITK
kislinsk added a comment to T27340: [ModelFit] Request for Mac Workbench installer.

Any details?

Oct 13 2020, 12:21 PM · Auto-closed, Restricted Project, MITK
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

Deleted branch bugfix/T26897-RemoveCustomFindGitModule.

Oct 13 2020, 12:18 PM · Noteworthy, MITK
kislinsk closed T26897: Build error: Could not find git for clone of qRestAPI as Resolved.

Should be fixed now.

Oct 13 2020, 12:15 PM · Noteworthy, MITK
kislinsk committed rMITKe02262024ec3: Merge branch 'bugfix/T26897-RemoveCustomFindGitModule' into develop (authored by kislinsk).
Merge branch 'bugfix/T26897-RemoveCustomFindGitModule' into develop
Oct 13 2020, 12:12 PM
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

I wonder how this is related to our findings from December last year.

Oct 13 2020, 11:53 AM · Noteworthy, MITK
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

Pushed new branch bugfix/T26897-RemoveCustomFindGitModule.

Oct 13 2020, 11:38 AM · Noteworthy, MITK
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

I noticed a few things that may be related or not but we should clean them anyway:

Oct 13 2020, 10:45 AM · Noteworthy, MITK
kislinsk closed T27852: [CDash] Add option to clean build directory as Resolved.
Oct 13 2020, 10:27 AM · MITK
kislinsk added a comment to T27852: [CDash] Add option to clean build directory.

Deleted branch feature/T27852-CDashAddOptionToCleanDirs.

Oct 13 2020, 10:27 AM · MITK
kislinsk committed rMITKaabd0623f1d6: Merge branch 'feature/T27852-CDashAddOptionToCleanDirs' into develop (authored by kislinsk).
Merge branch 'feature/T27852-CDashAddOptionToCleanDirs' into develop
Oct 13 2020, 10:26 AM
kislinsk added a comment to T27852: [CDash] Add option to clean build directory.

You can add the following options to your configuration script:

Oct 13 2020, 10:25 AM · MITK
kislinsk added a comment to T27852: [CDash] Add option to clean build directory.

Pushed new branch feature/T27852-CDashAddOptionToCleanDirs.

Oct 13 2020, 10:22 AM · MITK
kislinsk moved T27844: CDash links to commits in phabricator seems not to work correctly from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Oct 13 2020, 9:41 AM · Restricted Project, Restricted Project, MITK

Oct 12 2020

kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

May be completely unrelated but who knows: https://cmake.org/pipermail/cmake-developers/2015-November/027082.html

Oct 12 2020, 11:44 PM · Noteworthy, MITK
kislinsk triaged T27852: [CDash] Add option to clean build directory as Low priority.
Oct 12 2020, 11:15 AM · MITK
kislinsk updated the task description for T27851: Unhide label presets.
Oct 12 2020, 10:52 AM · MITK (v2021.02)
kislinsk triaged T27851: Unhide label presets as High priority.
Oct 12 2020, 10:51 AM · MITK (v2021.02)
kislinsk closed T27849: MITK extensions do not work in CDash script on Linux and macOS as Resolved.
Oct 12 2020, 10:35 AM · MITK