Page MenuHomePhabricator
Feed Advanced Search

Jan 9 2020

kislinsk edited projects for T26966: [Segmentation] Help button in threshold dialogs have no function, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK
kislinsk edited projects for T26967: [Segmentation] Pressing the X button on threshold confirm dialogs does not stop the execution, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · Restricted Project, Cleared, MITK (v2021.02)
kislinsk edited projects for T26968: [DataManager] "Show only selected nodes" button causes 2D widgets in the 3D renderwindow to vanish , added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · Auto-closed, MITK
kislinsk edited projects for T26972: Dialog and plugin layout seems to be not shown correctly on laptops, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK (v2024.06), Missing Info
kislinsk edited projects for T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK (v2021.02)
kislinsk edited projects for T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · Missing Info, MITK (v2021.02)
kislinsk edited projects for T26974: [Segmentation] Region Growing 3D with 4D dataset not working, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK (v2021.02)
kislinsk edited projects for T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · Request for Discussion, Missing Info, MITK (v2021.02)
kislinsk edited projects for T26979: Error when loading a measurement or pointset and then an image, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · Request for Discussion, Cleared, MITK (v2021.02)
kislinsk edited projects for T26980: MITK_CREATE_MACRO should prohibit dependencies against autoload modules, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK, Noteworthy
kislinsk edited projects for T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · Cleared, MITK (v2021.02)
kislinsk edited projects for T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK
kislinsk committed rMITK7b5540fce06a: Remove moc header files without Qt classes (authored by kislinsk).
Remove moc header files without Qt classes
Jan 9 2020, 10:36 AM
kislinsk committed rMITK4b302e31d894: Remove unused code (authored by kislinsk).
Remove unused code
Jan 9 2020, 10:08 AM
kislinsk added a comment to T26977: Fix Nightly warnings.

Pushed new branch T26977-FixWarnings.

Jan 9 2020, 10:07 AM · MITK
kislinsk triaged T26977: Fix Nightly warnings as Low priority.
Jan 9 2020, 9:44 AM · MITK
kislinsk committed rMITK16c4a3d324d0: Remove invalid link-time dependency to auto-load service (authored by kislinsk).
Remove invalid link-time dependency to auto-load service
Jan 9 2020, 8:56 AM
kislinsk added a comment to T26976: PythonQt is not installed on macOS when creating an MITK installer.

Also, BasicImageProcessing has an invalid link-time dependency to the auto-load service MatchPointRegistrationIO. We should consider extending our mitk_create_module macro to check if there's a link-time dependency to a service.

Jan 9 2020, 8:48 AM · MITK
kislinsk committed rMITK6e1b92791898: Manually install PythonQt (authored by kislinsk).
Manually install PythonQt
Jan 9 2020, 8:35 AM
kislinsk added a comment to T26976: PythonQt is not installed on macOS when creating an MITK installer.

Pushed new branch T26976-InstallPythonQtOnMacOs.

Jan 9 2020, 8:34 AM · MITK
kislinsk triaged T26976: PythonQt is not installed on macOS when creating an MITK installer as Normal priority.
Jan 9 2020, 8:32 AM · MITK

Jan 8 2020

kislinsk closed T26971: MitkREST module tests affect each other when run in parallel as Resolved.
Jan 8 2020, 3:02 PM · MITK
kislinsk closed T26971: MitkREST module tests affect each other when run in parallel, a subtask of T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients, as Resolved.
Jan 8 2020, 3:02 PM · MITK
kislinsk committed rMITK8abd6f7dca36: Merge branch 'T26971-RunRESTTestsSerial' (authored by kislinsk).
Merge branch 'T26971-RunRESTTestsSerial'
Jan 8 2020, 3:02 PM
kislinsk committed rMITK86879bb05edd: Run tests serial (authored by kislinsk).
Run tests serial
Jan 8 2020, 3:01 PM
kislinsk added a comment to T26971: MitkREST module tests affect each other when run in parallel.

Pushed new branch T26971-RunRESTTestsSerial.

Jan 8 2020, 3:01 PM · MITK
kislinsk triaged T26971: MitkREST module tests affect each other when run in parallel as Normal priority.
Jan 8 2020, 3:00 PM · MITK
kislinsk renamed T26966: [Segmentation] Help button in threshold dialogs have no function from Help button in dialogs have no function to [Segmentation] Help button in threshold dialogs have no function.
Jan 8 2020, 2:19 PM · MITK
kislinsk renamed T26967: [Segmentation] Pressing the X button on threshold confirm dialogs does not stop the execution from Pressing the X button on Confirm dialogs does not stop the execution to [Segmentation] Pressing the X button on threshold confirm dialogs does not stop the execution.
Jan 8 2020, 2:18 PM · Restricted Project, Cleared, MITK (v2021.02)
kislinsk closed T26965: MitkREST module tests fail on Windows when executed via ctest but work when executed directly, a subtask of T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients, as Resolved.
Jan 8 2020, 2:17 PM · MITK
kislinsk closed T26965: MitkREST module tests fail on Windows when executed via ctest but work when executed directly as Resolved.
Jan 8 2020, 2:17 PM · MITK
kislinsk committed rMITK49cd8819e818: Merge branch 'T26965-FixTestPathEnv' (authored by kislinsk).
Merge branch 'T26965-FixTestPathEnv'
Jan 8 2020, 2:14 PM
kislinsk committed rMITK9fe461be1f57: Append to PATH instead of overriding PATH (authored by kislinsk).
Append to PATH instead of overriding PATH
Jan 8 2020, 2:12 PM
kislinsk added a comment to T26965: MitkREST module tests fail on Windows when executed via ctest but work when executed directly.

Pushed new branch T26965-FixTestPathEnv.

Jan 8 2020, 2:12 PM · MITK
kislinsk triaged T26965: MitkREST module tests fail on Windows when executed via ctest but work when executed directly as Normal priority.
Jan 8 2020, 2:10 PM · MITK

Jan 7 2020

kislinsk closed T26955: MitkQtPythonTest fails because of missing library dependencies on Linux as Resolved.
Jan 7 2020, 4:33 PM · MITK
kislinsk closed T26955: MitkQtPythonTest fails because of missing library dependencies on Linux, a subtask of T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients, as Resolved.
Jan 7 2020, 4:33 PM · MITK
kislinsk committed rMITK113ddd8808d2: Merge branch 'T26955-FixPythonTestEnv' (authored by kislinsk).
Merge branch 'T26955-FixPythonTestEnv'
Jan 7 2020, 4:33 PM
kislinsk committed rMITK8b6094784d76: Reactivate test on Windows (authored by kislinsk).
Reactivate test on Windows
Jan 7 2020, 4:32 PM
kislinsk added a comment to T19153: Python tests can't be run on the dartclient on Windows.

We noticed in T26955 that the test is able to run on Windows.

Jan 7 2020, 4:31 PM · Bugzilla, MITK
kislinsk committed rMITK1260dfb17afe: Add hint to Phabricator task. (authored by kislinsk).
Add hint to Phabricator task.
Jan 7 2020, 4:22 PM
kislinsk committed rMITKb89b18f9faa8: Use LD_LIBRARY_PATH to execute mitkPythonTest (authored by kislinsk).
Use LD_LIBRARY_PATH to execute mitkPythonTest
Jan 7 2020, 4:19 PM
kislinsk added a comment to T26955: MitkQtPythonTest fails because of missing library dependencies on Linux.

Pushed new branch T26955-FixPythonTestEnv.

Jan 7 2020, 4:18 PM · MITK
kislinsk triaged T26955: MitkQtPythonTest fails because of missing library dependencies on Linux as Normal priority.
Jan 7 2020, 12:52 PM · MITK

Dec 23 2019

kislinsk triaged T26949: DICOM SEG - 3D segmentations with only one slice cannot be reloaded as DICOM SEG as Normal priority.
Dec 23 2019, 2:55 PM · Auto-closed, MITK, DICOM, Missing Info
kislinsk triaged T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object as Normal priority.
Dec 23 2019, 2:54 PM · MITK (v2024.06)
kislinsk triaged T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG as Normal priority.
Dec 23 2019, 2:54 PM · MITK (v2024.06), Cleared
kislinsk closed T26954: Use Visual Studio project folder feature for MITK and MITK extensions as Resolved.
Dec 23 2019, 2:53 PM · MITK, Noteworthy
kislinsk added a comment to T26954: Use Visual Studio project folder feature for MITK and MITK extensions.

In Visual Studio, all MITK targets are now categorized in folders. MITK extension targets have their own root folder.

Dec 23 2019, 2:53 PM · MITK, Noteworthy
kislinsk committed rMITKfcd6631834ea: Merge branch 'T26954-UseFolders' into releases/2018-04 (authored by kislinsk).
Merge branch 'T26954-UseFolders' into releases/2018-04
Dec 23 2019, 2:52 PM
kislinsk committed rMITK0e0bcfc78ed1: Merge remote-tracking branch 'origin/T26954-UseFolders' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26954-UseFolders'
Dec 23 2019, 2:51 PM
kislinsk committed rMITK8e156483616c: Merge remote-tracking branch 'origin/T26954-UseFolders' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26954-UseFolders'
Dec 23 2019, 2:51 PM
kislinsk committed rMITK51ee1c19203d: Merge remote-tracking branch 'origin/T26954-UseFolders' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26954-UseFolders'
Dec 23 2019, 2:51 PM
kislinsk committed rMITKe3782b339f55: Merge remote-tracking branch 'origin/T26954-UseFolders' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26954-UseFolders'
Dec 23 2019, 2:51 PM
kislinsk committed rMITK02265dcc26d1: Move MatchPointAlgorithms into Modules (authored by kislinsk).
Move MatchPointAlgorithms into Modules
Dec 23 2019, 2:51 PM
kislinsk committed rMITKbac1e5791cb9: Mix missing property name (authored by kislinsk).
Mix missing property name
Dec 23 2019, 2:45 PM
kislinsk committed rMITKc57f76b198ca: Put command-line apps into Modules/Executables folder (authored by kislinsk).
Put command-line apps into Modules/Executables folder
Dec 23 2019, 2:45 PM
kislinsk committed rMITKac1c3bd39b0f: Categorize remaining targets (authored by kislinsk).
Categorize remaining targets
Dec 23 2019, 2:38 PM
kislinsk committed rMITKf04b1ca5b861: Use folders for target/project organization (authored by kislinsk).
Use folders for target/project organization
Dec 23 2019, 2:10 PM
kislinsk added a comment to T26954: Use Visual Studio project folder feature for MITK and MITK extensions.

Pushed new branch T26954-UseFolders.

Dec 23 2019, 2:10 PM · MITK, Noteworthy
kislinsk triaged T26954: Use Visual Studio project folder feature for MITK and MITK extensions as Wishlist priority.
Dec 23 2019, 1:59 PM · MITK, Noteworthy

Dec 20 2019

kislinsk added a comment to T26930: Crash Ubuntu 18.04.3 Qt 5.12.4.

TL;DR: MitkWorkbench --BlueBerry.clean works again.

Dec 20 2019, 8:03 PM · MITK
kislinsk closed T26930: Crash Ubuntu 18.04.3 Qt 5.12.4 as Resolved.
Dec 20 2019, 8:00 PM · MITK
kislinsk added a comment to T26930: Crash Ubuntu 18.04.3 Qt 5.12.4.

It's a GCC bug that bit us in the past already and that's why we were pre-loading org.mitk.gui.qt.common. Now it's org.blueberry.core.expressions.

Dec 20 2019, 8:00 PM · MITK
kislinsk committed rMITKba83f51a8ff9: Merge branch 'T26930-FixPreloading' (authored by kislinsk).
Merge branch 'T26930-FixPreloading'
Dec 20 2019, 7:46 PM
kislinsk committed rMITKf22aa6c62e6b: Fix pre-loading of org.blueberry.core.expressions (authored by kislinsk).
Fix pre-loading of org.blueberry.core.expressions
Dec 20 2019, 7:39 PM
kislinsk added a comment to T26930: Crash Ubuntu 18.04.3 Qt 5.12.4.

Pushed new branch T26930-FixPreloading.

Dec 20 2019, 7:39 PM · MITK
kislinsk claimed T26930: Crash Ubuntu 18.04.3 Qt 5.12.4.
Dec 20 2019, 7:23 PM · MITK
kislinsk closed T26942: Crash on DICOM loading as Resolved.
Dec 20 2019, 3:30 PM · DICOM, Kaapana (internal), MITK
kislinsk committed rMITKfc9eb6fb17b5: Merge branch 'T26942-ImproveCESTPrivateTagParsing' (authored by kislinsk).
Merge branch 'T26942-ImproveCESTPrivateTagParsing'
Dec 20 2019, 3:28 PM
kislinsk committed rMITKd51de1cd1846: Fix wrong assumption made about ASCII format (authored by kislinsk).
Fix wrong assumption made about ASCII format
Dec 20 2019, 3:27 PM
kislinsk reopened T26942: Crash on DICOM loading as "Open".

CI

Dec 20 2019, 12:48 PM · DICOM, Kaapana (internal), MITK
kislinsk changed the edit policy for Photoacoustics.
Dec 20 2019, 12:03 PM
kislinsk committed rMITK926e62c0b205: Merge branch 'T26942-ImproveCESTPrivateTagParsing' (authored by kislinsk).
Merge branch 'T26942-ImproveCESTPrivateTagParsing'
Dec 20 2019, 11:59 AM
kislinsk committed rMITK2abe8ed53c56: Make parsing even more robust against unexpected input (authored by kislinsk).
Make parsing even more robust against unexpected input
Dec 20 2019, 11:58 AM
kislinsk committed rMITK36f887654582: Merge branch 'T26944-ClearBorderOfRenderWindowMenuButtons' (authored by kislinsk).
Merge branch 'T26944-ClearBorderOfRenderWindowMenuButtons'
Dec 20 2019, 10:09 AM
kislinsk committed rMITKfbc49fc5c831: Prevent stylesheet inheritance in first place (authored by kislinsk).
Prevent stylesheet inheritance in first place
Dec 20 2019, 10:08 AM
kislinsk committed rMITKfb7ccddc0b51: Merge branch 'T26942-ImproveCESTPrivateTagParsing' (authored by kislinsk).
Merge branch 'T26942-ImproveCESTPrivateTagParsing'
Dec 20 2019, 10:01 AM
kislinsk committed rMITK66d2e034ea99: Use std::size type for length and offset (authored by kislinsk).
Use std::size type for length and offset
Dec 20 2019, 10:00 AM
kislinsk closed T26942: Crash on DICOM loading as Resolved.
Dec 20 2019, 9:55 AM · DICOM, Kaapana (internal), MITK
kislinsk committed rMITK6a9ff80fa313: Merge branch 'T26942-ImproveCESTPrivateTagParsing' (authored by kislinsk).
Merge branch 'T26942-ImproveCESTPrivateTagParsing'
Dec 20 2019, 9:55 AM
kislinsk committed rMITKaef3aa0e5c16: Improve and fix parsing of private tags (authored by kislinsk).
Improve and fix parsing of private tags
Dec 20 2019, 9:54 AM
kislinsk added a comment to T26942: Crash on DICOM loading.

Pushed new branch T26942-ImproveCESTPrivateTagParsing.

Dec 20 2019, 9:54 AM · DICOM, Kaapana (internal), MITK
kislinsk claimed T26942: Crash on DICOM loading.
Dec 20 2019, 9:40 AM · DICOM, Kaapana (internal), MITK
kislinsk added a comment to T26942: Crash on DICOM loading.

Despite all of the obvious flaws of the parsing code around the highlighted line linked above, the particular reason for the crash is a missing check against npos regarding the results of the find() calls. Even without a more comprehensive fix, the hex number string extraction and conversion to ASCII characters should be enhanced by checking against non-ASCII hex values.

Dec 20 2019, 9:13 AM · DICOM, Kaapana (internal), MITK
kislinsk added a comment to T26942: Crash on DICOM loading.

@k656s Is the example data available on our network drives?

Dec 20 2019, 9:09 AM · DICOM, Kaapana (internal), MITK
kislinsk committed rMDe714e4a9628a: Fix layer and value property types (authored by kislinsk).
Fix layer and value property types
Dec 20 2019, 6:03 AM
kislinsk committed rMITK69f7f38253f8: Merge branch 'T26944-ClearBorderOfRenderWindowMenuButtons' (authored by kislinsk).
Merge branch 'T26944-ClearBorderOfRenderWindowMenuButtons'
Dec 20 2019, 5:44 AM
kislinsk closed T26944: Render window menu buttons have render window widget decoration border on Linux as Resolved.
Dec 20 2019, 5:44 AM · MITK
kislinsk committed rMITKcb13b3acdb1f: Explicitly clear border of render window menu buttons (authored by kislinsk).
Explicitly clear border of render window menu buttons
Dec 20 2019, 5:44 AM
kislinsk added a comment to T26944: Render window menu buttons have render window widget decoration border on Linux.

Pushed new branch T26944-ClearBorderOfRenderWindowMenuButtons.

Dec 20 2019, 5:44 AM · MITK
kislinsk triaged T26944: Render window menu buttons have render window widget decoration border on Linux as Low priority.
Dec 20 2019, 5:41 AM · MITK
kislinsk closed T26943: "Show crosshair" render window menu item has wrong default as Resolved.
Dec 20 2019, 5:32 AM · MITK
kislinsk committed rMITKd02a92d0a398: Merge branch 'T26943-FixShowCrosshair' (authored by kislinsk).
Merge branch 'T26943-FixShowCrosshair'
Dec 20 2019, 5:28 AM
kislinsk committed rMITK8199d2f06739: Fix default visibility of crosshair in render window menu (authored by kislinsk).
Fix default visibility of crosshair in render window menu
Dec 20 2019, 5:28 AM
kislinsk added a comment to T26943: "Show crosshair" render window menu item has wrong default.

Pushed new branch T26943-FixShowCrosshair.

Dec 20 2019, 5:27 AM · MITK
kislinsk triaged T26943: "Show crosshair" render window menu item has wrong default as Normal priority.
Dec 20 2019, 5:26 AM · MITK

Dec 19 2019

kislinsk updated the task description for T26150: Build tree version of MitkWorkbench crashes twice before eventually starting on Ubuntu with GCC.
Dec 19 2019, 4:50 PM · MITK (2018-04-2)
kislinsk renamed T26941: MITK_USE_Python3 and CMake 3.16 does not work from MITK_USE_Python3 and CMake 3.16 does not work (bug in CMake 3.16) to MITK_USE_Python3 and CMake 3.16 does not work.
Dec 19 2019, 4:27 PM · MITK
kislinsk committed rMITK85205724ec57: Merge branch 'T26941-WorkaroundCMake3.16' (authored by kislinsk).
Merge branch 'T26941-WorkaroundCMake3.16'
Dec 19 2019, 4:26 PM