Page MenuHomePhabricator
Feed Advanced Search

Mar 23 2020

kislinsk added a comment to T27243: DICOM plugin depends on autoload module.

Pushed new branch T27243-FixAutoloadDependency.

Mar 23 2020, 10:41 AM · MITK (v2021.02)
kislinsk claimed T27243: DICOM plugin depends on autoload module.
Mar 23 2020, 9:57 AM · MITK (v2021.02)

Mar 20 2020

kislinsk closed T27245: Set Doxygen output dir before extension point documentation handling as Resolved.
Mar 20 2020, 5:22 AM · MITK
kislinsk committed rMITK1fc10de191fa: Merge branch 'T27245-DoxygenExtensionPoint' (authored by kislinsk).
Merge branch 'T27245-DoxygenExtensionPoint'
Mar 20 2020, 5:22 AM
kislinsk committed rMITK1e07bc112a98: Prevent creation of directory in root directory (authored by kislinsk).
Prevent creation of directory in root directory
Mar 20 2020, 5:21 AM
kislinsk added a comment to T27245: Set Doxygen output dir before extension point documentation handling.

Pushed new branch T27245-DoxygenExtensionPoint.

Mar 20 2020, 5:21 AM · MITK
kislinsk triaged T27245: Set Doxygen output dir before extension point documentation handling as Low priority.
Mar 20 2020, 5:18 AM · MITK

Mar 19 2020

kislinsk updated the task description for T27243: DICOM plugin depends on autoload module.
Mar 19 2020, 4:27 PM · MITK (v2021.02)
kislinsk triaged T27243: DICOM plugin depends on autoload module as High priority.
Mar 19 2020, 4:26 PM · MITK (v2021.02)
kislinsk closed T27087: Remove Autoload-Modul-Workarround in the FixMacOS script as Resolved.

Was removed meanwhile and revealed errors regarding plugins that depend on autoload modules.

Mar 19 2020, 4:22 PM · MITK
kislinsk renamed T27242: Exclude test drivers from packaging from Fix MITK packaging to Exclude test drivers from packaging.
Mar 19 2020, 4:20 PM · MITK (v2021.02)
kislinsk committed rMITK5a51e19f7bd4: Merge branch 'T27242-FixPackaging' (authored by kislinsk).
Merge branch 'T27242-FixPackaging'
Mar 19 2020, 4:19 PM
kislinsk committed rMITKe89106816638: Do not package test drivers (authored by kislinsk).
Do not package test drivers
Mar 19 2020, 3:03 PM
kislinsk added a comment to T27242: Exclude test drivers from packaging.

Pushed new branch T27242-FixPackaging.

Mar 19 2020, 3:03 PM · MITK (v2021.02)
kislinsk triaged T27242: Exclude test drivers from packaging as High priority.
Mar 19 2020, 3:01 PM · MITK (v2021.02)

Mar 17 2020

kislinsk created challengeR.
Mar 17 2020, 12:40 PM

Mar 16 2020

kislinsk updated subscribers of T23345: Save nrrd segmentation as DICOM.
Mar 16 2020, 3:49 PM · Auto-closed, MITK
kislinsk triaged T27187: MitkCLMatchPointReg silently not built. as Normal priority.
Mar 16 2020, 3:40 PM · Auto-closed, MITK
kislinsk triaged T27189: REST API for data storage as Wishlist priority.
Mar 16 2020, 3:38 PM · MITK (v2024.06), Restricted Project, Request for Discussion

Mar 10 2020

kislinsk committed rMITK389bf1243c68: Merge remote-tracking branch 'origin/T27170-MinimalBuild' (authored by kislinsk).
Merge remote-tracking branch 'origin/T27170-MinimalBuild'
Mar 10 2020, 10:16 AM
kislinsk committed rMITK6fac19f31b83: Explicitly disable Qwt (authored by kislinsk).
Explicitly disable Qwt
Mar 10 2020, 9:53 AM

Mar 9 2020

kislinsk added a comment to T27206: Use new Qt5 signal-slot syntax.

The recommended way of using QtOverload seems to be via macros in C++14 (our minimum C++ standard). There are also macros for const overloads and explicitly non-const overloads:
https://doc.qt.io/qt-5/qtglobal.html#qOverload

Mar 9 2020, 10:40 AM · Auto-closed, MITK
kislinsk added a comment to T27206: Use new Qt5 signal-slot syntax.

+1

Mar 9 2020, 10:37 AM · Auto-closed, MITK
kislinsk added a comment to T27206: Use new Qt5 signal-slot syntax.

Also, concerning the super ugly version, I did this sometimes (although I'd prefer the QtOverload-way):

connect(mySpinBox, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged), mySlider, &QSlider::setValue);
Mar 9 2020, 10:01 AM · Auto-closed, MITK

Mar 7 2020

kislinsk renamed T27203: QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux from QmitkAbstractNodeSelectionWidgetTest regularily fails on headless Linux to QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux.
Mar 7 2020, 7:35 AM · MITK
kislinsk closed T27203: QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux as Resolved.
Mar 7 2020, 7:34 AM · MITK
kislinsk added a comment to T27206: Use new Qt5 signal-slot syntax.

That's a bit extrem. I wouldn't call the following statement super multiline or verbose:

connect(mySpinBox,  QtOverload<int>::of(&QSpinBox::valueChanged), this, &MyClass::OnChange);
Mar 7 2020, 7:33 AM · Auto-closed, MITK

Mar 6 2020

kislinsk added a comment to T27206: Use new Qt5 signal-slot syntax.

Note that this is an alternative syntax, not a successor. For example, you can't use the new syntax for overloaded signals like valueChanged(int/double) of QSpinBox, or to be precise, it is possible but super ugly, verbose and multi-line. So I wouldn't recommend to systematically change everything to the modern C++ syntax but I think it is worth it to take lambdas into account which could result in the removal of quite some short slots that otherwiese are boilerplate with there declaration and definition compared to a single-line lambda.

Mar 6 2020, 8:48 PM · Auto-closed, MITK
kislinsk committed rMITK513cb3889ee3: Use Qt platform "minimal" on Linux (headless) for… (authored by kislinsk).
Use Qt platform "minimal" on Linux (headless) for…
Mar 6 2020, 4:12 PM
kislinsk committed rMITK115a857bb5e4: Improve variable name (authored by kislinsk).
Improve variable name
Mar 6 2020, 3:44 PM
kislinsk added a revision to T27203: QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux: Unknown Object (Differential Revision).
Mar 6 2020, 3:09 PM · MITK
kislinsk committed rMITK8a3f766249ae: Use Qt platform "minimal" on Linux (authored by kislinsk).
Use Qt platform "minimal" on Linux
Mar 6 2020, 3:05 PM
kislinsk added a comment to T27203: QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux.

Pushed new branch T27203-FixQmitkAbstractNodeSelectionTestOnHeadlessLinux.

Mar 6 2020, 3:05 PM · MITK
kislinsk triaged T27203: QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux as Normal priority.
Mar 6 2020, 2:58 PM · MITK
kislinsk committed rMITKa4e34a157e98: Merge branch 'T27170-MinimalBuild' (authored by kislinsk).
Merge branch 'T27170-MinimalBuild'
Mar 6 2020, 10:33 AM
kislinsk committed rMITKab6051b64c9f: Move external project iteration above build configuration handling (authored by kislinsk).
Move external project iteration above build configuration handling
Mar 6 2020, 10:33 AM

Mar 5 2020

kislinsk updated the task description for T27196: Rewrite packaging of MITK.
Mar 5 2020, 12:07 PM · MITK (v2024.06), Cleared
kislinsk triaged T27196: Rewrite packaging of MITK as High priority.
Mar 5 2020, 12:07 PM · MITK (v2024.06), Cleared
kislinsk closed T27170: Revise minimal build configuration as Resolved.
Mar 5 2020, 12:00 PM · MITK
kislinsk added a comment to T27170: Revise minimal build configuration.

This seems to break packaging on macOS. I merged into the master anyway as I will now to continue to completely rewrite our packaging.

Mar 5 2020, 12:00 PM · MITK
kislinsk committed rMITK42355e69db60: Merge branch 'T27170-MinimalBuild' (authored by kislinsk).
Merge branch 'T27170-MinimalBuild'
Mar 5 2020, 11:59 AM
kislinsk added a comment to T27190: Clang format style for * and & at variables.

Agree, but I also recommend to disable the auto-formatting in VS2019, as we had quite some inconsistencies in the past with it. When we agreed on a final clang-format, we should apply it to the whole code base (master) and after that look into reenabling the feature in VS2019.

Mar 5 2020, 11:35 AM · Request for Discussion, MITK
kislinsk added a member for MITK Reviewer Group I: kalali.
Mar 5 2020, 11:11 AM
kislinsk renamed MITK Reviewer Group I from MITK Reviewers Group I to MITK Reviewer Group I.
Mar 5 2020, 10:54 AM
kislinsk renamed MITK Reviewer Group I from MITK Core Reviewers to MITK Reviewers Group I.
Mar 5 2020, 10:54 AM

Mar 4 2020

kislinsk committed rMITK6c7b4a97a43a: Fix packaged auto-load modules on Linux (authored by kislinsk).
Fix packaged auto-load modules on Linux
Mar 4 2020, 2:55 PM
kislinsk committed rMITKc9c3c2aeaf84: Fix variable name of executable target (authored by kislinsk).
Fix variable name of executable target
Mar 4 2020, 2:55 PM
kislinsk committed rMITK44546b9bc5ff: Remove redundant install code and move executable install code to… (authored by kislinsk).
Remove redundant install code and move executable install code to…
Mar 4 2020, 1:31 PM
kislinsk committed rMITKaeee9d2ccc46: Introduce global property containing all executable "modules" (authored by kislinsk).
Introduce global property containing all executable "modules"
Mar 4 2020, 1:31 PM
kislinsk committed rMITK41365825c890: Remove old Qt install code (authored by kislinsk).
Remove old Qt install code
Mar 4 2020, 1:31 PM
kislinsk created MITK (v2021.02).
Mar 4 2020, 11:39 AM
kislinsk added a reverting change for rMITKe1bef4e60f54: Move installing of auto-load modules to mitkInstallRules.cmake: rMITK035034f72f0f: Revert "Move installing of auto-load modules to mitkInstallRules.cmake".
Mar 4 2020, 11:24 AM
kislinsk committed rMITK035034f72f0f: Revert "Move installing of auto-load modules to mitkInstallRules.cmake" (authored by kislinsk).
Revert "Move installing of auto-load modules to mitkInstallRules.cmake"
Mar 4 2020, 11:24 AM

Mar 3 2020

kislinsk triaged T27186: New segmentation behaviour can be confusing as High priority.
Mar 3 2020, 4:12 PM · MITK
kislinsk triaged T27181: MITK - DICOM Seg - not saved when started without terminal as High priority.
Mar 3 2020, 4:12 PM · Cleared, MITK (v2021.02)
kislinsk triaged T27184: Clipping plane deformation tool doesn't show updates in 3d window as Normal priority.

Please do set the priority when creating an MITK task.

Mar 3 2020, 4:11 PM · Next Milestone, MITK, Missing Info, Restricted Project
kislinsk committed rMITKe1bef4e60f54: Move installing of auto-load modules to mitkInstallRules.cmake (authored by kislinsk).
Move installing of auto-load modules to mitkInstallRules.cmake
Mar 3 2020, 3:43 PM
kislinsk committed rMITK49c52af7bcef: Remove temporary fix (authored by kislinsk).
Remove temporary fix
Mar 3 2020, 3:43 PM
kislinsk added a comment to T27170: Revise minimal build configuration.

Set MITK_WHITELIST in build configuration so the configuration in the example above is now easier/shorter. You don't have to set the MITK_WHITELIST anymore, only the MITK_BUILD_CONFIGURATION.

Mar 3 2020, 12:28 PM · MITK
kislinsk committed rMITKf8c89ee7168a: Set CoreCmdApps whitelist in CoreCmdApps build config (authored by kislinsk).
Set CoreCmdApps whitelist in CoreCmdApps build config
Mar 3 2020, 12:27 PM
kislinsk added a comment to T27170: Revise minimal build configuration.

The packaging does actually work contrary to what I wrote above, as I missed the .sh scripts that are necessary to start the actual executables. However, it does NOT copy the autoload services which is possibly the last TODO in this task.

Mar 3 2020, 12:11 PM · MITK
kislinsk added a comment to T27170: Revise minimal build configuration.

I added all the DICOM-related IO services to the whitelist and renamed the build configuration/whitelist from MinimalCmdApps to CoreCmdApps. I adapt the example above to reflect the changes.

Mar 3 2020, 12:09 PM · MITK
kislinsk committed rMITK51e60d5703b5: Rename MinimalCmdApps to CoreCmdApps (authored by kislinsk).
Rename MinimalCmdApps to CoreCmdApps
Mar 3 2020, 12:08 PM
kislinsk committed rMITK5d86d1a893fa: Add auto-load modules for DICOM IO (authored by kislinsk).
Add auto-load modules for DICOM IO
Mar 3 2020, 12:07 PM
kislinsk added a comment to T27176: MITK - DICOM Seg - load created files.

So adding a DICOM SEG to a directory already containing other DICOM files makes MITK unable to load the original DICOM files anymore.

Mar 3 2020, 9:59 AM · Missing Info, MITK (v2021.02)
kislinsk added a comment to T27178: MITK - DICOM Seg - loaded DCM SEG not associated with referenced DCM .

Is it still a non-trivial thing? I thought we already have the possibility to handle DICOM references? I may miss the point here but when loading a DICOM image with a reference ID or whatever it is called and if this referenced image is present in the current scene, it should be taken into account, right?

Mar 3 2020, 9:56 AM · Auto-closed, Missing Info, MITK

Mar 2 2020

kislinsk committed rMITKbad8a11d294c: Merge branch 'T27170-MinimalBuild' (authored by kislinsk).
Merge branch 'T27170-MinimalBuild'
Mar 2 2020, 3:55 PM
kislinsk committed rMITK5eaf2c0b0fb8: Move build configuration processing before Qt handling (authored by kislinsk).
Move build configuration processing before Qt handling
Mar 2 2020, 3:14 PM
kislinsk committed rMITK0320e9daaef1: Fix missing quotes (authored by kislinsk).
Fix missing quotes
Mar 2 2020, 2:23 PM
kislinsk closed T27172: Update supported platforms as Resolved.
Mar 2 2020, 12:29 PM · MITK
kislinsk committed rMITK2bb057a6115b: Merge branch 'T27172-UpdateSupportedPlatforms' (authored by kislinsk).
Merge branch 'T27172-UpdateSupportedPlatforms'
Mar 2 2020, 12:29 PM
kislinsk committed rMITK9cf1d15539bc: Update supported platforms (authored by kislinsk).
Update supported platforms
Mar 2 2020, 12:27 PM
kislinsk added a comment to T27172: Update supported platforms.

Pushed new branch T27172-UpdateSupportedPlatforms.

Mar 2 2020, 12:27 PM · MITK
kislinsk triaged T27172: Update supported platforms as Wishlist priority.
Mar 2 2020, 12:26 PM · MITK
kislinsk closed T27168: Fix default animation range for slice and time animations as Resolved.
Mar 2 2020, 9:35 AM · MITK

Feb 28 2020

kislinsk added a comment to T27170: Revise minimal build configuration.

The example above shows how to build MitkFileConverter in about 15 minutes. It uses Ninja as build system so do a sudo apt install ninja-build first. I also built the package target afterwards and it succeeded to package everything in a relocatable tarball, however, when executing the packaged MitkFileConverter, dependencies of MitkCommandline were missing. So this is something we have to investigate.

Feb 28 2020, 5:01 PM · MITK
kislinsk committed rMITK4325a085b302: Merge branch 'T27170-MinimalBuild' (authored by kislinsk).
Merge branch 'T27170-MinimalBuild'
Feb 28 2020, 4:55 PM
kislinsk added a comment to T27170: Revise minimal build configuration.
Build MitkFileConverter
# Shallow-clone latest master branch of MITK into MITK directory
git clone --depth=1 https://phabricator.mitk.org/source/mitk.git MITK
Feb 28 2020, 4:54 PM · MITK
kislinsk committed rMITKfddd47e6033c: Add minimal whitelist including Core apps (authored by kislinsk).
Add minimal whitelist including Core apps
Feb 28 2020, 4:26 PM
kislinsk committed rMITK44299f401a24: Add minimal build configurations (authored by kislinsk).
Add minimal build configurations
Feb 28 2020, 4:26 PM
kislinsk committed rMITKc236d3cc6378: Move Core apps to own module (authored by kislinsk).
Move Core apps to own module
Feb 28 2020, 4:25 PM
kislinsk committed rMITK66d92427d11a: Use mitkFunctionCreateCommandLineApp (authored by kislinsk).
Use mitkFunctionCreateCommandLineApp
Feb 28 2020, 4:25 PM
kislinsk committed rMITK64cd5e2cf38c: Guard test components with BUILD_TESTING (authored by kislinsk).
Guard test components with BUILD_TESTING
Feb 28 2020, 4:25 PM
kislinsk added a comment to T27170: Revise minimal build configuration.

Pushed new branch T27170-MinimalBuild.

Feb 28 2020, 4:25 PM · MITK
kislinsk updated the task description for T27170: Revise minimal build configuration.
Feb 28 2020, 4:20 PM · MITK
kislinsk triaged T27170: Revise minimal build configuration as Normal priority.
Feb 28 2020, 4:17 PM · MITK
kislinsk committed rMITKc9b4d0b96cf0: Merge branch 'T27168-DefaultRangeForSliceAndTimeAnimations' (authored by kislinsk).
Merge branch 'T27168-DefaultRangeForSliceAndTimeAnimations'
Feb 28 2020, 1:55 PM
kislinsk committed rMITKd5e6766c12a4: Set default animation value range to maximum (authored by kislinsk).
Set default animation value range to maximum
Feb 28 2020, 1:55 PM
kislinsk committed rMITK36b612e83167: Modernize code (authored by kislinsk).
Modernize code
Feb 28 2020, 1:55 PM
kislinsk added a comment to T27168: Fix default animation range for slice and time animations.

Pushed new branch T27168-DefaultRangeForSliceAndTimeAnimations.

Feb 28 2020, 1:54 PM · MITK
kislinsk triaged T27168: Fix default animation range for slice and time animations as Normal priority.
Feb 28 2020, 1:53 PM · MITK
kislinsk closed T19561: Movie Maker: Link to own wiki page instead of FFmpeg download site as Wontfix.
Feb 28 2020, 1:52 PM · MITK, Bugzilla
kislinsk committed rMITK2602161c0494: Disable build of docbook manpages (authored by kislinsk).
Disable build of docbook manpages
Feb 28 2020, 9:38 AM

Feb 26 2020

kislinsk added a revision to T25745: Integrate new DICOM browser widget from CTK: Unknown Object (Differential Revision).
Feb 26 2020, 2:07 PM · MITK
kislinsk committed rMITKe2db633f76ad: Disable build of docbook manpages (authored by kislinsk).
Disable build of docbook manpages
Feb 26 2020, 2:06 PM
kislinsk added a comment to T25745: Integrate new DICOM browser widget from CTK.

Pushed new branch T25745-DontBuildGDCMManPages.

Feb 26 2020, 2:06 PM · MITK

Feb 24 2020

kislinsk created Python Ontology Populator.
Feb 24 2020, 2:05 PM
kislinsk closed T27135: Disable precompiled headers in OpenCV as Resolved.
Feb 24 2020, 10:01 AM · MITK
kislinsk committed rMITK41f1350d6201: Merge remote-tracking branch 'origin/T27135-DisablePrecompiledHeadersInOpenCV' (authored by kislinsk).
Merge remote-tracking branch 'origin/T27135-DisablePrecompiledHeadersInOpenCV'
Feb 24 2020, 10:00 AM
kislinsk triaged T27152: DICOM editor not fully migrated to new CTK version as Normal priority.
Feb 24 2020, 9:00 AM · MITK (v2021.02)