Page MenuHomePhabricator
Feed Advanced Search

Dec 21 2017

clarkson committed rMITK709e1ebc1bd1: Fix syntax error in logging statement caused by outputting Qt::WindowFlags (authored by clarkson).
Fix syntax error in logging statement caused by outputting Qt::WindowFlags
Dec 21 2017, 2:32 PM
clarkson committed rMITK8e04e20fbb3c: Dont delete vtkRenderWindow in mitk::BaseRenderer as noe QVTKOpenGLWidget… (authored by clarkson).
Dont delete vtkRenderWindow in mitk::BaseRenderer as noe QVTKOpenGLWidget…
Dec 21 2017, 2:32 PM
clarkson committed rMITK0857201939d5: Update explanation of overloaded resizeGL. (authored by clarkson).
Update explanation of overloaded resizeGL.
Dec 21 2017, 2:32 PM
clarkson committed rMITK8a1e0f18793b: Put mitk::RenderWindowBase initialisation back to where it was before. (authored by clarkson).
Put mitk::RenderWindowBase initialisation back to where it was before.
Dec 21 2017, 2:32 PM
clarkson committed rMITK41398c4577d6: Force immediate update when resizing. (authored by clarkson).
Force immediate update when resizing.
Dec 21 2017, 2:31 PM
clarkson committed rMITK77635882ae3c: Plug in new QVTKOpenGLWidget, but not updating. (authored by clarkson).
Plug in new QVTKOpenGLWidget, but not updating.
Dec 21 2017, 2:31 PM
clarkson committed rMITK18b05cb10cd9: Correct use of direct.h for Mac (authored by clarkson).
Correct use of direct.h for Mac
Dec 21 2017, 2:31 PM
clarkson committed rMITKc8437808f32d: Work-around variable not used warning on Mac. (authored by clarkson).
Work-around variable not used warning on Mac.
Dec 21 2017, 2:31 PM

Dec 12 2017

clarkson added a comment to T19784: VTK 7 & Qt5.6 OpenGL Rendering conflict on OSX 10.11.

Hello Everyone,

Dec 12 2017, 10:00 AM · MITK, Bugzilla

May 15 2017

clarkson updated the task description for T22845: mitkNavigationToolStorageDeserializer.cpp writes to mitk::IOUtil::GetProgramPath().
May 15 2017, 10:24 AM · IGT, MITK
clarkson created T22845: mitkNavigationToolStorageDeserializer.cpp writes to mitk::IOUtil::GetProgramPath().
May 15 2017, 10:24 AM · IGT, MITK

Oct 28 2016

clarkson committed rMITK954153d9421d: PersistenceService output MITK_DEBUG, not MITK_INFO, so its silent on startup (authored by clarkson).
PersistenceService output MITK_DEBUG, not MITK_INFO, so its silent on startup
Oct 28 2016, 11:46 AM
clarkson committed rMITKc0f69b9d5fa0: PersistenceActivator should not force debug output (authored by clarkson).
PersistenceActivator should not force debug output
Oct 28 2016, 11:46 AM

Sep 1 2016

clarkson added a comment to T17303: [dashboard] mitk::NavigationToolStorageDeserializer uses directory without write permission on windows continous dart client.

Any news on this?

Sep 1 2016, 8:07 AM · Bugzilla, MITK

Aug 9 2016

clarkson added a comment to T17303: [dashboard] mitk::NavigationToolStorageDeserializer uses directory without write permission on windows continous dart client.

Steve Thompson, here at UCL, just tested it, and reported that it does appear to fix our problem. Thanks.

Aug 9 2016, 2:38 PM · Bugzilla, MITK
clarkson created T19849: Pixel Value not updated for 3D+t image.
Aug 9 2016, 9:10 AM · MITK (2016-11)
clarkson added a comment to T17303: [dashboard] mitk::NavigationToolStorageDeserializer uses directory without write permission on windows continous dart client.

Did it work?

Aug 9 2016, 8:56 AM · Bugzilla, MITK

Aug 5 2016

clarkson added a comment to T17303: [dashboard] mitk::NavigationToolStorageDeserializer uses directory without write permission on windows continous dart client.

Hi Alfred.

Aug 5 2016, 3:56 PM · Bugzilla, MITK

Aug 2 2016

clarkson added projects to T19443: Persistence service should not produce debug output: MITK, Bugzilla.
Aug 2 2016, 10:22 AM · MITK (2016-11), Bugzilla
clarkson added a comment to T19443: Persistence service should not produce debug output.

See branch:
https://github.com/MattClarkson/MITK/commits/19443-silence-persistence-service

Aug 2 2016, 10:22 AM · MITK (2016-11), Bugzilla
clarkson added a comment to T19339: External projects must define project name and list of dependencies.

See this:

Aug 2 2016, 10:22 AM · MITK (2016-03), Bugzilla
clarkson added a comment to T19339: External projects must define project name and list of dependencies.

Add to this, SWIG.cmake does not call mitkMacroEmptyExternalProject at all, and Python should do similar for both the source and build targets.

Aug 2 2016, 10:22 AM · MITK (2016-03), Bugzilla
clarkson added projects to T19339: External projects must define project name and list of dependencies: MITK, Bugzilla.
Aug 2 2016, 10:22 AM · MITK (2016-03), Bugzilla
clarkson added a comment to T19331: Remove doxygen warnings DOCBOOK_PROGRAMLISTING, PLANTUML_JAR_PATH, FreeSans.

Hi there,

Aug 2 2016, 10:22 AM · Bugzilla, MITK
clarkson added a comment to T19331: Remove doxygen warnings DOCBOOK_PROGRAMLISTING, PLANTUML_JAR_PATH, FreeSans.

Hi there,

Aug 2 2016, 10:22 AM · Bugzilla, MITK
clarkson added projects to T19331: Remove doxygen warnings DOCBOOK_PROGRAMLISTING, PLANTUML_JAR_PATH, FreeSans: MITK, Bugzilla.
Aug 2 2016, 10:22 AM · Bugzilla, MITK
clarkson added a comment to T19331: Remove doxygen warnings DOCBOOK_PROGRAMLISTING, PLANTUML_JAR_PATH, FreeSans.

Patch coming.

Aug 2 2016, 10:22 AM · Bugzilla, MITK
clarkson added a comment to T19331: Remove doxygen warnings DOCBOOK_PROGRAMLISTING, PLANTUML_JAR_PATH, FreeSans.

Hi there,

Aug 2 2016, 10:22 AM · Bugzilla, MITK
clarkson added a comment to T18819: Unknown file extension causes Command Line Modules to throw errors..

Hi Sascha,

Aug 2 2016, 10:19 AM · MITK (2015-03), Bugzilla
clarkson added a comment to T18819: Unknown file extension causes Command Line Modules to throw errors..

Not really. I just try to avoid exceptions if I can. In Java it used to be quite expensive to raise exceptions. Maybe this is an invalid approach now. I am getting old after all.

Aug 2 2016, 10:19 AM · MITK (2015-03), Bugzilla
clarkson added projects to T18819: Unknown file extension causes Command Line Modules to throw errors.: MITK, Bugzilla.
Aug 2 2016, 10:19 AM · MITK (2015-03), Bugzilla
clarkson added a comment to T18819: Unknown file extension causes Command Line Modules to throw errors..

Oh yes.

Aug 2 2016, 10:19 AM · MITK (2015-03), Bugzilla
clarkson added a comment to T18819: Unknown file extension causes Command Line Modules to throw errors..

What about:

Aug 2 2016, 10:19 AM · MITK (2015-03), Bugzilla
clarkson added a comment to T18819: Unknown file extension causes Command Line Modules to throw errors..

Add the moment I have no program with which to test it.

Aug 2 2016, 10:19 AM · MITK (2015-03), Bugzilla
clarkson added a comment to T18067: CLI modules incorrectly parsing file extension when saving temporary file.

I just tried that on the train into work. QTemporaryFile has a private copy constructor. So as soon as you try putting one in a QHash, compiler complains. Also, using "this" may not be a good idea. The QmitkCmdLineModuleRunner derives from QWidget. Its displayed on screen. When the process finishes, currently, the ClearUpTemporaryFiles() is called. If we resort to destroying QTemporaryFile only when the widget is destroyed there will be a delay for as long as the widget is on screen. Is that a good idea?

Aug 2 2016, 10:14 AM · MITK (2014-10), Bugzilla
clarkson added a comment to T18067: CLI modules incorrectly parsing file extension when saving temporary file.

I agree on the basis

Aug 2 2016, 10:14 AM · MITK (2014-10), Bugzilla
clarkson added a comment to T18067: CLI modules incorrectly parsing file extension when saving temporary file.

I just pushed to bug-18067-file-extensions-on-save
What do you think?

Aug 2 2016, 10:14 AM · MITK (2014-10), Bugzilla
clarkson added a comment to T18067: CLI modules incorrectly parsing file extension when saving temporary file.

See pull request #77 on Github, and also here:
https://github.com/NifTK/MITK/commit/e01e4bc989ccf6b94c0f0f50a358f5950f52d3e4

Aug 2 2016, 10:14 AM · MITK (2014-10), Bugzilla
clarkson added a comment to T18067: CLI modules incorrectly parsing file extension when saving temporary file.

Hi Sascha,

Aug 2 2016, 10:14 AM · MITK (2014-10), Bugzilla
clarkson added a comment to T18067: CLI modules incorrectly parsing file extension when saving temporary file.

And I also tried to tighten up the error handling, as some exceptions were squashed.

Aug 2 2016, 10:14 AM · MITK (2014-10), Bugzilla
clarkson added a comment to T18067: CLI modules incorrectly parsing file extension when saving temporary file.

To add to this. The problem is, that when saving a temporary file, the code generates a random file name and then iterates through the list of file extensions, trying each one until it works. But it incorrectly adds an extra dot.

Aug 2 2016, 10:14 AM · MITK (2014-10), Bugzilla
clarkson added projects to T18067: CLI modules incorrectly parsing file extension when saving temporary file: MITK, Bugzilla.
Aug 2 2016, 10:14 AM · MITK (2014-10), Bugzilla
clarkson added a comment to T18064: Qt Designer Plugins not installed on Windows.

We had a work around for this.

Aug 2 2016, 10:14 AM · Bugzilla, MITK
clarkson added projects to T18064: Qt Designer Plugins not installed on Windows: MITK, Bugzilla.
Aug 2 2016, 10:14 AM · Bugzilla, MITK
clarkson added a comment to T18064: Qt Designer Plugins not installed on Windows.

It stems from running "make package", and then installing the package, and the DLLs are not there.

Aug 2 2016, 10:14 AM · Bugzilla, MITK
clarkson added a comment to T17864: Make Movie Maker work on Linux and Mac.

sorry. im away. Can't look at this right now.

Aug 2 2016, 10:13 AM · Bugzilla, MITK
clarkson added a comment to T17864: Make Movie Maker work on Linux and Mac.

Hi there,

Aug 2 2016, 10:13 AM · Bugzilla, MITK
clarkson added projects to T17864: Make Movie Maker work on Linux and Mac: MITK, Bugzilla.
Aug 2 2016, 10:13 AM · Bugzilla, MITK
clarkson added a comment to T17864: Make Movie Maker work on Linux and Mac.

Hi there,

Aug 2 2016, 10:13 AM · Bugzilla, MITK
clarkson added a comment to T17864: Make Movie Maker work on Linux and Mac.

FYI. Im trying to get round to doing this myself. If someone can provide guidance on how they want it done, then I could look at it in the week of 30th June.

Aug 2 2016, 10:13 AM · Bugzilla, MITK
clarkson added a comment to T17864: Make Movie Maker work on Linux and Mac.

Pull request:
https://github.com/MITK/MITK/pull/68

Aug 2 2016, 10:13 AM · Bugzilla, MITK
clarkson added a comment to T17814: Maybe Patch: QmitkStdMultiWidget should not change plane visibility by name.

I just checked the method from MITK/master/head, and it looks fixed already.
I think we can close this one.

Aug 2 2016, 10:12 AM · Bugzilla, MITK
clarkson added a comment to T17814: Maybe Patch: QmitkStdMultiWidget should not change plane visibility by name.

(In reply to Thomas Kilgus from comment #3)

One more try:
Matt, do you have a full patch or pull request by chance? :)

Aug 2 2016, 10:12 AM · Bugzilla, MITK
clarkson added projects to T17814: Maybe Patch: QmitkStdMultiWidget should not change plane visibility by name: MITK, Bugzilla.
Aug 2 2016, 10:12 AM · Bugzilla, MITK
clarkson added a comment to T17814: Maybe Patch: QmitkStdMultiWidget should not change plane visibility by name.

sorry. Im away. I can't currently look at this right now.

Aug 2 2016, 10:12 AM · Bugzilla, MITK
clarkson added projects to T17768: Loading libraries crashes if find files with name shorter than dot plus library extension: MITK, Bugzilla.
Aug 2 2016, 10:12 AM · Bugzilla, MITK
clarkson added a comment to T16803: Mac OSX 10.9 Maverick compatibility.

I agree with Miklos. Third party developers (eg. UCL) may have any number of different reasons for requiring those parameters. They may have integrated several other libraries that the core MITK platform does not use, and these other libraries may require these flags to be set, or the 10.8 sdk. So, 16776 should not be removed.

Aug 2 2016, 10:10 AM · Bugzilla, MITK
clarkson added a comment to T16383: Unknown status: Resizing of images in 2D-Rendering should be disabled by default.

Hi there,

Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added a comment to T16383: Unknown status: Resizing of images in 2D-Rendering should be disabled by default.

I believe this is still a valid bug. See also 16335.

Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added projects to T16376: CTK Designer plugins not fixed up, leading to paths outside bundle: MITK, Bugzilla.
Aug 2 2016, 10:08 AM · MITK (2013-12), Bugzilla
clarkson added a comment to T16376: CTK Designer plugins not fixed up, leading to paths outside bundle.

Patched:
https://github.com/NifTK/MITK/commit/e42fba272c10c077e825dd13ce50159c632cd68b

Aug 2 2016, 10:08 AM · MITK (2013-12), Bugzilla
clarkson added a comment to F1077: screenshot-high-res-geometry-showing-low-res-BAD.tiff.

screenshot 4

Aug 2 2016, 10:08 AM
clarkson added a comment to T16335: Geometry Problem - Images are Misaligned.

screenshot 2

Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added a comment to T16335: Geometry Problem - Images are Misaligned.

And before I forget:

Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added a comment to T16335: Geometry Problem - Images are Misaligned.

screenshot 4

Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added a comment to T16335: Geometry Problem - Images are Misaligned.

screenshot 3

Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added projects to T16335: Geometry Problem - Images are Misaligned: MITK, Bugzilla.
Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added a comment to F1074: screenshot-low-res-geometry-OK.tiff.

screenshot 1

Aug 2 2016, 10:08 AM
clarkson added a comment to F1075: screenshot-low-res-geometry-showing-high-res-data-OK.tiff.

screenshot 2

Aug 2 2016, 10:08 AM
clarkson added a comment to T16335: Geometry Problem - Images are Misaligned.

high resolution test image

Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added a comment to F1073: test_image_high_res.nii.gz.

high resolution test image

Aug 2 2016, 10:08 AM
clarkson added a comment to T16335: Geometry Problem - Images are Misaligned.

screenshot 1

Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added a comment to T16335: Geometry Problem - Images are Misaligned.

Looks like adding the attachments hides the file names.
The screenshots were attached in the same order they are described.

Aug 2 2016, 10:08 AM · Bugzilla, MITK
clarkson added a comment to F1076: screenshot-high-res-geometry-OK.tiff.

screenshot 3

Aug 2 2016, 10:08 AM
clarkson added a comment to F1072: test_image_low_res.nii.

low resolution test image.

Aug 2 2016, 10:08 AM
clarkson added a comment to T16209: Static initialiser crash in various DLLs.

Hi there,

Aug 2 2016, 10:07 AM · MITK (2013-12), Bugzilla
clarkson added a comment to T16209: Static initialiser crash in various DLLs.

Hi Sascha,

Aug 2 2016, 10:07 AM · MITK (2013-12), Bugzilla
clarkson added a comment to T16209: Static initialiser crash in various DLLs.

Hi Johannes,

Aug 2 2016, 10:07 AM · MITK (2013-12), Bugzilla
clarkson added a comment to T16099: Add .gipl, .gipl.gz, .nii.gz, .img and .img.gz to Load/Save file extension lists.

https://github.com/NifTK/MITK/commit/d6c04100622b7528eb0fbe51193fc2ca00d1ae42

Aug 2 2016, 10:07 AM · Bugzilla, MITK
clarkson added projects to T16099: Add .gipl, .gipl.gz, .nii.gz, .img and .img.gz to Load/Save file extension lists: MITK, Bugzilla.
Aug 2 2016, 10:07 AM · Bugzilla, MITK
clarkson added a comment to T15790: remove duplicated include directories.

That should work for me.

Aug 2 2016, 10:05 AM · Bugzilla, MITK
clarkson added a comment to T15790: remove duplicated include directories.

This appeared to help:
https://github.com/NifTK/MITK/commit/c92d85a2817c5b6dffcbc457e198f152d8743938

Aug 2 2016, 10:05 AM · Bugzilla, MITK
clarkson added a comment to T15427: Command line modules plugin discards executable too soon (timeout).

Both branches updated.

Aug 2 2016, 10:04 AM · Bugzilla, MITK
clarkson added a comment to T15427: Command line modules plugin discards executable too soon (timeout).

Hi All,

Aug 2 2016, 10:04 AM · Bugzilla, MITK
clarkson added a comment to T15092: Mac icons not copied and Info.plist has wrong value for icon location.

followed by

Aug 2 2016, 10:03 AM · Bugzilla, MITK
clarkson added a comment to T15092: Mac icons not copied and Info.plist has wrong value for icon location.

For this issue, when I run "make package", the resultant bundle is wrong.

Aug 2 2016, 10:03 AM · Bugzilla, MITK
clarkson added projects to T15092: Mac icons not copied and Info.plist has wrong value for icon location: MITK, Bugzilla.
Aug 2 2016, 10:03 AM · Bugzilla, MITK
clarkson added projects to T15077: FunctionCreateBlueBerryApplication.cmake should provide ability to ignore or override the generation of start${_APP_NAME}_${BUILD_TYPE}.bat: MITK, Bugzilla.
Aug 2 2016, 10:03 AM · MITK (2013-06), Bugzilla
clarkson added a comment to T15077: FunctionCreateBlueBerryApplication.cmake should provide ability to ignore or override the generation of start${_APP_NAME}_${BUILD_TYPE}.bat.

Patch here:
https://github.com/NifTK/MITK/commits/MITK-bug-15077-trac-2280-Enable-Override-StartApp-Batch-Script

Aug 2 2016, 10:03 AM · MITK (2013-06), Bugzilla
clarkson added a comment to T15077: FunctionCreateBlueBerryApplication.cmake should provide ability to ignore or override the generation of start${_APP_NAME}_${BUILD_TYPE}.bat.

Seems ok to me.

Aug 2 2016, 10:03 AM · MITK (2013-06), Bugzilla
clarkson added a comment to T14974: The GUI for the programs integrated with the command line tool is not generated correctly.

Thats caused by the qt-designer plugin for the CTK widgets not being available.

Aug 2 2016, 10:02 AM · MITK (2013-09), Bugzilla
clarkson added a comment to T14692: No strings are passed on to command line modules.

Hi Sascha,

Aug 2 2016, 10:01 AM · MITK (2013-03), Bugzilla
clarkson added a comment to T14692: No strings are passed on to command line modules.

Hi Sascha,

Aug 2 2016, 10:01 AM · MITK (2013-03), Bugzilla
clarkson added a comment to T14692: No strings are passed on to command line modules.

Hi Sascha,

Aug 2 2016, 10:01 AM · MITK (2013-03), Bugzilla
clarkson added a comment to T14682: Nifti Output is not imported correctly into MITK from CommandLine Module.

I don't know. I presume it can, but then you have the problem .... is it a change request, or is it a bug? What about people that do not want an automatic global re-init? It could be made a preference to the Command Line Modules plugin.

Aug 2 2016, 10:01 AM · MITK (2013-03), Bugzilla
clarkson added a comment to T14676: define file names for output generated in command line module during run time.

Going back to this .... I still can't quite understand your two use-cases. I don't understand your description of option 1. Then I gave a description of what I thought you mean in the second half of your first email. Then you said this would solve case 1... which was a surprise as i didn't understand it!!!

Aug 2 2016, 10:01 AM · Bugzilla, MITK
clarkson added a comment to T14682: Nifti Output is not imported correctly into MITK from CommandLine Module.

If there are no images loaded within mitkWorkbench (or the diffusion app), then there is no Geometry3D defined.

Aug 2 2016, 10:01 AM · MITK (2013-03), Bugzilla
clarkson added a comment to T14682: Nifti Output is not imported correctly into MITK from CommandLine Module.

Please can you give a more complete description?

Aug 2 2016, 10:01 AM · MITK (2013-03), Bugzilla
clarkson added a comment to T14692: No strings are passed on to command line modules.

Hi Sascha,

Aug 2 2016, 10:01 AM · MITK (2013-03), Bugzilla
clarkson added a comment to T14676: define file names for output generated in command line module during run time.

Do you mean:

Aug 2 2016, 10:01 AM · Bugzilla, MITK