Page MenuHomePhabricator
Feed All Stories

Nov 16 2023

kislinsk committed rMITK954c353a7b4f: [Segmentation] Fix several crashes in group deletion edge cases (authored by kislinsk).
[Segmentation] Fix several crashes in group deletion edge cases
Nov 16 2023, 4:59 PM
kislinsk closed T30252: [Segmentation] Deleting an empty group causes Workbench crash as Resolved by committing rMITK954c353a7b4f: [Segmentation] Fix several crashes in group deletion edge cases.
Nov 16 2023, 4:59 PM · MITK
kislinsk committed rMITK615a558597e5: Find any label instance as closest label instance as last resort (authored by kislinsk).
Find any label instance as closest label instance as last resort
Nov 16 2023, 4:59 PM
kislinsk committed rMITK1c8399354fa4: Do not select label of group that is about to get removed (authored by kislinsk).
Do not select label of group that is about to get removed
Nov 16 2023, 4:59 PM
kislinsk committed rMITK9787dadafd24: Make messages for group deletion more explicit and clear (authored by kislinsk).
Make messages for group deletion more explicit and clear
Nov 16 2023, 4:59 PM
floca renamed T30249: [Py] UC2.3 - Load images and explore properties from UC5 - Load and save images out of a pthon script to [Py] UC5 - Load and save images out of a pthon script.
Nov 16 2023, 4:30 PM · Moved to git.dkfz.de, MITK
floca triaged T30171: [Py] View to execute scripts that interact with the rest of the workbench as Normal priority.
Nov 16 2023, 4:30 PM · Moved to git.dkfz.de, MITK
floca triaged T30172: [Py] UC1.1 - Selected image can be manipulated with simpleITK and updated as Normal priority.
Nov 16 2023, 4:29 PM · Moved to git.dkfz.de, MITK
floca triaged T30174: [Py] UC1.3 - Selected image can be manipulated with simpleITK and added to data storage as Normal priority.
Nov 16 2023, 4:29 PM · Moved to git.dkfz.de, MITK
floca triaged T30173: [Py] UC1.2 - Selected image are stored as Normal priority.
Nov 16 2023, 4:29 PM · Moved to git.dkfz.de, MITK
floca triaged T30175: [Py] UC1.4 - All images in data storage that are visible are set opacity 50% in a specific render window as Normal priority.
Nov 16 2023, 4:29 PM · Moved to git.dkfz.de, MITK
floca triaged T30249: [Py] UC2.3 - Load images and explore properties as High priority.
Nov 16 2023, 4:29 PM · Moved to git.dkfz.de, MITK
floca triaged T30170: [Py] Python in MITK as High priority.
Nov 16 2023, 4:27 PM · Moved to git.dkfz.de, MITK
a178n added a comment to T30253: SAM tool: Installation could show error message for wrong python path.

Pushed new branch to rMITK MITK: feature/T30253-sam-message-update.

Nov 16 2023, 1:27 PM · MITK (v2024.06)
kislinsk closed T30248: 2023 Week 46 (Mid November) as Resolved.
Nov 16 2023, 11:40 AM · MITK
a178n updated the task description for T30253: SAM tool: Installation could show error message for wrong python path.
Nov 16 2023, 11:27 AM · MITK (v2024.06)
a178n triaged T30253: SAM tool: Installation could show error message for wrong python path as Normal priority.
Nov 16 2023, 11:25 AM · MITK (v2024.06)
a178n closed T29645: Test Plan for SAM, a subtask of T29524: SAM in MITK, as Resolved.
Nov 16 2023, 11:17 AM · Moved to git.dkfz.de, MITK
a178n closed T29645: Test Plan for SAM as Resolved.
Nov 16 2023, 11:17 AM · MITK (v2023.12)
kislinsk added a revision to T30252: [Segmentation] Deleting an empty group causes Workbench crash: Unknown Object (Differential Revision).
Nov 16 2023, 10:53 AM · MITK
kislinsk added a comment to T30252: [Segmentation] Deleting an empty group causes Workbench crash.

See D884 for fixes.

Nov 16 2023, 8:32 AM · MITK
kislinsk claimed T30252: [Segmentation] Deleting an empty group causes Workbench crash.
Nov 16 2023, 8:16 AM · MITK

Nov 15 2023

a178n triaged T30252: [Segmentation] Deleting an empty group causes Workbench crash as Unbreak Now! priority.
Nov 15 2023, 5:12 PM · MITK
s434n added a comment to T30252: [Segmentation] Deleting an empty group causes Workbench crash.

Can reproduce. I agree with your explanation. When group 1 is empty, it can't actually be selected. There's the dotted line, but group 2 is still in focus (which is stated in the popup dialog). I guess after group 2 is deleted the "focus" is not set correctly.
I guess we could either ensure that the next available label is automatically selected, since usually there is always a label selected, or the "Delete group" should be respective to the dotted-line selection of a group.
I'm not sure if this contradicts previous discussions we had about the topic, but I would actually prefer the second option. Generally, it feels weird that one is able to kind of select a group and interact with its context menu, but the buttons above still refer to the group of the focused label. For example, it is impossible to add a label to an empty group with the buttons (except for the first one).

Nov 15 2023, 4:58 PM · MITK
a178n added a comment to T30252: [Segmentation] Deleting an empty group causes Workbench crash.
Nov 15 2023, 4:36 PM · MITK
a178n created T30252: [Segmentation] Deleting an empty group causes Workbench crash.
Nov 15 2023, 4:34 PM · MITK
kislinsk closed T30251: Compiler warnings/errors because of QList on Visual Studio 2022 version 17.8 as Resolved.
Nov 15 2023, 1:45 PM · MITK (v2023.12)
kislinsk added a comment to T30251: Compiler warnings/errors because of QList on Visual Studio 2022 version 17.8.

Deleted branch from rMITK MITK: bugfix/T30251-Fix_VS2022_v17.8_warnings_as_errors.

Nov 15 2023, 1:45 PM · MITK (v2023.12)
kislinsk committed rMITKadce35032fe3: Disable deprecation warnings triggered by QList (authored by kislinsk).
Disable deprecation warnings triggered by QList
Nov 15 2023, 1:44 PM
kislinsk committed rMITKe71031222baa: Merge branch 'bugfix/T30251-Fix_VS2022_v17.8_warnings_as_errors' into develop (authored by kislinsk).
Merge branch 'bugfix/T30251-Fix_VS2022_v17.8_warnings_as_errors' into develop
Nov 15 2023, 1:44 PM
kislinsk added a comment to T30251: Compiler warnings/errors because of QList on Visual Studio 2022 version 17.8.

Pushed new branch to rMITK MITK: bugfix/T30251-Fix_VS2022_v17.8_warnings_as_errors.

Nov 15 2023, 1:44 PM · MITK (v2023.12)
kislinsk triaged T30251: Compiler warnings/errors because of QList on Visual Studio 2022 version 17.8 as High priority.
Nov 15 2023, 1:38 PM · MITK (v2023.12)

Nov 14 2023

a178n edited the content of 2023 Week 46 (Mid November).
Nov 14 2023, 3:46 PM
a178n edited the content of 2023 Week 46 (Mid November).
Nov 14 2023, 1:32 PM
s434n triaged T30250: [MxN] Windows created by preset have no in-window menus as Normal priority.
Nov 14 2023, 12:20 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca created T30249: [Py] UC2.3 - Load images and explore properties.
Nov 14 2023, 12:02 PM · Moved to git.dkfz.de, MITK
kompan edited the content of 2023 Week 46 (Mid November).
Nov 14 2023, 9:43 AM

Nov 13 2023

kislinsk edited the content of Changelog.
Nov 13 2023, 9:42 PM · MITK
kislinsk added a comment to T30248: 2023 Week 46 (Mid November).

Deleted branch from rMITK MITK: release/T30248-2023-Week-46.

Nov 13 2023, 9:41 PM · MITK
kislinsk committed rMITK3d1fc8872cb5: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Nov 13 2023, 9:40 PM
s434n committed rMITKc61b76f04a10: write only image data from itk result directly to output image instead of… (authored by s434n).
write only image data from itk result directly to output image instead of…
Nov 13 2023, 9:39 PM
s434n closed T29608: [Segmentation Utils] Workbench crashes for Morphological operations as Resolved by committing rMITK9a17e7beb611: Correctly handle results of morphological operations.
Nov 13 2023, 9:39 PM · MITK (v2023.12)
s434n committed rMITK9a17e7beb611: Correctly handle results of morphological operations (authored by s434n).
Correctly handle results of morphological operations
Nov 13 2023, 9:39 PM
kislinsk committed rMITK42a0db2e744f: Add Boost as dependency of Eigen (authored by kislinsk).
Add Boost as dependency of Eigen
Nov 13 2023, 9:39 PM
kislinsk committed rMITKe5401e929755: 2023 Week 46 (Mid November) (authored by kislinsk).
2023 Week 46 (Mid November)
Nov 13 2023, 9:39 PM
kislinsk edited the content of 2023 Week 46 (Mid November).
Nov 13 2023, 5:25 PM
kislinsk added a comment to T30248: 2023 Week 46 (Mid November).

Pushed new branch to rMITK MITK: release/T30248-2023-Week-46.

Nov 13 2023, 4:23 PM · MITK
kislinsk triaged T30248: 2023 Week 46 (Mid November) as Normal priority.
Nov 13 2023, 11:38 AM · MITK
kislinsk edited the content of MITK v2023.04.2.
Nov 13 2023, 11:36 AM
kislinsk created an object: 2023 Week 46 (Mid November).
Nov 13 2023, 11:36 AM
a178n triaged T30247: MONAILabel: Improve doxygen docstrings as Normal priority.
Nov 13 2023, 10:07 AM · Moved to git.dkfz.de, MITK (v2024.12)
a178n edited projects for T30240: MonaiLabel: How to support more apps, added: MITK (v2023.12); removed Request for Discussion, MITK.
Nov 13 2023, 9:59 AM · Moved to git.dkfz.de, MITK (v2024.12)

Nov 9 2023

kislinsk updated the task description for T30246: DataNode::SetName() does not trigger Modified event anymore.
Nov 9 2023, 8:56 PM · MITK (v2023.12)
kislinsk closed T30246: DataNode::SetName() does not trigger Modified event anymore as Invalid.

I would argue that, while it is an implicit API-change, it works as expected and intended. The commit message contains a rationale. The name is really something that should be the property of the base data rather than the data node, which is dedicated to non-persistent and typically visualization related properties. The most straight-forward solution would be to replace your call of SetName(name) with SetStringProperty("name", name) instead of changing the code of SetName(). By default, this will add the name property to the data node without falling back to a potentially existing base data property. Another solution would be to also listen to the Modified event of the BaseData or its PropertyList or even directly of its name StringProperty.

Nov 9 2023, 8:54 PM · MITK (v2023.12)
kislinsk renamed T30246: DataNode::SetName() does not trigger Modified event anymore from Please enter a meaningful title to DataNode::SetName() does not trigger Modified event anymore.
Nov 9 2023, 8:35 PM · MITK (v2023.12)
kislinsk triaged T30246: DataNode::SetName() does not trigger Modified event anymore as Normal priority.
Nov 9 2023, 8:35 PM · MITK (v2023.12)
a178n added a comment to T30240: MonaiLabel: How to support more apps.

New checkbox "Allow all models" added to Preferences. Changes included in D875

Nov 9 2023, 4:23 PM · Moved to git.dkfz.de, MITK (v2024.12)
a178n added a revision to T30240: MonaiLabel: How to support more apps: Unknown Object (Differential Revision).
Nov 9 2023, 4:22 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca committed rMITKe882a330a799: T30243 - Crash/Freeze when selection in DataManager is changed while MatchPoint… (authored by floca).
T30243 - Crash/Freeze when selection in DataManager is changed while MatchPoint…
Nov 9 2023, 11:57 AM
floca closed T30243: Crash/Freeze when selection in DataManager is changed while MatchPoint controller is open. as Resolved by committing rMITK476723c66866: Fixed T30243.
Nov 9 2023, 11:57 AM · MITK (v2023.12)
floca committed rMITK476723c66866: Fixed T30243 (authored by floca).
Fixed T30243
Nov 9 2023, 11:57 AM

Nov 8 2023

floca added a revision to T30243: Crash/Freeze when selection in DataManager is changed while MatchPoint controller is open.: Unknown Object (Differential Revision).
Nov 8 2023, 8:51 PM · MITK (v2023.12)
floca triaged T30243: Crash/Freeze when selection in DataManager is changed while MatchPoint controller is open. as Unbreak Now! priority.
Nov 8 2023, 8:49 PM · MITK (v2023.12)
s434n added a revision to T29608: [Segmentation Utils] Workbench crashes for Morphological operations: Unknown Object (Differential Revision).
Nov 8 2023, 4:41 PM · MITK (v2023.12)
s434n committed rMITK287a0803af1f: Keep track of synchronized MxN windows to avoid nodes being hidden (authored by s434n).
Keep track of synchronized MxN windows to avoid nodes being hidden
Nov 8 2023, 4:07 PM
s434n closed T30184: [MxN] Turning on data synchronizing hides newly added nodes as Resolved by committing rMITK287a0803af1f: Keep track of synchronized MxN windows to avoid nodes being hidden.
Nov 8 2023, 4:07 PM · MITK (v2023.12)
s434n committed rMITK43f51f83fa9e: keep track of synchronized windows to set correct initial selection (authored by s434n).
keep track of synchronized windows to set correct initial selection
Nov 8 2023, 4:07 PM
s434n claimed T29608: [Segmentation Utils] Workbench crashes for Morphological operations.
Nov 8 2023, 4:04 PM · MITK (v2023.12)
kislinsk added a revision to T30155: Bounding boxes / ROIs in MITK: Unknown Object (Differential Revision).
Nov 8 2023, 3:45 PM · MITK (v2024.06)
a178n triaged T30242: [MONAILabel] Trouble activating SSL support in Httplib as Normal priority.
Nov 8 2023, 2:27 PM · Moved to git.dkfz.de, MITK (v2024.12)
a178n committed rMITK1ee8b7dc19a1: Totalsegmentator version update & minor changes (authored by a178n).
Totalsegmentator version update & minor changes
Nov 8 2023, 2:00 PM
a178n committed rMITK88d9629de541: Totalsegmentator v2 version update (authored by a178n).
Totalsegmentator v2 version update
Nov 8 2023, 2:00 PM
s434n triaged T30241: [MxN] Rethink select-all logic in MxN data selection as Normal priority.
Nov 8 2023, 11:30 AM · Moved to git.dkfz.de, MITK (v2024.12)

Nov 7 2023

s434n moved T29608: [Segmentation Utils] Workbench crashes for Morphological operations from Backlog to Cycle on the MITK (v2023.12) board.
Nov 7 2023, 5:40 PM · MITK (v2023.12)
s434n edited projects for T29608: [Segmentation Utils] Workbench crashes for Morphological operations, added: MITK (v2023.12); removed MITK.
Nov 7 2023, 5:39 PM · MITK (v2023.12)
kompan committed rMITKd75ec56551b5: Remove turboFLASH conversion from UIs. (authored by kompan).
Remove turboFLASH conversion from UIs.
Nov 7 2023, 1:06 PM
kompan committed rMITKae2bb372f427: Replace signal to concentration conversion image. (authored by kompan).
Replace signal to concentration conversion image.
Nov 7 2023, 1:06 PM
kompan committed rMITK12c868af1d84: Make AIFImageNodeSelector only visible when DedicatedAIFImage box is checked. (authored by kompan).
Make AIFImageNodeSelector only visible when DedicatedAIFImage box is checked.
Nov 7 2023, 1:06 PM
kompan committed rMITK435bd831b730: Rename AIF field from "AIF mask" to "Arterial Input Function (AIF)". (authored by kompan).
Rename AIF field from "AIF mask" to "Arterial Input Function (AIF)".
Nov 7 2023, 1:06 PM
kompan committed rMITK8672bb60a98e: Update doxygen documentation for MRPerfusionView. (authored by kompan).
Update doxygen documentation for MRPerfusionView.
Nov 7 2023, 1:06 PM
kompan committed rMITK947d6046609d: Remove code from Num2CX settings which was forgotten to be removed as part of… (authored by kompan).
Remove code from Num2CX settings which was forgotten to be removed as part of…
Nov 7 2023, 1:06 PM
kompan committed rMITKb3cb7b42e785: Update doxygen documentation for ConcentrationCurveConverterView. (authored by kompan).
Update doxygen documentation for ConcentrationCurveConverterView.
Nov 7 2023, 1:06 PM
kompan committed rMITK992913ec348a: Remove turboFLASH conversion from ConcentrationCurveConverterView. (authored by kompan).
Remove turboFLASH conversion from ConcentrationCurveConverterView.
Nov 7 2023, 1:06 PM
kompan committed rMITK4956a50d5868: Remove turboFLASH conversion from MRPerfusionView. (authored by kompan).
Remove turboFLASH conversion from MRPerfusionView.
Nov 7 2023, 1:06 PM
kompan committed rMITK22b440a035e7: Remove turboFLASH conversion from MRSignal2ConcentrationMiniApp. (authored by kompan).
Remove turboFLASH conversion from MRSignal2ConcentrationMiniApp.
Nov 7 2023, 1:06 PM
floca added a comment to T30240: MonaiLabel: How to support more apps.

I would lean to adding a preference "allow unsupported models" (default ==false). If people activate it, they can see all models (that are not blacklisted) and not just the white listed (verified) once.
If the risk is communicated and users are willing to take it, then I would not actively prevent people from using models (as long as they don't crash MITK or so).

Nov 7 2023, 12:02 PM · Moved to git.dkfz.de, MITK (v2024.12)
a178n triaged T30240: MonaiLabel: How to support more apps as Normal priority.
Nov 7 2023, 10:18 AM · Moved to git.dkfz.de, MITK (v2024.12)

Nov 3 2023

floca committed rMITK8dcc50cc2600: T27718 Added DICOM Volume Diagnostics app (authored by floca).
T27718 Added DICOM Volume Diagnostics app
Nov 3 2023, 7:27 PM
floca committed rMITK4293212e5fa7: Fixed review remarks (authored by floca).
Fixed review remarks
Nov 3 2023, 7:26 PM
floca committed rMITK4220dc3ebb22: fixed gcc compiler error (authored by floca).
fixed gcc compiler error
Nov 3 2023, 7:26 PM
floca closed T27718: Miniapp for basic DICOM testing as Resolved by committing rMITK51d7f4f13072: Added DICOM Volume Diagnostics app.
Nov 3 2023, 7:26 PM · MITK (v2023.12), Kaapana (internal)
floca committed rMITK51d7f4f13072: Added DICOM Volume Diagnostics app (authored by floca).
Added DICOM Volume Diagnostics app
Nov 3 2023, 7:26 PM
kislinsk added a member for MITK-MBI: a332l.
Nov 3 2023, 11:14 AM
kausch added a member for MIC: a332l.
Nov 3 2023, 10:27 AM

Nov 2 2023

s434n added a revision to T30184: [MxN] Turning on data synchronizing hides newly added nodes: Unknown Object (Differential Revision).
Nov 2 2023, 7:06 PM · MITK (v2023.12)
s434n renamed T30184: [MxN] Turning on data synchronizing hides newly added nodes from [MxN] Turning on data synchronizing hides segmentation of non-visible nodes to [MxN] Turning on data synchronizing hides newly added nodes.
Nov 2 2023, 5:43 PM · MITK (v2023.12)
s434n triaged T30234: [MxN] Adding new render window turns on visibility of selected nodes as Low priority.
Nov 2 2023, 5:29 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n committed rMITKf21266a4176c: Reactivate / fix exponentiation in formula parser (authored by s434n).
Reactivate / fix exponentiation in formula parser
Nov 2 2023, 10:39 AM
s434n committed rMITKc5bc8ba32dfb: adjust whitespace (authored by s434n).
adjust whitespace
Nov 2 2023, 10:39 AM
s434n committed rMITK68832adcdf1d: reactivate / fix exponentiation in formula parser (authored by s434n).
reactivate / fix exponentiation in formula parser
Nov 2 2023, 10:39 AM