Page MenuHomePhabricator
Create Task
Maniphest T23737

Introduce IIdentifiable
Closed, ResolvedPublic
Actions

Description

Introduce an Interface that offers that can be implemented to offer the identification capabilities.

Something like:

class IIdentifiable
{
  public:
    using UIDType = std::string;
    UIDType getUID() const = 0;
}

Related Objects
Search...

StatusAssignedTask
 ResolvedflocaT23721 Project "Astonishing Angelfish"
 ResolvedkislinskT23736 Introduction of UIDs for data/nodes etc
 ResolvedkislinskT23743 Introduce mitkNodePredicateID and mitkNodePredicateDataID
 ResolvedflocaT23754 DataStorage/Relationship clean up/refactoring
 ResolvedkislinskT23761 DataNode Property getter should regard base data properties if necessary
 ResolvedkislinskT23762 Implement IPropertyOwner for DataNode
 ResolvedkislinskT23757 Introduce IPropertyOwner
 DuplicateNoneT23770 Add relation rule for Images and Source images
 ResolvedkislinskT23771 Add mitk::NodePredicateLambda
 ResolvedflocaT23805 PropertyRuleClass for "simple" ID relations
 ResolvedflocaT23808 Add Rule base class for DICOM source imagereferences
 OpenNoneT23811 PatientViewPlugin ++
 ResolvedkalaliT23749 Implement base class for DataStorageViewer
 ResolvedflocaT23766 Introduce PropertyRelationsService
 ResolvedflocaT23767 Introduce IPropertyRelations
 ResolvedflocaT23769 Implement PropertyRelationRule base class
 ResolvedkislinskT23740 Introduce IDs to BaseData
 ResolvedkislinskT23737 Introduce IIdentifiable
 ResolvedkislinskT23932 Implement IPropertyOwner for BaseData
 ResolvedflocaT26142 Property persistence for property relation instance identifing (RII) properties
 OpenNoneT26950 Add rule class for DICOM Seg relations to source image
 ResolvedflocaT26843 Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule
 ResolvedkalaliT27559 Crash when changing parent data nodes in Data Manager

Event Timeline

floca created this task.Nov 17 2017, 9:39 AM
floca added a parent task: T23740: Introduce IDs to BaseData.Nov 17 2017, 10:26 AM
floca added a parent task: T23743: Introduce mitkNodePredicateID and mitkNodePredicateDataID.Nov 17 2017, 10:39 AM
nolden added a comment.Nov 17 2017, 11:50 AM

if the ID is unique, this should maybe named getUID . And I wonder if we should make the IDType a proper class, did you discuss this?

floca updated the task description. (Show Details)Nov 17 2017, 11:51 AM

Specific class: Nope. Valid point worth a discussion. I would propse if we don't clarify it todo we make a subtask out of it

kislinsk claimed this task.Dec 10 2017, 12:08 AM
kislinsk added a comment.Dec 10 2017, 12:22 AM

Pushed new branch T23737-IIdentifiable.

kislinsk mentioned this in rMITK45e2d3f5c372: Merge branch 'T23737-IIdentifiable' into T23736-IntroductionOfUIDs.Dec 10 2017, 12:28 AM
kislinsk closed this task as Resolved.Dec 10 2017, 12:54 AM
kislinsk added a comment.Dec 16 2017, 8:15 AM

mitk::IIdentifiable interface was changed to mitk::Identifiable base class. It takes responsibility of encapsulating the UID. It is movable but not copyable. mitk::UIDManipulator can be used by data readers to manipulate the UID after identifiable object creation time.

MITK · MIC · IMSY · DKFZ