Page MenuHomePhabricator
Feed Advanced Search

Dec 4 2020

kislinsk committed rMITK15ae7b34fd0f: Merge branch 'bugfix/T28062-FixIsotropicWaveletsDep' into develop (authored by kislinsk).
Merge branch 'bugfix/T28062-FixIsotropicWaveletsDep' into develop
Dec 4 2020, 12:27 PM
kislinsk added a comment to T28062: Fix IsotropicWavelets (ITK) dependency.

Pushed new branch bugfix/T28062-FixIsotropicWaveletsDep.

Dec 4 2020, 12:26 PM · MITK (v2021.02)
kislinsk added a comment to T28062: Fix IsotropicWavelets (ITK) dependency.

I added an explicit private target dependency to IsotropicWavelets in BasicImageProcessing as it is the only module where it is used.

Dec 4 2020, 11:15 AM · MITK (v2021.02)
kislinsk renamed T28062: Fix IsotropicWavelets (ITK) dependency from Remove unused ITKIsotropicWavelets dependency to Fix IsotropicWavelets (ITK) dependency.
Dec 4 2020, 11:14 AM · MITK (v2021.02)
kislinsk reopened T28062: Fix IsotropicWavelets (ITK) dependency as "Open".

Argh... it is actually used in BasicImageProcessing without being specified as dependency. :-( I will investigate if it is just a header that is included or if we need to revert and try to fix the retrival issue of the remote module.

Dec 4 2020, 10:15 AM · MITK (v2021.02)
kislinsk closed T28062: Fix IsotropicWavelets (ITK) dependency as Resolved.
Dec 4 2020, 9:59 AM · MITK (v2021.02)
kislinsk added a comment to T28062: Fix IsotropicWavelets (ITK) dependency.

Deleted branch bugfix/T28062-RemoveITKIsotropicWaveletsDependency.

Dec 4 2020, 9:58 AM · MITK (v2021.02)
kislinsk committed rMITK23b915bd3a92: Remove unused IsotropicWavelets module (authored by kislinsk).
Remove unused IsotropicWavelets module
Dec 4 2020, 9:58 AM
kislinsk committed rMITKa723c00cf64d: Merge branch 'bugfix/T28062-RemoveITKIsotropicWaveletsDependency' into develop (authored by kislinsk).
Merge branch 'bugfix/T28062-RemoveITKIsotropicWaveletsDependency' into develop
Dec 4 2020, 9:58 AM
kislinsk added a comment to T28062: Fix IsotropicWavelets (ITK) dependency.

Pushed new branch bugfix/T28062-RemoveITKIsotropicWaveletsDependency.

Dec 4 2020, 9:57 AM · MITK (v2021.02)
kislinsk updated the task description for T28062: Fix IsotropicWavelets (ITK) dependency.
Dec 4 2020, 9:55 AM · MITK (v2021.02)
kislinsk triaged T28062: Fix IsotropicWavelets (ITK) dependency as Normal priority.
Dec 4 2020, 9:55 AM · MITK (v2021.02)
kislinsk added a project to T28061: Use official ITK release tarball instead of snapshot: Noteworthy.
Dec 4 2020, 9:24 AM · Noteworthy, MITK (v2021.02)
kislinsk closed T28061: Use official ITK release tarball instead of snapshot as Resolved.
Dec 4 2020, 9:22 AM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T28061: Use official ITK release tarball instead of snapshot.

Deleted branch bugfix/T28061-UseOfficialITKTarball.

Dec 4 2020, 9:22 AM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITK23d75d193a19: Use official ITK release tarball (authored by kislinsk).
Use official ITK release tarball
Dec 4 2020, 9:21 AM
kislinsk committed rMITK6cbf68ecc068: Merge branch 'bugfix/T28061-UseOfficialITKTarball' into develop (authored by kislinsk).
Merge branch 'bugfix/T28061-UseOfficialITKTarball' into develop
Dec 4 2020, 9:21 AM
kislinsk added a comment to T28061: Use official ITK release tarball instead of snapshot.

Pushed new branch bugfix/T28061-UseOfficialITKTarball.

Dec 4 2020, 9:20 AM · Noteworthy, MITK (v2021.02)
kislinsk triaged T28061: Use official ITK release tarball instead of snapshot as Normal priority.
Dec 4 2020, 9:19 AM · Noteworthy, MITK (v2021.02)

Dec 3 2020

kislinsk added a comment to T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15.

Deleted branch bugfix/T28060-CMP0091.

Dec 3 2020, 7:28 PM · MITK
kislinsk committed rMITK2ce6115f1a86: Set policy CMP0091 to OLD for all projects (authored by kislinsk).
Set policy CMP0091 to OLD for all projects
Dec 3 2020, 7:28 PM
kislinsk committed rMITKc32297641777: Merge branch 'bugfix/T28060-CMP0091' into develop (authored by kislinsk).
Merge branch 'bugfix/T28060-CMP0091' into develop
Dec 3 2020, 7:28 PM
kislinsk added a comment to T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15.

Pushed new branch bugfix/T28060-CMP0091.

Dec 3 2020, 7:27 PM · MITK
kislinsk triaged T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15 as High priority.
Dec 3 2020, 7:24 PM · MITK

Dec 2 2020

kislinsk added a member for wDB: kislinsk.
Dec 2 2020, 10:48 AM

Dec 1 2020

kislinsk moved T28047: CDash script does not fetch tags from Backlog to Done on the CI board.
Dec 1 2020, 2:35 PM · CI, MITK
kislinsk closed T28047: CDash script does not fetch tags as Resolved.
Dec 1 2020, 2:31 PM · CI, MITK
kislinsk committed rMITKca8dcec7aa87: Fetch tags on update (authored by kislinsk).
Fetch tags on update
Dec 1 2020, 2:30 PM
kislinsk committed rMITK7cdad74bd60a: Merge branch 'bugfix/T28047-FetchTags' into develop (authored by kislinsk).
Merge branch 'bugfix/T28047-FetchTags' into develop
Dec 1 2020, 2:30 PM
kislinsk triaged T28047: CDash script does not fetch tags as Normal priority.
Dec 1 2020, 2:22 PM · CI, MITK
kislinsk added a comment to T27969: Toggling "Show cross hair" in a render window menu does not update the check state in other render window menus.

As it is a public API change I suggest that you tag this task with Noteworthy and write a line about the breaking change or in case it is not trivial a short migration guide.

Dec 1 2020, 12:35 PM · Noteworthy, MITK (v2021.02)

Nov 30 2020

kislinsk closed T26449: XNAT connection failes due to missing OpenSSL connections as Resolved.
Nov 30 2020, 8:08 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T26449: XNAT connection failes due to missing OpenSSL connections.

Deleted branch bugfix/T26449-XNAT-OpenSSL.

Nov 30 2020, 8:08 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITKa2232f1fb214: Fix copying/installing of OpenSSL for XNAT (authored by kislinsk).
Fix copying/installing of OpenSSL for XNAT
Nov 30 2020, 8:07 PM
kislinsk committed rMITK01c1803b4ab9: Merge branch 'bugfix/T26449-XNAT-OpenSSL' into develop (authored by kislinsk).
Merge branch 'bugfix/T26449-XNAT-OpenSSL' into develop
Nov 30 2020, 8:07 PM
kislinsk added a comment to T26449: XNAT connection failes due to missing OpenSSL connections.

Pushed new branch bugfix/T26449-XNAT-OpenSSL.

Nov 30 2020, 3:22 PM · Noteworthy, MITK (v2021.02)
kislinsk reopened T26449: XNAT connection failes due to missing OpenSSL connections as "Open".

It is not acceptable that there is a hidden manual process involved. There's legacy code in the XNAT plugin's CMakeLists.txt that tries to do that automatically but fails as it copies/installs the wrong files. To make the whole thing more visible, I will add the following two CMake cache variables to set the two DLLs. Manual copying and installing shouldn't be neccessary anymore then.

Nov 30 2020, 2:51 PM · Noteworthy, MITK (v2021.02)
kislinsk closed T27383: Update external toolkits as Resolved.

All experimental CI clients succeeded. Merged into develop.

Nov 30 2020, 1:13 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27383: Update external toolkits.

Deleted branch feature/T27383-UpdateExternalToolkits.

Nov 30 2020, 1:12 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITK9874d31b713b: Update CTK (authored by kislinsk).
Update CTK
Nov 30 2020, 1:12 PM
kislinsk committed rMITK5d038485ea3e: Update cpprestsdk (authored by kislinsk).
Update cpprestsdk
Nov 30 2020, 1:12 PM
kislinsk committed rMITK57974357d5a2: Update GDCM (authored by kislinsk).
Update GDCM
Nov 30 2020, 1:12 PM
kislinsk committed rMITK5510b6fa5197: Update DCMQI (authored by kislinsk).
Update DCMQI
Nov 30 2020, 1:12 PM
kislinsk committed rMITK281619c2322d: Update CppUnit (authored by kislinsk).
Update CppUnit
Nov 30 2020, 1:12 PM
kislinsk committed rMITKdbaabe8ae3d9: Automatically set minimum required version of Qt5 in documentation (authored by kislinsk).
Automatically set minimum required version of Qt5 in documentation
Nov 30 2020, 1:12 PM
kislinsk committed rMITKd023c47ada6a: Update Boost (authored by kislinsk).
Update Boost
Nov 30 2020, 1:12 PM
kislinsk committed rMITKd17a6809c901: Increase minimum required version of CMake to 3.18 (authored by kislinsk).
Increase minimum required version of CMake to 3.18
Nov 30 2020, 1:12 PM
kislinsk committed rMITK4b76000c2bc4: Auto-clean updated external projects by default (authored by kislinsk).
Auto-clean updated external projects by default
Nov 30 2020, 1:12 PM
kislinsk committed rMITK4a46a7bbaf45: Use clang toolset on macOS (authored by kislinsk).
Use clang toolset on macOS
Nov 30 2020, 1:12 PM
kislinsk committed rMITK7efb747b216f: Do not add PCRE as dependency on Windows (authored by kislinsk).
Do not add PCRE as dependency on Windows
Nov 30 2020, 1:12 PM
kislinsk committed rMITK267ccffb09a0: Upgrade Qwt from v6.1.0 to v6.1.5 (authored by kislinsk).
Upgrade Qwt from v6.1.0 to v6.1.5
Nov 30 2020, 1:12 PM
kislinsk committed rMITK9ad33a15dfda: Merge branch 'feature/T27383-UpdateExternalToolkits' into develop (authored by kislinsk).
Merge branch 'feature/T27383-UpdateExternalToolkits' into develop
Nov 30 2020, 1:12 PM
kislinsk added a comment to T27383: Update external toolkits.

Poco 1.10.1 isn't a trivial update. It's known that Poco messes around with all the defines of Windows.h and there's a compiler definition POCO_NO_UNWINDOWS to control it that we use. However, something changed in Poco and all kinds of compiler and linker errors pop up even in unrelated modules and plugins as header declarations and implementations may differ, or method names are suddenly masked by definitions. It's hard to narrow it down as we seem to use a mix of both modes. So I call it a night for this task with all the updates mentioned above. Everything else is probably worth own dedicated tasks if necessary. The next big update we should focus on is ITK, though.

Nov 30 2020, 1:02 PM · Noteworthy, MITK (v2021.02)

Nov 29 2020

kislinsk added a comment to T27383: Update external toolkits.

Our current version of ITK does not compile with OpenCV 3.4.12.

Nov 29 2020, 7:54 AM · Noteworthy, MITK (v2021.02)

Nov 28 2020

kislinsk added a comment to T27383: Update external toolkits.

Eigen update to v3.3.8 does not work. We have to wait for v3.3.9 which is going to be released in the next few days, according to https://gitlab.com/libeigen/eigen/-/issues/2011.

Nov 28 2020, 9:42 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27383: Update external toolkits.
DependencyOld versionNew version
Boost1.701.74
cpprestsdk2.10.102.10.16
CMake3.14.53.18
CppUnit1.12.11.15.1
CTK78341aba (Dec 07, 2019)7210c5bc (Nov 08, 2020)
DCMQIea4f0809 (Jan 23, 2020)99192b76 (Nov 06, 2020)
GDCM3.0.43.0.8
Qwt6.1.06.1.5
Nov 28 2020, 11:28 AM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27383: Update external toolkits.

Pushed new branch feature/T27383-UpdateExternalToolkits.

Nov 28 2020, 6:05 AM · Noteworthy, MITK (v2021.02)
kislinsk claimed T27383: Update external toolkits.
Nov 28 2020, 5:22 AM · Noteworthy, MITK (v2021.02)
kislinsk closed T26451: DICOM plugin cannot parse DICOM directories in macOS installer as Resolved.

I close this task as it is very likely fixed in T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers. Please re-open if it is not the case for you by using the workaround or building the latest develop version . :-)

Nov 28 2020, 5:15 AM · MITK
kislinsk closed T26451: DICOM plugin cannot parse DICOM directories in macOS installer, a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Nov 28 2020, 5:15 AM · Moved to git.dkfz.de, MITK, Cleared
kislinsk edited projects for T24398: Dicom plugin: Retrieve does not work, added: MITK (v2021.02); removed MITK.
Nov 28 2020, 5:12 AM · MITK (v2024.12)
kislinsk removed a parent task for T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers: T24398: Dicom plugin: Retrieve does not work.
Nov 28 2020, 5:12 AM · Cleared, MITK (v2021.02)
kislinsk removed a subtask for T24398: Dicom plugin: Retrieve does not work: T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.
Nov 28 2020, 5:12 AM · MITK (v2024.12)
kislinsk closed T27669: Dicom import issue with MITK binaries (package) and Ubuntu, a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Nov 28 2020, 5:11 AM · Moved to git.dkfz.de, MITK, Cleared
kislinsk closed T27669: Dicom import issue with MITK binaries (package) and Ubuntu as Resolved.

Fixed in T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Nov 28 2020, 5:11 AM · Missing Info, DICOM, MITK
kislinsk closed T28006: MatchPointRegistration module compilation fails with Clang 11 as Resolved.

@nolden FYI: you can (auto-)link tasks and Differentials by either

Nov 28 2020, 5:09 AM · MITK
kislinsk added a revision to T28006: MatchPointRegistration module compilation fails with Clang 11: Unknown Object (Differential Revision).
Nov 28 2020, 5:01 AM · MITK
kislinsk closed T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies as Resolved.
Nov 28 2020, 4:59 AM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

Deleted branch bugfix/T28002-ImprovePackageDependsFiles.

Nov 28 2020, 4:58 AM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITK2fcef017026b: Improve OpenGL package depends file (authored by kislinsk).
Improve OpenGL package depends file
Nov 28 2020, 4:58 AM
kislinsk committed rMITK8d95c9efc8f5: Remove manual target_link_libraries() calls (authored by kislinsk).
Remove manual target_link_libraries() calls
Nov 28 2020, 4:58 AM
kislinsk committed rMITKb230ef804a9f: Disable doc_usersguide and doc_developersguide targets (authored by kislinsk).
Disable doc_usersguide and doc_developersguide targets
Nov 28 2020, 4:58 AM
kislinsk committed rMITK17b0699cf55e: Fix Doxygen warnings (authored by kislinsk).
Fix Doxygen warnings
Nov 28 2020, 4:58 AM
kislinsk committed rMITK43330b6521cc: Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop (authored by kislinsk).
Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop
Nov 28 2020, 4:57 AM

Nov 27 2020

kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

PACKAGE_DEPENDS now properly supports Boost, OpenMesh, OpenMP, OpenSSL, and Python3. For example:

Nov 27 2020, 10:29 AM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITK7b7ee8878f4c: Use package depends file for OpenMP (authored by kislinsk).
Use package depends file for OpenMP
Nov 27 2020, 9:59 AM
kislinsk committed rMITK60465748878a: Use package depends files for cpprestsdk and OpenSSL (authored by kislinsk).
Use package depends files for cpprestsdk and OpenSSL
Nov 27 2020, 9:59 AM
kislinsk committed rMITK060a408bbbc8: Introduce TARGET_DEPENDS option (authored by kislinsk).
Introduce TARGET_DEPENDS option
Nov 27 2020, 9:59 AM
kislinsk committed rMITK52b1bcb0fbe7: Improved Boost package depends file (authored by kislinsk).
Improved Boost package depends file
Nov 27 2020, 9:59 AM
kislinsk committed rMITKf0334bdaacfe: Use package depends file for OpenMesh (authored by kislinsk).
Use package depends file for OpenMesh
Nov 27 2020, 9:59 AM
kislinsk committed rMITK6aba543698a3: Remove dangling package depends file (authored by kislinsk).
Remove dangling package depends file
Nov 27 2020, 9:59 AM
kislinsk committed rMITK5ab8273f7517: Improve Qt5 package depends file (authored by kislinsk).
Improve Qt5 package depends file
Nov 27 2020, 9:59 AM
kislinsk committed rMITKd7ce88180b51: Improve Poco package depends file (authored by kislinsk).
Improve Poco package depends file
Nov 27 2020, 9:59 AM
kislinsk committed rMITKa05e410e0585: Use package depends file for Python3 (authored by kislinsk).
Use package depends file for Python3
Nov 27 2020, 9:59 AM
kislinsk committed rMITK665a1d1281a6: Improve ITK package depends file (authored by kislinsk).
Improve ITK package depends file
Nov 27 2020, 9:59 AM
kislinsk committed rMITK6ea1fd8356da: Add Boost dependencies (authored by kislinsk).
Add Boost dependencies
Nov 27 2020, 9:59 AM
kislinsk committed rMITKc670e289d6e7: Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop (authored by kislinsk).
Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop
Nov 27 2020, 9:59 AM

Nov 25 2020

kislinsk triaged T28006: MatchPointRegistration module compilation fails with Clang 11 as Normal priority.
Nov 25 2020, 11:47 PM · MITK
kislinsk added a comment to T28006: MatchPointRegistration module compilation fails with Clang 11.

After reading the itk::NumericTraits documentation and looking into the actual definitions of ZeroValue() I guess the fix could be:

Nov 25 2020, 11:46 PM · MITK
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

TARGET_DEPENDS parameters are directly passed to target_link_libraries() and bypass the PACKAGE_DEPENDS mechanism.

Nov 25 2020, 11:34 PM · Noteworthy, MITK (v2021.02)
kislinsk added a project to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies: Noteworthy.

Public API change: Depending on VTK does not add a transitive dependency to Qt5 Widgets anymore, except, when the required VTK components have a public dependency to Qt5 Widgets of course.

Nov 25 2020, 9:05 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

Fixed VTK and TinyXML-2 so far.

Nov 25 2020, 8:49 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITKfc9c00185dfe: Move VTK-specific code to dedicated package depends file (authored by kislinsk).
Move VTK-specific code to dedicated package depends file
Nov 25 2020, 8:46 PM
kislinsk committed rMITK64ae7f4ccf69: Use package depends file for TinyXML-2 (authored by kislinsk).
Use package depends file for TinyXML-2
Nov 25 2020, 8:46 PM
kislinsk committed rMITK68f5331438a2: Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop (authored by kislinsk).
Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop
Nov 25 2020, 8:46 PM
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

Pushed new branch bugfix/T28002-ImprovePackageDependsFiles.

Nov 25 2020, 8:46 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

Holy moly, I just learned that the package depends files work completely different than I thought/was told the past 9 years. Instead of fixing the mitk_use_modules() function we just need to use the package depends files correctly.

Nov 25 2020, 8:22 PM · Noteworthy, MITK (v2021.02)
kislinsk changed the edit policy for MITK.
Nov 25 2020, 11:26 AM
kislinsk archived mitk.org.
Nov 25 2020, 11:25 AM
kislinsk archived SIDT.
Nov 25 2020, 11:24 AM