Deleted branch from rMITK MITK: feature/T28616-FixedSizeVisualizationForPointSets.

Pushed new branch to rMITK MITK: feature/T28616-FixedSizeVisualizationForPointSets.

Thanks!

Hi there! 🙂

Deleted branch bugfix/T26745-MinorFixes.

Pushed new branch bugfix/T26745-MinorFixes.

Deleted branch bugfix/T27926-ImproveGizmoInteraction.

Pushed new branch bugfix/T27926-ImproveGizmoInteraction.

Deleted branch bugfix/T26745-MITK-VTK-Interaction.

Pushed new branch bugfix/T26745-MITK-VTK-Interaction.

Deleted branch feature/T27247-ShowConsoleWindow.

Pushed new branch feature/T27247-ShowConsoleWindow.

Deleted branch T22654-threshold-components-tool.

Deleted branch T22810-Add-tolerance-to-surfacetoimagefilter.

Deleted branch T19360-legacy-scene-surface-line-width-incompatible.

Hi there! 🙂

Hi there! 🙂

Hi there! 🙂

Hi there! 🙂

Hi there! 🙂

The actual problem is that some time ago it was decided that modifications of properties also mark the property list containing the property modified (and than the containing data node). Personally I am not a fan of this decision and this task is a good example why. However, even if everyone now would agree that it wasn't the best decision, it would be a huge pain in the back to find and fix all the code locations that rely on this mechanism. Hence, I will close this task as Won't fix, sorry. :/

FYI: VTK integrated this fix:

In T26653#188477, @kislinsk wrote:

@maleike

I re-enabled depth peeling support based on your pull request and also enabled depth peeling for volumes and FXAA. It works well for surfaces and volumes but totally breaks rendering of images/cross hair with opacity < 1. So this is not yet complete and I/we have to fix this before I am able to merge it.

Pushed new branch T26653-MasterIntegrationFixes.

All remaining issues solved by @maleike. I reintroduced the rendering mode preference but instead of switching between "Standard" (default, basically equivalent to "nothing") and "Depth Peeling" it now allows to switch between "No anti-aliasing" and "Fast Approximate Anti-Aliasing (FXAA)" (default). Depth peeling is always enabled as it only kicks in if there are translucent objects in the scene and in the worst case it is preferable to have not the fasted rendering instead of having a broken rendering. The future will show if we there is really a need to additionally add quality options regarding depth peeling.

Also PointSets have a similar problem with opacity now.

I re-enabled depth peeling support based on your pull request and also enabled depth peeling for volumes and FXAA. It works well for surfaces and volumes but totally breaks rendering of images/cross hair with opacity < 1. So this is not yet complete and I/we have to fix this before I am able to merge it.

Pushed new branch T26653-ReenableDepthPeeling.

Is this solved?

Yes. It's the two fixes that are necessary!

We try to fix these kind of compatibility issues based on the releases/2018-04 branch or backport their fix to the releases/2018-04 branch in case it was fixed only in the master branch. But I think we actually build that branch on macOS Catalina and the two fixes that were necessary are:

Thx, for the clarification. Will there be a new release? The current one is not compatible with the actual Mac OS dev kits.

Pushed new branch T19683-ShowOnlySelectedNodesSecondLevel.

Cool! 👍🏻
Will look into this on Community Day.

Requested code changes in pull request.

Merged into releases/2018-04.

Pushed new branch T26655-GizmoFix.

Not yet working. Tree doesn't collapse only the first time.

Yes, unfortunately the current solution only works for first level.

I experienced a problem with that approach:
I have an image with many segmentation nodes as child nodes. If I want to hide all segmentation nodes except for one (using "show only selected node") it does not hide all other segmentation nodes because they are not on the first level.

If you ask for all the nodes from data storage then you get also child nodes in random order. In the previous implementation, visibility of all child nodes of widgets are set to True when the widgets node is reached. Nonetheless, child nodes visibility were afterwards set to False in the outer loop.
Now the loop is only done on nodes in the first level that contain data, therefore crosshair nodes stay always visible.

Could you elaborate on this? I don't get it: aren't we processing each single data node inside the data storage?

In Ubuntu 18.04 data storage is accessed in random order therefore the visibility of crosshair was set randomly. Fixed in branch: T19683-ShowOnlySelectedNodesCrosshairVisibility-RandomAccess.

Pushed new branch T19683-ShowOnlySelectedNodesCrosshairVisibility-RandomAccess.

FYI: Nvidia used the new MITK extension mechanism to integrate their segmentation tools into MITK without touching the MITK source code.
https://github.com/NVIDIA/ai-assisted-annotation-client/tree/master/mitk-plugin

Through merge conflicts.. The baserenderer argument was added in the master.

QmitkDataNodeShowSelectedNodesAction.cpp and QmitkDataNodeShowSelectedNodesAction2.cpp in Plugins/org.mitk.gui.qt.application/src/

Which 2 actions?

Why are there now 2 actions? Did we miss some side effects with the base renderer?

Pushed new branch T19683-ShowOnlySelectedNodesCrosshairVisibilty-baseRenderer.

Would be good to leave the baseRenderer as an argument so that you can set the visibility of a specific node in a predefined base renderer (e.g. by using the RenderWindowManager). This is useful when using the new MultiWidget(Editor).

Pushed new branch T19683-ShowOnlySelectedNodesCrosshairVisibility.

No, I think in 2018.04 we even do not have SimpleITK anymore. So, closing as Invalid eventhough it was valid back then.

Is this still an open topic?

Pushed new branch T26160-PR232.