Page MenuHomePhabricator
Feed Advanced Search

May 3 2023

s434n closed T29285: [Checklist] Revise Remeshing checklist as Resolved.
May 3 2023, 11:19 AM · MITK (v2023.04), Checklist
s434n placed T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers up for grabs.

This task should be revised / kept in mind when reworking the interpolation in general

May 3 2023, 11:15 AM · MITK (v2024.06)
s434n edited projects for T29295: MONAI Label App as auto-segmentation tool in MITK, added: Next Milestone, MITK; removed MITK (v2023.04).
May 3 2023, 11:14 AM · MITK (v2024.06)
s434n placed T28491: [Segmentation] Slice interpolation 'confirm for all slices' sometimes crahes up for grabs.

This task should be revised / checked if the problem still exists when the interpolation controller has been reworked.

May 3 2023, 11:12 AM · MITK (v2023.12)
s434n placed T29105: [3D Surface Interpolation] 3D+t Interpolation Preview Crashes When Going Through Different Time Steps up for grabs.
May 3 2023, 11:07 AM · Breaking Change, MITK (v2024.06), Checklist
s434n claimed T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash.
May 3 2023, 11:02 AM · MITK (v2023.04)
s434n moved T29451: [SEG] Response labels all not displayed on Workbench from Backlog to Cycle on the MITK (v2023.04) board.
May 3 2023, 11:01 AM · Cleared, MITK (v2023.04)
s434n moved T29548: [Segmentation] Missing I- button from Backlog to Cycle on the MITK (v2023.04) board.
May 3 2023, 11:00 AM · MITK (v2023.04)
s434n moved T29554: [Segmentation] Creating a new group while interpolating causes crash from Backlog to Cycle on the MITK (v2023.04) board.
May 3 2023, 11:00 AM · MITK (v2023.04)
s434n committed rMITK73e2653f20ac: update names in MultiLabelTreeModelTest to [x] format (authored by s434n).
update names in MultiLabelTreeModelTest to [x] format
May 3 2023, 9:47 AM
s434n committed rMITKb0ecf2e828ed: Fix QmitkMultiLabelTreeModelTest (authored by s434n).
Fix QmitkMultiLabelTreeModelTest
May 3 2023, 9:47 AM

May 2 2023

s434n committed rMITK153c651cd278: Fix single slice confirmation using first label (authored by s434n).
Fix single slice confirmation using first label
May 2 2023, 3:12 PM
s434n closed T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label as Resolved by committing rMITK153c651cd278: Fix single slice confirmation using first label.
May 2 2023, 3:12 PM · MITK (v2023.04)
s434n committed rMITKd60fee688b89: add newline at end of file (authored by s434n).
add newline at end of file
May 2 2023, 3:12 PM
s434n committed rMITK6a3ba774a438: consider existing segmentation when transfering interpolated content to avoid… (authored by s434n).
consider existing segmentation when transfering interpolated content to avoid…
May 2 2023, 3:12 PM
s434n committed rMITK608eedaad204: transfer preview to correct label value in single slice confirmation (authored by s434n).
transfer preview to correct label value in single slice confirmation
May 2 2023, 3:12 PM
s434n added a comment to T29554: [Segmentation] Creating a new group while interpolating causes crash.

I think this is caused because the interpolator gets notified of a new group being added as soon as that happens, but before a new label has been added to the group. When trying to update the interpolation, it tries to get the value of the active label inside QmitkSlicesInterpolator::OnInterpolationActivated(), which causes the error because there is no active label set.

May 2 2023, 2:56 PM · MITK (v2023.04)
s434n triaged T29554: [Segmentation] Creating a new group while interpolating causes crash as High priority.
May 2 2023, 2:54 PM · MITK (v2023.04)

Apr 28 2023

s434n committed rMITKbf040ef50daa: Adapt screenshot maker to support MxN MultiWidget (authored by s434n).
Adapt screenshot maker to support MxN MultiWidget
Apr 28 2023, 4:49 PM
s434n committed rMITKa0125d7eead9: fix missing capitalization in Qt header names (authored by s434n).
fix missing capitalization in Qt header names
Apr 28 2023, 4:49 PM
s434n committed rMITKf299aefc4da2: use QDir::separator and correct Qt header name style (authored by s434n).
use QDir::separator and correct Qt header name style
Apr 28 2023, 4:49 PM
s434n committed rMITK20e10ab5b4e9: adapt screenshot maker to support MxN MultiWidget (authored by s434n).
adapt screenshot maker to support MxN MultiWidget
Apr 28 2023, 4:49 PM
s434n added a comment to T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.

I have added a fix for this in D810. It only includes a fix to OnAcceptInterpolationClicked and does not refactor AcceptAllInterpolations, which is still quite clunky. But this should at least solve the buggy behavior.

Apr 28 2023, 4:48 PM · MITK (v2023.04)
s434n added a revision to T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label: Unknown Object (Differential Revision).
Apr 28 2023, 4:46 PM · MITK (v2023.04)

Apr 27 2023

s434n committed rMITK9438e02ecc03: Disable movie maker view when MxN display is active (authored by s434n).
Disable movie maker view when MxN display is active
Apr 27 2023, 1:36 PM
s434n committed rMITK9aa6cd55c343: disable movie maker view when MxN display is active (authored by s434n).
disable movie maker view when MxN display is active
Apr 27 2023, 1:36 PM
s434n committed rMITK875a72d47d23: save parent as member in movie maker (authored by s434n).
save parent as member in movie maker
Apr 27 2023, 1:36 PM

Apr 25 2023

s434n committed rMITK9fd32f3856d8: add MxN documentation to plugin manuals list (authored by s434n).
add MxN documentation to plugin manuals list
Apr 25 2023, 2:54 PM
s434n committed rMITK870a2877df48: Fix the temporary fix for planar figures in MxN (authored by s434n).
Fix the temporary fix for planar figures in MxN
Apr 25 2023, 2:54 PM
s434n committed rMITKf12d9f2983dc: block only MxN windows instead of everything but std in planar figure temp fix (authored by s434n).
block only MxN windows instead of everything but std in planar figure temp fix
Apr 25 2023, 2:54 PM

Apr 24 2023

s434n claimed T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.
Apr 24 2023, 1:48 PM · MITK (v2023.04)
s434n committed rMITKd4252972b8b3: Temporary fix concerning planar figures and MxN (authored by s434n).
Temporary fix concerning planar figures and MxN
Apr 24 2023, 1:48 PM
s434n committed rMITK626bd28d6979: do not filter out 3d std render window in temporary fix (authored by s434n).
do not filter out 3d std render window in temporary fix
Apr 24 2023, 1:48 PM
s434n committed rMITK4de72c04025d: skip rendering of planar figures in windows that are not from StdMultiWidget (authored by s434n).
skip rendering of planar figures in windows that are not from StdMultiWidget
Apr 24 2023, 1:47 PM

Apr 21 2023

s434n added a comment to T29333: [mxn multi widget] Measurements / planar figure not working.

Since this is probably not going to be fixed until this release, I have added a safeguard in PlanarFigureMapper2D::MitkRender() that completely skips rendering of planar figures in all windows that don't belong to the StdMultiWidget, to avoid unexpected behavior and crashes.
When this task is tackled, that needs to be removed!

Apr 21 2023, 3:34 PM · MITK (v2024.06)
s434n claimed T29302: Movie maker plugin does not work correctly with the new mxn multi widget.
Apr 21 2023, 1:46 PM · MITK (v2024.06)
s434n closed T29531: [Properties][MxN] Properties view can crash when windows are changed as Resolved.
Apr 21 2023, 11:32 AM · MITK (v2023.04)
s434n committed rMITKf32a54c1ca37: Make selection in Properties view update on changes (authored by s434n).
Make selection in Properties view update on changes
Apr 21 2023, 11:31 AM
s434n committed rMITKd40cec3d36b3: remove hardcoded number in check before resetting combobox (authored by s434n).
remove hardcoded number in check before resetting combobox
Apr 21 2023, 11:31 AM
s434n committed rMITKae843d11ccfa: update combobox of render window names when IRenderWindowPart changes or is… (authored by s434n).
update combobox of render window names when IRenderWindowPart changes or is…
Apr 21 2023, 11:31 AM

Apr 20 2023

s434n added a revision to T29531: [Properties][MxN] Properties view can crash when windows are changed: Unknown Object (Differential Revision).
Apr 20 2023, 2:49 PM · MITK (v2023.04)
s434n triaged T29531: [Properties][MxN] Properties view can crash when windows are changed as Normal priority.
Apr 20 2023, 2:01 PM · MITK (v2023.04)

Apr 19 2023

s434n closed T29347: Measurement Checklist - Possible inconsistent recentering behavior when clicking on geometry node in Data Manager. as Invalid.

It was discussed and agreed upon, that it does not make sense to adapt this behavior in the Data Manager. If we want a clean implementation of the "set focus on planar figure"-feature, it should belong in the corresponding view (i.e. Measurement) instead of the Data Manager.
As this is not currently a specifically requested feature, this task will be closed.

Apr 19 2023, 12:00 PM · Request for Discussion, Checklist

Apr 17 2023

s434n added a comment to T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers.

This is not solved with {D795}, right? I can still see slicer->GetRenderer() in line 926, so the render window is still retrieved from the slice navigation controller, which requires the getter to be available in the slice navigation controller.

Apr 17 2023, 6:00 PM · MITK (v2024.06)
s434n closed T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly as Resolved.
Apr 17 2023, 1:02 PM · Request for Discussion, MITK (v2023.04)
s434n committed rMITKcb3252d138eb: Make interpolation work with arbitrary windows (authored by s434n).
Make interpolation work with arbitrary windows
Apr 17 2023, 1:02 PM
s434n committed rMITKdb669006e1b4: remove unused parameter (authored by s434n).
remove unused parameter
Apr 17 2023, 1:02 PM
s434n committed rMITKf54d96a9d628: use corner annotation text and update code style (authored by s434n).
use corner annotation text and update code style
Apr 17 2023, 1:02 PM
s434n committed rMITK3633565343ee: make interpolation work with arbitrary windows instead of hardcoded std windows (authored by s434n).
make interpolation work with arbitrary windows instead of hardcoded std windows
Apr 17 2023, 1:02 PM

Apr 14 2023

s434n added a revision to T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly: Unknown Object (Differential Revision).
Apr 14 2023, 11:51 AM · Request for Discussion, MITK (v2023.04)
s434n edited projects for T29347: Measurement Checklist - Possible inconsistent recentering behavior when clicking on geometry node in Data Manager., added: Request for Discussion; removed MITK (v2023.04), Cleared.

After looking at the checklist again, I don't think there is a need to change anything. The checklist specifically only speaks of selecting the line-node once. When following the checklist instructions, everything should work as described.

Apr 14 2023, 11:23 AM · Request for Discussion, Checklist

Apr 13 2023

s434n added a comment to T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.
Apr 13 2023, 5:18 PM · MITK (v2023.04)
s434n updated the task description for T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.
Apr 13 2023, 5:15 PM · MITK (v2023.04)
s434n triaged T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label as High priority.
Apr 13 2023, 5:15 PM · MITK (v2023.04)

Apr 4 2023

s434n claimed T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.
Apr 4 2023, 3:33 PM · Request for Discussion, MITK (v2023.04)
s434n claimed T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers.
Apr 4 2023, 3:29 PM · MITK (v2024.06)

Apr 3 2023

s434n committed rMITKfc6a61b982a3: Fix some bugs in MxN crosshairscorrectly enable/disable crosshairs and fix… (authored by s434n).
Fix some bugs in MxN crosshairscorrectly enable/disable crosshairs and fix…
Apr 3 2023, 10:30 AM
s434n committed rMITK382c8cfb7894: correctly enable/disable crosshairs and fix crosshair rendering on inverted… (authored by s434n).
correctly enable/disable crosshairs and fix crosshair rendering on inverted…
Apr 3 2023, 10:30 AM

Mar 31 2023

s434n closed T29297: [mxn multi widget] Optimize data accessibility inside render windows as Resolved.
Mar 31 2023, 11:47 AM · MITK (v2023.04)
s434n removed a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29298: [mxn multi widget] Add context menu to render window specific data inspector.
Mar 31 2023, 11:45 AM · MITK (v2023.04)
s434n removed a parent task for T29298: [mxn multi widget] Add context menu to render window specific data inspector: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Mar 31 2023, 11:45 AM · MITK
s434n removed a parent task for T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Mar 31 2023, 11:45 AM · MITK (v2023.04)
s434n removed a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized.
Mar 31 2023, 11:45 AM · MITK (v2023.04)
s434n renamed T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized from [mxn multi widget] Allow drag 'n drop in render window specific data inspector to [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized.
Mar 31 2023, 11:44 AM · MITK (v2023.04)

Mar 30 2023

s434n added a comment to T26555: [mxn multi widget] Provide different default layouts.

This task is basically done with D778, which introduced a mechanism to save/load custom layouts, as well as select from provided presets. The only thing we could further add would be more presets, as there is only one at the moment (two rows with each view direction each).

Mar 30 2023, 11:07 AM · MITK
s434n committed rMITKff61541ae92d: Introduce saving and loading of custom and preset window layouts (authored by s434n).
Introduce saving and loading of custom and preset window layouts
Mar 30 2023, 11:05 AM
s434n committed rMITK51364988ffb6: Merge branch 'develop' into feature/T26555-mxn-default-layouts (authored by s434n).
Merge branch 'develop' into feature/T26555-mxn-default-layouts
Mar 30 2023, 11:05 AM
s434n committed rMITK08f94571dd80: correctly set view plane selection in utility widgets (authored by s434n).
correctly set view plane selection in utility widgets
Mar 30 2023, 11:05 AM
s434n committed rMITKcad68daa40c7: make required connection type clearer for save signal (authored by s434n).
make required connection type clearer for save signal
Mar 30 2023, 11:05 AM
s434n committed rMITKce36b832b6ad: replace filename in SaveLayout function with an ostream (authored by s434n).
replace filename in SaveLayout function with an ostream
Mar 30 2023, 11:05 AM
s434n committed rMITKdd4691c235ac: Add default name to custom window layouts (authored by s434n).
Add default name to custom window layouts
Mar 30 2023, 11:05 AM
s434n committed rMITK0b9302b9c098: improve error handling and slight restructuring for simplification (authored by s434n).
improve error handling and slight restructuring for simplification
Mar 30 2023, 11:05 AM
s434n committed rMITKf21434068e4e: make window layout presets more distinct by name prefix (authored by s434n).
make window layout presets more distinct by name prefix
Mar 30 2023, 11:05 AM
s434n committed rMITKa9657c01042c: unify CustomLayoutLoad and PresetLayoutLoad in general LoadLayout (authored by s434n).
unify CustomLayoutLoad and PresetLayoutLoad in general LoadLayout
Mar 30 2023, 11:05 AM
s434n committed rMITKa39d22d1d7d1: fix dependency and unusable QT ui parameter (authored by s434n).
fix dependency and unusable QT ui parameter
Mar 30 2023, 11:05 AM
s434n committed rMITK57bdb4e383f8: make integer counter unsigned to get rid of comparison warnings (authored by s434n).
make integer counter unsigned to get rid of comparison warnings
Mar 30 2023, 11:05 AM
s434n committed rMITK118762582cc7: introduce saving and loading of custom and preset window layouts (authored by s434n).
introduce saving and loading of custom and preset window layouts
Mar 30 2023, 11:05 AM

Mar 29 2023

s434n added a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus.
Mar 29 2023, 4:38 PM · MITK
s434n added a parent task for T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Mar 29 2023, 4:38 PM · MITK (v2024.06)
s434n triaged T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus as Low priority.
Mar 29 2023, 4:38 PM · MITK (v2024.06)
s434n added a comment to T29492: [mxn multi widget] Update and extend checklist.

This was briefly touched upon in the group meeting today. An idea that came up was to include a section in some checklists to gather feedback on existing and suggestions for new features / UX in general.

Mar 29 2023, 11:26 AM · MITK (v2023.04)
s434n claimed T29492: [mxn multi widget] Update and extend checklist.
Mar 29 2023, 11:24 AM · MITK (v2023.04)

Feb 22 2023

s434n claimed T26555: [mxn multi widget] Provide different default layouts.
Feb 22 2023, 5:11 PM · MITK
s434n removed a project from T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View: Request for Discussion.
Feb 22 2023, 5:07 PM · MITK (v2023.04), Restricted Project

Feb 13 2023

s434n moved T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View from Backlog to MITK Meeting on the Request for Discussion board.
Feb 13 2023, 1:26 PM · MITK (v2023.04), Restricted Project
s434n added a project to T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View: Request for Discussion.
Feb 13 2023, 1:26 PM · MITK (v2023.04), Restricted Project

Feb 7 2023

s434n closed T29446: Create a citation file for MITK as Resolved.
Feb 7 2023, 1:44 PM · MITK (v2023.04)
s434n committed rMITK843460b12e3c: add further review suggestions (authored by s434n).
add further review suggestions
Feb 7 2023, 1:43 PM
s434n committed rMITKfe4dd45bdb9d: Add citation file (authored by s434n).
Add citation file
Feb 7 2023, 1:43 PM
s434n committed rMITKa1c59b23625a: add review suggestions (authored by s434n).
add review suggestions
Feb 7 2023, 1:43 PM
s434n committed rMITK5e0a85e5a994: add initial version of citation file (authored by s434n).
add initial version of citation file
Feb 7 2023, 1:43 PM

Feb 2 2023

s434n added a comment to T29347: Measurement Checklist - Possible inconsistent recentering behavior when clicking on geometry node in Data Manager..

I don't think it is necessarily a bug, but rather unintuitive how it works. The recentering is not triggered by the clicking of a node, but via changes in the selection. One can also do things like select multiple lines (on different slices), then deselect one, and the view recenters to one of the still selected nodes.
For me, it would feel more intuitive if the view just recenters every time a node is clicked, regardless of the selection. But there is no bug apparent to me here.

Feb 2 2023, 11:47 AM · Request for Discussion, Checklist

Jan 31 2023

s434n moved T29446: Create a citation file for MITK from Backlog to Cycle on the MITK (v2023.04) board.
Jan 31 2023, 10:29 AM · MITK (v2023.04)

Jan 27 2023

s434n added a revision to T29446: Create a citation file for MITK: Unknown Object (Differential Revision).
Jan 27 2023, 5:25 PM · MITK (v2023.04)

Jan 25 2023

s434n triaged T29446: Create a citation file for MITK as Normal priority.
Jan 25 2023, 11:52 AM · MITK (v2023.04)

Nov 29 2022

s434n moved T29392: [SEG] Add dedicated writer to store multi-label images in nifti from Backlog to In candidates on the MITK (v2023.04) board.
Nov 29 2022, 1:44 PM · MITK (v2024.06)
s434n edited projects for T29392: [SEG] Add dedicated writer to store multi-label images in nifti, added: MITK (v2023.04); removed MITK.
Nov 29 2022, 1:44 PM · MITK (v2024.06)
s434n moved T29415: [mxn multi widget] Allow mxn windows to show 3D view from Backlog to In candidates on the MITK (v2023.04) board.
Nov 29 2022, 1:41 PM · MITK (v2024.06)
s434n edited projects for T29415: [mxn multi widget] Allow mxn windows to show 3D view, added: MITK (v2023.04); removed MITK.
Nov 29 2022, 1:41 PM · MITK (v2024.06)
s434n moved T28800: [Segmentation] Threshold tool updates after each digit if typed in manually from In candidates to Segmentation on the MITK (v2023.04) board.
Nov 29 2022, 1:38 PM · MITK (v2023.12), Checklist, Request for Discussion