Page MenuHomePhabricator
Feed Advanced Search

Oct 21 2022

kislinsk closed T29106: [Segmentation Options] "show only selected nodes" is not immediately applied as Resolved by committing rMITK61b0df79d32e: Immediately apply "Show only selected nodes".
Oct 21 2022, 6:02 AM · MITK (v2022.10), Checklist
kislinsk added a comment to T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation.

Deleted branch from rMITK MITK: bugfix/T28936-RemoveMultilabelSegmentationPlugin.

Oct 21 2022, 6:00 AM · MITK (v2022.10), Breaking Change
kislinsk committed rMITK5e85b0218094: Remove Multilabel Segmentation plugin (authored by kislinsk).
Remove Multilabel Segmentation plugin
Oct 21 2022, 6:00 AM
kislinsk closed T27810: [Multilabel Segmentation] Inconsistencies and unclear functionality in operations of Utilities view, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Oct 21 2022, 6:00 AM · MITK (v2022.10), Breaking Change
kislinsk closed T27810: [Multilabel Segmentation] Inconsistencies and unclear functionality in operations of Utilities view as Resolved by committing rMITK06e76d49de6b: Remove Multilabel Segmentation plugin.
Oct 21 2022, 6:00 AM · MITK (v2022.10), Cleared, Restricted Project
kislinsk closed T28500: Multilabel Segmentation Utilities do not work for multilabel segmentations, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Oct 21 2022, 6:00 AM · MITK (v2022.10), Breaking Change
kislinsk closed T28500: Multilabel Segmentation Utilities do not work for multilabel segmentations as Resolved by committing rMITK06e76d49de6b: Remove Multilabel Segmentation plugin.
Oct 21 2022, 6:00 AM · MITK (v2024.06), Missing Info
kislinsk closed T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries / dimensions in Utilities View as Resolved by committing rMITK06e76d49de6b: Remove Multilabel Segmentation plugin.
Oct 21 2022, 6:00 AM · MITK (v2022.10), Cleared
kislinsk closed T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries / dimensions in Utilities View, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Oct 21 2022, 6:00 AM · MITK (v2022.10), Breaking Change
kislinsk closed T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation as Resolved by committing rMITK06e76d49de6b: Remove Multilabel Segmentation plugin.
Oct 21 2022, 6:00 AM · MITK (v2022.10), Breaking Change
kislinsk closed T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, a subtask of T28176: [Segmentation] Inspection of module and plugin, as Resolved.
Oct 21 2022, 6:00 AM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk committed rMITK06e76d49de6b: Remove Multilabel Segmentation plugin (authored by kislinsk).
Remove Multilabel Segmentation plugin
Oct 21 2022, 6:00 AM

Oct 20 2022

kislinsk moved T29368: Fill tool uses wrong label value from Backlog to Segmentation on the MITK (v2022.10) board.
Oct 20 2022, 10:53 AM · MITK (v2022.10)
kislinsk triaged T29368: Fill tool uses wrong label value as Unbreak Now! priority.
Oct 20 2022, 10:53 AM · MITK (v2022.10)
kislinsk changed the visibility for F2578705: bug.mitk.
Oct 20 2022, 10:53 AM

Oct 19 2022

kislinsk added a revision to T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries / dimensions in Utilities View: Unknown Object (Differential Revision).
Oct 19 2022, 12:20 PM · MITK (v2022.10), Cleared
kislinsk added a revision to T27810: [Multilabel Segmentation] Inconsistencies and unclear functionality in operations of Utilities view: Unknown Object (Differential Revision).
Oct 19 2022, 12:20 PM · MITK (v2022.10), Cleared, Restricted Project
kislinsk added a revision to T28500: Multilabel Segmentation Utilities do not work for multilabel segmentations: Unknown Object (Differential Revision).
Oct 19 2022, 12:20 PM · MITK (v2024.06), Missing Info
kislinsk added a revision to T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation: Unknown Object (Differential Revision).
Oct 19 2022, 12:20 PM · MITK (v2022.10), Breaking Change
kislinsk added a comment to T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation.

Pushed new branch to rMITK MITK: bugfix/T28936-RemoveMultilabelSegmentationPlugin.

Oct 19 2022, 12:17 PM · MITK (v2022.10), Breaking Change
kislinsk claimed T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation.
Oct 19 2022, 12:13 PM · MITK (v2022.10), Breaking Change
kislinsk raised the priority of T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading from Normal to High.
Oct 19 2022, 11:25 AM · Cleared, Checklist, MITK (v2022.10)
kislinsk lowered the priority of T28524: Refactor LabelSetImage and associated classes. from Unbreak Now! to Normal.
Oct 19 2022, 10:29 AM · MITK, Next Milestone
kislinsk lowered the priority of T28525: Design refactoring of LabelSetImage and associated classes from Unbreak Now! to Normal.
Oct 19 2022, 10:29 AM · Next Milestone
kislinsk edited projects for T29340: Colored pixels remain unchanged, even when sliding the Level Window slider to low numbers, added: Next Milestone; removed MITK (v2022.10).

I think it actually is an issue or at least unexpected. The level window seems to have trouble with color images in general.

Oct 19 2022, 10:27 AM · Next Milestone, Missing Info, Checklist
kislinsk lowered the priority of T29340: Colored pixels remain unchanged, even when sliding the Level Window slider to low numbers from Unbreak Now! to Normal.
Oct 19 2022, 10:26 AM · Next Milestone, Missing Info, Checklist
kislinsk updated the task description for T29367: [Segmentation] New render window specific reinit warning is confusing.
Oct 19 2022, 8:54 AM · MITK (v2022.10)
kislinsk moved T29367: [Segmentation] New render window specific reinit warning is confusing from Backlog to MITK Meeting on the Request for Discussion board.
Oct 19 2022, 8:53 AM · MITK (v2022.10)
kislinsk moved T29367: [Segmentation] New render window specific reinit warning is confusing from Backlog to Segmentation on the MITK (v2022.10) board.
Oct 19 2022, 8:53 AM · MITK (v2022.10)
kislinsk triaged T29367: [Segmentation] New render window specific reinit warning is confusing as Unbreak Now! priority.
Oct 19 2022, 8:53 AM · MITK (v2022.10)
kislinsk changed the visibility for F2578516: test.mitk.
Oct 19 2022, 8:40 AM
kislinsk claimed T29106: [Segmentation Options] "show only selected nodes" is not immediately applied.

I hope it's okay that I took over D687? Please have a look at it and try to understand the solution as well as the difference to the previously suggested solution.

Oct 19 2022, 7:10 AM · MITK (v2022.10), Checklist

Oct 18 2022

kislinsk committed rMITK870c9308f540: Simplify allocations (authored by kislinsk).
Simplify allocations
Oct 18 2022, 9:35 PM
kislinsk committed rMITKc35d03a0524f: Remove unused methods (authored by kislinsk).
Remove unused methods
Oct 18 2022, 9:35 PM
kislinsk added a comment to T29342: Workbench reports excessive RAM usage on MacOSX Monterey.

Deleted branch from rMITK MITK: bugfix/T29342-FixReportOfProcessMemory.

Oct 18 2022, 9:35 PM · Checklist, MITK (v2022.10)
kislinsk committed rMITK2091b0c85e5d: Match reported memory usage on Linux to GNOME system monitor (authored by kislinsk).
Match reported memory usage on Linux to GNOME system monitor
Oct 18 2022, 9:35 PM
kislinsk committed rMITK00e9644fb1a4: Modernize class design and fix small inaccuracies (authored by kislinsk).
Modernize class design and fix small inaccuracies
Oct 18 2022, 9:35 PM
kislinsk committed rMITK88f922990164: Match reported memory usage on macOS to Chromium (authored by kislinsk).
Match reported memory usage on macOS to Chromium
Oct 18 2022, 9:35 PM
kislinsk committed rMITK5aa449e9337e: Removed unused include (authored by kislinsk).
Removed unused include
Oct 18 2022, 9:35 PM
kislinsk closed T29342: Workbench reports excessive RAM usage on MacOSX Monterey as Resolved by committing rMITKe77f5618dad4: Fix reports of memory usage on Linux and macOS.
Oct 18 2022, 9:35 PM · Checklist, MITK (v2022.10)
kislinsk committed rMITKe77f5618dad4: Fix reports of memory usage on Linux and macOS (authored by kislinsk).
Fix reports of memory usage on Linux and macOS
Oct 18 2022, 9:35 PM
kislinsk closed T29366: Add Turbo colormap as Resolved.
Oct 18 2022, 3:52 PM · MITK (v2022.10)
kislinsk added a comment to T29366: Add Turbo colormap.

Deleted branch from rMITK MITK: feature/T29366-TurboColorMap.

Oct 18 2022, 3:52 PM · MITK (v2022.10)
kislinsk committed rMITK486d27ca88c7: Add Turbo colormap (authored by kislinsk).
Add Turbo colormap
Oct 18 2022, 3:52 PM
kislinsk committed rMITK1a76b443aad6: Merge branch 'feature/T29366-TurboColorMap' into develop (authored by kislinsk).
Merge branch 'feature/T29366-TurboColorMap' into develop
Oct 18 2022, 3:52 PM
kislinsk added a comment to T29366: Add Turbo colormap.

Pushed new branch to rMITK MITK: feature/T29366-TurboColorMap.

Oct 18 2022, 3:51 PM · MITK (v2022.10)
kislinsk triaged T29366: Add Turbo colormap as Wishlist priority.
Oct 18 2022, 3:49 PM · MITK (v2022.10)

Oct 17 2022

kislinsk added a comment to T29357: [Segmentation] Tools can be activated without selected label.

Deleted branch from rMITK MITK: bugfix/T29357-FixToolButtonsEnabledCheck.

Oct 17 2022, 3:12 PM · Breaking Change, Checklist, MITK (v2022.10)
kislinsk committed rMITKc2cc1b889425: Remove EnabledMode from QmitkToolSelectionBox (authored by kislinsk).
Remove EnabledMode from QmitkToolSelectionBox
Oct 17 2022, 3:12 PM
kislinsk closed T29357: [Segmentation] Tools can be activated without selected label as Resolved by committing rMITKdca8a8f6c291: Remove EnabledMode from QmitkToolSelectionBox.
Oct 17 2022, 3:12 PM · Breaking Change, Checklist, MITK (v2022.10)
kislinsk committed rMITKdca8a8f6c291: Remove EnabledMode from QmitkToolSelectionBox (authored by kislinsk).
Remove EnabledMode from QmitkToolSelectionBox
Oct 17 2022, 3:12 PM
kislinsk added a project to T29357: [Segmentation] Tools can be activated without selected label: Breaking Change.
Oct 17 2022, 12:00 PM · Breaking Change, Checklist, MITK (v2022.10)
kislinsk added a revision to T29357: [Segmentation] Tools can be activated without selected label: Unknown Object (Differential Revision).
Oct 17 2022, 11:59 AM · Breaking Change, Checklist, MITK (v2022.10)
kislinsk added a comment to T29357: [Segmentation] Tools can be activated without selected label.

Pushed new branch to rMITK MITK: bugfix/T29357-FixToolButtonsEnabledCheck.

Oct 17 2022, 11:28 AM · Breaking Change, Checklist, MITK (v2022.10)
kislinsk claimed T29357: [Segmentation] Tools can be activated without selected label.
Oct 17 2022, 11:06 AM · Breaking Change, Checklist, MITK (v2022.10)
kislinsk added a comment to T29353: [SEG] segmentation view ends up in invalid state if segmentations are loaded before images.

Deleted branch from rMITK MITK: bugfix/T29353-InvalidSegmentationViewStates.

Oct 17 2022, 9:06 AM · Checklist, MITK (v2022.10)
kislinsk committed rMITK4ad97a5dfe79: Rename On prefix from methods that are no slots (authored by kislinsk).
Rename On prefix from methods that are no slots
Oct 17 2022, 9:05 AM
kislinsk committed rMITK4bd91c146951: Fix selection handling of Segmentation View (authored by kislinsk).
Fix selection handling of Segmentation View
Oct 17 2022, 9:05 AM
kislinsk committed rMITK47a8b41133bc: Fix unused parameter warning (authored by kislinsk).
Fix unused parameter warning
Oct 17 2022, 9:05 AM
kislinsk committed rMITK6c3ea29d3d69: Fix a potentially wrong segmentation selection (authored by kislinsk).
Fix a potentially wrong segmentation selection
Oct 17 2022, 9:05 AM
kislinsk committed rMITK035c6062c0f4: Refactor self-call check per instance (authored by kislinsk).
Refactor self-call check per instance
Oct 17 2022, 9:05 AM
kislinsk committed rMITK94c627cbe744: Show interpolation warning only with multiple labels (authored by kislinsk).
Show interpolation warning only with multiple labels
Oct 17 2022, 9:05 AM
kislinsk committed rMITK03cb15e10697: Fix invalid states of Segmentation View for certain selection scenarios (authored by kislinsk).
Fix invalid states of Segmentation View for certain selection scenarios
Oct 17 2022, 9:05 AM
kislinsk closed T29353: [SEG] segmentation view ends up in invalid state if segmentations are loaded before images as Resolved by committing rMITK03cb15e10697: Fix invalid states of Segmentation View for certain selection scenarios.
Oct 17 2022, 9:05 AM · Checklist, MITK (v2022.10)

Oct 14 2022

kislinsk added a comment to T29338: "Rename Label" window improvements.

Deleted branch from rMITK MITK: bugfix/T29338-RenameLabelWindowImprovements.

Oct 14 2022, 5:21 PM · MITK (v2022.10)
kislinsk committed rMITK1db0fce17a1f: Remove unused includes (authored by kislinsk).
Remove unused includes
Oct 14 2022, 5:21 PM
kislinsk committed rMITK4350791bddb6: Keep order of custom suggestions (authored by kislinsk).
Keep order of custom suggestions
Oct 14 2022, 5:21 PM
kislinsk committed rMITKff731492a348: Fix deadlock (authored by kislinsk).
Fix deadlock
Oct 14 2022, 5:21 PM
kislinsk committed rMITK7aa06a06c548: Save and restore geometry of QmitkNewSegmentationDialog (authored by kislinsk).
Save and restore geometry of QmitkNewSegmentationDialog
Oct 14 2022, 5:21 PM
kislinsk committed rMITK8a1b79c3cdcc: Only allow suggestions with unique names (authored by kislinsk).
Only allow suggestions with unique names
Oct 14 2022, 5:21 PM
kislinsk committed rMITK1a6512e0746b: Rename label on ALT + double click (authored by kislinsk).
Rename label on ALT + double click
Oct 14 2022, 5:21 PM
kislinsk closed T29338: "Rename Label" window improvements, a subtask of T29157: NCT ISSO Annotation Support with MITK Segmentation Flow, as Resolved.
Oct 14 2022, 5:21 PM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk closed T29338: "Rename Label" window improvements as Resolved by committing rMITK1df5a1490746: Improve New/Rename Label dialog.
Oct 14 2022, 5:21 PM · MITK (v2022.10)
kislinsk committed rMITK1df5a1490746: Improve New/Rename Label dialog (authored by kislinsk).
Improve New/Rename Label dialog
Oct 14 2022, 5:21 PM
kislinsk added a comment to T29342: Workbench reports excessive RAM usage on MacOSX Monterey.

Fixed on all platforms now.

Oct 14 2022, 3:10 PM · Checklist, MITK (v2022.10)
kislinsk added a revision to T29342: Workbench reports excessive RAM usage on MacOSX Monterey: Unknown Object (Differential Revision).
Oct 14 2022, 3:07 PM · Checklist, MITK (v2022.10)
kislinsk added a comment to T29342: Workbench reports excessive RAM usage on MacOSX Monterey.

Besides some maintenance work along the road, I verified the process memory report on Windows and matched it to the GNOME system monitor memory report on Linux.

Oct 14 2022, 12:29 PM · Checklist, MITK (v2022.10)
kislinsk added a comment to T29342: Workbench reports excessive RAM usage on MacOSX Monterey.

Pushed new branch to rMITK MITK: bugfix/T29342-FixReportOfProcessMemory.

Oct 14 2022, 12:27 PM · Checklist, MITK (v2022.10)
kislinsk assigned T29360: [Storage inspector] Node predicate not used correctly to kalali.
Oct 14 2022, 7:13 AM · MITK (v2022.10)
kislinsk closed T29345: Level Window Checklist - Default range of loaded image different for Ubuntu 22.04 and Windows 10. as Invalid.

Same for Windows 10, Ubuntu 20.04, and Ubuntu 22.04.

Oct 14 2022, 7:12 AM · Missing Info, Checklist, MITK (v2022.10)

Oct 13 2022

kislinsk added a revision to T29353: [SEG] segmentation view ends up in invalid state if segmentations are loaded before images: Unknown Object (Differential Revision).
Oct 13 2022, 4:51 PM · Checklist, MITK (v2022.10)
kislinsk added a comment to T29353: [SEG] segmentation view ends up in invalid state if segmentations are loaded before images.

Pushed new branch to rMITK MITK: bugfix/T29353-InvalidSegmentationViewStates.

Oct 13 2022, 4:33 PM · Checklist, MITK (v2022.10)
kislinsk added a comment to T29353: [SEG] segmentation view ends up in invalid state if segmentations are loaded before images.

Looking at the code I noticed that there are quite a few possibilities to trigger invalid states which all have in common, that the selection of the reference image or working image are handled separately while neglecting the overall selection situation. I will refactor the two OnSelection handlers into a common one that can assess the overall situation without duplicating logic. This will also fix a few other bugs and will also enable to use the layer, label, and label set widgets when only a working image is selected. This is totally fine as all actions these widgets provide are independent from a reference image.

Oct 13 2022, 3:03 PM · Checklist, MITK (v2022.10)
kislinsk closed T29350: NodeSelectionDialog window, ok btn is only partially visible in some resolutions as Resolved.
Oct 13 2022, 11:12 AM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kislinsk added a comment to T29350: NodeSelectionDialog window, ok btn is only partially visible in some resolutions.

Deleted branch from rMITK MITK: bugfix/T29350-NodeSelectionDialogNeedsMarginAndSpacing.

Oct 13 2022, 11:12 AM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kislinsk committed rMITKc6974b7170ca: Reset margin and spacing to defaults (authored by kislinsk).
Reset margin and spacing to defaults
Oct 13 2022, 11:11 AM
kislinsk committed rMITK641e779ba527: Merge branch 'bugfix/T29350-NodeSelectionDialogNeedsMarginAndSpacing' into… (authored by kislinsk).
Merge branch 'bugfix/T29350-NodeSelectionDialogNeedsMarginAndSpacing' into…
Oct 13 2022, 11:11 AM
kislinsk added a comment to T29350: NodeSelectionDialog window, ok btn is only partially visible in some resolutions.

Pushed new branch to rMITK MITK: bugfix/T29350-NodeSelectionDialogNeedsMarginAndSpacing.

Oct 13 2022, 11:11 AM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kislinsk claimed T29350: NodeSelectionDialog window, ok btn is only partially visible in some resolutions.
Oct 13 2022, 11:07 AM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kislinsk edited projects for T29337: Global Reinit HotKey functionality not there in Mac OSX, added: Cleared; removed Missing Info.

It works on Windows and Ubuntu. The default hotkey for reinit is Ctrl+R and can be specified in the preferences. Maybe Ctrl+R has already a special meaning on macOS. We need to check but I would classify this task as cleared for further investigation.

Oct 13 2022, 10:43 AM · MITK (v2024.12), Cleared, Checklist
kislinsk added a project to T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading: Cleared.

The images mentioned in the checklist are:

Oct 13 2022, 10:33 AM · Cleared, Checklist, MITK (v2022.10)
kislinsk updated the task description for T29345: Level Window Checklist - Default range of loaded image different for Ubuntu 22.04 and Windows 10..
Oct 13 2022, 10:24 AM · Missing Info, Checklist, MITK (v2022.10)
kislinsk claimed T29345: Level Window Checklist - Default range of loaded image different for Ubuntu 22.04 and Windows 10..
Oct 13 2022, 10:22 AM · Missing Info, Checklist, MITK (v2022.10)
kislinsk added a project to T29346: Level Window Checklist - Level Window slider inconsistent upper/lower bound behavior on mouse clicks.: Cleared.
Oct 13 2022, 10:21 AM · MITK (v2023.04), Cleared
kislinsk edited projects for T29348: Improve Welcome page with basic navigation hints, added: Cleared; removed Restricted Project.
Oct 13 2022, 10:21 AM · Cleared, Checklist, MITK (v2022.10)
kislinsk added a project to T29355: Update 3D Segmentation Checklist to reflect current 3D Segmentation tools status: Cleared.
Oct 13 2022, 10:20 AM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kislinsk removed a project from T29344: Image Rendering - No difference between "Jet" and "Jet Transparent": Missing Info.
Oct 13 2022, 10:20 AM · Cleared, Checklist, MITK (v2022.10)
kislinsk added a project to T29344: Image Rendering - No difference between "Jet" and "Jet Transparent": Cleared.
Oct 13 2022, 10:19 AM · Cleared, Checklist, MITK (v2022.10)
kislinsk added a project to T29350: NodeSelectionDialog window, ok btn is only partially visible in some resolutions: Cleared.
Oct 13 2022, 10:18 AM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kislinsk renamed T29348: Improve Welcome page with basic navigation hints from Checklist Measurement - Possible bug in zoom behavior. to Improve Welcome page with basic navigation hints.
Oct 13 2022, 10:16 AM · Cleared, Checklist, MITK (v2022.10)