Page MenuHomePhabricator
Feed Advanced Search

Jul 27 2020

thomass committed rMITKdb8bf5c52f67: Rename documentation manual page names with leading the (authored by thomass).
Rename documentation manual page names with leading the
Jul 27 2020, 3:48 PM
thomass added a revision to T27610: [MITKDoc] Rename Plugin and Module names with leading "The" article: Unknown Object (Differential Revision).
Jul 27 2020, 3:29 PM · MITK (v2021.02)
thomass created T27610: [MITKDoc] Rename Plugin and Module names with leading "The" article.
Jul 27 2020, 2:40 PM · MITK (v2021.02)
thomass added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

So I am not quite sure that about the re-init problem but to further clarify my list:

Jul 27 2020, 8:35 AM · MITK (v2021.10), Missing Info, Restricted Project

Jul 24 2020

thomass added a comment to T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data .

I would suggest that you land it for now since it solves the bug and I will create another task in which I also take a look into the stepper problem. But both is fine for me :)

Jul 24 2020, 12:42 PM · MITK (v2021.02)

Jul 22 2020

thomass updated the task description for T27105: [MITKDoc] Revise Measurement Plugin Documentation.
Jul 22 2020, 8:45 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27106: [MITKDoc] Revise Volume Visualization Plugin Documentation.
Jul 22 2020, 8:44 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27107: [MITKDoc] Revise Screenshot Maker Plugin Documentation.
Jul 22 2020, 8:44 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27108: [MITKDoc] Revise Remeshing Plugin Documentation.
Jul 22 2020, 8:43 AM · MITK (v2021.02)
thomass updated the task description for T27109: [MITKDoc] Revise Properties Plugin Documentation.
Jul 22 2020, 8:43 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27110: [MITKDoc] Revise Command Line Tool/ Automatisation Plugin Documentation.
Jul 22 2020, 8:42 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27111: [MITKDoc] Revise Matchpoint Registration Visualizer Plugin Documentation.
Jul 22 2020, 8:42 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27112: [MITKDoc] Revise Matchpoint Registration Evaluator Plugin Documentation.
Jul 22 2020, 8:41 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27113: [MITKDoc] Revise Matchpoint Registration Manipulator Plugin Documentation.
Jul 22 2020, 8:41 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27114: [MITKDoc] Revise Matchpoint Mapper Plugin Documentation.
Jul 22 2020, 8:40 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27115: [MITKDoc] Revise Matchpoint Frame Correction Plugin Documentation.
Jul 22 2020, 8:39 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27116: [MITKDoc] Revise Matchpoint Algorithm Browser Plugin Documentation.
Jul 22 2020, 8:39 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27117: [MITKDoc] Revise Matchpoint Algorithm Control Plugin Documentation.
Jul 22 2020, 8:38 AM · Cleared, MITK (v2021.02)

Jul 21 2020

thomass added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

Most likely errors:

  • segmentation is always performed on timestep 0 (Threshold/ULThreshold)
  • dynamic segmentation is converted into a 3D segmentation (Otsu, Fast Marching, Picking)
Jul 21 2020, 4:37 PM · MITK (v2021.10), Missing Info, Restricted Project

Jul 20 2020

thomass added a comment to T27568: US 2D image cannot be read: invalid tilt information.

Just as a remark: I am getting the exact same error, if I want to load a dcm image from a folder that contains more than one image. Those images originate from a cadaver study which means that before acquisiton most of the patient input data is left blank (study,series etc). If I put the files into separate folders, they are loaded correctly.

Jul 20 2020, 10:19 AM · Restricted Project, MITK

Jul 11 2020

thomass added a comment to T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data .

I totally forgot to claim the task but I also worked on it *sigh*. Your fix in D346 solves the problem, but I wondered if function initialize() should really be called if the activated() has not been called yet. An alternative would be to have an additional flag "m_activated" or likewise.

Jul 11 2020, 10:10 AM · MITK (v2021.02)

Jul 9 2020

thomass added a comment to T27546: [Segmentation] Crash in Add Tool when using 4D images and static segmentations.

Substract Tool also crashes, Paint, Wipe and Correction works

Jul 9 2020, 4:51 PM · MITK (v2021.02)
thomass moved T27546: [Segmentation] Crash in Add Tool when using 4D images and static segmentations from Backlog to Segmentation on the MITK (v2021.02) board.
Jul 9 2020, 4:39 PM · MITK (v2021.02)
thomass triaged T27546: [Segmentation] Crash in Add Tool when using 4D images and static segmentations as High priority.
Jul 9 2020, 4:39 PM · MITK (v2021.02)
thomass added a comment to T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data .

If timestep != 0, the m_CurrentTimeStep is changed with SetCurrentTimeStep(t). In this function Initalize() is called without the m_SmoothFilter initialized before. m_SmoothFilter equals nullptr.

Jul 9 2020, 3:28 PM · MITK (v2021.02)
thomass moved T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data from Backlog to Segmentation on the MITK (v2021.02) board.
Jul 9 2020, 3:10 PM · MITK (v2021.02)
thomass triaged T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data as High priority.
Jul 9 2020, 3:10 PM · MITK (v2021.02)
thomass added a comment to T27462: Workbench crashes when loading multiple 3D+t datasets.

Probably a similar to T24767 (sorry for re-opening but maybe the information from that one helps to narrow it down).
I acutally produced the crash even if the timesteps where valid in both images (contrary to the description).

Jul 9 2020, 2:24 PM · MITK (v2021.02)
thomass edited projects for T24767: Workbench crashes when loading two 3D+t images with different number of time steps, added: MITK (v2021.02); removed MITK.
Jul 9 2020, 2:19 PM · MITK (v2021.02)
thomass reopened T24767: Workbench crashes when loading two 3D+t images with different number of time steps as "Open".

Although the task was closed I can still reproduce the error:

Jul 9 2020, 2:18 PM · MITK (v2021.02)

Jul 8 2020

thomass added a comment to T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget.

On the develop (neither debug nor release) I also cannot reproduce the bug, so I think we can close it for now.

Jul 8 2020, 11:48 AM · MITK (v2021.02)
thomass closed T26974: [Segmentation] Region Growing 3D with 4D dataset not working as Resolved.
Jul 8 2020, 10:29 AM · MITK (v2021.02)
thomass committed rMITK1640525aa59e: T26974 Add function to extract 3D image for seed point selection (authored by thomass).
T26974 Add function to extract 3D image for seed point selection
Jul 8 2020, 10:28 AM
thomass committed rMITK7b2c675918d6: update fix for review remark (authored by thomass).
update fix for review remark
Jul 8 2020, 10:28 AM
thomass committed rMITK954b64dbf060: fix review remarks for point set selection (authored by thomass).
fix review remarks for point set selection
Jul 8 2020, 10:28 AM
thomass committed rMITKa295e8f25b64: remove dependency of specific renderwindow0 and use GetTimeNavigationController (authored by thomass).
remove dependency of specific renderwindow0 and use GetTimeNavigationController
Jul 8 2020, 10:28 AM
thomass committed rMITK276e6ad67c96: Add function to extract 3D image for seed point selection (authored by thomass).
Add function to extract 3D image for seed point selection
Jul 8 2020, 10:28 AM

Jul 3 2020

thomass added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.
Plugin namedynamic timestep =0dynamic timestep != 0static t=0static t =2
Thresholdperforms segmentation on all timestepsperforms segmentation on all timestepsperforms segmentation on timestep 0performs segmentation on timestep 0
UL thresholdperforms segmentation on all timestepsperforms segmentation on all timestepsperforms segmentation on timestep 0performs segmentation on timestep 0
Otsuperforms static 3D seg on the selected timestep + it only matters which time point is selected not on which it was createdsee dynamic t = 0performs segmentation on the timestep selected right before executionperforms segmentation on the timestep selected right before execution
Fast Marchingit doesn't matter on which timesteps the seeds are selected, they all account for initial image / performs segmentation only on the timestep selected, others are blanksee dynamic t=0
Watershedsegmentation cannot be produced with US4DCyl / LinearModel / performs static 3D seg on the selected timestepsee dynamic t=0performs segmentation on timestep 0performs segmentation on timestep 2 / it only matters which time point is selected not on which it was created
PickingCreates a 3D segmentation with picked region and deletes all other segmentations (in all timesteps)
Jul 3 2020, 2:19 PM · MITK (v2021.10), Missing Info, Restricted Project
thomass claimed T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.
Jul 3 2020, 11:08 AM · MITK (v2021.10), Missing Info, Restricted Project

Jun 30 2020

thomass added a revision to T26974: [Segmentation] Region Growing 3D with 4D dataset not working: Unknown Object (Differential Revision).
Jun 30 2020, 11:26 AM · MITK (v2021.02)

Jun 25 2020

thomass added a comment to T25825: [Segmentation] Crash using Watershed on different time steps.

But the 3d segmentation has only 1 timestep with duration = sum of durations of all 4D image timesteps, right?

Jun 25 2020, 1:44 PM · MITK (v2021.02)

Jun 19 2020

thomass removed a project from T26974: [Segmentation] Region Growing 3D with 4D dataset not working: Missing Info.
Jun 19 2020, 3:27 PM · MITK (v2021.02)
thomass added a comment to T26974: [Segmentation] Region Growing 3D with 4D dataset not working.

The error described above results from the function add seed that currently takes 3D images only. It can be solved with using a timeselector to crop the current time step and set a 3D seed.
However, the task is related to the discussion on time points versus time steps and should be revised accordingly.

Jun 19 2020, 3:18 PM · MITK (v2021.02)
thomass added a comment to T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion .

When the workbench is started from scratch it works.

Jun 19 2020, 11:34 AM · Cleared, MITK (v2021.02)
thomass claimed T26974: [Segmentation] Region Growing 3D with 4D dataset not working.
Jun 19 2020, 9:49 AM · MITK (v2021.02)

Jun 16 2020

thomass added a comment to T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion .

I used a master that was three weeks old, I will double check on the current develop

Jun 16 2020, 10:17 AM · Cleared, MITK (v2021.02)

Jun 10 2020

thomass moved T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion from Backlog to Segmentation on the MITK (v2021.02) board.
Jun 10 2020, 10:52 AM · Cleared, MITK (v2021.02)
thomass triaged T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion as High priority.
Jun 10 2020, 10:47 AM · Cleared, MITK (v2021.02)
thomass added a comment to T25825: [Segmentation] Crash using Watershed on different time steps.
  • Works for dynamic (4D) segmentations but creates the same segmentation for all timesteps
  • Could not be reproduced for static segmentations since the workbench crashes during the creation of a static segmentation (related to T27476)
Jun 10 2020, 9:45 AM · MITK (v2021.02)
thomass added a comment to T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0.
  1. Works for timestep 0
  2. Independent from segmentation tool so might be a problem of the selection concept not the segmentation
Jun 10 2020, 9:40 AM · MITK (v2021.02)
thomass updated the task description for T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0.
Jun 10 2020, 9:36 AM · MITK (v2021.02)
thomass triaged T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0 as High priority.
Jun 10 2020, 9:34 AM · MITK (v2021.02)

Jun 8 2020

thomass added a project to T26974: [Segmentation] Region Growing 3D with 4D dataset not working: Missing Info.

@gaoh: Can you tell what you mean by dynamic mask?

Jun 8 2020, 2:29 PM · MITK (v2021.02)
thomass lowered the priority of T27067: ImageCropper cannot crop some images (4d?) from High to Normal.

I will leave the task open since the handling in the respective class might need further refactoring to fully understand the behavior (as also mentioned by @kalali in the D279 review).
I remove the MITK2020 tag for now since the mentioned bug is resolved by the fix in D279.

Jun 8 2020, 2:14 PM · MITK
thomass committed rMITKae05e678acfd: <<Allow 4D image handling in Boundingshapecropper> (authored by thomass).
<<Allow 4D image handling in Boundingshapecropper>
Jun 8 2020, 2:05 PM
thomass added a comment to T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid.

Task T26596 is mentioned but does not correlate with the Topic asaik...maybe transposed digits in the task number?

Jun 8 2020, 11:52 AM · Auto-closed, MITK

May 26 2020

thomass updated the task description for T27444: [Registration] Manipulator crashes on Start Manual Registration.
May 26 2020, 12:55 PM · MITK (v2021.02)
thomass moved T27444: [Registration] Manipulator crashes on Start Manual Registration from Backlog to Registration on the MITK (v2021.02) board.
May 26 2020, 12:54 PM · MITK (v2021.02)
thomass triaged T27444: [Registration] Manipulator crashes on Start Manual Registration as High priority.
May 26 2020, 12:53 PM · MITK (v2021.02)

Apr 23 2020

thomass committed rMITK3df935e97fdb: initial commit (authored by thomass).
initial commit
Apr 23 2020, 8:20 AM

Apr 22 2020

thomass added a revision to T27067: ImageCropper cannot crop some images (4d?): Unknown Object (Differential Revision).
Apr 22 2020, 1:05 PM · MITK

Apr 15 2020

thomass added a comment to T27067: ImageCropper cannot crop some images (4d?).

The reason seems to be that a BoundingShape as such is 3D with an index of size=3 that does not equal the index array of the 4D image. I will test the fix for other images to make sure.

Apr 15 2020, 12:23 PM · MITK
thomass committed rMITKea9929dd148e: correct index for cropping a 4d image with a 3d bounding box (authored by thomass).
correct index for cropping a 4d image with a 3d bounding box
Apr 15 2020, 12:20 PM
thomass added a comment to T27067: ImageCropper cannot crop some images (4d?).

Pushed new branch T27067-ImageCropperCorrect4D.

Apr 15 2020, 12:20 PM · MITK
thomass claimed T27067: ImageCropper cannot crop some images (4d?).
Apr 15 2020, 11:40 AM · MITK
thomass closed T23551: MITK does not support Dicom Subgroup Tags as Resolved.

This was also communicated to Siemens and only occured when loading their early stage clinical prototype data. Can not be reproduced with the newer data. The task can be closed for now.

Apr 15 2020, 8:11 AM · MITK

Mar 27 2020

thomass triaged T27264: Extent Movie Maker to directly create gifs as Wishlist priority.
Mar 27 2020, 1:38 PM · Auto-closed, MITK
thomass triaged T27263: Measurements and pointsets display no valuable information as Normal priority.
Mar 27 2020, 1:31 PM · MITK (v2022.04)
thomass triaged T27262: Plugin for automatic metric computation as Normal priority.
Mar 27 2020, 12:55 PM · Auto-closed, MITK

Mar 12 2020

thomass raised the priority of T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message from Low to Normal.

As stated before, we encountered more examples that raised the unknown exception, so I don’t agree to lower the priority on that.

Mar 12 2020, 3:41 PM · Auto-closed, Request for Discussion, Restricted Project, MITK

Mar 3 2020

thomass added a comment to T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message.

The latest Release installer

Mar 3 2020, 1:20 PM · Auto-closed, Request for Discussion, Restricted Project, MITK

Mar 2 2020

thomass triaged T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message as Unbreak Now! priority.
Mar 2 2020, 3:44 PM · Auto-closed, Request for Discussion, Restricted Project, MITK

Feb 28 2020

thomass claimed T27106: [MITKDoc] Revise Volume Visualization Plugin Documentation.
Feb 28 2020, 8:10 AM · Cleared, MITK (v2021.02)

Feb 14 2020

thomass updated the task description for T27109: [MITKDoc] Revise Properties Plugin Documentation.
Feb 14 2020, 2:15 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27105: [MITKDoc] Revise Measurement Plugin Documentation.
Feb 14 2020, 2:14 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27104: [MITKDoc] Revise Modelfit Plugin Documentation.
Feb 14 2020, 2:14 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27103: [MITKDoc] Revise Point Set Interaction Plugin Documentation.
Feb 14 2020, 2:14 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27102: [MITKDoc] Revise Movie Maker Plugin Documentation.
Feb 14 2020, 2:13 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27101: [MITKDoc] Revise Logging Plugin Documentation.
Feb 14 2020, 2:12 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27099: [MITKDoc] Revise Clipping Plane Plugin Documentation.
Feb 14 2020, 2:11 PM · MITK (v2024.06), Cleared
thomass updated the task description for T27098: [MITKDoc] Revise Image Cropper Plugin Documentation.
Feb 14 2020, 2:11 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27097: [MITKDoc] Revise Statistics Plugin Documentation.
Feb 14 2020, 2:11 PM · Cleared, MITK (v2021.02)
thomass placed T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation up for grabs.
Feb 14 2020, 10:43 AM · Cleared, MITK (v2021.02)

Feb 13 2020

thomass committed rMITK00ae9bf751a0: Reorganize plugin list in documentation, changed some list levels and fixed… (authored by thomass).
Reorganize plugin list in documentation, changed some list levels and fixed…
Feb 13 2020, 9:56 AM
thomass claimed T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation.
Feb 13 2020, 9:51 AM · Cleared, MITK (v2021.02)
thomass claimed T27098: [MITKDoc] Revise Image Cropper Plugin Documentation.
Feb 13 2020, 9:51 AM · Cleared, MITK (v2021.02)

Feb 12 2020

thomass triaged T27117: [MITKDoc] Revise Matchpoint Algorithm Control Plugin Documentation as Normal priority.
Feb 12 2020, 9:55 AM · Cleared, MITK (v2021.02)
thomass triaged T27116: [MITKDoc] Revise Matchpoint Algorithm Browser Plugin Documentation as Normal priority.
Feb 12 2020, 9:54 AM · Cleared, MITK (v2021.02)
thomass triaged T27115: [MITKDoc] Revise Matchpoint Frame Correction Plugin Documentation as Normal priority.
Feb 12 2020, 9:53 AM · Cleared, MITK (v2021.02)
thomass triaged T27114: [MITKDoc] Revise Matchpoint Mapper Plugin Documentation as Normal priority.
Feb 12 2020, 9:52 AM · Cleared, MITK (v2021.02)
thomass triaged T27113: [MITKDoc] Revise Matchpoint Registration Manipulator Plugin Documentation as Normal priority.
Feb 12 2020, 9:51 AM · Cleared, MITK (v2021.02)
thomass triaged T27112: [MITKDoc] Revise Matchpoint Registration Evaluator Plugin Documentation as Normal priority.
Feb 12 2020, 9:50 AM · Cleared, MITK (v2021.02)
thomass triaged T27111: [MITKDoc] Revise Matchpoint Registration Visualizer Plugin Documentation as Normal priority.
Feb 12 2020, 9:49 AM · Cleared, MITK (v2021.02)
thomass triaged T27110: [MITKDoc] Revise Command Line Tool/ Automatisation Plugin Documentation as Normal priority.
Feb 12 2020, 9:47 AM · Cleared, MITK (v2021.02)
thomass triaged T27109: [MITKDoc] Revise Properties Plugin Documentation as Normal priority.
Feb 12 2020, 9:46 AM · Cleared, MITK (v2021.02)
thomass triaged T27108: [MITKDoc] Revise Remeshing Plugin Documentation as Normal priority.
Feb 12 2020, 9:44 AM · MITK (v2021.02)
thomass triaged T27107: [MITKDoc] Revise Screenshot Maker Plugin Documentation as Normal priority.
Feb 12 2020, 9:43 AM · Cleared, MITK (v2021.02)
thomass triaged T27106: [MITKDoc] Revise Volume Visualization Plugin Documentation as Normal priority.
Feb 12 2020, 9:41 AM · Cleared, MITK (v2021.02)
thomass triaged T27105: [MITKDoc] Revise Measurement Plugin Documentation as Normal priority.
Feb 12 2020, 9:40 AM · Cleared, MITK (v2021.02)
thomass triaged T27104: [MITKDoc] Revise Modelfit Plugin Documentation as Normal priority.
Feb 12 2020, 9:36 AM · Cleared, MITK (v2021.02)