Page MenuHomePhabricator
Feed Advanced Search

Feb 19 2019

hentsch committed rMITKdf22d9abdd6e: Changed layout of data and global options to QToolbox (authored by hentsch).
Changed layout of data and global options to QToolbox
Feb 19 2019, 5:14 PM
hentsch committed rMITKa043041ddaed: Resolved T26067 (authored by hentsch).
Resolved T26067
Feb 19 2019, 5:14 PM
hentsch committed rMITK51238abe2dd3: added title to global options (authored by hentsch).
added title to global options
Feb 19 2019, 5:14 PM
hentsch added a comment to T26067: Add possibility to add x-data.

Pushed new branch T26067-addXData.

Feb 19 2019, 5:14 PM · MITK
hentsch merged T25987: Use AddData2D into T26067: Add possibility to add x-data.
Feb 19 2019, 1:43 PM · MITK
hentsch merged task T25987: Use AddData2D into T26067: Add possibility to add x-data.
Feb 19 2019, 1:43 PM · MITK
hentsch claimed T26067: Add possibility to add x-data.
Feb 19 2019, 1:42 PM · MITK
hentsch triaged T26067: Add possibility to add x-data as Normal priority.
Feb 19 2019, 1:41 PM · MITK
hentsch merged task T23413: integrate heatmap in MitkChart? into Restricted Maniphest Task.
Feb 19 2019, 9:36 AM · MITK
hentsch awarded T25870: [chart] Implement the chart types spline, area, area_spline and scatter a Mountain of Wealth token.
Feb 19 2019, 9:19 AM · Restricted Project, MITK
hentsch awarded T25859: [chart] implement stacked chart a Burninate token.
Feb 19 2019, 9:18 AM · MITK

Feb 13 2019

hentsch triaged T26037: Make use of custom statistic values possible as Normal priority.
Feb 13 2019, 3:59 PM · MITK
hentsch removed a parent task for T25833: Leak/Debugbreak when closing workbench related to MitkChart: Unknown Object (Maniphest Task).
Feb 13 2019, 12:10 PM · Restricted Project, MITK
hentsch renamed T25833: Leak/Debugbreak when closing workbench related to MitkChart from Leak/Debugbreak when closing workbench after opening new image statistics plugin to Leak/Debugbreak when closing workbench related to MitkChart.
Feb 13 2019, 12:10 PM · Restricted Project, MITK
hentsch lowered the priority of T25833: Leak/Debugbreak when closing workbench related to MitkChart from Normal to Low.

Is not fixed with Qt 5.12.
It does only appear in Debug mode
Also, it also appears without building the image statistics plugin (measurement toolbox). Hence, the problem is probably originated in MitkChart (which uses QWebEngineWidget):

Feb 13 2019, 12:10 PM · Restricted Project, MITK
hentsch closed T25856: [image statistics plugin] Histogram and Line profile are shown together in Caching case as Resolved by committing rMITKce2297c86dfb: resolved T25856.
Feb 13 2019, 8:58 AM · Restricted Project, MITK
hentsch committed rMITK8e864db4588c: Merge branch 'T25856-histogramAndLineProfileShown' (authored by hentsch).
Merge branch 'T25856-histogramAndLineProfileShown'
Feb 13 2019, 8:58 AM
hentsch committed rMITKce2297c86dfb: resolved T25856 (authored by hentsch).
resolved T25856
Feb 13 2019, 8:56 AM
hentsch added a comment to T25856: [image statistics plugin] Histogram and Line profile are shown together in Caching case.

Pushed new branch T25856-histogramAndLineProfileShown.

Feb 13 2019, 8:56 AM · Restricted Project, MITK
hentsch claimed T25856: [image statistics plugin] Histogram and Line profile are shown together in Caching case.
Feb 13 2019, 8:38 AM · Restricted Project, MITK

Feb 12 2019

hentsch added a comment to T25833: Leak/Debugbreak when closing workbench related to MitkChart.

Is most probably a Qt bug:
https://bugreports.qt.io/browse/QTBUG-69030
Should be fixed with Qt 5.12
The QtWebEngineView is full of bugs 😠

Feb 12 2019, 2:48 PM · Restricted Project, MITK
hentsch triaged T26029: [image statistics plugin] 4D image + 4D segmentation as mask does not work as Normal priority.
Feb 12 2019, 2:25 PM · Restricted Project, MITK
hentsch updated subscribers of T25180: ImageStatistics timestep segmentation bug.

@steint Can't reproduce it with the current master. Can you try it again?

Feb 12 2019, 2:17 PM · MITK
hentsch closed T25851: [image statistics plugin] Mask image is not cleared on image change as Resolved.

part of T25785

Feb 12 2019, 2:01 PM · Restricted Project, MITK
hentsch added a comment to T19124: When selecting more than one measurement, statistics aren't calculated.

This feature has to be implemented in MaskGenerator, where the functionality of adding multiple masks could be given.

Feb 12 2019, 11:56 AM · Bugzilla, MITK
hentsch added a parent task for T23191: Image Statistics plugin: 4D data + intensity profile does not work: Unknown Object (Maniphest Task).
Feb 12 2019, 11:53 AM · MITK

Feb 8 2019

hentsch committed rMITK42d15fe91ec2: Merge branch 'T25785-resetPlanarFigureWithNewImage' (authored by hentsch).
Merge branch 'T25785-resetPlanarFigureWithNewImage'
Feb 8 2019, 4:11 PM
hentsch committed rMITKa059461bef3f: Resolved T25785 (authored by hentsch).
Resolved T25785
Feb 8 2019, 4:11 PM
hentsch added a comment to T26011: Update TestingMacros.

This old macros could be the reason for T25716

Feb 8 2019, 2:32 PM · Restricted Project, MITK
hentsch closed T25743: ImageStatisticsCalculator bug: 4D image + planarFigure lead to same results for each timestep as Resolved.
Feb 8 2019, 2:30 PM · MITK
hentsch closed T25743: ImageStatisticsCalculator bug: 4D image + planarFigure lead to same results for each timestep, a subtask of T25512: Restructure image statistics calculator, as Resolved.
Feb 8 2019, 2:30 PM · MITK

Feb 7 2019

hentsch added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

I guess there's something wrong with the original image matrix.
MITK tries to fix the normal to be perpendicular, which leads to a matrix that can't be inverted anymore.

Feb 7 2019, 5:31 PM · MITK
hentsch added a comment to T25697: Optimization of MitkImageStatisticsCalculatorTest.

In m_Pic3DImageMask2, only one label is used whereas 2 are used in m_Pic3DImageMask.
And the test is supposed to test the second label: ComputeStatisticsNew(m_Pic3DImage, imgMaskGen.GetPointer(), nullptr, 2);, where 2 is the label.

Feb 7 2019, 4:14 PM · Restricted Project, MITK
hentsch added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

I have the issue again with other data data from a cooperation partner. Also Slicer has issues with the original DICOM data set:

Feb 7 2019, 3:22 PM · MITK
hentsch closed T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests as Resolved.
Feb 7 2019, 3:04 PM · Restricted Project, MITK
hentsch closed T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests, a subtask of T25697: Optimization of MitkImageStatisticsCalculatorTest, as Resolved.
Feb 7 2019, 3:03 PM · Restricted Project, MITK
hentsch added a comment to T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests.

Only the old statistics plugin was affected. In the new plugin, all is ok.

Feb 7 2019, 1:38 PM · Restricted Project, MITK
hentsch added a comment to T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests.

I checked TestPic3DImageMaskStatistics_label2 and TestUS4DCylImageMaskStatistics_time1_label_2 via code changes (not possible via GUI). The values are consistent between test and GUI.
I can confirm that in TestUS4DCylAxialPlanarFigureMaskStatistics_time1 everything is the same too (see T24653)

Feb 7 2019, 1:05 PM · Restricted Project, MITK
hentsch committed rRTTB1caa6f3159bb: Merge branch 'master' into personal/hentsch/eMITK-2019.02 (authored by hentsch).
Merge branch 'master' into personal/hentsch/eMITK-2019.02
Feb 7 2019, 9:13 AM
hentsch committed rMITK69569a196b06: Merge branch 'T25998-compilationErrorsDiffusion' (authored by hentsch).
Merge branch 'T25998-compilationErrorsDiffusion'
Feb 7 2019, 8:52 AM
hentsch committed rMITKb07ad5ffe6fb: Fix for use of evil using namespace (authored by hentsch).
Fix for use of evil using namespace
Feb 7 2019, 8:51 AM

Feb 6 2019

hentsch committed rRTTB51c0a0def053: Merge branch 'T25235-buildInstructionsDCMTK' (authored by hentsch).
Merge branch 'T25235-buildInstructionsDCMTK'
Feb 6 2019, 2:48 PM
hentsch committed rRTTBed1a81e42f3c: libpng12 is not longer available in Ubuntu 18.04 (authored by hentsch).
libpng12 is not longer available in Ubuntu 18.04
Feb 6 2019, 2:48 PM
hentsch committed rMITKb5f9304de2bf: Merge branch 'T25998-compilationErrorsDiffusion' (authored by hentsch).
Merge branch 'T25998-compilationErrorsDiffusion'
Feb 6 2019, 2:40 PM
hentsch committed rMITK45ed86fb30f6: fixes for blind flight (authored by hentsch).
fixes for blind flight
Feb 6 2019, 2:39 PM
hentsch updated subscribers of T25998: Compilation errors in Diffusion plugins due to changes in MitkChart.
Feb 6 2019, 1:50 PM · MITK
hentsch committed rMITK017e6420a8f9: Merge branch 'T25998-compilationErrorsDiffusion' (authored by hentsch).
Merge branch 'T25998-compilationErrorsDiffusion'
Feb 6 2019, 1:49 PM
hentsch closed T25998: Compilation errors in Diffusion plugins due to changes in MitkChart as Resolved by committing rMITK859cc610f63d: resolved T25998.
Feb 6 2019, 1:49 PM · MITK
hentsch committed rMITK859cc610f63d: resolved T25998 (authored by hentsch).
resolved T25998
Feb 6 2019, 1:49 PM
hentsch added a comment to T25998: Compilation errors in Diffusion plugins due to changes in MitkChart.

Pushed new branch T25998-compilationErrorsDiffusion.

Feb 6 2019, 1:48 PM · MITK
hentsch triaged T25998: Compilation errors in Diffusion plugins due to changes in MitkChart as Normal priority.
Feb 6 2019, 1:36 PM · MITK
hentsch triaged T25994: Voxelizer plugin doesn't work anymore as Normal priority.
Feb 6 2019, 9:17 AM · Restricted Project, Restricted Project

Feb 5 2019

hentsch committed rRTTBfe463da7968c: Merge branch 'T25235-buildInstructionsDCMTK' (authored by hentsch).
Merge branch 'T25235-buildInstructionsDCMTK'
Feb 5 2019, 3:52 PM
hentsch committed rRTTB24574e36a6f3: Resolved T25235 (authored by hentsch).
Resolved T25235
Feb 5 2019, 3:51 PM
hentsch updated subscribers of T23331: Replace deprecated mitkExtractImageFilter in PlanarFigureMaskGenerator.
Feb 5 2019, 2:56 PM · Auto-closed, Restricted Project, MITK
hentsch updated subscribers of T23104: Deprecate QmitkPlotWidget.
Feb 5 2019, 2:51 PM · Restricted Project, MITK
hentsch updated subscribers of T25683: Chart Example Plugin.
Feb 5 2019, 2:50 PM · MITK
hentsch updated subscribers of T25715: VerifyStatistics should use epsilon instead of boiler plate code to handle small differences.
Feb 5 2019, 2:49 PM · MITK
hentsch updated subscribers of T25697: Optimization of MitkImageStatisticsCalculatorTest.
Feb 5 2019, 2:49 PM · Restricted Project, MITK
hentsch updated subscribers of T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests.
Feb 5 2019, 2:48 PM · Restricted Project, MITK
hentsch closed T25989: Displaying line chart does not work anymore as Resolved by committing rMITKecbc32119bf8: resolved T25989.
Feb 5 2019, 12:03 PM · Restricted Project, MITK
hentsch committed rMITK4bfb6ee8fdcc: Merge branch 'T25989-displayingLineChart' (authored by hentsch).
Merge branch 'T25989-displayingLineChart'
Feb 5 2019, 12:03 PM
hentsch closed T25989: Displaying line chart does not work anymore, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Feb 5 2019, 12:03 PM · Restricted Project, MITK
hentsch committed rMITKecbc32119bf8: resolved T25989 (authored by hentsch).
resolved T25989
Feb 5 2019, 12:02 PM
hentsch added a comment to T25989: Displaying line chart does not work anymore.

Pushed new branch T25989-displayingLineChart.

Feb 5 2019, 12:02 PM · Restricted Project, MITK
hentsch triaged T25989: Displaying line chart does not work anymore as Normal priority.
Feb 5 2019, 11:42 AM · Restricted Project, MITK
hentsch committed rMITKabed3f7beebd: Merge branch 'T25975-newPlotlyVersion' (authored by hentsch).
Merge branch 'T25975-newPlotlyVersion'
Feb 5 2019, 11:42 AM
hentsch closed T25975: Migrate to newest plotly.js version, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Feb 5 2019, 11:42 AM · Restricted Project, MITK
hentsch closed T25975: Migrate to newest plotly.js version as Resolved by committing rMITKfea713f26de7: resolved T25975 used new plotly version 1.44.1.
Feb 5 2019, 11:42 AM · Restricted Project, MITK
hentsch committed rMITKed953d13bd0c: added info about plotly to module documentation (authored by hentsch).
added info about plotly to module documentation
Feb 5 2019, 11:17 AM
hentsch committed rMITKb272de6956db: updated documentation (authored by hentsch).
updated documentation
Feb 5 2019, 11:17 AM
hentsch committed rMITKfea713f26de7: resolved T25975 used new plotly version 1.44.1 (authored by hentsch).
resolved T25975 used new plotly version 1.44.1
Feb 5 2019, 11:17 AM
hentsch committed rMITK4494f8af86ba: Renamed resource file to Chart (authored by hentsch).
Renamed resource file to Chart
Feb 5 2019, 11:17 AM
hentsch committed rMITK2a71a407c88e: removed unused code (authored by hentsch).
removed unused code
Feb 5 2019, 11:17 AM
hentsch committed rMITKc24b52f1b061: typo (authored by hentsch).
typo
Feb 5 2019, 11:17 AM
hentsch committed rMITK662d69a37520: Renamed enum (authored by hentsch).
Renamed enum
Feb 5 2019, 11:17 AM
hentsch committed rMITK74376101677f: Used the power of C++ (authored by hentsch).
Used the power of C++
Feb 5 2019, 11:17 AM
hentsch committed rMITK4868c58fdebc: Removed Qt version check as minimal Qt version is 5.11.1 (authored by hentsch).
Removed Qt version check as minimal Qt version is 5.11.1
Feb 5 2019, 11:17 AM
hentsch added a comment to T25975: Migrate to newest plotly.js version.

Pushed new branch T25975-newPlotlyVersion.

Feb 5 2019, 11:16 AM · Restricted Project, MITK
hentsch triaged T25987: Use AddData2D as Normal priority.
Feb 5 2019, 9:58 AM · MITK
hentsch moved T25967: RegEx cant read special characters from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 5 2019, 9:47 AM · Restricted Project, Restricted Project
hentsch triaged T25967: RegEx cant read special characters as Normal priority.
Feb 5 2019, 9:47 AM · Restricted Project, Restricted Project
hentsch created T25985: Make segmentation contour thickness customizable.
Feb 5 2019, 8:54 AM · MITK
hentsch added a comment to T22533: rework RTSTRUCT visualization.

still relevant. Very annoying is the bug that contours are not visible in each slice

Feb 5 2019, 8:50 AM · MITK (v2024.06), Restricted Project
hentsch triaged T25984: add Meaning of dicom tags to data (node) properties as Normal priority.
Feb 5 2019, 8:35 AM · DICOM, MITK, Restricted Project

Feb 1 2019

hentsch claimed T25975: Migrate to newest plotly.js version.
Feb 1 2019, 3:10 PM · Restricted Project, MITK
hentsch triaged T25975: Migrate to newest plotly.js version as Normal priority.
Feb 1 2019, 3:00 PM · Restricted Project, MITK
hentsch triaged T25974: add SetChartTypeForAllDataAndReload functionality as Normal priority.
Feb 1 2019, 2:59 PM · Auto-closed, MITK
hentsch triaged T25973: Add legend position as Normal priority.
Feb 1 2019, 2:58 PM · MITK
hentsch triaged T25972: Add title to plugin as Normal priority.
Feb 1 2019, 2:56 PM · MITK
hentsch closed T25873: [chart] Theme change does not work as Resolved.
Feb 1 2019, 2:51 PM · Restricted Project, MITK
hentsch closed T25873: [chart] Theme change does not work, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Feb 1 2019, 2:51 PM · Restricted Project, MITK
hentsch closed T25962: Example chart plugin in Examples instead of Plugins as Resolved.

after discussion with @kislinsk
Is ok in Plugins directory

Feb 1 2019, 2:34 PM · Request for Discussion, MITK
hentsch closed T25966: implement function get color theme as Resolved.
Feb 1 2019, 2:33 PM · Request for Discussion, MITK
hentsch committed rMITK595127ec5b1c: Merge branch 'T25873-themeChange' (authored by hentsch).
Merge branch 'T25873-themeChange'
Feb 1 2019, 2:32 PM
hentsch committed rMITKfb2fee118b3a: Theme change triggering now automatically in QmitkChart instead of plugin. Only… (authored by hentsch).
Theme change triggering now automatically in QmitkChart instead of plugin. Only…
Feb 1 2019, 2:00 PM
hentsch committed rMITK731f56c4a609: removed function (authored by hentsch).
removed function
Feb 1 2019, 2:00 PM
hentsch committed rMITK9ffdebd3d842: removed unecessary include (authored by hentsch).
removed unecessary include
Feb 1 2019, 2:00 PM
hentsch committed rMITK163225a4e907: cleaned resource files (authored by hentsch).
cleaned resource files
Feb 1 2019, 2:00 PM
hentsch committed rMITK977e843f69a9: included theming in JS (authored by hentsch).
included theming in JS
Feb 1 2019, 2:00 PM