Page MenuHomePhabricator
Feed All Stories

Jul 23 2020

neher committed rMITKDIFF28aae932ffa7: Merge branch 'T27593-ConstGradientContainer' (authored by neher).
Merge branch 'T27593-ConstGradientContainer'
Jul 23 2020, 3:34 PM
neher committed rMITKDIFF85ad246cb262: Constified (authored by neher).
Constified
Jul 23 2020, 3:34 PM
neher added a comment to T27593: Make gradient container const.

Pushed new branch T27593-ConstGradientContainer.

Jul 23 2020, 3:34 PM · MITK Diffusion
neher closed T27590: Streamline tractography min voxel size is not set in GUI as Resolved.
Jul 23 2020, 3:33 PM · MITK Diffusion
neher committed rMITKDIFF366a1bd5f3cf: Merge branch 'T27590-StreamlineMinVoxel' (authored by neher).
Merge branch 'T27590-StreamlineMinVoxel'
Jul 23 2020, 3:32 PM
kalali claimed T27595: Refactor DeformableClippingPlane plugin to use the new node selection widgets.
Jul 23 2020, 2:26 PM · Cleared, MITK (v2021.02)
kalali triaged T27595: Refactor DeformableClippingPlane plugin to use the new node selection widgets as High priority.
Jul 23 2020, 2:26 PM · Cleared, MITK (v2021.02)
kislinsk triaged T27594: Refactor Remeshing plugin to use the new node selection widgets as High priority.
Jul 23 2020, 2:23 PM · Restricted Project, Cleared, MITK (v2021.02)
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Jul 23 2020, 2:18 PM · MITK, Restricted Project, Cleared
kislinsk triaged T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit as High priority.
Jul 23 2020, 2:15 PM · Request for Discussion, MITK (v2021.02)
kislinsk triaged T27339: Provide public MITK ModelFit installer on a regular basis as Wishlist priority.
Jul 23 2020, 2:14 PM · MITK (v2024.06)
kislinsk triaged T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid as Wishlist priority.
Jul 23 2020, 2:14 PM · Auto-closed, MITK
kislinsk closed T27529: How to do step 1 with Qt-Creator as Wontfix.

Thanks @kleina.

Jul 23 2020, 2:11 PM · MITK
kislinsk added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Do I really need to reinit to the segmentation image or am I able to use the segmentation tools if I reinit to the reference image?

Jul 23 2020, 2:10 PM · Request for Discussion, MITK (v2021.02)
kislinsk added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Now I understand, thanks. The actual issue is not really related to segmentations in the first place but to the image navigator / world geometry. I guess the logic to limit the time slider (world geometry?) just counts the time steps of the selected data without taking other data into account that may have multiple time steps in the same time range. I do not know if this is easy to fix as both scenarios are valid. In terms of modifying segmentations it is pretty bad, but in case you want to focus on or inspect a certain data and reinit to it it would be very confusing to have a different number of timesteps in the slider than the data actually has.

Jul 23 2020, 2:05 PM · Request for Discussion, MITK (v2021.02)
neher committed rMITKDIFF74a10e1d4f92: Setting in each init (authored by neher).
Setting in each init
Jul 23 2020, 2:03 PM
neher added a comment to T27590: Streamline tractography min voxel size is not set in GUI.

Pushed new branch T27590-StreamlineMinVoxel.

Jul 23 2020, 2:03 PM · MITK Diffusion
neher triaged T27593: Make gradient container const as Normal priority.
Jul 23 2020, 1:50 PM · MITK Diffusion
kalali added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Well, to be precise: It is not possible to have a static segmentation on a 4D image, reinit it and show another timestep than 0. Is this intended?
What is the workflow for inspecting a 4D image at timestep t != 0 in order to segment something? From what I experience, the user has to initialize the view to the 4D image (not the segmentation) and then change the timestep to the desired one.

Jul 23 2020, 1:48 PM · Request for Discussion, MITK (v2021.02)
kislinsk added a revision to T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image: Unknown Object (Differential Revision).
Jul 23 2020, 1:01 PM · Cleared, MITK (v2021.02)
kompan added a comment to T26840: Mission Homepage Reorganization .

Pushed new branch bugfix/T26840-MitkHomepageReorganization-TopLevel-integrationBranch.

Jul 23 2020, 12:53 PM · MITK
floca claimed T27582: ImageStatistic check for same geometry is to pedantic.
Jul 23 2020, 11:43 AM · MITK (v2021.02)
floca claimed T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects.
Jul 23 2020, 11:38 AM · MITK (v2021.02)
kislinsk added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Hm, is there a misunderstanding that @kalali thought a static segmentation of a dynamic image covers only a single timestep instead of the whole time range of the dynamic image with a single timestep? So my first guess is that this task is somewhat invalid. Disussing in general if a reinit should also reset the scene timestep to 0 is something we could address separately I guess.

Jul 23 2020, 11:04 AM · Request for Discussion, MITK (v2021.02)
floca added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

@kalali Could elaborate on the question? I am somewhat drawing a blank what the question or change proposal now is.

Jul 23 2020, 10:56 AM · Request for Discussion, MITK (v2021.02)
kalali created T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.
Jul 23 2020, 10:36 AM · Request for Discussion, MITK (v2021.02)
kalali closed T27559: Crash when changing parent data nodes in Data Manager, a subtask of T23754: DataStorage/Relationship clean up/refactoring, as Resolved.
Jul 23 2020, 9:51 AM · MITK
kalali closed T27559: Crash when changing parent data nodes in Data Manager as Resolved.
Jul 23 2020, 9:51 AM · Cleared, MITK (v2021.02)
kalali committed rMITK78716f321423: Use smart pointer for the dropped node (authored by kalali).
Use smart pointer for the dropped node
Jul 23 2020, 9:50 AM
kalali committed rMITK1f52411e3751: Use smart pointer for the dropped node (authored by kalali).
Use smart pointer for the dropped node
Jul 23 2020, 9:50 AM
neher triaged T27590: Streamline tractography min voxel size is not set in GUI as Normal priority.
Jul 23 2020, 9:41 AM · MITK Diffusion

Jul 22 2020

kislinsk added a comment to T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image.

Deleted branch bugfix/T27386-LabelSetImageAutoCrop.

Jul 22 2020, 8:25 PM · Cleared, MITK (v2021.02)
kislinsk committed rMITK415b55807ca4: Add auto-crop feature for LabelSetImages (authored by kislinsk).
Add auto-crop feature for LabelSetImages
Jul 22 2020, 8:24 PM
kislinsk closed T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image as Resolved by committing rMITK415b55807ca4: Add auto-crop feature for LabelSetImages.
Jul 22 2020, 8:24 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27559: Crash when changing parent data nodes in Data Manager.

Ralf does not introduce errors 😄

This reads like a general statement 😛

Jul 22 2020, 5:27 PM · Cleared, MITK (v2021.02)
kalali added a revision to T27559: Crash when changing parent data nodes in Data Manager: Restricted Differential Revision.
Jul 22 2020, 2:49 PM · Cleared, MITK (v2021.02)
kalali claimed T27559: Crash when changing parent data nodes in Data Manager.
Jul 22 2020, 2:34 PM · Cleared, MITK (v2021.02)
kalali added a comment to T27559: Crash when changing parent data nodes in Data Manager.

Ralf does not introduce errors 😄

Jul 22 2020, 2:33 PM · Cleared, MITK (v2021.02)
kalali added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

In addition to the existing results:

Jul 22 2020, 2:29 PM · MITK (v2021.10), Missing Info, Restricted Project
floca added a comment to T27559: Crash when changing parent data nodes in Data Manager.

I looked into the code and aggree on both:

  1. Using a smartpointer at L305 makes sense, not using it is hazardous.
  2. Ralf does not introduce errors 😄
Jul 22 2020, 12:02 PM · Cleared, MITK (v2021.02)
floca added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

My default proposal (see T27509) would lead to this status result:

Jul 22 2020, 11:52 AM · MITK (v2021.10), Missing Info, Restricted Project
floca moved T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images from Backlog to Segmentation on the MITK (v2021.02) board.
Jul 22 2020, 11:24 AM · MITK (v2021.02), Request for Discussion
floca edited projects for T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images, added: MITK (v2021.02); removed MITK.
Jul 22 2020, 11:24 AM · MITK (v2021.02), Request for Discussion
floca added a comment to T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images.

I would propose the following policy:

  1. All tools per default work only on the respective time step of the reference data and the segmentation, that are indicated by the currently selected time point (SliceNavigator). So this is general and independent from the fact if it is a 3D or a 4D segmentation. This is the same behavior like the interactive tools and does not break user expectations.
  2. It is up to the specific tool (must be discussed there) if for 4D reference images others then the current time step of the reference data step should be used. Per se, I would say no.
  3. It is up to the specific (3D) tool to allow the altering of more then the current segmentation time step (if the segmentation is 4D). If one wants such a feature I would add e.g. a check box to the tool like "confirm for all time steps".
Jul 22 2020, 11:23 AM · MITK (v2021.02), Request for Discussion
floca added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

Discussion about the default and preferred behavior: T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images.

Jul 22 2020, 11:19 AM · MITK (v2021.10), Missing Info, Restricted Project
kislinsk added a comment to T27559: Crash when changing parent data nodes in Data Manager.

I agree that the correct solution is to use a smart pointer in line 305 instead of a raw pointer. Ralf did not introduce a bug but made another one visible. :-)

Jul 22 2020, 11:18 AM · Cleared, MITK (v2021.02)
kalali added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

Discussion about the default and preferred behavior: T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images.

Jul 22 2020, 11:00 AM · MITK (v2021.10), Missing Info, Restricted Project
kalali added a project to T27559: Crash when changing parent data nodes in Data Manager: Cleared.
Jul 22 2020, 10:54 AM · Cleared, MITK (v2021.02)
kislinsk moved T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects from Backlog to MaaS on the MITK (v2021.02) board.
Jul 22 2020, 10:49 AM · MITK (v2021.02)
kislinsk lowered the priority of T25445: MultiLabel segmentation mapper is very slow from High to Normal.
Jul 22 2020, 10:45 AM · MITK (v2024.06), Request for Discussion
kalali committed rMITK441962fd3260: Refactor VolumeVisualization plugin to use the new node selection widgets (authored by kalali).
Refactor VolumeVisualization plugin to use the new node selection widgets
Jul 22 2020, 9:48 AM
kalali committed rMITKf02d94b825b4: Include single node selection widget in ui-file (authored by kalali).
Include single node selection widget in ui-file
Jul 22 2020, 9:48 AM
kalali closed T27556: Refactor VolumeVisualization plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Jul 22 2020, 9:48 AM · MITK, Restricted Project, Cleared
kalali committed rMITK22829f8b3562: Add a single node selection widget (authored by kalali).
Add a single node selection widget
Jul 22 2020, 9:48 AM
kalali closed T27556: Refactor VolumeVisualization plugin to use the new node selection widgets as Resolved.
Jul 22 2020, 9:48 AM · MITK (v2021.02)
kalali committed rMITK1d23c8802125: Remove unnecessary includes (authored by kalali).
Remove unnecessary includes
Jul 22 2020, 9:48 AM
kalali committed rMITK5685977e2b9b: Clean classes (authored by kalali).
Clean classes
Jul 22 2020, 9:48 AM
neher closed T27584: Ubuntu 20.04 as Resolved.
Jul 22 2020, 8:59 AM · MITK Diffusion
neher committed rMITKDIFFef5030ce5701: Merge branch 'T27584-Ubuntu2004' (authored by neher).
Merge branch 'T27584-Ubuntu2004'
Jul 22 2020, 8:57 AM
neher committed rMITKDIFF1eb30bd764dc: Fixed gcc 9 issues (authored by neher).
Fixed gcc 9 issues
Jul 22 2020, 8:57 AM
neher added a comment to T27584: Ubuntu 20.04.

Pushed new branch T27584-Ubuntu2004.

Jul 22 2020, 8:57 AM · MITK Diffusion
neher triaged T27584: Ubuntu 20.04 as Normal priority.
Jul 22 2020, 8:56 AM · MITK Diffusion
thomass updated the task description for T27105: [MITKDoc] Revise Measurement Plugin Documentation.
Jul 22 2020, 8:45 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27104: [MITKDoc] Revise Modelfit Plugin Documentation.
Jul 22 2020, 8:44 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27106: [MITKDoc] Revise Volume Visualization Plugin Documentation.
Jul 22 2020, 8:44 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27103: [MITKDoc] Revise Point Set Interaction Plugin Documentation.
Jul 22 2020, 8:44 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27107: [MITKDoc] Revise Screenshot Maker Plugin Documentation.
Jul 22 2020, 8:44 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27102: [MITKDoc] Revise Movie Maker Plugin Documentation.
Jul 22 2020, 8:44 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27101: [MITKDoc] Revise Logging Plugin Documentation.
Jul 22 2020, 8:43 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27108: [MITKDoc] Revise Remeshing Plugin Documentation.
Jul 22 2020, 8:43 AM · MITK (v2021.02)
kompan updated the task description for T27100: [MITKDoc] Revise DataManager Plugin Documentation.
Jul 22 2020, 8:43 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27109: [MITKDoc] Revise Properties Plugin Documentation.
Jul 22 2020, 8:43 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27099: [MITKDoc] Revise Clipping Plane Plugin Documentation.
Jul 22 2020, 8:42 AM · MITK (v2024.06), Cleared
thomass updated the task description for T27110: [MITKDoc] Revise Command Line Tool/ Automatisation Plugin Documentation.
Jul 22 2020, 8:42 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27098: [MITKDoc] Revise Image Cropper Plugin Documentation.
Jul 22 2020, 8:42 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27111: [MITKDoc] Revise Matchpoint Registration Visualizer Plugin Documentation.
Jul 22 2020, 8:42 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27097: [MITKDoc] Revise Statistics Plugin Documentation.
Jul 22 2020, 8:41 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27112: [MITKDoc] Revise Matchpoint Registration Evaluator Plugin Documentation.
Jul 22 2020, 8:41 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27096: [MITKDoc] Revise MultiLabel Segmentation Utilities Plugin Documentation.
Jul 22 2020, 8:41 AM · MITK (v2021.02)
thomass updated the task description for T27113: [MITKDoc] Revise Matchpoint Registration Manipulator Plugin Documentation.
Jul 22 2020, 8:41 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27095: [MITKDoc] Revise MultiLabel Segmentation Plugin Documentation.
Jul 22 2020, 8:40 AM · MITK (v2021.02)
thomass updated the task description for T27114: [MITKDoc] Revise Matchpoint Mapper Plugin Documentation.
Jul 22 2020, 8:40 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation.
Jul 22 2020, 8:40 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27115: [MITKDoc] Revise Matchpoint Frame Correction Plugin Documentation.
Jul 22 2020, 8:39 AM · Cleared, MITK (v2021.02)
thomass updated the task description for T27116: [MITKDoc] Revise Matchpoint Algorithm Browser Plugin Documentation.
Jul 22 2020, 8:39 AM · Cleared, MITK (v2021.02)
kompan updated the task description for T27093: [MITKDoc] Revise Segmentation Plugin.
Jul 22 2020, 8:39 AM · MITK (v2021.02)
thomass updated the task description for T27117: [MITKDoc] Revise Matchpoint Algorithm Control Plugin Documentation.
Jul 22 2020, 8:38 AM · Cleared, MITK (v2021.02)

Jul 21 2020

kislinsk added a revision to T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image: Unknown Object (Differential Revision).
Jul 21 2020, 10:30 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image.

Pushed new branch bugfix/T27386-LabelSetImageAutoCrop.

Jul 21 2020, 10:18 PM · Cleared, MITK (v2021.02)
kalali added a comment to T27559: Crash when changing parent data nodes in Data Manager.

Sorry for blaming here but I had some suspicions and indeed, the bug was introduced here: 8dea40a4a757

Jul 21 2020, 10:14 PM · Cleared, MITK (v2021.02)
floca edited the content of CEST User Manual.
Jul 21 2020, 6:48 PM · MITK
floca triaged T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects as High priority.
Jul 21 2020, 6:30 PM · MITK (v2021.02)
floca moved T27582: ImageStatistic check for same geometry is to pedantic from Backlog to MaaS on the MITK (v2021.02) board.
Jul 21 2020, 6:21 PM · MITK (v2021.02)
floca triaged T27582: ImageStatistic check for same geometry is to pedantic as High priority.
Jul 21 2020, 6:21 PM · MITK (v2021.02)
floca claimed T27581: MRPerfusionMiniApp does not support 2-Step-Linear-Model.
Jul 21 2020, 5:26 PM · MITK
floca added a revision to T27581: MRPerfusionMiniApp does not support 2-Step-Linear-Model: Unknown Object (Differential Revision).
Jul 21 2020, 5:16 PM · MITK
floca triaged T27581: MRPerfusionMiniApp does not support 2-Step-Linear-Model as Normal priority.
Jul 21 2020, 5:07 PM · MITK
thomass added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

Most likely errors:

  • segmentation is always performed on timestep 0 (Threshold/ULThreshold)
  • dynamic segmentation is converted into a 3D segmentation (Otsu, Fast Marching, Picking)
Jul 21 2020, 4:37 PM · MITK (v2021.10), Missing Info, Restricted Project
floca edited the content of CEST User Manual.
Jul 21 2020, 2:10 PM · MITK
kahl added a comment to T27564: [Segmentation] Integrate deep learning methods for Segmentation in MITK.

Pushed new branch feature/T27564-integrate-deeplearning-segmentation-V2.

Jul 21 2020, 1:21 PM · MITK