- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jul 23 2020
Pushed new branch T27593-ConstGradientContainer.
Thanks @kleina.
Do I really need to reinit to the segmentation image or am I able to use the segmentation tools if I reinit to the reference image?
Now I understand, thanks. The actual issue is not really related to segmentations in the first place but to the image navigator / world geometry. I guess the logic to limit the time slider (world geometry?) just counts the time steps of the selected data without taking other data into account that may have multiple time steps in the same time range. I do not know if this is easy to fix as both scenarios are valid. In terms of modifying segmentations it is pretty bad, but in case you want to focus on or inspect a certain data and reinit to it it would be very confusing to have a different number of timesteps in the slider than the data actually has.
Pushed new branch T27590-StreamlineMinVoxel.
Well, to be precise: It is not possible to have a static segmentation on a 4D image, reinit it and show another timestep than 0. Is this intended?
What is the workflow for inspecting a 4D image at timestep t != 0 in order to segment something? From what I experience, the user has to initialize the view to the 4D image (not the segmentation) and then change the timestep to the desired one.
Pushed new branch bugfix/T26840-MitkHomepageReorganization-TopLevel-integrationBranch.
Hm, is there a misunderstanding that @kalali thought a static segmentation of a dynamic image covers only a single timestep instead of the whole time range of the dynamic image with a single timestep? So my first guess is that this task is somewhat invalid. Disussing in general if a reinit should also reset the scene timestep to 0 is something we could address separately I guess.
@kalali Could elaborate on the question? I am somewhat drawing a blank what the question or change proposal now is.
Jul 22 2020
Deleted branch bugfix/T27386-LabelSetImageAutoCrop.
In T27559#206803, @kalali wrote:In T27559#206800, @floca wrote:Ralf does not introduce errors 😄
This reads like a general statement 😛
In T27559#206800, @floca wrote:Ralf does not introduce errors 😄
In addition to the existing results:
I looked into the code and aggree on both:
- Using a smartpointer at L305 makes sense, not using it is hazardous.
- Ralf does not introduce errors 😄
My default proposal (see T27509) would lead to this status result:
In T27509#204970, @floca wrote:I would propose the following policy:
- All tools per default work only on the respective time step of the reference data and the segmentation, that are indicated by the currently selected time point (SliceNavigator). So this is general and independent from the fact if it is a 3D or a 4D segmentation. This is the same behavior like the interactive tools and does not break user expectations.
- It is up to the specific tool (must be discussed there) if for 4D reference images others then the current time step of the reference data step should be used. Per se, I would say no.
- It is up to the specific (3D) tool to allow the altering of more then the current segmentation time step (if the segmentation is 4D). If one wants such a feature I would add e.g. a check box to the tool like "confirm for all time steps".
In T27507#206792, @kalali wrote:Discussion about the default and preferred behavior: T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images.
I agree that the correct solution is to use a smart pointer in line 305 instead of a raw pointer. Ralf did not introduce a bug but made another one visible. :-)
Discussion about the default and preferred behavior: T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images.
Pushed new branch T27584-Ubuntu2004.
Jul 21 2020
Pushed new branch bugfix/T27386-LabelSetImageAutoCrop.
Sorry for blaming here but I had some suspicions and indeed, the bug was introduced here: 8dea40a4a757
Most likely errors:
- segmentation is always performed on timestep 0 (Threshold/ULThreshold)
- dynamic segmentation is converted into a 3D segmentation (Otsu, Fast Marching, Picking)
Pushed new branch feature/T27564-integrate-deeplearning-segmentation-V2.