Page MenuHomePhabricator
Feed All Stories

Sep 24 2020

wiesenfa committed rCHALLENGER88b673042288: set dpi default to 150 (authored by wiesenfa).
set dpi default to 150
Sep 24 2020, 1:05 PM
wiesenfa committed rCHALLENGER88e1de7d8cc3: set dpi default to 300 (authored by wiesenfa).
set dpi default to 300
Sep 24 2020, 1:05 PM
wiesenfa committed rCHALLENGERb2891c3b4f02: Merge branch 'develop' of https://phabricator.mitk.org/source/challenger into… (authored by wiesenfa).
Merge branch 'develop' of https://phabricator.mitk.org/source/challenger into…
Sep 24 2020, 1:00 PM
wiesenfa committed rCHALLENGERc66c18f1fbcd: allow setting dpi (authored by wiesenfa).
allow setting dpi
Sep 24 2020, 1:00 PM
eisenman claimed T27774: wrong text in report on algorithm subsets.
  1. I think it will be confusing if it writes "top 5 of 5 algorithms", I would put an if
  2. which changes? as.challenge does not have a full data attribute. The changes in subset have been done by you, see my comments in T27685.
Sep 24 2020, 12:53 PM · challengeR (v1.0)
eisenman added a comment to T27774: wrong text in report on algorithm subsets.

Ok, weird. For me it says: "The top 5 out of 5 algorithms are considered."

Sep 24 2020, 12:32 PM · challengeR (v1.0)
eisenman moved T27773: package dependencies from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 12:23 PM · challengeR (v1.0)
eisenman committed rCHALLENGER64f2452c0f45: Merge branch 'feature/T27773-FixPackageDependencies' into develop (authored by eisenman).
Merge branch 'feature/T27773-FixPackageDependencies' into develop
Sep 24 2020, 12:23 PM
eisenman committed rCHALLENGERce606a59b22c: Move ggplot2 and purrr to Depends (authored by eisenman).
Move ggplot2 and purrr to Depends
Sep 24 2020, 12:20 PM
wiesenfa added a comment to T27774: wrong text in report on algorithm subsets.
set.seed(4)
strip=runif(n,.9,1)
c_ideal=cbind(task="c_ideal",
              rbind(
                      data.frame(alg_name="A1",value=runif(n,.9,1),case=1:n),
                      data.frame(alg_name="A2",value=runif(n,.8,.89),case=1:n),
                      data.frame(alg_name="A3",value=runif(n,.7,.79),case=1:n),
                      data.frame(alg_name="A4",value=runif(n,.6,.69),case=1:n),
                      data.frame(alg_name="A5",value=runif(n,.5,.59),case=1:n)
              ))
challenge=as.challenge(c_ideal, 
                       algorithm="alg_name", case="case", value="value",
                       smallBetter = T)
ranking=challenge%>%aggregateThenRank(FUN = "mean", # aggregation function, 
                                      na.treat="na.rm", # either "na.rm" to remove missing data, 
                                      ties.method = "min" # a character string specifying 
)
Sep 24 2020, 12:18 PM · challengeR (v1.0)
eisenman claimed T27773: package dependencies.
Sep 24 2020, 12:12 PM · challengeR (v1.0)
eisenman added a comment to T27774: wrong text in report on algorithm subsets.

currently It says "The top 0 out of 0 algorithms are considered." in my latest example

Sep 24 2020, 12:07 PM · challengeR (v1.0)
wiesenfa moved T27338: Report contains misleading information on missing values from In Progress to Done on the challengeR (v1.0) board.
Sep 24 2020, 12:07 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER0e1a1e5dae75: description of missings in reports+as.challenge (authored by wiesenfa).
description of missings in reports+as.challenge
Sep 24 2020, 12:06 PM
wiesenfa added a comment to T27774: wrong text in report on algorithm subsets.

currently It says "The top 0 out of 0 algorithms are considered." in my latest example

Sep 24 2020, 11:46 AM · challengeR (v1.0)
wiesenfa added a comment to T27774: wrong text in report on algorithm subsets.
  1. I think it will be confusing if it writes "top 5 of 5 algorithms", I would put an if
  2. which changes? as.challenge does not have a full data attribute. The changes in subset have been done by you, see my comments in T27685.
Sep 24 2020, 11:45 AM · challengeR (v1.0)
eisenman added a comment to T27774: wrong text in report on algorithm subsets.
  1. This is on purpose as I wanted to avoid further nested ifs, but can be discussed.
  2. This was the only variable where I found all algorithm factors. How can they be accessed now? fulldata is not working anymore after you latest changes.
Sep 24 2020, 11:40 AM · challengeR (v1.0)
wiesenfa added a comment to T27773: package dependencies.

yes I think so. maybe you have purrr (or dplyr) and ggplot loaded in the workspace.
packages in depends are loaded at startup (and we need these package to be available by the user). imports does not load the packages, functions of challengeR can however call them.
it is true that packages in depends should be minimize, but these are needed

Sep 24 2020, 11:38 AM · challengeR (v1.0)
eisenman added a comment to T27773: package dependencies.

Are you using the latest develop branch? There everything works for me.

Sep 24 2020, 11:34 AM · challengeR (v1.0)
wiesenfa triaged T27774: wrong text in report on algorithm subsets as High priority.
Sep 24 2020, 11:32 AM · challengeR (v1.0)
wiesenfa created T27773: package dependencies.
Sep 24 2020, 11:21 AM · challengeR (v1.0)
kompan closed T27116: [MITKDoc] Revise Matchpoint Algorithm Browser Plugin Documentation as Resolved.
Sep 24 2020, 10:27 AM · Cleared, MITK (v2021.02)
kompan committed rMITKa912e9dce820: Revise Matchpoint algorithm browser documentation. (authored by kompan).
Revise Matchpoint algorithm browser documentation.
Sep 24 2020, 10:27 AM
kompan committed rMITK1b88f63fd98d: Update BuildTag description. (authored by kompan).
Update BuildTag description.
Sep 24 2020, 10:27 AM
kompan committed rMITK22fb87e87b6c: Update Interaction description. (authored by kompan).
Update Interaction description.
Sep 24 2020, 10:27 AM
kompan committed rMITK30ea97d9c6a6: Add description of Version and BuildTag. (authored by kompan).
Add description of Version and BuildTag.
Sep 24 2020, 10:27 AM
kompan committed rMITK39de0380e119: Update Location definition. (authored by kompan).
Update Location definition.
Sep 24 2020, 10:27 AM
kompan committed rMITK71b6e8863aff: Update documentation. (authored by kompan).
Update documentation.
Sep 24 2020, 10:27 AM
kompan committed rMITK00975fc60625: Remove sentence about default path in the usage section. (authored by kompan).
Remove sentence about default path in the usage section.
Sep 24 2020, 10:27 AM
kompan committed rMITK64a361dd73f4: Update images. (authored by kompan).
Update images.
Sep 24 2020, 10:27 AM
kompan triaged T27772: Clean up ModelFitInspector in TOC of doxygen documentation as Normal priority.
Sep 24 2020, 9:37 AM · Cleared, MITK (v2021.02)
aguilera moved T27764: [shiny] Detect early when insufficient number of columns are loaded from Backlog to In Progress on the webChallengeR board.
Sep 24 2020, 9:14 AM · webChallengeR
floca committed rMITK3d7a1b765f58: T27111 - Revise documentation of MatchPoint Visualizer (authored by floca).
T27111 - Revise documentation of MatchPoint Visualizer
Sep 24 2020, 9:06 AM
floca committed rMITKd887bc53b9bb: Fixed review remarks (authored by floca).
Fixed review remarks
Sep 24 2020, 9:06 AM
floca committed rMITKfaf315c77212: Revise documentation of MatchPoint Visualizer (authored by floca).
Revise documentation of MatchPoint Visualizer
Sep 24 2020, 9:06 AM
floca closed T27111: [MITKDoc] Revise Matchpoint Registration Visualizer Plugin Documentation as Resolved by committing rMITKfaf315c77212: Revise documentation of MatchPoint Visualizer.
Sep 24 2020, 9:06 AM · Cleared, MITK (v2021.02)
aguilera moved T27765: [shiny] Make sure that column specified for metric values has numeric values from In Progress to Done on the webChallengeR board.
Sep 24 2020, 9:05 AM · webChallengeR
aguilera moved T27765: [shiny] Make sure that column specified for metric values has numeric values from Backlog to In Progress on the webChallengeR board.
Sep 24 2020, 9:04 AM · webChallengeR

Sep 23 2020

eisenman moved T27769: Top x performing algorithms are not mentioned in the reports anymore from In Progress to Done on the challengeR (v1.0) board.

This issue is fixed in T27677.

Sep 23 2020, 11:24 PM · challengeR (v1.0)
eisenman moved T27677: Update text in reports (feedback from Lena) from In Progress to Done on the challengeR (v1.0) board.
Sep 23 2020, 11:24 PM · challengeR (v1.0)
eisenman added a comment to T27677: Update text in reports (feedback from Lena).

In section 3.2.1 "Visualizing bootstrap results", two visualization methods are mentioned, but only one is contained in the report: "To investigate which tasks separate algorithms well (i.e., lead to a stable ranking), two visualization methods
are recommended."

Do we add a second plot or adapt the text?

Sep 23 2020, 11:24 PM · challengeR (v1.0)
eisenman created T27770: Inconsistency in report description.
Sep 23 2020, 11:22 PM · challengeR (v1.0)
eisenman committed rCHALLENGER53cad48c02bb: Merge branch 'feature/T27677-RestructureReports' into develop (authored by eisenman).
Merge branch 'feature/T27677-RestructureReports' into develop
Sep 23 2020, 11:20 PM
eisenman committed rCHALLENGER3487afdc60ae: Rephrase some explanations (authored by eisenman).
Rephrase some explanations
Sep 23 2020, 11:17 PM
eisenman committed rCHALLENGERce659d3df8a2: Mention top x performing algorithms in the single-task reports (authored by eisenman).
Mention top x performing algorithms in the single-task reports
Sep 23 2020, 11:17 PM
aguilera moved T27758: [shiny] Remove "next" button from page "Generate report" from In Progress to Done on the webChallengeR board.
Sep 23 2020, 10:50 PM · webChallengeR
aguilera moved T27758: [shiny] Remove "next" button from page "Generate report" from Backlog to In Progress on the webChallengeR board.
Sep 23 2020, 10:45 PM · webChallengeR
aguilera moved T27757: [shiny] Contradicting instruction on page "Uncertainty analysis" from In Progress to Done on the webChallengeR board.
Sep 23 2020, 10:42 PM · webChallengeR
aguilera moved T27757: [shiny] Contradicting instruction on page "Uncertainty analysis" from Backlog to In Progress on the webChallengeR board.
Sep 23 2020, 10:39 PM · webChallengeR
aguilera moved T27766: [shiny] Update workflow figure from In Progress to Done on the webChallengeR board.
Sep 23 2020, 10:39 PM · webChallengeR
aguilera moved T27766: [shiny] Update workflow figure from Backlog to In Progress on the webChallengeR board.
Sep 23 2020, 10:31 PM · webChallengeR
aguilera moved T27761: [shiny] Prevent generation of report if field "name" is empty from In Progress to Done on the webChallengeR board.
Sep 23 2020, 10:31 PM · webChallengeR
aguilera moved T27761: [shiny] Prevent generation of report if field "name" is empty from Backlog to In Progress on the webChallengeR board.
Sep 23 2020, 9:47 PM · webChallengeR
eisenman claimed T27769: Top x performing algorithms are not mentioned in the reports anymore.
Sep 23 2020, 6:58 PM · challengeR (v1.0)
eisenman triaged T27769: Top x performing algorithms are not mentioned in the reports anymore as High priority.
Sep 23 2020, 6:39 PM · challengeR (v1.0)
eisenman committed rCHALLENGER4edfe8f3555b: Complete overview of plots (authored by eisenman).
Complete overview of plots
Sep 23 2020, 5:18 PM
kislinsk triaged T27663: Crosshair navigation not disabled in QmitkMeasurementView as Low priority.
Sep 23 2020, 4:37 PM · Breaking Change, MITK
kalali closed T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets as Resolved.
Sep 23 2020, 3:06 PM · MITK, Cleared
kalali closed T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Sep 23 2020, 3:06 PM · MITK, Restricted Project, Cleared
kalali committed rMITK37cb6b019f24: Refactor BasicImageProcessing plugin to use the new node selection widgets (authored by kalali).
Refactor BasicImageProcessing plugin to use the new node selection widgets
Sep 23 2020, 3:04 PM
kalali committed rMITKc62c87720cd3: Correct combo box information string (authored by kalali).
Correct combo box information string
Sep 23 2020, 3:04 PM
kalali committed rMITKad3b729fbec7: Use different signal-slot connection syntax (authored by kalali).
Use different signal-slot connection syntax
Sep 23 2020, 3:04 PM
kalali committed rMITKa3af275fcd47: Use new Qt5 signal-slot syntax (authored by kalali).
Use new Qt5 signal-slot syntax
Sep 23 2020, 3:04 PM
kalali committed rMITK3a674ca1e74d: Use smart pointer explicitly (authored by kalali).
Use smart pointer explicitly
Sep 23 2020, 3:04 PM
kalali committed rMITK1ce667e7d8c1: Add single node selection widgets (authored by kalali).
Add single node selection widgets
Sep 23 2020, 3:04 PM
kalali committed rMITK12a990bdeb32: Remove dead functions (authored by kalali).
Remove dead functions
Sep 23 2020, 3:04 PM
kalali committed rMITKfe2e8ad01759: Clean class, remove unnecessary comments, use auto (authored by kalali).
Clean class, remove unnecessary comments, use auto
Sep 23 2020, 3:04 PM
eisenman created T27766: [shiny] Update workflow figure.
Sep 23 2020, 12:16 PM · webChallengeR
kompan claimed T27115: [MITKDoc] Revise Matchpoint Frame Correction Plugin Documentation.
Sep 23 2020, 12:13 PM · Cleared, MITK (v2021.02)
kompan claimed T27116: [MITKDoc] Revise Matchpoint Algorithm Browser Plugin Documentation.
Sep 23 2020, 12:12 PM · Cleared, MITK (v2021.02)
eisenman triaged T27765: [shiny] Make sure that column specified for metric values has numeric values as High priority.
Sep 23 2020, 12:12 PM · webChallengeR
eisenman triaged T27764: [shiny] Detect early when insufficient number of columns are loaded as High priority.
Sep 23 2020, 12:11 PM · webChallengeR
eisenman triaged T27761: [shiny] Prevent generation of report if field "name" is empty as High priority.
Sep 23 2020, 11:40 AM · webChallengeR
eisenman created T27758: [shiny] Remove "next" button from page "Generate report".
Sep 23 2020, 11:17 AM · webChallengeR
eisenman created T27757: [shiny] Contradicting instruction on page "Uncertainty analysis".
Sep 23 2020, 11:14 AM · webChallengeR
kislinsk moved T27721: [Segmentation] 2D Fast Marching crashes with 4D image and static segmentation from Backlog to Segmentation on the MITK (v2021.02) board.
Sep 23 2020, 10:31 AM · MITK (v2021.02)
kislinsk moved T27737: Extend "Checkliste Segmentierung – Optionen" from Backlog to Segmentation on the MITK (v2021.02) board.
Sep 23 2020, 10:31 AM · MITK (v2022.04), Cleared
nolden closed T27438: Fix compile errors on Fedora 32 using gcc 10.1 as Resolved.

This is resolved, dart client is running on my workstation

Sep 23 2020, 9:46 AM · MITK (v2021.02)
nolden closed T27612: Fix build errors with clang 10.x as Resolved.

Clang 10 on Linux configuration is running now nightly on my desktop machine. "WorkbenchRelease" is green, "All" unfortunately hits an internal clang error [1][2]. Setting this up on ubuntu would probably solve this, or some update on fedora.

Sep 23 2020, 9:45 AM · Breaking Change, MITK (v2021.02)
kompan claimed T27745: [MITKDoc] Revise Model Fit Generic View Documentation.
Sep 23 2020, 9:37 AM · MITK (v2022.04)
kompan closed T27744: [MITKDoc] Revise Model Fit Demo View Documentation as Resolved.
Sep 23 2020, 9:37 AM · Cleared, MITK (v2021.02)
kompan committed rMITKfccf5e1fdb9f: Revise fit generator demo view documentation. (authored by kompan).
Revise fit generator demo view documentation.
Sep 23 2020, 9:33 AM
kompan added a comment to T27744: [MITKDoc] Revise Model Fit Demo View Documentation.

Pushed new branch bugfix/T27744-ReviseModelFitDemo.

Sep 23 2020, 9:32 AM · Cleared, MITK (v2021.02)
kompan closed T27104: [MITKDoc] Revise Modelfit Plugin Documentation as Resolved.
Sep 23 2020, 9:19 AM · Cleared, MITK (v2021.02)
kompan committed rMITK2ae1dd0a4a8a: Revise ModelFit Inspector View documentation. (authored by kompan).
Revise ModelFit Inspector View documentation.
Sep 23 2020, 9:18 AM
kompan committed rMITK1f58904cfd7a: Rewording. (authored by kompan).
Rewording.
Sep 23 2020, 9:18 AM
kompan committed rMITKfdc97a9807ca: Correct typo. (authored by kompan).
Correct typo.
Sep 23 2020, 9:18 AM
kompan committed rMITKf270b3ecdb88: Update screenshots. (authored by kompan).
Update screenshots.
Sep 23 2020, 9:18 AM
kompan committed rMITK792f47ef6f7f: Revise and update documentation. Make sure T1-Help works. (authored by kompan).
Revise and update documentation. Make sure T1-Help works.
Sep 23 2020, 9:18 AM
kompan committed rMITK1727e4b9d081: Remove contact information section. (authored by kompan).
Remove contact information section.
Sep 23 2020, 9:18 AM
kislinsk added a comment to T27196: Rewrite packaging of MITK.

Pushed new branch bugfix/T27196-RewritePackaging.

Sep 23 2020, 8:21 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T27196: Rewrite packaging of MITK.

Sep 23 2020, 8:21 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T27663: Crosshair navigation not disabled in QmitkMeasurementView .

What version of MITK do you use? I cannot reproduce any trouble with the cross hair while placing planar figures.

Sep 23 2020, 4:54 AM · Breaking Change, MITK

Sep 22 2020

kislinsk closed T19407: Basic image processing fixes as Wontfix.

Hi there! 🙂

Sep 22 2020, 7:09 AM · Auto-closed, Request for Discussion, Bugzilla, MITK
kislinsk closed T25403: Warning 4251 is not disabled globally as Wontfix.

Hi there! 🙂

Sep 22 2020, 7:09 AM · Auto-closed, MITK
kislinsk added a comment to T27624: Fix Doxygen errors.

Deleted branch bugfix/T27624-FixDoxygenErrors.

Sep 22 2020, 7:01 AM · MITK (v2021.02)
kislinsk committed rMITK0d336d68636c: Restrict input of documentation generation to header files (authored by kislinsk).
Restrict input of documentation generation to header files
Sep 22 2020, 7:00 AM
kislinsk closed T27624: Fix Doxygen errors as Resolved by committing rMITK0d336d68636c: Restrict input of documentation generation to header files.
Sep 22 2020, 7:00 AM · MITK (v2021.02)

Sep 21 2020

eisenman committed rCHALLENGERe3ef40f37895: Adapt sections (authored by eisenman).
Adapt sections
Sep 21 2020, 11:48 PM
eisenman committed rCHALLENGER8ba1c489befb: Cite paper (authored by eisenman).
Cite paper
Sep 21 2020, 11:48 PM