We commented out the entire if-else clause for the RT data and it seems to do what it is supposed to do, even without the special conditions. Need to check that in more detail.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 10 2021
Jun 10 2021
• kleina added a comment to T28544: Difference of loading RT data DicomBrowser vs. "Standard loading".
• kleina removed a project from T28455: RT struct 3D visibility is not working correctly: Request for Discussion.
• kleina triaged T28544: Difference of loading RT data DicomBrowser vs. "Standard loading" as Normal priority.
Pushed new branch to rMITK MITK: bugfix/T28455-rt-struct-3d-visibility.
Jun 8 2021
Jun 8 2021
• kleina committed rOBSHYPPOPYd59c6efb638f: Usage of default value for new member. (authored by • kleina).
Usage of default value for new member.
Jun 7 2021
Jun 7 2021
Added .arcconfig for Hyppopy
• kleina committed rOBSHYPPOPY4de04affc17e: Added test for setting of default value for _add_member (authored by • kleina).
Added test for setting of default value for _add_member
• kleina committed rOBSHYPPOPY019b7655537b: If the passed value for a new member equals 'None', (authored by • kleina).
If the passed value for a new member equals 'None',
• kleina moved T28300: [MPI] MPI as a general dependency might be problematic from In Progress to Bugfixes on the Hyppopy board.
Jun 4 2021
Jun 4 2021
Jun 4 2021, 12:21 PM · Restricted Project
Jun 4 2021, 12:21 PM · Restricted Project
Jun 4 2021, 12:06 PM · Restricted Project
Jun 2 2021
Jun 2 2021
Discussed it in the MITK meeting:
• kleina moved T28455: RT struct 3D visibility is not working correctly from Backlog to MITK Meeting on the Request for Discussion board.
May 10 2021
May 10 2021
• kleina added a project to T28455: RT struct 3D visibility is not working correctly: Request for Discussion.
I narrowed it down.
If you load a RTStruct via DICOMBrwoser, the node has a special "visible" property for stdmulti.widget3 (the 3D view). You can enable/disbale it via the Properties plugin. #Workaround :-P
Ok, we tested it on several machines and it is as described above: After loading via DICOM Browser we can confirm the issue.
Apr 22 2021
Apr 22 2021
Added .arcconfig
• kleina committed rOBSHYPPOPYace9c97f5ba3: Fixed MPISolverWrapper's direct call of blackbox internal (authored by • kleina).
Fixed MPISolverWrapper's direct call of blackbox internal
Apr 21 2021
Apr 21 2021
• kleina reopened T28410: MPISolverWrapper's direct call of blackbox internal seems wrong as "Open".
• kleina committed rOBSHYPPOPY727320895a4e: Removed deprecated loss_function_batch_call (authored by • kleina).
Removed deprecated loss_function_batch_call
• kleina committed rOBSHYPPOPY543bba87253a: Make sure fallback only gets executed when batch_call fails. (authored by • kleina).
Make sure fallback only gets executed when batch_call fails.
• kleina committed rOBSHYPPOPYa2cfa7ce75ac: Fixed MPISolverWrapper's direct call of blackbox internal (authored by • kleina).
Fixed MPISolverWrapper's direct call of blackbox internal
• kleina added a project to T28300: [MPI] MPI as a general dependency might be problematic: Request for Discussion.
• kleina moved T28376: Blackbox class - reorder the loss function call try from In Progress to Done on the Hyppopy board.
• kleina moved T28298: Check for all print outputs in code base and convert them to log messages from In Progress to Done on the Hyppopy board.
• kleina closed T28376: Blackbox class - reorder the loss function call try as Resolved by committing rOBSHYPPOPY5f8b57e426c0: Reordered the loss function call try..
• kleina committed rOBSHYPPOPY5f8b57e426c0: Reordered the loss function call try. (authored by • kleina).
Reordered the loss function call try.
• kleina added a revision to T28376: Blackbox class - reorder the loss function call try: Unknown Object (Differential Revision).
• kleina committed rOBSHYPPOPYe704bebf3217: Reordered the loss function call try. (authored by • kleina).
Reordered the loss function call try.
• kleina removed a project from T28376: Blackbox class - reorder the loss function call try: Request for Discussion.
• kleina moved T28410: MPISolverWrapper's direct call of blackbox internal seems wrong from In Progress to Done on the Hyppopy board.
• kleina added a revision to T28410: MPISolverWrapper's direct call of blackbox internal seems wrong: Unknown Object (Differential Revision).
• kleina committed rOBSHYPPOPY19e487728222: Converted "print" outputs to "log" outputs. (authored by • kleina).
Converted "print" outputs to "log" outputs.
• kleina moved T28410: MPISolverWrapper's direct call of blackbox internal seems wrong from Done to In Progress on the Hyppopy board.
Your argument makes sense to me. I did not have a specific order in mind when implementing it, so I do not have any counterargument here.
• kleina moved T28376: Blackbox class - reorder the loss function call try from Backlog to In Progress on the Hyppopy board.
Changed blackbox call.
• kleina committed rOBSHYPPOPY8c13e7810091: Converted "print" outputs to "log" outputs. (authored by • kleina).
Converted "print" outputs to "log" outputs.
• kleina moved T28455: RT struct 3D visibility is not working correctly from Backlog to Cycle on the MITK (v2021.10) board.
• kleina edited projects for T28455: RT struct 3D visibility is not working correctly, added: MITK (v2021.10); removed MITK.
• kleina added a revision to T28298: Check for all print outputs in code base and convert them to log messages: Unknown Object (Differential Revision).
• kleina reopened T28410: MPISolverWrapper's direct call of blackbox internal seems wrong as "Open".
Forgot something and didn't request review correctly. I will open this one agian.
Apr 20 2021
Apr 20 2021
• kleina committed rOBSHYPPOPYf1c392fea782: Converted "print" outputs to "log" outputs. (authored by • kleina).
Converted "print" outputs to "log" outputs.
Apr 19 2021
Apr 19 2021
• kleina moved T28332: Support cascaded MPI processing from In Progress to Testing/Evaluations on the Hyppopy board.
Apr 15 2021
Apr 15 2021
• kleina committed rOBSHYPPOPYa340b927d14a: * Added alternative loss_function draft, that does not use a callback function. (authored by • kleina).
* Added alternative loss_function draft, that does not use a callback function.
I updated the draft in the branch directly (same file).
• kleina moved T28332: Support cascaded MPI processing from Backlog to In Progress on the Hyppopy board.
Apr 9 2021
Apr 9 2021
• kleina triaged T28441: Volume Visualization fails for images with segmentations as Normal priority.
Apr 7 2021
Apr 7 2021
• kleina committed rOBSHYPPOPY74953c92ecff: Merge branch 'fix/T28410-direct-call-of-blackbox-internal' into dev (authored by • kleina).
Merge branch 'fix/T28410-direct-call-of-blackbox-internal' into dev
Merge branch 'master' into dev
• kleina committed rOBSHYPPOPY4b872a7644c7: Don't call internal blackbox_func dirctly. Instead we use blackbox.call() now. (authored by • kleina).
Don't call internal blackbox_func dirctly. Instead we use blackbox.call() now.
• kleina moved T28300: [MPI] MPI as a general dependency might be problematic from Backlog to In Progress on the Hyppopy board.
• kleina moved T28410: MPISolverWrapper's direct call of blackbox internal seems wrong from In Progress to Done on the Hyppopy board.
• kleina moved T26148: Integrate virtual energy function for evaluations tasks from In Progress to Done on the Hyppopy board.
• kleina closed T28410: MPISolverWrapper's direct call of blackbox internal seems wrong as Resolved.
• kleina added a comment to T28410: MPISolverWrapper's direct call of blackbox internal seems wrong.
I agree with the raised point. I checked the classes again and do not see a valid reason behind the blackbox_func call. I will fix this.
• kleina moved T28410: MPISolverWrapper's direct call of blackbox internal seems wrong from Backlog to In Progress on the Hyppopy board.
• kleina added a project to T28410: MPISolverWrapper's direct call of blackbox internal seems wrong: Hyppopy.
• kleina moved T28298: Check for all print outputs in code base and convert them to log messages from Backlog to In Progress on the Hyppopy board.
Sorry, I was on vacation.
Mar 10 2021
Mar 10 2021
• kleina updated the task description for T28356: MITK v2021.02 does not recognize loaded mask as segmentation.
• kleina updated the task description for T28356: MITK v2021.02 does not recognize loaded mask as segmentation.
• kleina triaged T28356: MITK v2021.02 does not recognize loaded mask as segmentation as High priority.
Mar 8 2021
Mar 8 2021
• kleina moved T25982: add all hp space modalities loguniform, ... from Backlog to Done on the Hyppopy board.
• kleina moved T26146: restructure gridsearch to be memory safe from Backlog to Done on the Hyppopy board.
• kleina moved T26227: Own documentation section for hyper parameter aspects from Backlog to Done on the Hyppopy board.
• kleina moved T26096: Add groups to hyperparameter dict structure from Backlog to Done on the Hyppopy board.
• kleina moved T26241: VirtualFunction should get better name from Backlog to Done on the Hyppopy board.
• kleina moved T26242: Solvers exceptions due to missing hyper parameter configs should be more telling. from Backlog to Done on the Hyppopy board.
• kleina moved T26243: Missing number of iterations is not handled if there is an incomplete config section from Backlog to Done on the Hyppopy board.
Mar 5 2021
Mar 5 2021
The auto wrapping functionality for MPISolverWrapper looks correct and straightforward to me. A check for function type is already included in the HyppopySolver.
I agree. As we already said, we have to work on the mpiplayground anyways and convert it into a propper mpi_example. I will spawn a task for that and include your suggestion there.
Feb 11 2021
Feb 11 2021
• kleina added a comment to rOBSHYPPOPY1358b14d22f9: Merge branch 'T26755_mpi4hyppopy' of https://github.com/MIC-DKFZ/Hyppopy into….
@kleina I think you should move the mpi playground stuff away from the top level. Examples would be better suited. Don't you think?
That makes a lot of sense. I personally like the idea of a "optional dependency" better. I will have a look.
Feb 9 2021
Feb 9 2021
Jan 28 2021
Jan 28 2021
• kleina committed rOBSHYPPOPY38bf9e41f9e5: Merge branch 'T26755_mpi4hyppopy' (authored by • kleina).
Merge branch 'T26755_mpi4hyppopy'
• kleina committed rOBSHYPPOPYfd1e3a1ce194: Fexed tests. Parameter "normed" was updated to "density" in scipy.stats.norm (authored by • kleina).
Fexed tests. Parameter "normed" was updated to "density" in scipy.stats.norm
• kleina committed rOBSHYPPOPY1a7a0544bf5e: Merge branch 'T26755_mpi4hyppopy' of https://github.com/MIC-DKFZ/Hyppopy into… (authored by • kleina).
Merge branch 'T26755_mpi4hyppopy' of https://github.com/MIC-DKFZ/Hyppopy into…
• kleina committed rOBSHYPPOPY9e0e45582629: removed loss_function_call, which is depricated and was no longer used anyway. (authored by • kleina).
removed loss_function_call, which is depricated and was no longer used anyway.
• kleina committed rOBSHYPPOPY63a9cb87d47e: Merge branch 'T26755_mpi4hyppopy' (authored by • kleina).
Merge branch 'T26755_mpi4hyppopy'
Dec 23 2020
Dec 23 2020