Page MenuHomePhabricator
Feed All Stories

May 14 2024

floca committed rMITKb6bb9b40d428: Secured usage of GetLabel results to ensure that not nullptr access is (authored by floca).
Secured usage of GetLabel results to ensure that not nullptr access is
May 14 2024, 9:28 AM
floca committed rMITK18037d1366b5: Changed return of GetLabel() to ensure secure usage of method with auto. (authored by floca).
Changed return of GetLabel() to ensure secure usage of method with auto.
May 14 2024, 9:28 AM
kislinsk committed rMITK085d28103a7a: Merge branch 'bugfix/T30445-ChangeDefaultBuildConfig' into develop (authored by kislinsk).
Merge branch 'bugfix/T30445-ChangeDefaultBuildConfig' into develop
May 14 2024, 8:29 AM
kislinsk closed T30445: Change default build configuration from Custom to WorkbenchRelease as Resolved.
May 14 2024, 8:29 AM · MITK
kislinsk committed rMITK889397425908: Propagate CMAKE_CONFIGURATION_TYPES to MITK build (authored by kislinsk).
Propagate CMAKE_CONFIGURATION_TYPES to MITK build
May 14 2024, 8:29 AM
kislinsk committed rMITK5a6eec50ba1a: Change default build configuration from Custom to WorkbenchRelease (authored by kislinsk).
Change default build configuration from Custom to WorkbenchRelease
May 14 2024, 8:29 AM
kislinsk added a comment to T30445: Change default build configuration from Custom to WorkbenchRelease.

Deleted branch from rMITK MITK: bugfix/T30445-ChangeDefaultBuildConfig.

May 14 2024, 8:29 AM · MITK
kislinsk added a comment to T30445: Change default build configuration from Custom to WorkbenchRelease.

Pushed new branch to rMITK MITK: bugfix/T30445-ChangeDefaultBuildConfig.

May 14 2024, 8:28 AM · MITK
kislinsk triaged T30445: Change default build configuration from Custom to WorkbenchRelease as Low priority.
May 14 2024, 8:22 AM · MITK

May 13 2024

floca committed rMITKaf12ad9b29fe: T30442-fix_clear_label_content_refresh (authored by floca).
T30442-fix_clear_label_content_refresh
May 13 2024, 1:39 PM
floca closed T30442: [SEG] Clear content on one label does not directly refresh the render windows as Resolved by committing rMITK9345a199763e: Fixed T30442.
May 13 2024, 1:39 PM · MITK (v2024.06)
floca committed rMITK9345a199763e: Fixed T30442 (authored by floca).
Fixed T30442
May 13 2024, 1:39 PM
kislinsk added a revision to T30444: [SEG] Crash when working a lot with labels on label delete : Unknown Object (Differential Revision).
May 13 2024, 12:05 PM · MITK (v2024.06)
floca added a revision to T30442: [SEG] Clear content on one label does not directly refresh the render windows: Unknown Object (Differential Revision).
May 13 2024, 11:55 AM · MITK (v2024.06)
floca moved T30444: [SEG] Crash when working a lot with labels on label delete from Backlog to Cycle on the MITK (v2024.06) board.
May 13 2024, 11:29 AM · MITK (v2024.06)
kislinsk closed T30443: Tab button of 2nd view is not correctly rendered as Resolved.

Could also verify with Ubuntu and macOS installers that it only seems to happen on the Windows installers with Qt 6.6.1. Close as resolved.

May 13 2024, 9:54 AM · MITK (v2024.06)
kislinsk added a comment to T30443: Tab button of 2nd view is not correctly rendered.

Qt 6.6.3 is the latest version of the Qt 6.6 range. I upgraded e230-nuc03. e230-nuc01 is not accessible via Remote Desktop because of expired credentials, have to upgrade later in office. Ubuntu 20.04 and 22.04 clients already build with Qt 6.6.2.

May 13 2024, 9:33 AM · MITK (v2024.06)
kislinsk added a comment to T30443: Tab button of 2nd view is not correctly rendered.

I was surprised not being able to reproduce this issue anymore with my local build. I then tested the snapshot installer and I was able to reproduce. The only difference I see is Qt 6.6.1 (installer) vs. Qt 6.6.2 (local). I will upgrade Qt on our Windows CI clients and check again...

May 13 2024, 9:00 AM · MITK (v2024.06)
kislinsk triaged T30443: Tab button of 2nd view is not correctly rendered as Normal priority.
May 13 2024, 8:43 AM · MITK (v2024.06)
kislinsk claimed T30443: Tab button of 2nd view is not correctly rendered.
May 13 2024, 8:43 AM · MITK (v2024.06)

May 11 2024

floca added a comment to T30444: [SEG] Crash when working a lot with labels on label delete .

After monkey testing in RelWDebugInfo, I think I found a lead. It can happen due to different processing of the Qt event queue that GetLabel is queried in a widget on a label that does not exist anymore. But it is not checked if GetLabel returns nullptr. Which in this case can happen. I hope this will fix the problem..,

May 11 2024, 12:24 PM · MITK (v2024.06)
floca triaged T30444: [SEG] Crash when working a lot with labels on label delete as Unbreak Now! priority.
May 11 2024, 12:21 PM · MITK (v2024.06)
floca changed the visibility for F3651393: bug_tab.PNG.
May 11 2024, 12:19 PM
floca changed the visibility for F3651396: bug_tab2.PNG.
May 11 2024, 12:18 PM
floca created T30443: Tab button of 2nd view is not correctly rendered.
May 11 2024, 12:17 PM · MITK (v2024.06)

May 10 2024

floca triaged T30442: [SEG] Clear content on one label does not directly refresh the render windows as Low priority.
May 10 2024, 3:04 PM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Deleted branch from rMITK MITK: bugfix/T26934-FixLogoAnnotation.

May 10 2024, 2:57 PM · MITK (v2024.06)
kislinsk committed rMITKe6532b6e2a0f: Remove multi widget decoration manager duplicate (authored by kislinsk).
Remove multi widget decoration manager duplicate
May 10 2024, 2:56 PM
kislinsk closed T26934: Multiple logos in screenshot when using screenshot maker plugin as Resolved by committing rMITK208cf8597f01: Remove multi widget decoration manager duplicate.
May 10 2024, 2:56 PM · MITK (v2024.06)
kislinsk committed rMITK208cf8597f01: Remove multi widget decoration manager duplicate (authored by kislinsk).
Remove multi widget decoration manager duplicate
May 10 2024, 2:56 PM
floca closed T30422: [SEG] Erase tool double click is irritating as Resolved.
May 10 2024, 2:20 PM · Checklist, MITK (v2024.06)
floca committed rMITK196b8d8a4948: BREAKING: Removed background click feature from EraseRegionTool (authored by floca).
BREAKING: Removed background click feature from EraseRegionTool
May 10 2024, 2:20 PM
floca committed rMITK4b9a5e0625e1: T30422-Remove_erase_tool_background_click (authored by floca).
T30422-Remove_erase_tool_background_click
May 10 2024, 2:20 PM
floca committed rMITK6a2778e74939: T30417-Fix_confusing_highlighting_invisible_labels (authored by floca).
T30417-Fix_confusing_highlighting_invisible_labels
May 10 2024, 2:19 PM
floca committed rMITK87c91fb3dedf: Fixed gcc error (authored by floca).
Fixed gcc error
May 10 2024, 2:19 PM
floca closed T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX as Resolved by committing rMITK27cad36203c2: Refactored QmitkMultiLabelInspector to use the highlight guard.
May 10 2024, 2:19 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca committed rMITK27cad36203c2: Refactored QmitkMultiLabelInspector to use the highlight guard (authored by floca).
Refactored QmitkMultiLabelInspector to use the highlight guard
May 10 2024, 2:19 PM
floca committed rMITK692addbcd6fe: Rework mapper to support highlight invisible (authored by floca).
Rework mapper to support highlight invisible
May 10 2024, 2:19 PM
floca committed rMITK57fedf2e5d5d: Introduced the LabelHighlightGuard (authored by floca).
Introduced the LabelHighlightGuard
May 10 2024, 2:19 PM
kompan triaged T30441: [Perfusion] Baseline range bug for variable flip angle conversion as Normal priority.
May 10 2024, 10:55 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
floca edited projects for T30412: [Statistics] Planar figure cannot be set as ROI for askew images, added: Next Milestone, MITK, Request for Discussion; removed Missing Info, Checklist, MITK (v2024.06).

We should clarify how we handle the reinit or reinit warning in the Measurement view. Should be very simelar to the Segmentation view.

May 10 2024, 10:39 AM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk added a revision to T26934: Multiple logos in screenshot when using screenshot maker plugin: Unknown Object (Differential Revision).
May 10 2024, 10:25 AM · MITK (v2024.06)
kompan triaged T30440: [Perfusion] Error when loading AIF from csv file in DCE MR Perfusion DataFit View as Normal priority.
May 10 2024, 10:24 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch to rMITK MITK: bugfix/T26934-FixLogoAnnotation.

May 10 2024, 10:23 AM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Deleted branch from rMITK MITK: bugfix/T26934-FixHighResScreenshots.

May 10 2024, 10:18 AM · MITK (v2024.06)
kompan triaged T30439: [Perfusion] Only a selection of debug parameter images generated as sub-nodes as Normal priority.
May 10 2024, 9:55 AM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion, Checklist
kislinsk added a revision to T26934: Multiple logos in screenshot when using screenshot maker plugin: Unknown Object (Differential Revision).
May 10 2024, 1:14 AM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch to rMITK MITK: bugfix/T26934-FixHighResScreenshots.

May 10 2024, 1:08 AM · MITK (v2024.06)
kislinsk edited projects for T26934: Multiple logos in screenshot when using screenshot maker plugin, added: MITK (v2024.06); removed Auto-closed, MITK.
May 10 2024, 1:06 AM · MITK (v2024.06)
kislinsk reopened T26934: Multiple logos in screenshot when using screenshot maker plugin as "Open".
May 10 2024, 1:05 AM · MITK (v2024.06)

May 9 2024

floca moved T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX from Backlog to Cycle on the MITK (v2024.06) board.
May 9 2024, 10:53 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca moved T30422: [SEG] Erase tool double click is irritating from Backlog to Cycle on the MITK (v2024.06) board.
May 9 2024, 10:53 AM · Checklist, MITK (v2024.06)
floca moved T30432: [Perfusion] Possible to write text into info box from Backlog to Cycle on the MITK (v2024.06) board.
May 9 2024, 10:53 AM · Moved to git.dkfz.de, MITK (v2024.12)
floca moved T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported from Backlog to Cycle on the MITK (v2024.06) board.
May 9 2024, 10:53 AM · Missing Info, Checklist, MITK (v2024.06)
floca added a comment to T30422: [SEG] Erase tool double click is irritating.

How to adapt: Use the "clear label" option in the context menue of the label inspector.

May 9 2024, 10:52 AM · Checklist, MITK (v2024.06)
floca claimed T30422: [SEG] Erase tool double click is irritating.
May 9 2024, 10:48 AM · Checklist, MITK (v2024.06)
floca added a revision to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX: Restricted Differential Revision.
May 9 2024, 10:47 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca claimed T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.
May 9 2024, 10:45 AM · Request for Discussion, Checklist, MITK (v2024.06)

May 8 2024

kislinsk closed T30414: [Documentation] Help contents have wrong titles and root pages as Resolved.
May 8 2024, 3:11 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30414: [Documentation] Help contents have wrong titles and root pages.

Deleted branch from rMITK MITK: bugfix/T30414-MakeIndexDefaultPage.

May 8 2024, 3:10 PM · Checklist, MITK (v2024.06)
kislinsk committed rMITK020a66f6cbc3: Make Help Index the default page of the Help Perspective (authored by kislinsk).
Make Help Index the default page of the Help Perspective
May 8 2024, 3:10 PM
kislinsk committed rMITK897afafbd408: Merge branch 'bugfix/T30414-MakeIndexDefaultPage' into develop (authored by kislinsk).
Merge branch 'bugfix/T30414-MakeIndexDefaultPage' into develop
May 8 2024, 3:09 PM
kislinsk added a comment to T30414: [Documentation] Help contents have wrong titles and root pages.

Pushed new branch to rMITK MITK: bugfix/T30414-MakeIndexDefaultPage.

May 8 2024, 3:08 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30414: [Documentation] Help contents have wrong titles and root pages.

In the past we used the XLST functionalities from Qt 5 to remove certain parts for the help files. Since Qt 6 we removed the transformation as it is not easy to set up a feasible alternative with libxml for example. The downside now is to have a little bit more clutter in the Help Contents. Since the Help Index still looks like the Help Contents before, I think we should simply change the default view of the Help Perspective to Help Index and live with the Help Contents as-is.

May 8 2024, 2:53 PM · Checklist, MITK (v2024.06)
kislinsk closed T30438: Clean up old pages and Doxygen code as Resolved.
May 8 2024, 2:19 PM · MITK
kislinsk added a comment to T30438: Clean up old pages and Doxygen code.

Deleted branch from rMITK MITK: bugfix/T30438-CleanUpHelpAndDoxygenCode.

May 8 2024, 2:19 PM · MITK
kislinsk committed rMITKf334cf284601: Remove parsing of CMake files by Doxygen (authored by kislinsk).
Remove parsing of CMake files by Doxygen
May 8 2024, 2:19 PM
kislinsk committed rMITK9f0bc7eef1b2: Fix Doxygen warnings (authored by kislinsk).
Fix Doxygen warnings
May 8 2024, 2:19 PM
kislinsk committed rMITKf7fbf08cb62c: Merge branch 'bugfix/T30438-CleanUpHelpAndDoxygenCode' into develop (authored by kislinsk).
Merge branch 'bugfix/T30438-CleanUpHelpAndDoxygenCode' into develop
May 8 2024, 2:19 PM
kislinsk added a comment to T30438: Clean up old pages and Doxygen code.

Pushed new branch to rMITK MITK: bugfix/T30438-CleanUpHelpAndDoxygenCode.

May 8 2024, 2:01 PM · MITK
kislinsk triaged T30438: Clean up old pages and Doxygen code as Normal priority.
May 8 2024, 1:52 PM · MITK
kislinsk added a comment to T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.

Deleted branch from rMITK MITK: bugfix/T30416-AddUsageHintsToMeasurementView.

May 8 2024, 1:49 PM · MITK (v2024.06), Checklist
kislinsk added a comment to T30413: [Documentation] Help pages are blank in certain situations.

Deleted branch from rMITK MITK: bugfix/T30413-FixBlankHelpPages.

May 8 2024, 1:49 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T29525: Pixel Value View should be aware of label set images.

Deleted branch from rMITK MITK: bugfix/T29525-IgnoreLabelSetImagesInPixelValueView.

May 8 2024, 1:49 PM · MITK
kislinsk committed rMITKd1d7a9b8627f: Let berry::HelpPluginActivator manage URL scheme handler for qthelp (authored by kislinsk).
Let berry::HelpPluginActivator manage URL scheme handler for qthelp
May 8 2024, 1:47 PM
kislinsk committed rMITK772e994e409b: Fix initialization order (authored by kislinsk).
Fix initialization order
May 8 2024, 1:47 PM
kislinsk closed T30413: [Documentation] Help pages are blank in certain situations as Resolved by committing rMITK262b488cf8fa: Fix blank help pages.
May 8 2024, 1:47 PM · Checklist, MITK (v2024.06)
kislinsk committed rMITK262b488cf8fa: Fix blank help pages (authored by kislinsk).
Fix blank help pages
May 8 2024, 1:47 PM
kislinsk committed rMITKacb7c13c6a23: Show usage hint when drawing planar figures (authored by kislinsk).
Show usage hint when drawing planar figures
May 8 2024, 1:46 PM
kislinsk committed rMITKb723e24abc7e: Show usage hint when drawing planar figures (authored by kislinsk).
Show usage hint when drawing planar figures
May 8 2024, 1:46 PM
kislinsk closed T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious as Resolved by committing rMITKb723e24abc7e: Show usage hint when drawing planar figures.
May 8 2024, 1:46 PM · MITK (v2024.06), Checklist
kislinsk committed rMITK6326d8f1413d: Ignore label set images in Pixel Value view (authored by kislinsk).
Ignore label set images in Pixel Value view
May 8 2024, 1:45 PM
kislinsk closed T29525: Pixel Value View should be aware of label set images as Resolved by committing rMITK750a0ef57a2e: Ignore label set images in Pixel Value view.
May 8 2024, 1:45 PM · MITK
kislinsk committed rMITK750a0ef57a2e: Ignore label set images in Pixel Value view (authored by kislinsk).
Ignore label set images in Pixel Value view
May 8 2024, 1:45 PM
kislinsk added a revision to T30413: [Documentation] Help pages are blank in certain situations: Unknown Object (Differential Revision).
May 8 2024, 12:19 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30413: [Documentation] Help pages are blank in certain situations.

Pushed new branch to rMITK MITK: bugfix/T30413-FixBlankHelpPages.

May 8 2024, 12:17 PM · Checklist, MITK (v2024.06)
kislinsk claimed T30413: [Documentation] Help pages are blank in certain situations.
May 8 2024, 12:10 PM · Checklist, MITK (v2024.06)
a178n added a project to T30429: Bounding box Corner control: Next Milestone.
May 8 2024, 11:33 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n added a comment to T30431: [TotalSeg] Installation status for user.

The task will be addressed after migrating the install options into Preferences. Then the status update for installation will be implemented for all "AI" tools.

May 8 2024, 11:32 AM · Moved to git.dkfz.de, MITK (v2024.12)
kompan added a comment to T30435: Rename "Time" to "Timestep" in Image Navigator?.

It is not straighforward which name to use, since what is displayed in the Image Navigator depends on if the dynamic image has been globally or locally initiated. Therefore, for now we keep the name "Time" in the Image Navigator. What is shown is therefore not obvious for the user and should be documented clearly in the F1 help. It needs to be checked if this is the case.
A solution could be to provide a separate slider in the ModelFit Inspector View.

May 8 2024, 11:21 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n removed a project from T30422: [SEG] Erase tool double click is irritating: Request for Discussion.

RFD result: Remove the functionality

May 8 2024, 11:16 AM · Checklist, MITK (v2024.06)
a178n added a project to T30431: [TotalSeg] Installation status for user: Next Milestone.
May 8 2024, 11:05 AM · Moved to git.dkfz.de, MITK (v2024.12)
kompan added projects to T30425: [SEG] Segment Anything - Loading errors occur when opening the preferences: MITK (v2024.06), Checklist.
May 8 2024, 11:03 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n assigned T30432: [Perfusion] Possible to write text into info box to kompan.
May 8 2024, 10:59 AM · Moved to git.dkfz.de, MITK (v2024.12)
a178n added projects to T30433: [Perfusion] Inconsistent appearance of info box message "Cannot compute parameters. No node selected.": Next Milestone, MITK.
May 8 2024, 10:57 AM · Moved to git.dkfz.de, MITK (v2024.12)
a178n added a project to T30434: [Perfusion] Concentration curve converter VFA box tab key skips flip angles: Next Milestone.
May 8 2024, 10:57 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n edited projects for T30435: Rename "Time" to "Timestep" in Image Navigator?, added: Next Milestone, MITK; removed Request for Discussion, MITK (v2024.06).
May 8 2024, 10:56 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n lowered the priority of T30410: [Segmentation] 2-d interpolation does not interpolate between multiple slices from Unbreak Now! to Normal.
May 8 2024, 10:34 AM · Moved to git.dkfz.de, MITK (v2024.12)
kompan moved T18489: Help perspective cannot be closed from Backlog to Cycle on the MITK (v2024.06) board.
May 8 2024, 9:57 AM · MITK (v2024.12), Request for Discussion
kompan reopened T18489: Help perspective cannot be closed as "Open".
May 8 2024, 9:41 AM · MITK (v2024.12), Request for Discussion