In T27498#209136, @floca wrote:Just double checked it. As I said the segmentation and ML segmentation view already use auto select and work as they should.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jan 19 2021
Jan 19 2021
Jan 19 2021, 12:07 PM · Restricted Project
Jan 19 2021, 12:07 PM · Restricted Project
Jan 19 2021, 12:06 PM · Restricted Project
Jan 19 2021, 12:06 PM · Restricted Project
s669m added a parent task for T28167: System set up: Multi Provider Site Version: T28175: TFDA MVP v1.
Jan 19 2021, 12:06 PM · Restricted Project
Jan 19 2021, 12:06 PM · Restricted Project
Jan 19 2021, 12:05 PM · Restricted Project
Jan 19 2021, 12:05 PM · Restricted Project
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.
floca moved T28118: Refactoring of SegTool2D from Backlog to Segmentation on the MITK (v2021.02) board.
kislinsk renamed T27701: Overhaul or remove PluginGenerator from Plugin Generator tests fail to Overhaul or remove PluginGenerator.
kislinsk edited projects for T27701: Overhaul or remove PluginGenerator, added: Next Milestone, MITK; removed MITK (v2021.02).
Deleted branch from rMITK MITK: bugfix/T28173-CMakeWarnings.
Use CMake's FindDCMTK module
Search for DCMTK only if necessary
Reduce CMake config noise
Get rid of CMake deprecation warning
kislinsk committed rMITK020d23f2ed29: Merge branch 'bugfix/T28173-CMakeWarnings' into develop (authored by kislinsk).
Merge branch 'bugfix/T28173-CMakeWarnings' into develop
Pushed new branch to rMITK MITK: bugfix/T28173-CMakeWarnings.
Jan 18 2021
Jan 18 2021
T28127 Reopen_segmentation_in_MITK
floca closed T28127: Reopen segmentation in MITK as Resolved by committing rMITK5f64c29977dd: Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict.
floca committed rMITK5f64c29977dd: Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict (authored by floca).
Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict
floca added a revision to T28127: Reopen segmentation in MITK: Unknown Object (Differential Revision).
In T28127#217365, @kislinsk wrote:It depends. NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION is only for checking in predicates;
As long as nobody has missused it so far, it is just used for that. ;) At least I have introduced it with this purpose and only used it there.
Merge branch 'T28017-VTK9-CodeIssues2'
neher committed rMITKDIFFa1bbe1077655: Final changes for dependency upgrade compatibility (authored by neher).
Final changes for dependency upgrade compatibility
Pushed new branch T28017-VTK9-CodeIssues2.
kislinsk triaged T28172: Include MITK-ProjectTemplate in MITK Differential builds as Normal priority.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28171-MigrateToCurrentMITKDevelopBranch.
kislinsk committed rMPT9551835199a1: Merge branch 'bugfix/T28171-MigrateToCurrentMITKDevelopBranch' into develop (authored by kislinsk).
Merge branch 'bugfix/T28171-MigrateToCurrentMITKDevelopBranch' into develop
Fix enum value names
Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28171-MigrateToCurrentMITKDevelopBranch.
kislinsk triaged T28171: Migrate MITK-ProjectTemplate to current MITK develop branch as Normal priority.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
kislinsk committed rMPTa3cdbda12c8c: Adapt branching model to MITK repository (authored by kislinsk).
Adapt branching model to MITK repository
It depends. NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION is only for checking in predicates; not for constant use throughout MITK while are there calculations after calculations after calculations and so the values would drift away further from the actual truth, right? So for a temporary fix, I'm okay. But we should definitely check what is going on in DCMQI and fix on that side preferably.
In T28127#217306, @kislinsk wrote:1e-5 should still be conservative enough for the purpose of geometries.
Is your statement also valid for 5e-5? Beause 1e-5 would not be enough in that case.
Jan 18 2021, 10:25 AM · Restricted Project
Jan 18 2021, 10:23 AM · Restricted Project
Jan 18 2021, 10:20 AM · Restricted Project
Deleted branch bugfix/T28164-CopyrightDate.
kislinsk committed rMITK7609ba5f5be8: Merge branch 'bugfix/T28164-CopyrightDate' into develop (authored by kislinsk).
Merge branch 'bugfix/T28164-CopyrightDate' into develop
Adjust date range
Pushed new branch bugfix/T28164-CopyrightDate.
Thanks for looking into this issue as well. :-) I think 1e-5 is okay. We/you already introduced NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION not long ago since we had similar issues and 1e-5 should still be conservative enough for the purpose of geometries.
Jan 17 2021
Jan 17 2021
The problem seems to be that DCMQI rounds the the orientation matrix values at the 5th decimal place when storing to DCM Seg.
Pushed new branch feature/T28118-Refactor_SegTool2D_and_derived_classes.
Jan 16 2021
Jan 16 2021
floca added a revision to T28148: Fix/Refactor ContourElement: Unknown Object (Differential Revision).
Jan 15 2021
Jan 15 2021
I understand. :-) Just wanted to give you more options to think about as it is probably only a temporal solution. Sooner or later (currently read "later"), our minimum version requirements won't match again with the OS-provided Qt version. So we cannot run away from it forever I guess. :D
yes exactly, the problem with the scripted version, ist still, that it is necessary to provide credentials. That was fine, as long we were the only ones creating the containers.
The version of @nolden downloading the packages in ubuntu allows others to just build the container, without having to provide credentials at all.
Thank. New command-line interface looks nice, but the challenge is where to put the credentials, especially if you want to put the script open source like in the Kaapana dockerfiles.
kislinsk renamed T27693: Packaging Python does not work/is not implemented from Cannot start nightly workbench on a clean Ubuntu 18/20 to Packaging Python does not work/is not implemented.
kislinsk edited projects for T27196: Rewrite packaging of MITK, added: Next Milestone, MITK; removed MITK (v2021.02).
Jan 14 2021
Jan 14 2021
As it already works (?) and we will stay at least another year with Qt 5 we can do this. But in general, do you know of the new Qt Installer Framework with command-line interface? It's much easier now to install Qt with a single command and there are a few possibilities to provide credentials if that's an issue. See here for examples: https://phabricator.mitk.org/T27960#214043
Merge branch 'T28017-VTK9-CodeIssues'
Solved tinyxml update issues
Deleted branch feature/T28155-MakeQtLogMessagesOptional.
Make Qt log messages optional
kislinsk committed rMITK46eee069a4bf: Merge branch 'feature/T28155-MakeQtLogMessagesOptional' into develop (authored by kislinsk).
Merge branch 'feature/T28155-MakeQtLogMessagesOptional' into develop
Pushed new branch feature/T28155-MakeQtLogMessagesOptional.
Jan 13 2021
Jan 13 2021
kislinsk added a revision to T28155: Make Qt log messages optional: Unknown Object (Differential Revision).
Since we need to patch VTK anyway, I took the opportunity to upgrade from VTK 9.0.0 to 9.0.1.
Deleted branch bugfix/T28151-FixVTKOnMacOSXCode12.
Exclude unistd.h from Windows builds
kislinsk committed rMITKda3e2af67311: Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop (authored by kislinsk).
Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop