Page MenuHomePhabricator

goyette (Nil Goyette)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (185 w, 4 d)

Recent Activity

Jun 19 2019

goyette created T26413: Nifti2 support.
Jun 19 2019, 2:52 PM · MITK

Sep 25 2018

goyette added a comment to T14956: Can't use MeshUtil<MeshType>::MeshFromPolyData.

You can delete this task of you want. We don't need it anymore, I don't even know why we needed it and maybe it has been randomly fixed in the last 5 years.

Sep 25 2018, 5:58 PM · Bugzilla, MITK
goyette added a comment to T22066: Docking a plugin on OS X is nearly impossible.

Only tested in a 10.13 VM, but I confirm that upgrading to Qt5.11.1 didn't fix this problem.

Sep 25 2018, 5:24 PM · MITK

Aug 24 2018

goyette added a comment to T25285: Ellipsoid crash.

Yes, thank you!

Aug 24 2018, 2:19 PM · MITK (2018-04)

Aug 23 2018

goyette created T25285: Ellipsoid crash.
Aug 23 2018, 5:40 PM · MITK (2018-04)

Aug 17 2018

goyette added a comment to T25267: MatchPoint build errors.

Sigh. I tried on my personal computer and it worked... The only difference is my VS version (15.7.4). I still see the Could NOT find HDF5 errors but it seems they are unimportant. If nobody has seen this "internal error", then maybe my setup is broken fo real.

Aug 17 2018, 2:26 AM · MITK (2018-04)

Aug 16 2018

goyette created T25267: MatchPoint build errors.
Aug 16 2018, 7:33 PM · MITK (2018-04)
goyette added a comment to T25265: CTK cmake error.

I thought I used the current master but I tried again this morning and everthing is fine. I probably mistyped the source folder name and picked an old version. My bad.

Aug 16 2018, 3:12 PM · MITK

Aug 15 2018

goyette created T25265: CTK cmake error.
Aug 15 2018, 9:14 PM · MITK

Jul 4 2018

goyette created T25024: Image navigator slicing.
Jul 4 2018, 7:18 PM · Request for Discussion, MITK

Jun 28 2018

goyette added a comment to T24767: Workbench crashes when loading two 3D+t images with different number of time steps.

I think I found a way to fix it. I only tested with the 2 images in my previous post, but it looks ok.

Jun 28 2018, 4:01 AM · MITK

Jun 26 2018

goyette added a comment to T24767: Workbench crashes when loading two 3D+t images with different number of time steps.

I tested with our images and I confirm the bug in 2016.11 and 2018.04.
image1: Dimensions: 128 128 74 65 Spacing: [2.03125, 2.03125, 2] https://drive.google.com/open?id=1a1UuHc3hQJLY9tAC4G3Gxz4oEBJZFEJ0
Image2: Dimensions: 128 128 74 2 Spacing: [2.03125, 2.03125, 2] https://drive.google.com/open?id=134hjTj3vLZbVS9717V86r2xecoD1RTBZ

Jun 26 2018, 7:49 PM · MITK

May 2 2018

goyette added a comment to T23990: Changing render window layout mess up Qt layout.

I forgot to add that it's easily visible withe the new dark theme. There's no need of special screenshot and black magic, just follow the colored lines.

May 2 2018, 8:24 PM · Pull Request, Restricted Project, MITK
goyette claimed T23990: Changing render window layout mess up Qt layout.

I made a new PR. It's almost identical to the first but at least it's tested on the current master. It still compiles and it still work as it should.

May 2 2018, 7:51 PM · Pull Request, Restricted Project, MITK

Dec 22 2017

goyette added a comment to T22065: QmitkRenderWindowMenu disappears or flickers on OS X.

Cool. The menus were impossible to use on OS X. However, I suggest that you reopen this issue. I tested master to check if the other problem that was explained in my 3-05-2017 post was solved. It affects all OSes. From my tests, it's still a problem. It might be considered minor but:

Dec 22 2017, 2:21 PM · MITK, Pull Request
goyette added a comment to T22870: Crash on segmentation threshold [0, 1[.

Hahaha, dammit, yes, I meant T22065. Not sure what happened :) I copied my post in the right issue. Thank you.

Dec 22 2017, 2:21 PM · Pull Request, MITK

Dec 21 2017

goyette added a comment to T22870: Crash on segmentation threshold [0, 1[.

Cool. The menus were impossible to use on OS X. However, I suggest that you reopen this issue. I tested master to check if the other problem that was explained in my 3-05-2017 post was solved. It affects all OSes. From my tests, it's still a problem. It might be considered minor but:

  • it's still a bug
  • I already posted a solution 4 months ago, it might be useful to use it
Dec 21 2017, 9:34 PM · Pull Request, MITK

Oct 19 2017

goyette created T23573: Error on time navigation of 4D images.
Oct 19 2017, 2:56 PM · MITK

Sep 29 2017

goyette committed rMITK0ebdbae72cd2: Fix crash on Threshold (authored by goyette).
Fix crash on Threshold
Sep 29 2017, 9:57 AM

Aug 31 2017

goyette added a comment to T22065: QmitkRenderWindowMenu disappears or flickers on OS X.

I pushed 2 new commits because I received a bug report from one of my user who told me he sometimes had strange result in fullscreen. Since then, no problem on any OS so I think it's safe to look at this PR.

Aug 31 2017, 6:09 PM · MITK, Pull Request

Jun 23 2017

goyette added a comment to T22989: unsigned char binary image in segmentation plugin.

I tested with the MITK 2016.11 release and I can at least confirm the bug for "Fast Marching 3D" and "Region Growing 3D"
Use the 'short' folder in https://drive.google.com/drive/folders/0B6we0HAWUUiERzl6MVVXQmJlenc?usp=sharing

Jun 23 2017, 2:44 PM · MITK

Jun 22 2017

goyette created T22989: unsigned char binary image in segmentation plugin.
Jun 22 2017, 5:24 PM · MITK

May 26 2017

goyette created T22898: Bug on 2D interpolation in Segmentatoin plugin.
May 26 2017, 7:17 PM · MITK

May 25 2017

goyette created T22895: No notification on LUTProperty change.
May 25 2017, 3:38 PM · MITK

May 24 2017

goyette added a comment to T22870: Crash on segmentation threshold [0, 1[.

A new PR: https://github.com/MITK/MITK/pull/199

May 24 2017, 9:55 PM · Pull Request, MITK
goyette closed T22811: No notification on ColorProperty change as Invalid.

You are totally right, this PR can't change anything because there's already a Modified() called just before. Furthermore, I can't even reproduce my own bug! My callbacks are now called as they should. I'm not sure what happened :| I'll convince myself that something related changed in MITK 2016.11 but I doubt it ^^

May 24 2017, 4:16 PM · Pull Request, MITK
goyette added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

I can't say I have the solution to that problem, but here's anyway what I would do:

  • Never modify node without BaseData.
  • If "Show helper objects" is checked: hide them too
  • otherwise, don't.
May 24 2017, 3:37 PM · Bugzilla, Pull Request, MITK

May 23 2017

goyette added a comment to T22811: No notification on ColorProperty change.

Haha, oups, as you can see, I didn't actually remember what I did :)

May 23 2017, 4:12 PM · Pull Request, MITK
goyette added a comment to T22811: No notification on ColorProperty change.

I agree that there's a Modified() in LookupTableProperty but the bug is related to ColorProperty. You know your code base much more than me so maybe these properties are super related and I'm not aware of it but... why is LookupTableProperty relevant?

May 23 2017, 3:47 PM · Pull Request, MITK
goyette added a comment to T22870: Crash on segmentation threshold [0, 1[.

Hum, looking at it right now, I agree that it looks random :) I know that I tried doing the simple way (like goch's snippet) in the "logical" places but it wasn't working. I don't remember why though so I'll try again and keep you updated.

May 23 2017, 3:38 PM · Pull Request, MITK

May 22 2017

goyette committed rMITK96b967bff173: Find icons in contextMenuAction extension point (authored by goyette).
Find icons in contextMenuAction extension point
May 22 2017, 5:50 PM
goyette committed rMITKc7d4870c0371: Add a tolerance parameter to SurfaceToImageFilter (authored by goyette).
Add a tolerance parameter to SurfaceToImageFilter
May 22 2017, 5:00 PM
goyette committed rMITK9591512a03e7: More const methods in FiberBundle (authored by goyette).
More const methods in FiberBundle
May 22 2017, 4:40 PM

May 18 2017

goyette added a project to T22870: Crash on segmentation threshold [0, 1[: Pull Request.

PR: https://github.com/MITK/MITK/pull/198

May 18 2017, 9:06 PM · Pull Request, MITK
goyette claimed T22870: Crash on segmentation threshold [0, 1[.
May 18 2017, 7:22 PM · Pull Request, MITK
goyette created T22870: Crash on segmentation threshold [0, 1[.
May 18 2017, 7:21 PM · Pull Request, MITK

May 12 2017

goyette created T22843: Icons are never found in contextMenuAction extension point.
May 12 2017, 9:22 PM · Pull Request, MITK

May 11 2017

goyette added a comment to T22065: QmitkRenderWindowMenu disappears or flickers on OS X.

Finally, a new, improved and shinny PR: https://github.com/MITK/MITK/pull/196

May 11 2017, 7:45 PM · MITK, Pull Request

May 10 2017

goyette added a comment to T19257: "Show only selected nodes" changes visibility of helper objects.

Clearly related to T19683. There's already a PR for this.

May 10 2017, 5:53 PM · MITK, Bugzilla

May 9 2017

goyette added a project to T19683: "Show only selected node" changes the visibility of crosshair: Pull Request.
May 9 2017, 6:13 PM · Bugzilla, Pull Request, MITK
goyette added a comment to T19522: Segmentation not displayed in 3d-render window.

I'm not sure what has changed but it doesn't work anymore. I think those lines are wrong now and make the application crashes when we later use dataSetMapper, texture or imageActor.

May 9 2017, 6:07 PM · MITK, Bugzilla
goyette added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

Not only an OS X problem. Clearly not a feature if the option is named "Show only selected node". A programmers can understand that the crosshair is in fact 3 nodes but a user shouldn't have to.

May 9 2017, 3:05 PM · Bugzilla, Pull Request, MITK

May 8 2017

goyette created T22820: Make more method const in FiberBundle.
May 8 2017, 6:56 PM · Pull Request, MITK

May 5 2017

goyette created T22811: No notification on ColorProperty change.
May 5 2017, 8:03 PM · Pull Request, MITK
goyette created T22810: Add a tolerance parameter to SurfaceToImageFilter.
May 5 2017, 7:21 PM · Pull Request, MITK

May 3 2017

goyette added a comment to T19522: Segmentation not displayed in 3d-render window.

As asked on the ML, is there any update on this?

May 3 2017, 7:25 PM · MITK, Bugzilla
goyette added a comment to T22065: QmitkRenderWindowMenu disappears or flickers on OS X.

It took me a while but I tested a little more and:

  • Forget my PR, it's not good enough. It was a wonderful fix for OS X (the menus are unusable without my fix) but it doesn't fix the next point
  • There are visual glitches on Windows too. (Probably linux too), let me explain.
May 3 2017, 7:15 PM · MITK, Pull Request

Feb 28 2017

goyette added a comment to T22065: QmitkRenderWindowMenu disappears or flickers on OS X.

Haha, ok, you're right, I don't want to do that. I don't know much about the deprecation process, so here's one question. Lets say my code is ok, the bug is fixed, but I deleted one public method somewhere because it made no sense anymore and it's incompatible with what I did. Are you telling me I must keep the old implementation along my new implementation for the next version(s)? The old implementation is buggy; it would make no sense to keep it.

Feb 28 2017, 6:08 PM · MITK, Pull Request

Feb 27 2017

goyette added a comment to T22065: QmitkRenderWindowMenu disappears or flickers on OS X.

Yes, I changed the public interface. I understand that you don't want to change it because some people might be using it, but all changes are related to the RenderWindowMenu. I doubt anyone outside of MITK is using this class.

Feb 27 2017, 3:33 PM · MITK, Pull Request
goyette committed rMITKa9b01002db1b: Fix crosshair rotation cursor (authored by goyette).
Fix crosshair rotation cursor
Feb 27 2017, 9:48 AM

Feb 26 2017

goyette added a comment to T22573: Bad rotation zone for images with small spacing.

PR: https://github.com/MITK/MITK/pull/177

Feb 26 2017, 4:45 AM · Pull Request, MITK
goyette created T22573: Bad rotation zone for images with small spacing.
Feb 26 2017, 4:32 AM · Pull Request, MITK
goyette added a comment to T22464: Stuck in crosshair rotation.

PR: https://github.com/MITK/MITK/pull/176

Feb 26 2017, 4:12 AM · Pull Request, MITK

Feb 21 2017

goyette claimed T22464: Stuck in crosshair rotation.

While working on another task, I fiex this bug. I will post a PR in the next days.

Feb 21 2017, 5:59 PM · Pull Request, MITK

Feb 3 2017

goyette created T22464: Stuck in crosshair rotation.
Feb 3 2017, 5:37 PM · Pull Request, MITK

Dec 9 2016

goyette added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

Ah, nice! Yes, this is exactly what I had in mind. Stuff staying mostly where it was but now aligned on the grid. Thank you.

Dec 9 2016, 9:52 AM · Pull Request, MITK (2016-11)
goyette added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

I wanted to compile and test it myself but I stopped trying when I read kislinsk reply., so here's my image

.
I don't know if this patch is trying to fix the same problem I have; I have no big rotation problem like in the image above, I just want Reinit to keep the minus signs in the affine, so the user is not too confused when segmenting an image.

Dec 9 2016, 9:21 AM · Pull Request, MITK (2016-11)

Nov 24 2016

goyette added a comment to T22065: QmitkRenderWindowMenu disappears or flickers on OS X.

PR https://github.com/MITK/MITK/pull/168

Nov 24 2016, 7:11 PM · MITK, Pull Request
goyette claimed T22065: QmitkRenderWindowMenu disappears or flickers on OS X.
Nov 24 2016, 6:19 PM · MITK, Pull Request

Nov 22 2016

goyette added a comment to T22065: QmitkRenderWindowMenu disappears or flickers on OS X.

I found what's causing the problem: the QSplitter.
I did a quick test, commenting some of the splitter code, and it was fine.
I'll try to compile master on OS X to see if it's still a problem. I'll try pushing a patch in the next days if it is.

Nov 22 2016, 5:14 PM · MITK, Pull Request

Nov 21 2016

goyette added a comment to T22065: QmitkRenderWindowMenu disappears or flickers on OS X.

I tried to fix this problem myself in the last days. It's really strange!
The normal behavior is

Nov 21 2016, 9:39 PM · MITK, Pull Request

Nov 8 2016

goyette created T22066: Docking a plugin on OS X is nearly impossible.
Nov 8 2016, 8:28 PM · MITK
goyette created T22065: QmitkRenderWindowMenu disappears or flickers on OS X.
Nov 8 2016, 8:05 PM · MITK, Pull Request

Aug 2 2016

goyette added a comment to T19040: Coronal picking OS X.

Thank you for the investigation.

Aug 2 2016, 10:20 AM · MITK (2015-03), Bugzilla
goyette added projects to T19040: Coronal picking OS X: MITK, Bugzilla.
Aug 2 2016, 10:20 AM · MITK (2015-03), Bugzilla
goyette added a comment to T17912: Accessing data storage from within a module.

It would be really practical for us too.

Aug 2 2016, 10:13 AM · Bugzilla, MITK
goyette added a comment to T15588: DicomReader ignores slice thickness (0018,0050) when a 2D+t dicom series is loaded.

I found a 3D image with this particular problem. gdcmdump tells me
(0018,0050) DS [0.28] # 4,1 Slice Thickness
(0018,0088) DS [-0.28 ] # 6,1 Spacing Between Slices
(0028,0030) DS [0.28\0.28 ] # 10,2 Pixel Spacing

Aug 2 2016, 10:04 AM · MITK, Bugzilla
goyette added a comment to T15475: Mesh rendering problem on timestep > 0.

Oh, sorry for the delay. The way I coded, addind false in the ctor was indeed simple and solves the problem. I didn't test the other ideas, but as a user, I believe selected should be false by default.

Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
goyette added a comment to T15475: Mesh rendering problem on timestep > 0.

I don't have the code you are asking for, but in order to help you, I created a simple mesh (2 tetrahedra) as an example and the rendering is also broken, so here's the code: https://gist.github.com/anonymous/1a54610a912c49e0d251 It's absolutely ugly (sorry!) but it's enough to see the bug.

Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
goyette added a comment to T15475: Mesh rendering problem on timestep > 0.

Hey, thanks for your patch. The rendering without an interactor is now ok. With an interactor though, I still have almost the same problem as in my first post. I believe the only problenm is that they are all selected by default.

Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
goyette added a comment to T15475: Mesh rendering problem on timestep > 0.

I don't do anything special; I just add an interactor.
mitk::DataNode::Pointer meshNode = mitk::DataNode::New();
meshNode->SetData(aMeshWithLotOfGates);
meshNode->SetStringProperty("name", "MY MESH");
GetDataStorage()->Add(meshNode, m_CurrentImageNode);
mitk::PointSetInteractor::Pointer interactor =

mitk::PointSetInteractor::New("onlymovepointsetinteractor", meshNode);

meshNode->EnableInteractor();

Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
goyette added a comment to T15475: Mesh rendering problem on timestep > 0.

Yes, the bug is on a 4D mitk::Mesh. It works perfectly on 3D Mesh because, as I wrote, the problem arises on t > 0.

Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
goyette added projects to T15475: Mesh rendering problem on timestep > 0: MITK, Bugzilla.
Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
goyette added projects to T15355: Negative spacing set to 1.0: MITK, Bugzilla.
Aug 2 2016, 10:04 AM · Bugzilla, MITK
goyette added projects to T14956: Can't use MeshUtil<MeshType>::MeshFromPolyData: MITK, Bugzilla.
Aug 2 2016, 10:02 AM · Bugzilla, MITK
goyette added a comment to T14173: image cropper crashes with 2d images.

Just to say that I have the same problem with 2D images. When I load a 2D image (png or jpg), create a bounding object and cut the image with a BoundingObjectCutter, it fails when I call :
mitk::BoundingObjectCutter::Pointer filter = mitk::BoundingObjectCutter::New();
filter->Set some stuff
filter->Update();
In mitkBoundingObjectCutter.cpp in GenerateInputRequestedRegion() on line
delete [] dimensions;
I get a HEAP CORRUPTION DETECTED from VS2010.

Aug 2 2016, 10:00 AM · MITK (2013-06), Bugzilla