Page MenuHomePhabricator

klemmma (Martin Klemm)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (181 w, 3 d)

Recent Activity

Apr 19 2018

klemmma updated subscribers of T24685: Adding NDI Aurora support for 5DoF tools (two tools per physical port).
Apr 19 2018, 1:51 PM · IGT, MITK
klemmma updated subscribers of T24685: Adding NDI Aurora support for 5DoF tools (two tools per physical port).
Apr 19 2018, 1:43 PM · IGT, MITK
klemmma added a comment to T24685: Adding NDI Aurora support for 5DoF tools (two tools per physical port).

I was testing these changes with an Aurora device with the following configurations:

Apr 19 2018, 1:33 PM · IGT, MITK
klemmma added a comment to T24685: Adding NDI Aurora support for 5DoF tools (two tools per physical port).

Added a patch for mitkNDITrackingDevice.cpp. The only changes necessary were in the DiscoverWiredTools() method. The implementation of the NDI protocol was not 100% correct. The PHSR(OCCUPIED, &portHandle) method has to be called two times (one time per channel). Subsequently, PHSR(ALL, &portHandle) is called to retrieve all port handles.

Apr 19 2018, 1:22 PM · IGT, MITK
klemmma triaged T24685: Adding NDI Aurora support for 5DoF tools (two tools per physical port) as Normal priority.
Apr 19 2018, 1:15 PM · IGT, MITK

Jun 9 2017

klemmma committed rMITK59f2d2acfc63: navigation data recorder can be set up in such way that only valid navigation… (authored by klemmma).
navigation data recorder can be set up in such way that only valid navigation…
Jun 9 2017, 2:50 PM

Sep 20 2016

aurelien awarded rMITKa5312246035b: Context menu action can be initialized with icon attribute via the extension… a Like token.
Sep 20 2016, 8:29 AM

Aug 2 2016

klemmma added projects to T19837: Adding the emission of a message received event in OpenIGTLink device: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · Bugzilla, MITK
klemmma added projects to T19836: Adding the capabilities to clear OpenIGTLink buffers/queues: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · Bugzilla, MITK
klemmma added projects to T19763: IGTLDevice overwrites the device name set in the message: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · Bugzilla, MITK
klemmma added projects to T19559: Adding the possibility to only record valid NavigationData in the NavigationDataRecorder: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · MITK, Pull Request, Bugzilla
klemmma added a comment to T19559: Adding the possibility to only record valid NavigationData in the NavigationDataRecorder.

Flag can be set to configure onlyValidDataRecording on/off. Data of one timestep is only recorded if all inputs are valid. As soon as one is invalid this timestep is skipped.

Aug 2 2016, 10:23 AM · MITK, Pull Request, Bugzilla
klemmma added a comment to T19260: OpenIGTLink measurements.

New test files for 16 channels

Aug 2 2016, 10:21 AM · Bugzilla, MITK
klemmma added a comment to F1265: LogFilesOpenIGTLinkTest10000And50000_16ch.7z.

New test files for 16 channels

Aug 2 2016, 10:21 AM
klemmma added projects to T19195: All QmlMitkRenderWindowItems have the same name: MITK, Bugzilla.
Aug 2 2016, 10:21 AM · Bugzilla, MITK
klemmma added a comment to T19195: All QmlMitkRenderWindowItems have the same name.

Added a branch and pull request of my current workaround:

Aug 2 2016, 10:21 AM · Bugzilla, MITK
klemmma added projects to T18924: Virtual Tracker causes crash after changing number of tools: MITK, Bugzilla.
Aug 2 2016, 10:19 AM · Bugzilla, MITK
klemmma added a comment to T18924: Virtual Tracker causes crash after changing number of tools.

Callstack after crash

Aug 2 2016, 10:19 AM · Bugzilla, MITK
klemmma added a comment to T18924: Virtual Tracker causes crash after changing number of tools.

I am currently working on the following branch: bug-18713-UIsupportForOpenIGTLinkTrackingDevices

Aug 2 2016, 10:19 AM · Bugzilla, MITK
klemmma added a comment to F1236: callstack.txt.

Callstack after crash

Aug 2 2016, 10:19 AM
klemmma added projects to T18909: In QmlMitkRenderWindowItem the mouse position has a flipped y coordinate: MITK, Bugzilla.
Aug 2 2016, 10:19 AM · Bugzilla, MITK
klemmma added a comment to T18909: In QmlMitkRenderWindowItem the mouse position has a flipped y coordinate.

Added a pull request on github
m4271n:bug-18909-FlippedYCoordinateInRenderWindowItem

Aug 2 2016, 10:19 AM · Bugzilla, MITK
klemmma added a comment to T18713: UI support for openIGTlink tracking devices.

Created a pull request in Github

Aug 2 2016, 10:18 AM · MITK (2016-11), Bugzilla
klemmma added projects to T18495: Saving a jpg image as gipl, vti, pic, sdt, spr, vtk and subsequently loading them fails and produces errors: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · MITK, Bugzilla
klemmma added a comment to T18440: Image Names still written in the measurement view after data node is deselected.

[c814d3]: Merge branch 'bug-18440-ImageNameStillWrittenInTheMeasurementView'

Merged commits:

2014-11-19 18:12:03 Martin Klemm [ced2b1]
Reset the selected image label in the measurement view every time the selection is changed and no node is selected

Aug 2 2016, 10:16 AM · Bugzilla, MITK
klemmma added a comment to T18393: Experimental QML support is inflexible and inefficient.

Is anyone still working on this?

Aug 2 2016, 10:16 AM · Bugzilla, MITK
klemmma added a comment to T18380: OpenIGTLink support for IGT module.

From my point of view we can close it. I do not have anything to commit to this bug anymore.

Aug 2 2016, 10:16 AM · Bugzilla, MITK
klemmma added projects to T18380: OpenIGTLink support for IGT module: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · Bugzilla, MITK
klemmma added a comment to T18351: Locale is not set to C before reading and writing navigation data.

Set locale to C before reading. Reset after reading.

Aug 2 2016, 10:16 AM · Bugzilla, MITK
klemmma added projects to T18351: Locale is not set to C before reading and writing navigation data: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · Bugzilla, MITK
klemmma added a comment to T18340: hot spots in statistics do not work.

We did not know what the expected behaviour is exactly. But in mitkImageStatisticsCalculator the following lines look suspicious:

Aug 2 2016, 10:16 AM · MITK, Bugzilla
klemmma added projects to T18282: IGT Tutorial: It is possible to start the IGT several times which adds a new cone each time: MITK, Bugzilla.
Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added a comment to T18279: IGT Navigation Data Player crashes while reinitializing the tool.

This bug only occurs on Martin Klemm's system (Ubuntu 14.04 with ClassicGnome, i7, GeForce GTX 465/PCIe/SSE2).
Tested it on two other Linux PCs and one Windows PC.
The error occurs in mitkSlicedGeometry3D::PreSetSpacing() when the spacing is checked for being positive. It is not positive because the geometry, the spacing is calculated from, holds a zero matrix. We could not figure out where the geometry comes from.
The sphere object, that holds the geometry (most probably) is created in QmitkNavigationDataPlayerView::CreatePipeline().

Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added a comment to T18279: IGT Navigation Data Player crashes while reinitializing the tool.

The problem was that tinyXML read the values from the logfile in a wrong way because the locale of the system was set to German. TinyXML expected commas but got points. Then it cut the string before the point and therefore returned wrong values. After changing the system locale to English the error did not occur anymore.

Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added projects to T18279: IGT Navigation Data Player crashes while reinitializing the tool: MITK, Bugzilla.
Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added a comment to F1160: logfile.xml.

The recorded xml file

Aug 2 2016, 10:15 AM
klemmma added projects to T18275: NavigationToolManager: Saving a Tool file does not add proper file ending in Linux: MITK, Bugzilla.
Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added projects to T18273: IGT Tracking Toolbox: Crash on Test Connection after Adding a single tool: MITK, Bugzilla.
Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added projects to T18272: IGT Tracking Toolbox: Crash after Adding a Single Tool and Load Tool Storage: MITK, Bugzilla.
Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added a comment to T18272: IGT Tracking Toolbox: Crash after Adding a Single Tool and Load Tool Storage.

It is also possible to reproduce this by adding to single tools.

Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added a comment to T18272: IGT Tracking Toolbox: Crash after Adding a Single Tool and Load Tool Storage.

I forgot to say that I used the Polaris system to test this.

Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added a comment to T18209: [awesome icons] Wrong icon in "Remove all data?" dialog (close project).

Tested on Ubuntu 14.04 and could not reproduce this behaviour. It worked properly.

Aug 2 2016, 10:15 AM · MITK (2015-03), Bugzilla
klemmma added projects to T18201: Measurement interaction is active while scrolling and switching to another layer: MITK, Bugzilla.
Aug 2 2016, 10:15 AM · Bugzilla, MITK
klemmma added projects to T17912: Accessing data storage from within a module: MITK, Bugzilla.
Aug 2 2016, 10:13 AM · Bugzilla, MITK
klemmma added a comment to T17907: Neglected icon attribute in the extension point of the QmitkDataManagerView.

[bc222c]: Merge branch 'bug-17907-NeglectedIconAttributeInTheExtensionPointOfThe

Merged commits:

2014-11-12 15:58:27 Martin Klemm [a53122]
Context menu action can be initialized with icon attribute via the extension point

Aug 2 2016, 10:13 AM · MITK (2014-10), Bugzilla
klemmma added a comment to T17907: Neglected icon attribute in the extension point of the QmitkDataManagerView.

Patch file

Aug 2 2016, 10:13 AM · MITK (2014-10), Bugzilla
klemmma added a comment to F1130: patch.diff.

Patch file

Aug 2 2016, 10:13 AM
klemmma added a comment to T17907: Neglected icon attribute in the extension point of the QmitkDataManagerView.

The patch file contains the changes that were necessary to include the icon in the menu action. It was tested under Windows 7.

Aug 2 2016, 10:13 AM · MITK (2014-10), Bugzilla
klemmma added projects to T17907: Neglected icon attribute in the extension point of the QmitkDataManagerView: MITK, Bugzilla.
Aug 2 2016, 10:13 AM · MITK (2014-10), Bugzilla
klemmma added a comment to T17898: Volume visualisation plugin - saving and loading transfer functions does not work properly.

The transfer function is serialized using tinyXML. If the locale is not set properly and the system locale is not English the reading and writing of data is incorrect. Setting the locale before reading and writing data probably solves this problem.

Aug 2 2016, 10:13 AM · MITK (2014-10), Bugzilla
klemmma added a comment to T16843: Improve QmlRenderWindowItem.

Also check T19195 to be able to set different render window names

Aug 2 2016, 10:10 AM · Bugzilla, MITK
klemmma added a comment to T16600: New measurement becomes not automatically selected in Data Manager.

To reproduce this error perform the following steps:

Aug 2 2016, 10:09 AM · Bugzilla, MITK
klemmma added a comment to T13971: Volume visualisation tool tips.

[bb6a34]: Merge branch 'bug-13971-VolumeVisualizationToolTipsWereMissingOrIncorr

Merged commits:

2014-11-12 17:54:36 Martin Klemm [3ab3fd]
Added and corrected tooltips in Volume Visualization Plugin

Aug 2 2016, 9:59 AM · MITK (2015-03), Bugzilla
klemmma added a comment to T12254: mbi log is not thread-safe.

Writing messages to the mbi-log is thread-safe. The registration/unregistration of backends is not thread-safe, as explained above. To make it thread safe you have to add a mutex lock to the backend list. The problem is that the mbilog-module has no dependencies so far (and shall not get any). Therefore, we cannot use the ITK mutex.

Aug 2 2016, 9:55 AM · MITK, Bugzilla