Page MenuHomePhabricator
Feed Advanced Search

Aug 2 2016

graser added a comment to T9012: No native 2D(+t) image support anymore?.

(In reply to comment #1)

I know nothing that would be against that idea, just conversion into
appropriate ITK images gets a little harder for 2D images.

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T9012: No native 2D(+t) image support anymore?.

(In reply to comment #6)
see also T8509

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8925: 4D Images are not shown properly.

Could not find anything yet. Since a whole plane is missing, it seems like the geometry for that plane is broken. We assume it might be connected with Marcos Clone function of the geometries, since the bug appeared some time after it. Things to check:

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8925: 4D Images are not shown properly.

Apparently only occurs under windows

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8925: 4D Images are not shown properly.

We found the error. The class SliceGeometry3D has a member m_DirectionVector which was not properly initialzied in the constructor and copy constructor.

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8925: 4D Images are not shown properly.

[2ef50b]: Merge branch 'bug-8925-4DImages'

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8925: 4D Images are not shown properly.

only occurs on WINDOWS and in RELEASE mode

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added projects to T8925: 4D Images are not shown properly: MITK, Bugzilla.
Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8910: META BUG Geometry Cleanup.

There is a need for a IndexToWorld transform, that accepts mitk::index3d as input

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8909: Clarify meaning of Global Reinit vs Reinit.

see also T8350

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8909: Clarify meaning of Global Reinit vs Reinit.

We decided to declare the following behaviour as desired behaviour:

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added projects to T8909: Clarify meaning of Global Reinit vs Reinit: MITK, Bugzilla.
Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8906: Saving / Loading Images might alter geometry.

Possible connections:
T6507
T8092

Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added projects to T8910: META BUG Geometry Cleanup: MITK, Bugzilla.
Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added projects to T8906: Saving / Loading Images might alter geometry: MITK, Bugzilla.
Aug 2 2016, 9:47 AM · Bugzilla, MITK
graser added a comment to T8690: Level Window bound by image values.

After exceeding the upper bound of the window while changing the level-window with pressed mouse and move the interaction isn't working.

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8686: Remember Save-File Path.

What's the status, alfred?

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added projects to T8545: More basic functions in Mitk::Image (e.g. SetPixel): MITK, Bugzilla.
Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8545: More basic functions in Mitk::Image (e.g. SetPixel).

"GetPixel" method is already available.

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to F694: planerot.jpg.

Planes rotated and translated, so that they do not have a common intersection point inside the image anymore.

Aug 2 2016, 9:46 AM
graser added projects to T8525: Rotation of Planes in Viewer is buggy: MITK, Bugzilla.
Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8525: Rotation of Planes in Viewer is buggy.

We discussed this issue in the MITK meeting. The current behaviour is the most sensible solution! When you happen to translate and rotate the planes, so their intersection is outside, the current behavior would be the most expected.

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8525: Rotation of Planes in Viewer is buggy.
  • another feature request: indicate direction of planes/axisvector with an arrow at one end
Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

[375035]: Merge branch 'bug-8509-NewCast'

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

[38d851]: Merge branch 'bug-8509-CastChangesGeometry'

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

[444013]: Merge branch 'bug-8509-NewCast2'

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added projects to T8509: CastToMITK / CastToITK changes the geometry sometimes: MITK, Bugzilla.
Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

We fixed it now partly.

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

I will create a test for it and then push it

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

Test implemented for Casting 3D ITK to MITK...

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

possible connection
T4583

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

I was wrong! Can be solved without T8477!

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

Changed the code as described. But the warning is coming to the output a few times, when loading an rotated image, which should actually be allright.

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8509: CastToMITK / CastToITK changes the geometry sometimes.

Handling of Rotation in Image Geometries is not functionable.. need to fix that first: See T8477

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8477: Making Saving/Loading of 2D Images with 3D Geometry Information (e.g. 3D Rotation) possible.

I am planning to implement the following behaviour:

Aug 2 2016, 9:46 AM · Bugzilla, MITK
graser added a comment to T8477: Making Saving/Loading of 2D Images with 3D Geometry Information (e.g. 3D Rotation) possible.

Work in Progress: Currently we are changing the geometry class in a branch on
my computer.

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8477: Making Saving/Loading of 2D Images with 3D Geometry Information (e.g. 3D Rotation) possible.

CastToItk apparently does not alter m_Direction, so no rotation considered here

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8477: Making Saving/Loading of 2D Images with 3D Geometry Information (e.g. 3D Rotation) possible.

(Need to check if that still applies if a Translation was applied to the given
Transformationmatrix)

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8477: Making Saving/Loading of 2D Images with 3D Geometry Information (e.g. 3D Rotation) possible.

Only 1 MB attachment allowed, so i put the Image to T:\Temp\Extracted2DMitralValve.nrrd

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8477: Making Saving/Loading of 2D Images with 3D Geometry Information (e.g. 3D Rotation) possible.

After some discussion with Jan und Caspar, we found out, that it IS possible, to determine the Scaling and Rotation Matrix out of a composed TransformMatrix.
So, when the user sets the IndexToWorld Transformation Matrix directly, we can read out Spacing and Rotation Matrix out of that.
That means, for the new Geometry we could offer a SetTransformationMatrix Method, which sets up a nice and clean geometry!
(Need to check if that still applies if a Translation was applied to the given Transformationmatrix)

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8477: Making Saving/Loading of 2D Images with 3D Geometry Information (e.g. 3D Rotation) possible.

We began to change some stuff in the Geometry3D class.
Need to discuss a couple of things in the MITK meeting

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added projects to T8477: Making Saving/Loading of 2D Images with 3D Geometry Information (e.g. 3D Rotation) possible: MITK, Bugzilla.
Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added projects to T8372: Image Navigator stops working, when a bundle was closed: MITK, Bugzilla.
Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8320: Statics Bundle - Histogram not working.

I am not working on that one atm.
But really needs to be done, since Histogram is a must-have.

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8320: Statics Bundle - Histogram not working.

The problem is most probably inside the widget!
In QmitImageStatisticsView.cpp line 642
"m_Controls->m_HistogramWidget->UpdateItemModelFromHistogram();"

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added projects to T8320: Statics Bundle - Histogram not working: MITK, Bugzilla.
Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8320: Statics Bundle - Histogram not working.

the messed up logo might be somehow connected with T8188

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8320: Statics Bundle - Histogram not working.

Problem does NOT appear under Linux

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8308: ImageStatisticsCalculator crashes on ignoring zero value voxels.

new image

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8308: ImageStatisticsCalculator crashes on ignoring zero value voxels.

tested on my and alex's computer in the current MITK_extApp. Does not crash there. Assigning back to Sven.

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to F687: DistImagefrom3DSurface.nrrd.

new image

Aug 2 2016, 9:45 AM
graser added a comment to T8308: ImageStatisticsCalculator crashes on ignoring zero value voxels.

Tested with the attached image and several other images on current master clone. Works for me!

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8217: saving of 4D images behaves weird.

Duplicate

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8209: Develop dynamic extension checking for file writing.

e.g. when i click "save image" onto an image in the datamanager, in the dialog i can choose formats which are totally unsuitable, like:
pvtu
lsm
dwi / hdwi (only works with diffusion images)
pf
hqbi / qbi (qball)

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added projects to T8211: NRRD format does not save 4D images: MITK, Bugzilla.
Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8211: NRRD format does not save 4D images.

apparently it is saved as multiple indentical 4D images... same problem goes for ".nii" format

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added projects to T8092: Cannot save RGB images in specific formats: MITK, Bugzilla.
Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8092: Cannot save RGB images in specific formats.

The code is basically finished.
But we still have to implement a test for this issue.
We plan to push a 2D_rgb, 3D and 4D image into the test-data repository and use these for saving tests for all available image file formats.

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8092: Cannot save RGB images in specific formats.

Work in progress:

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8092: Cannot save RGB images in specific formats.

Need to check other constraints as well. e.g. is Pixeltype possible? What about dimension? time? geometry?

Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8092: Cannot save RGB images in specific formats.

The bug was discussed in the MITK meeting. The result:

  • No XML file! Better put in somewhere in the code.
  • Maybe use an abstract FileWriterInterface (???)
Aug 2 2016, 9:45 AM · Bugzilla, MITK
graser added a comment to T8000: GIPL image file format unsuitable for multiple component images.

GIPL (Guys Image Processing Lab) is a image file format, developed at the Guy's Hospital (in London), which is related to the King's College London School of Medicine and Dentistry.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
graser added a comment to T7998: "Active" Flags in properties cause trouble.

Since the property behavior is going to be changed soon. We should reconsider this bug later, after the change.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
graser added projects to T7998: "Active" Flags in properties cause trouble: MITK, Bugzilla.
Aug 2 2016, 9:44 AM · Bugzilla, MITK
graser added a comment to T7659: Only visible/active objects are saved via save mitk project.

We give it a try

Aug 2 2016, 9:44 AM · Bugzilla, MITK
graser added a comment to T7659: Only visible/active objects are saved via save mitk project.

Found out a dependent bug: 7998
Have to solve that first

Aug 2 2016, 9:44 AM · Bugzilla, MITK
graser added a comment to T7619: Develop a plan for replacing calls to Geometry3D::WorldToIndex(point, vec, vec).

An email has been sent to the mitk-users list:

Aug 2 2016, 9:44 AM · Bugzilla, MITK
graser added a comment to T7619: Develop a plan for replacing calls to Geometry3D::WorldToIndex(point, vec, vec).

(In reply to comment #4)

[bfac38]: Merge branch 'bug-7619-replace-world-to-index-calls'

Merged commits:

2011-04-06 17:00:34 Andreas Fetzer [7494fd]
In the classes

  • Geometry3D
  • PlaneGeometry3D
  • AbstractTransformGeometry

the functions "indexToWorld" and "worldToIndex" had an unused parameter. We
declared them as deprecated and created a new version of these functions
without the unused parameter.
Deprecated function calls "indexToWorld" and "worldToIndex" with the respective
non-deprecated function call.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
graser added a comment to T7079: mitkExtractImageFilter shifts the coronal plane for one slice.

The problem is located in the mitk::ExtractImageFilter.
The filter takes a 3D image as input and produces a 2D image output.
The geometry of the 2D output image is wrong.

Aug 2 2016, 9:43 AM · Auto-closed, Bugzilla, MITK
graser added projects to T6951: Image Cropper - Bounding Box is strange: MITK, Bugzilla.
Aug 2 2016, 9:43 AM · Bugzilla, MITK
graser added a comment to T6552: Segmentation Meta-Bug.

Current Status:

if you revert the changes in mitkPaintbrushTool.cpp and adapt line 311 like this:

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6552: Segmentation Meta-Bug.

Since your latest changes from 2011-02-01 the Paint Tool Feedback Contour does not work properly. I try to find out why ..

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6552: Segmentation Meta-Bug.

[SVN revision 29801]
FIX (#6552): Reverted some of the changes to make it work properly again.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6507: 3D image volume is mirrored after saving as .pic and reloading it.

Is this still a problem?

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added projects to T6492: MITK crashes on crosshair rotation: MITK, Bugzilla.
Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6492: MITK crashes on crosshair rotation.

Ok, somehow it works now..
Maybe it was caused by a change in the geometries which i reverted recently

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

[9d626c]: Merge branch 'bug-6397-PhilipsDicom'

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

Spacing is not quite right. Apparently milimeters are used, where centimeters
should have been used

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

Works fine now

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

In the Philips3D Dicom files, the spacing values are usually measured in centimeters.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

To support Philips3D DCM files 3

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

I found a small bug, causing different behaviour in release and debug mode. Fixed it and created Patch Number 3

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

[SVN revision 28684]
FIX (#6397): Philips3D Ultrasound DCM files are now supported.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to F650: Philips3D_DCM_Patch3.patch.

To support Philips3D DCM files 3

Aug 2 2016, 9:42 AM
graser added a comment to T6397: Support für Philips Ultraschalldaten.

yes, still works with windows. The UCHAR typedef came from a windows file WinDef.h, so it is better how u changed it.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

a little bit more information about the tags:

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

To support Philips3D DCM files 2

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

To support Philips3D DCM files

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

(In reply to comment #4)

I still need to fix: When u open a Philips3D DCM file, do not try to open all
other DCM files in the same directory

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

Solution looks good for me. You could do the next author a favor and split up
the long if-else block in mitkDicomSeriesReader.txx into multiple methods.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to F649: Philips3D_DCM_Patch2.patch.

To support Philips3D DCM files 2

Aug 2 2016, 9:42 AM
graser added a comment to T6397: Support für Philips Ultraschalldaten.

Philips3D US DCM files can now be read with the patch.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

An example file can be found under

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6397: Support für Philips Ultraschalldaten.

I have to handle 4D ultrasound images. They come from a Philips Ultrasound station. These stations usually generate files in a philips-proprietary format, that can be opened and analysed in Philips QLab Software.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to F648: Philips3D_DCM_Patch.patch.

To support Philips3D DCM files

Aug 2 2016, 9:42 AM
graser added a comment to T6397: Support für Philips Ultraschalldaten.

I wrote to the GDCM Mailing list about that problem and wait for response.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6332: Save File Dialog not working properly under Linux.

[SVN revision 28266]
FIX (#6332): Saving files in different formats works under Linux again!

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6332: Save File Dialog not working properly under Linux.

Tested On Windows!
Works fine! :)

Aug 2 2016, 9:42 AM · Bugzilla, MITK
graser added a comment to T6278: Reinit on some tilted images wrong.

Bug cannot be reproduced with the given data.
Seems to be solved.

Aug 2 2016, 9:41 AM · Bugzilla, MITK
graser added a comment to T6264: Basic Image Processing crashes when processing large data sets.

Was diskussed in the MITK meeting:

Aug 2 2016, 9:41 AM · Bugzilla, MITK